fix(access): effective-holders list for permission sets + explain user-picker discoverability by os-zhuang · Pull Request #2383 · objectstack-ai/objectui

os-zhuang · 2026-07-10T11:47:38Z

Closes#2382. Closes#2381. Both filed while dogfooding the Access pillar as a business admin against a live showcase boot.

#2382 — 已分配用户 now shows EFFECTIVE holders

The section listed sys_user_permission_set rows only — in the ADR-0090 model positions are THE distribution channel, so any normally-administered set showed 0 人 exactly where an admin decides whether to edit or delete it. Now:

holders = direct grants ∪ holders of every bound position (sys_position_permission_set → sys_position → sys_user_position), deduped per user;
per-row attribution badges: 直授 / 经岗位 X (a user holding both shows both);
position-held rows have no remove button (removal lives on the position's assignments — hint on hover);
an everyone-anchor binding renders as a note ("every signed-in member holds this set") instead of enumerating the tenant;
position expansion is additive and fail-soft — direct grants still render if any lookup errors.

#2381 — explain user picker was there; now it's discoverable

The picker existed all along (RecordPickerDialog over sys_user) but the trigger rendered as static text 「我(当前调用者)」 — reported as missing by our own dogfood. A ChevronsUpDown affordance fixes the discoverability; no behavior change.

Verification

3 new tests (AssignedUsersSection.test.tsx: merged holders + count, everyone note, remove-only-on-direct); app-shell suite 153 files / 1181 tests green.
Live browser (Vite console :5180 → fresh framework backend): the set bound to contributor with one position-held user renders 「已分配用户 1 人 · Held Henry · 经岗位 contributor · —」; explain panel: picking Held Henry returns HIS decision (principal card shows contributor/everyone + showcase_member_default).

🤖 Generated with Claude Code

…r-picker discoverability objectui#2382 — AssignedUsersSection listed sys_user_permission_set rows only, so any set distributed the normal way (via positions, ADR-0090's distribution channel) showed "0 users" right where an admin decides to edit or delete it. It now merges direct grants with the holders of every bound position (sys_position_permission_set → sys_position → sys_user_position), deduped per user with via badges (直授 / 经岗位 X). Position-held rows drop the remove affordance (that lives on the position's assignments); an everyone-anchor binding renders as a note instead of enumerating every signed-in member. Position expansion is additive and fail-soft — direct grants still render if it errors. objectui#2381 — the explain panel's user picker existed all along but the trigger read as static text ("我(当前调用者)"); a chevron makes it discoverable. Verified end-to-end against a live backend: picking another user explains THAT principal (their positions/permission sets in the principal card). 3 new tests (effective holders, everyone note, remove-only-direct); app-shell suite 153 files / 1181 tests green. Closes#2382. Closes#2381. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

vercel · 2026-07-10T11:47:44Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
objectui	Ignored		Jul 10, 2026 11:47am

github-actions · 2026-07-10T11:51:43Z

✅ Console Performance Budget

Metric	Value	Budget
Main entry (gzip)	59.7 KB	350 KB
Entry file	`index-Cv61PURs.js`	—
Status	PASS	—

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (index.js)	7.59KB	2.75KB
app-shell (runtime-config.js)	5.79KB	2.08KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	7.57KB	2.97KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	1.17KB	0.53KB
auth (AuthProvider.js)	19.11KB	4.04KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	4.79KB	1.88KB
auth (LoginForm.js)	9.55KB	3.36KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.63KB	2.15KB
auth (SocialSignInButtons.js)	8.89KB	3.61KB
auth (UserMenu.js)	3.40KB	1.22KB
auth (auth-gate-events.js)	1.29KB	0.66KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	26.07KB	6.30KB
auth (createAuthenticatedFetch.js)	3.93KB	1.55KB
auth (index.js)	1.75KB	0.76KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	4.29KB	0.82KB
auth (useIsWorkspaceAdmin.js)	1.61KB	0.85KB
collaboration (CommentThread.js)	18.38KB	4.49KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	3.65KB	1.42KB
collaboration (PresenceProvider.js)	2.42KB	0.96KB
collaboration (index.js)	1.25KB	0.53KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	441.37KB	95.21KB
core (index.js)	1.65KB	0.59KB
create-plugin (index.js)	9.28KB	2.98KB
data-objectstack (index.js)	110.51KB	27.26KB
fields (index.js)	186.64KB	45.58KB
i18n (LocalizationContext.js)	1.76KB	0.96KB
i18n (currency.js)	1.22KB	0.64KB
i18n (i18n.js)	4.32KB	1.77KB
i18n (index.js)	2.46KB	0.96KB
i18n (pickLocalized.js)	1.31KB	0.67KB
i18n (provider.js)	5.37KB	1.72KB
i18n (useObjectLabel.js)	21.15KB	4.68KB
i18n (useSafeTranslation.js)	2.68KB	0.98KB
layout (index.js)	38.41KB	10.65KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.74KB
mobile (index.js)	1.50KB	0.62KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	4.42KB	1.27KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.71KB	0.42KB
mobile (useResponsiveConfig.js)	1.36KB	0.63KB
mobile (useSpecGesture.js)	1.77KB	0.77KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	5.09KB	1.84KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	3.46KB	1.03KB
permissions (evaluator.js)	4.00KB	1.23KB
permissions (index.js)	0.91KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.52KB
permissions (usePermissions.js)	1.50KB	0.70KB
plugin-ai (index.js)	15.71KB	3.79KB
plugin-calendar (index.js)	45.12KB	12.34KB
plugin-charts (index.js)	46.31KB	13.06KB
plugin-chatbot (index.js)	173.83KB	41.47KB
plugin-dashboard (index.js)	108.35KB	26.87KB
plugin-designer (index.js)	213.95KB	43.04KB
plugin-detail (index.js)	204.97KB	49.43KB
plugin-editor (index.js)	2.46KB	1.10KB
plugin-form (index.js)	104.12KB	25.19KB
plugin-gantt (index.js)	136.81KB	33.91KB
plugin-grid (index.js)	171.16KB	45.19KB
plugin-kanban (index.js)	48.16KB	12.94KB
plugin-list (index.js)	98.18KB	23.16KB
plugin-map (index.js)	16.80KB	5.24KB
plugin-markdown (index.js)	13.65KB	4.67KB
plugin-report (index.js)	37.83KB	9.97KB
plugin-timeline (index.js)	25.37KB	7.20KB
plugin-tree (index.js)	8.21KB	2.76KB
plugin-view (index.js)	85.47KB	20.80KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.55KB	0.67KB
providers (UploadProvider.js)	11.71KB	3.53KB
providers (index.js)	0.44KB	0.22KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	3.19KB	1.38KB
react (LazyPluginLoader.js)	3.77KB	1.33KB
react (SchemaRenderer.js)	18.23KB	5.97KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	0.79KB	0.43KB
sdui-parser (codegen.js)	4.09KB	1.74KB
sdui-parser (index.js)	2.16KB	0.94KB
sdui-parser (parse.js)	10.04KB	2.82KB
sdui-parser (types.js)	0.29KB	0.24KB
sdui-parser (validate.js)	4.69KB	1.48KB
tenant (TenantContext.js)	0.31KB	0.25KB
tenant (TenantGuard.js)	1.04KB	0.43KB
tenant (TenantProvider.js)	2.76KB	0.98KB
tenant (TenantScopedQuery.js)	0.77KB	0.44KB
tenant (index.js)	0.75KB	0.38KB
tenant (resolver.js)	2.64KB	0.76KB
tenant (useTenant.js)	0.50KB	0.32KB
tenant (useTenantBranding.js)	0.62KB	0.39KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	0.99KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	0.20KB	0.18KB
types (crud.js)	0.20KB	0.18KB
types (data-display.js)	0.20KB	0.18KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	0.77KB	0.41KB
types (disclosure.js)	0.20KB	0.18KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (index.js)	1.54KB	0.68KB
types (layout.js)	0.20KB	0.18KB
types (mobile.js)	0.20KB	0.18KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (spec-report.js)	5.26KB	1.96KB
types (tenant.js)	0.20KB	0.18KB
types (theme.js)	0.20KB	0.18KB
types (ui-action.js)	0.75KB	0.46KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

✅ Core packages should be < 50KB gzipped
✅ Component packages should be < 100KB gzipped
⚠️ Plugin packages should be < 150KB gzipped

github-actionsBot added the tests label Jul 10, 2026

os-zhuang merged commit 672f18e into mainJul 10, 2026
10 checks passed

os-zhuang deleted the fix/access-explain-picker-holders branch July 10, 2026 14:22

os-zhuang mentioned this pull request Jul 10, 2026
chore: bump objectui to 672f18e38121 — Access-pillar effective holders + explain picker chevron objectstack-ai/objectstack#2794
Merged

Navigation Menu

Uh oh!

fix(access): effective-holders list for permission sets + explain user-picker discoverability - #2383

fix(access): effective-holders list for permission sets + explain user-picker discoverability#2383
os-zhuang merged 1 commit into
mainfrom
fix/access-explain-picker-holders

os-zhuang commented Jul 10, 2026

Uh oh!

vercelBot commented Jul 10, 2026

Uh oh!

github-actionsBot commented Jul 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

os-zhuang commented Jul 10, 2026

#2382 — 已分配用户 now shows EFFECTIVE holders

#2381 — explain user picker was there; now it's discoverable

Verification

Uh oh!

vercelBot commented Jul 10, 2026

Uh oh!

github-actionsBot commented Jul 10, 2026

✅ Console Performance Budget

📦 Bundle Size Report

Size Limits

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant