fix(plugin-form): managed 对象按 userActions.edit 逐字段 readonly 渲染，取消一刀切禁用（ADR-0092 D4） by os-zhuang · Pull Request #2395 · objectstack-ai/objectui

os-zhuang · 2026-07-11T09:24:42Z

概要

ADR-0092 D4 的 objectui 配套。ObjectForm（packages/plugin-form/src/ObjectForm.tsx:475）此前对任何非 platform 生命周期桶（config/system/append-only/better-auth）的所有表单字段一刀切 disabled —— 这是这些对象过去没有通用编辑 affordance 时的防御默认。

framework 侧（ADR-0092 D4 / #2817）已让 sys_user 通过 userActions:{edit:true} 开放档案字段编辑,并对非档案字段逐字段标 readonly。但 vendored console 的一刀切禁用把本应可编辑的 name/image 也锁死 → Edit 按钮"可见但不可用"（framework #2833）。

改动

ObjectForm 字段生成时：当对象在当前 mode 的 affordance 为 true（userActions.edit/userActions.create 显式开启）时,取消一刀切锁,改由每个字段自己的 readonly 决定：

const managed = !!managedBy && managedBy !== 'platform';
const modeAffordanceOpen = mode==='edit' ? userActions?.edit===true
: mode==='create' ? userActions?.create===true : false;
const managedBlanketLock = managed && !modeAffordanceOpen;
// disabled: schema.readOnly || mode==='view' || field.readonly || managedBlanketLock

sys_user（better-auth + edit:true）：name/image（readonly:false）→ 可编辑；readonly 字段仍被既有机制排除在编辑表单外,永不可编。
未开 affordance 的 managed 对象（如 sys_session）：一刀切锁保持,向后兼容。
platform 对象：不受影响。

服务端身份写守卫（framework #2828）才是真正边界,本改动仅 UX。

测试

新增 ObjectForm.managedEdit.test.tsx（3 例,全过）：better-auth+edit → name 可编辑且无 readonly 字段泄漏为可编辑 input；better-auth 无 edit → 一刀切禁用;platform → 可编辑。plugin-form 全套 196 通过;pnpm --filter @object-ui/plugin-form build 通过。

联动 / 相关

framework 侧 pnpm objectui:refresh 更新 pin SHA + vendored bundle 后,framework refactor(spec-bridge): remove the dead page/dashboard bridges (#1892) #2817（PR feat: gate detail/form edit & delete on the server's effective operation set (#3546) #2832）的 affordance 才真正可用。
修复 framework fix(console): dispatch flow actions from every surface + cover the screen-flow round trip (framework#3528) #2833 描述的问题 · ADR-0092 D4 · framework refactor(spec-bridge): remove the dead page/dashboard bridges (#1892) #2817 / feat(fields): 采纳 file-as-reference 值形态 — ObjectStack ADR-0104 D3 wave 2 (PR-7) #2828

🤖 Generated with Claude Code

https://claude.ai/code/session_01YGAN5VvvBi4YRGwpNT6e21

Generated by Claude Code

…anket-disable fields (ADR-0092 D4) ObjectForm disabled every field on any non-platform lifecycle bucket (config/system/append-only/better-auth) — a defensive default from when those objects had no generic edit affordance. Now that an object can open per-record editing via userActions.{edit,create} (framework ADR-0092 D4, e.g. sys_user exposing name/image), the blanket lock lifts for the current mode when its affordance is true, and each field's own readonly flag decides. Managed buckets still default the affordance off, so non-opted-in objects are unchanged. Server-side write guard remains the real boundary; this is UX only. Fixes the 'visible but non-functional Edit button' on sys_user surfaced verifying framework #2817 (framework-side #2833). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YGAN5VvvBi4YRGwpNT6e21

vercel · 2026-07-11T09:24:48Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
objectui	Ignored		Jul 11, 2026 9:24am

github-actions · 2026-07-11T09:28:39Z

✅ Console Performance Budget

Metric	Value	Budget
Main entry (gzip)	60.4 KB	350 KB
Entry file	`index-C3tl-NZd.js`	—
Status	PASS	—

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (index.js)	7.84KB	2.85KB
app-shell (runtime-config.js)	7.42KB	2.32KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	7.57KB	2.97KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	1.17KB	0.53KB
auth (AuthProvider.js)	21.08KB	4.19KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	12.12KB	3.41KB
auth (LoginForm.js)	14.70KB	4.38KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.63KB	2.15KB
auth (SocialSignInButtons.js)	8.89KB	3.61KB
auth (UserMenu.js)	3.40KB	1.22KB
auth (auth-gate-events.js)	1.29KB	0.66KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	28.83KB	7.01KB
auth (createAuthenticatedFetch.js)	3.93KB	1.55KB
auth (index.js)	1.75KB	0.76KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	4.74KB	0.85KB
auth (useIsWorkspaceAdmin.js)	1.61KB	0.85KB
collaboration (CommentThread.js)	18.38KB	4.49KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	3.65KB	1.42KB
collaboration (PresenceProvider.js)	2.42KB	0.96KB
collaboration (index.js)	1.25KB	0.53KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	441.37KB	95.21KB
core (index.js)	1.65KB	0.59KB
create-plugin (index.js)	9.28KB	2.98KB
data-objectstack (index.js)	110.51KB	27.26KB
fields (index.js)	186.64KB	45.58KB
i18n (LocalizationContext.js)	1.76KB	0.96KB
i18n (currency.js)	1.22KB	0.64KB
i18n (i18n.js)	4.32KB	1.77KB
i18n (index.js)	2.46KB	0.96KB
i18n (pickLocalized.js)	1.31KB	0.67KB
i18n (provider.js)	5.37KB	1.72KB
i18n (useObjectLabel.js)	21.15KB	4.68KB
i18n (useSafeTranslation.js)	2.68KB	0.98KB
layout (index.js)	38.41KB	10.65KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.74KB
mobile (index.js)	1.50KB	0.62KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	4.42KB	1.27KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.71KB	0.42KB
mobile (useResponsiveConfig.js)	1.36KB	0.63KB
mobile (useSpecGesture.js)	1.77KB	0.77KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	5.09KB	1.84KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	3.46KB	1.03KB
permissions (evaluator.js)	4.00KB	1.23KB
permissions (index.js)	0.91KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.52KB
permissions (usePermissions.js)	1.50KB	0.70KB
plugin-ai (index.js)	15.71KB	3.79KB
plugin-calendar (index.js)	45.12KB	12.34KB
plugin-charts (index.js)	46.31KB	13.06KB
plugin-chatbot (index.js)	173.88KB	41.49KB
plugin-dashboard (index.js)	108.35KB	26.87KB
plugin-designer (index.js)	213.95KB	43.04KB
plugin-detail (index.js)	205.03KB	49.47KB
plugin-editor (index.js)	2.46KB	1.10KB
plugin-form (index.js)	104.25KB	25.24KB
plugin-gantt (index.js)	136.81KB	33.91KB
plugin-grid (index.js)	171.87KB	45.39KB
plugin-kanban (index.js)	48.16KB	12.94KB
plugin-list (index.js)	98.18KB	23.16KB
plugin-map (index.js)	16.80KB	5.24KB
plugin-markdown (index.js)	13.65KB	4.67KB
plugin-report (index.js)	37.83KB	9.97KB
plugin-timeline (index.js)	25.37KB	7.20KB
plugin-tree (index.js)	8.21KB	2.76KB
plugin-view (index.js)	85.47KB	20.80KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.55KB	0.67KB
providers (UploadProvider.js)	11.71KB	3.53KB
providers (index.js)	0.44KB	0.22KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	3.19KB	1.38KB
react (LazyPluginLoader.js)	3.77KB	1.33KB
react (SchemaRenderer.js)	18.23KB	5.97KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	0.79KB	0.43KB
sdui-parser (codegen.js)	4.09KB	1.74KB
sdui-parser (index.js)	2.16KB	0.94KB
sdui-parser (parse.js)	10.04KB	2.82KB
sdui-parser (types.js)	0.29KB	0.24KB
sdui-parser (validate.js)	4.69KB	1.48KB
tenant (TenantContext.js)	0.31KB	0.25KB
tenant (TenantGuard.js)	1.04KB	0.43KB
tenant (TenantProvider.js)	2.76KB	0.98KB
tenant (TenantScopedQuery.js)	0.77KB	0.44KB
tenant (index.js)	0.75KB	0.38KB
tenant (resolver.js)	2.64KB	0.76KB
tenant (useTenant.js)	0.50KB	0.32KB
tenant (useTenantBranding.js)	0.62KB	0.39KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	0.99KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	0.20KB	0.18KB
types (crud.js)	0.20KB	0.18KB
types (data-display.js)	0.20KB	0.18KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	0.77KB	0.41KB
types (disclosure.js)	0.20KB	0.18KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (index.js)	1.54KB	0.68KB
types (layout.js)	0.20KB	0.18KB
types (mobile.js)	0.20KB	0.18KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (spec-report.js)	5.26KB	1.96KB
types (tenant.js)	0.20KB	0.18KB
types (theme.js)	0.20KB	0.18KB
types (ui-action.js)	0.75KB	0.46KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

✅ Core packages should be < 50KB gzipped
✅ Component packages should be < 100KB gzipped
⚠️ Plugin packages should be < 150KB gzipped

github-actionsBot added plugin tests labels Jul 11, 2026

os-zhuang marked this pull request as ready for review July 11, 2026 09:53

os-zhuang merged commit 5da9905 into mainJul 11, 2026
10 checks passed

os-zhuang deleted the claude/sys-user-edit-form-readonly branch July 11, 2026 09:53

os-zhuang mentioned this pull request Jul 12, 2026
Detail view: make Edit the primary CTA and move inline editing onto the field (hover pencil + double-click) #2401
Closed
5 tasks

Navigation Menu

Uh oh!

fix(plugin-form): managed 对象按 userActions.edit 逐字段 readonly 渲染，取消一刀切禁用（ADR-0092 D4） - #2395

fix(plugin-form): managed 对象按 userActions.edit 逐字段 readonly 渲染，取消一刀切禁用（ADR-0092 D4）#2395
os-zhuang merged 1 commit into
mainfrom
claude/sys-user-edit-form-readonly

os-zhuang commented Jul 11, 2026

Uh oh!

vercelBot commented Jul 11, 2026

Uh oh!

github-actionsBot commented Jul 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

os-zhuang commented Jul 11, 2026

概要

改动

测试

联动 / 相关

Uh oh!

vercelBot commented Jul 11, 2026

Uh oh!

github-actionsBot commented Jul 11, 2026

✅ Console Performance Budget

📦 Bundle Size Report

Size Limits

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants