Skip to content

fix(console-ai): reliable handoff auto-send + second-handoff context re-carry (ADR-0057 P4) - #2449

Merged
os-zhuang merged 1 commit into
mainfrom
claude/adr-0057-p4-optimize
Jul 13, 2026
Merged

fix(console-ai): reliable handoff auto-send + second-handoff context re-carry (ADR-0057 P4)#2449
os-zhuang merged 1 commit into
mainfrom
claude/adr-0057-p4-optimize

Conversation

@os-zhuang

Copy link
Copy Markdown
Contributor

Two reliability follow-ups to the P4 "Open in Builder →" handoff (#2439 / #2444). Backend counterpart: objectstack-ai/cloud#820 — merge that first (without it the re-carried context on a second handoff is sent but dropped server-side; not a regression, just inert).

1. Handoff auto-send swallow — fixed

The handoff's auto-sent first message could be dropped on a brand-new build conversation: the seed effect gated on the async-resolvedactiveAgent, which can settle afterPOST /conversations mints the id. The deferred-send replay only re-ran on id/doSend changes, so a seed landing post-id was never replayed — conversation created, no …/chat, empty Builder (observed live in the previous verification run; tenant DB showed the build conv with 0 messages).

Fix, two halves:

  • Seed gates on the route (agentSegment, known synchronously), not activeAgent.
  • The page stashes via stashPendingFirstMessage which bumps a pendingFirstMessageSeq; useDeferredFirstSend lists that pendingSignal in its replay deps, so an out-of-band seed replays even when the id already resolved.

Live-verified on the local rig (fresh registration → ask decline → click card): the build first turn auto-fired with context.parentConversationId captured on the wire, and the agent produced a blueprint. This was the exact scenario that swallowed before.

2. Second handoff re-carries the latest ask context

Build conversations are singletons per (user, app, product), and the ask thread is too — so a second handoff re-supplies the same parent id. The transport now re-arms on each falsy→truthy transition of the prop (the URL-mirror strips the param between handoffs, producing the edge), and the seed re-arms on each new handoffPrompt. Live-verified: after a second "Open in Builder →", the next build turn carried parentConversationId again.

Known residual (issue to follow, linked after filing)

The auto-send of the second prompt into an already-existing, mid-flight build conversation (first blueprint still Awaiting Approval) does not fire — the user sends once manually and the context still carries. Suspected hydration race: with an existing conversation the id is present at mount, so the replay fires before useChat finishes hydrating. Not a regression — before this PR a second handoff did nothing at all.

Tests

18/18 green: new pendingSignal post-id-seed replay (incl. a second bump), transport re-carry across strip→re-supply, plus all existing deferred-send / handoff-context / send-failure suites.

🤖 Generated with Claude Code

…f re-carry (ADR-0057 P4)
- Swallow fix: the handoff seed gated on the async-resolved activeAgent, which
can settle after the conversation id mints, so the deferred-send replay ran
with an empty pending and never re-fired (empty build conversation on handoff).
Seed now gates on the route (agentSegment, synchronous) + bumps a pendingSignal
that useDeferredFirstSend lists in its replay deps.
- Second-handoff re-carry: useObjectChat re-arms parentConversationId on each
falsy→truthy transition of the prop (singleton ask id repeats; the URL-mirror
strip→re-supply is the fresh-arrival signal), and the seed re-arms on each new
handoffPrompt.
Unit-tested (useDeferredFirstSend post-id-seed replay; transport re-carry).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@vercel

vercelBot commented Jul 13, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
objectuiIgnoredIgnoredJul 13, 2026 12:37pm

Request Review

@os-zhuang

Copy link
Copy Markdown
ContributorAuthor

Residual (second-handoff auto-send into a hydrating conversation) tracked in #2450.

@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

MetricValueBudget
Main entry (gzip)26.5 KB350 KB
Entry fileindex-DQZmHQtC.js
StatusPASS

📦 Bundle Size Report

PackageSizeGzipped
app-shell (index.js)7.84KB2.85KB
app-shell (runtime-config.js)7.42KB2.32KB
app-shell (types.js)0.01KB0.04KB
app-shell (urlParams.js)7.57KB2.97KB
auth (AuthContext.js)0.31KB0.24KB
auth (AuthGuard.js)1.17KB0.53KB
auth (AuthProvider.js)21.70KB4.21KB
auth (AuthShell.js)3.49KB1.40KB
auth (ForgotPasswordForm.js)12.12KB3.41KB
auth (LoginForm.js)16.53KB4.84KB
auth (PreviewBanner.js)0.90KB0.50KB
auth (RegisterForm.js)6.63KB2.15KB
auth (SocialSignInButtons.js)8.89KB3.61KB
auth (UserMenu.js)3.40KB1.22KB
auth (auth-gate-events.js)1.29KB0.66KB
auth (authStyles.js)5.04KB1.72KB
auth (createAuthClient.js)29.64KB7.14KB
auth (createAuthenticatedFetch.js)3.93KB1.55KB
auth (index.js)1.83KB0.79KB
auth (phone-identifier.js)1.11KB0.66KB
auth (types.js)0.59KB0.35KB
auth (useAuth.js)4.86KB0.85KB
auth (useIsWorkspaceAdmin.js)1.61KB0.85KB
collaboration (CommentThread.js)18.38KB4.49KB
collaboration (LiveCursors.js)3.17KB1.27KB
collaboration (PresenceAvatars.js)3.65KB1.42KB
collaboration (PresenceProvider.js)2.42KB0.96KB
collaboration (index.js)1.25KB0.53KB
collaboration (useCommentSearch.js)1.98KB0.88KB
collaboration (useConflictResolution.js)7.75KB1.86KB
collaboration (useMentionNotifications.js)1.81KB0.68KB
collaboration (usePresence.js)6.33KB1.84KB
collaboration (useRealtimeSubscription.js)7.91KB2.01KB
components (index.js)441.56KB95.29KB
core (index.js)1.65KB0.59KB
create-plugin (index.js)9.28KB2.98KB
data-objectstack (index.js)113.70KB28.15KB
fields (index.js)202.54KB49.50KB
i18n (LocalizationContext.js)1.76KB0.96KB
i18n (currency.js)1.22KB0.64KB
i18n (i18n.js)4.32KB1.77KB
i18n (index.js)2.46KB0.96KB
i18n (pickLocalized.js)1.31KB0.67KB
i18n (provider.js)5.37KB1.72KB
i18n (useObjectLabel.js)21.15KB4.68KB
i18n (useSafeTranslation.js)2.68KB0.98KB
layout (index.js)38.41KB10.65KB
mobile (MobileProvider.js)0.92KB0.49KB
mobile (ResponsiveContainer.js)0.94KB0.38KB
mobile (breakpoints.js)1.51KB0.70KB
mobile (createOfflineDataSource.js)5.61KB1.74KB
mobile (index.js)1.50KB0.62KB
mobile (offlineQueue.js)3.91KB1.35KB
mobile (pwa.js)0.97KB0.49KB
mobile (serviceWorker.js)1.48KB0.62KB
mobile (serviceWorkerSource.js)3.41KB1.48KB
mobile (useBreakpoint.js)1.54KB0.65KB
mobile (useGesture.js)4.42KB1.27KB
mobile (useOfflineSync.js)1.99KB0.72KB
mobile (usePullToRefresh.js)2.53KB0.85KB
mobile (useResponsive.js)0.71KB0.42KB
mobile (useResponsiveConfig.js)1.36KB0.63KB
mobile (useSpecGesture.js)1.77KB0.77KB
mobile (useTouchTarget.js)1.01KB0.54KB
permissions (MePermissionsProvider.js)5.09KB1.84KB
permissions (PermissionContext.js)0.31KB0.25KB
permissions (PermissionGuard.js)0.89KB0.45KB
permissions (PermissionProvider.js)3.46KB1.03KB
permissions (evaluator.js)4.00KB1.23KB
permissions (index.js)0.91KB0.41KB
permissions (store.js)0.91KB0.42KB
permissions (useFieldPermissions.js)1.28KB0.52KB
permissions (usePermissions.js)1.50KB0.70KB
plugin-ai (index.js)15.71KB3.79KB
plugin-calendar (index.js)45.12KB12.34KB
plugin-charts (index.js)46.31KB13.06KB
plugin-chatbot (index.js)175.64KB41.86KB
plugin-dashboard (index.js)108.35KB26.87KB
plugin-designer (index.js)213.94KB43.03KB
plugin-detail (index.js)210.10KB50.68KB
plugin-editor (index.js)2.46KB1.10KB
plugin-form (index.js)104.26KB25.24KB
plugin-gantt (index.js)139.25KB34.62KB
plugin-grid (index.js)171.84KB45.38KB
plugin-kanban (index.js)48.16KB12.94KB
plugin-list (index.js)98.18KB23.16KB
plugin-map (index.js)16.80KB5.24KB
plugin-markdown (index.js)13.65KB4.67KB
plugin-report (index.js)37.82KB9.96KB
plugin-timeline (index.js)25.37KB7.20KB
plugin-tree (index.js)8.21KB2.76KB
plugin-view (index.js)85.47KB20.80KB
providers (DataSourceProvider.js)0.75KB0.39KB
providers (MetadataProvider.js)1.37KB0.59KB
providers (ThemeProvider.js)1.55KB0.67KB
providers (UploadProvider.js)11.71KB3.53KB
providers (index.js)0.44KB0.22KB
providers (types.js)0.01KB0.04KB
react-runtime (index.js)3.19KB1.38KB
react (LazyPluginLoader.js)3.77KB1.33KB
react (SchemaRenderer.js)18.23KB5.97KB
react (data-invalidation.js)5.05KB2.08KB
react (index.js)0.79KB0.43KB
sdui-parser (codegen.js)4.09KB1.74KB
sdui-parser (index.js)2.16KB0.94KB
sdui-parser (parse.js)10.04KB2.82KB
sdui-parser (types.js)0.29KB0.24KB
sdui-parser (validate.js)4.69KB1.48KB
tenant (TenantContext.js)0.31KB0.25KB
tenant (TenantGuard.js)1.04KB0.43KB
tenant (TenantProvider.js)2.76KB0.98KB
tenant (TenantScopedQuery.js)0.77KB0.44KB
tenant (index.js)0.75KB0.38KB
tenant (resolver.js)2.64KB0.76KB
tenant (useTenant.js)0.50KB0.32KB
tenant (useTenantBranding.js)0.62KB0.39KB
types (ai.js)0.20KB0.17KB
types (api-types.js)0.20KB0.18KB
types (app.js)2.87KB0.99KB
types (base.js)0.20KB0.18KB
types (blocks.js)0.20KB0.18KB
types (complex.js)0.20KB0.18KB
types (crud.js)0.20KB0.18KB
types (data-display.js)0.20KB0.18KB
types (data-protocol.js)0.20KB0.19KB
types (data.js)0.20KB0.18KB
types (designer.js)0.77KB0.41KB
types (disclosure.js)0.20KB0.18KB
types (feedback.js)0.20KB0.18KB
types (field-types.js)0.20KB0.18KB
types (form.js)0.20KB0.18KB
types (index.js)1.54KB0.68KB
types (layout.js)0.20KB0.18KB
types (mobile.js)0.20KB0.18KB
types (navigation.js)0.20KB0.18KB
types (objectql.js)0.20KB0.18KB
types (overlay.js)0.20KB0.18KB
types (permissions.js)0.20KB0.18KB
types (plugin-scope.js)0.20KB0.18KB
types (record-components.js)0.20KB0.19KB
types (registry.js)0.20KB0.18KB
types (reports.js)0.20KB0.18KB
types (spec-report.js)5.26KB1.96KB
types (tenant.js)0.20KB0.18KB
types (theme.js)0.20KB0.18KB
types (ui-action.js)0.75KB0.46KB
types (views.js)0.20KB0.18KB
types (widget.js)0.20KB0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@os-zhuang