Uh oh!
There was an error while loading. Please reload this page.
feat(console-ai): the FAB becomes the ChatDock launcher when the dock is on (ADR-0057 P3b) - #2465
Merged
Merged
Conversation
…on (ADR-0057 P3b) ConsoleChatbotFab gains onOpenDock: when set (dock enabled), a click and a designer open-signal open the dock rail instead of arming the floating overlay, and the heavy floating chatbot is never mounted. ConsoleLayout passes dock.expand when dockEnabled and drops P3a's edge launcher (FAB is the launcher). Flag OFF → unchanged. Unit-tested. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The latest updates on your projects. Learn more about Vercel for GitHub. |
4 tasks
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on P3a (#2464). When
features.chatDockis enabled, the console FAB opens the docked rail instead of the floating overlay — the ADR's "FAB → launcher" step. One entry point.What
ConsoleChatbotFabgainsonOpenDock. When set (dock enabled): a click — and a designer "Ask AI" open signal (assistantBus) — opens the dock, and the heavy floating chatbot is never mounted (the FAB stays the lightweight button; the rail loads the chat on demand). When absent: unchanged floating-overlay behavior.ConsoleLayoutpassesdock.expandasonOpenDockwhen the dock is enabled, and drops P3a's edge launcher — the dock is gated on the sameshowChatbot, so the FAB is always present to launch it.Flag OFF → the FAB is completely unchanged. Additive.
Verification
chat-dock-panelpresent, floating overlay not mounted, FAB stays lightweight) — the docked "Assistant" rail renders the ask chat and the content reflows beside it. Screenshot in the session.ConsoleChatbotFabwithonOpenDock→ click calls it and never arms the overlay; the default (noonOpenDock) FAB is unchanged.Next
P3c —
/ai= the dock maximized + the Studio copilot moves to the shared right dock (properties reflow). Per the plan.Refs: #2464 (P3a), epic #2409.
🤖 Generated with Claude Code