Uh oh!
There was an error while loading. Please reload this page.
fix(console-ai): A1.b switcher hides platform built-in apps (setup/account) - #2474
Merged
Conversation
…count) The A1.b package switcher (#2466) listed every app with a _packageId, including code-delivered platform built-ins (setup / account, com.objectstack.*). Selecting one deep-linked /ai/build?package=<builtin> to a package the build agent can't author. Filter on the reserved com.objectstack.* package namespace — the only signal that reliably distinguishes built-ins on the /meta/app LIST response: _packageId is grafted onto every list item, whereas managedBy/source are sys_metadata row columns the list handler doesn't copy onto the item body, and the lock/editable envelope is single-GET only. New exported predicate isPlatformBuiltinApp; unit-tested. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2466 (ADR-0057 Amendment A1.b). Epic #2409.
Problem
The A1.b package switcher lists every app with a
_packageId, including code-delivered platform built-ins (setup/account,com.objectstack.*). Selecting one deep-links/ai/build?package=<builtin>to a package the build agent can't author — a dead end. Built-ins aren't editable and shouldn't be switch targets.Fix
Filter
switchablePackageson the reservedcom.objectstack.*package namespace. This is the signal that reliably distinguishes built-ins on the/meta/appLIST response:_packageIdis grafted onto every list item (getMetaItems); AI-built / user packages use non-reserved ids (e.g.app.xadv), platform ones usecom.objectstack.*(verified live:setup→com.objectstack.setup,account→com.objectstack.account, an AI-built todo app→app.xadv).managedBy/sourceare sys_metadata row columns the LIST handler does NOT copy onto the item body, and the resolvedlock/editableenvelope exists only on single-GET — so neither is usable for list-time filtering.New exported predicate
isPlatformBuiltinApp(app)drives the filter; unit-tested (built-ins excluded; AI/user packages and no-package / non-string ids handled; no false match on a mid-string prefix).Tests
deriveBoundPackageId.test.tsgains 4isPlatformBuiltinAppcases; 8 tests green in that file;tsc --noEmitclean.🤖 Generated with Claude Code