Skip to content

fix(console-ai): clear plaintext chat cache on logout / user switch - #2485

Merged
os-zhuang merged 2 commits into
mainfrom
claude/ai-chat-cache-clear-on-logout
Jul 14, 2026
Merged

fix(console-ai): clear plaintext chat cache on logout / user switch#2485
os-zhuang merged 2 commits into
mainfrom
claude/ai-chat-cache-clear-on-logout

Conversation

@os-zhuang

Copy link
Copy Markdown
Contributor

Highest-ROI item from the AI-chat subsystem review (#2478, security M2). Refs epic #2409.

Problem

Conversation content + tool payloads are cached in localStorage in plaintext (objectstack:ai-chat-conversation-id:* pointers and objectstack:ai-chat-messages:* bodies) and were never cleared on logout. On a shared machine, the next profile user could read the prior user's AI threads — which may contain business data surfaced by the ask agent.

Fix

useChatConversation now purges every objectstack:ai-chat-* key when the signed-in user changes:

  • defined → undefined (logout)
  • u1 → u2 (a different user signs in)

Initial mount never purges (no prior user). A mid-session auth flicker (userId momentarily undefined during a token refresh) would also purge, but that only forces a harmless server re-fetch — the server is the source of truth.

New exported purgeChatCaches() so an explicit logout path in the auth layer can also invoke it directly (follow-up).

Scope / safety

  • Removes only keys under the two objectstack:ai-chat-* prefixes; unrelated localStorage is untouched (tested).
  • No behavior change for a normal single-user session.

Tests

useChatConversation.test.tsx +4 cases (purge scope excludes unrelated keys; no purge on initial mount; purge on logout; purge on user switch). Full hook suite green (33); tsc --noEmit clean.

🤖 Generated with Claude Code

os-zhuangand others added 2 commits July 14, 2026 12:31
…d (ADR-0057 A1.b)
When the build surface is opened to edit an existing app (?package=X), the
empty-state guidance was still the magic-flow 'describe an app to build' copy
+ from-scratch starters — wrong for editing a bound app.
Now the build surface has two empty states, keyed on editPackageId:
- magic flow (no ?package=): 'Build with AI' + build-a-CRM/tracker starters.
- edit mode (?package=X): 'Editing "<app>"' + 'what would you like to
change… I'll modify this app in place' + change-oriented starters (add a
field / object / dashboard / automation).
App name comes from metadata (editAppLabel); falls back to a generic 'Edit
this app' title until metadata loads, so a raw package id (app.xadv) never
flashes. agentEmptyState + buildAgentSuggestions gain the edit branch and are
exported + unit-tested (8 cases). Empty state stays string-props into
ChatbotEnhanced — no plugin-chatbot change.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Conversation content + tool payloads are cached in localStorage in plaintext
(objectstack:ai-chat-conversation-id:* and :ai-chat-messages:*). They were
never cleared on logout, so on a shared machine the next profile user could
read the prior user's AI threads (which may contain data surfaced by the ask
agent).
useChatConversation now purges all objectstack:ai-chat-* keys when the signed-in
user changes (defined -> undefined = logout, or u1 -> u2 = switch). A mid-session
auth flicker would also purge, but that only forces a harmless server re-fetch.
New exported purgeChatCaches() so an explicit logout path can also call it.
Unit-tested (purge scope, no-purge-on-initial-mount, logout, user-switch).
Refs #2478 (M2).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@vercel

vercelBot commented Jul 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
objectuiIgnoredIgnoredJul 14, 2026 5:55am

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

MetricValueBudget
Main entry (gzip)27.3 KB350 KB
Entry fileindex-CJvYHjCH.js
StatusPASS

📦 Bundle Size Report

PackageSizeGzipped
app-shell (index.js)7.84KB2.85KB
app-shell (runtime-config.js)7.42KB2.32KB
app-shell (types.js)0.01KB0.04KB
app-shell (urlParams.js)7.57KB2.97KB
auth (AuthContext.js)0.31KB0.24KB
auth (AuthGuard.js)1.17KB0.53KB
auth (AuthProvider.js)21.70KB4.21KB
auth (AuthShell.js)3.49KB1.40KB
auth (ForgotPasswordForm.js)12.12KB3.41KB
auth (LoginForm.js)17.12KB5.00KB
auth (PreviewBanner.js)0.90KB0.50KB
auth (RegisterForm.js)6.63KB2.15KB
auth (SocialSignInButtons.js)9.60KB3.89KB
auth (UserMenu.js)3.40KB1.22KB
auth (auth-gate-events.js)1.29KB0.66KB
auth (authStyles.js)5.04KB1.72KB
auth (createAuthClient.js)30.17KB7.28KB
auth (createAuthenticatedFetch.js)3.93KB1.55KB
auth (index.js)1.83KB0.79KB
auth (phone-identifier.js)1.11KB0.66KB
auth (types.js)0.59KB0.35KB
auth (useAuth.js)4.86KB0.85KB
auth (useIsWorkspaceAdmin.js)1.61KB0.85KB
collaboration (CommentThread.js)18.38KB4.49KB
collaboration (LiveCursors.js)3.17KB1.27KB
collaboration (PresenceAvatars.js)3.65KB1.42KB
collaboration (PresenceProvider.js)2.42KB0.96KB
collaboration (index.js)1.25KB0.53KB
collaboration (useCommentSearch.js)1.98KB0.88KB
collaboration (useConflictResolution.js)7.75KB1.86KB
collaboration (useMentionNotifications.js)1.81KB0.68KB
collaboration (usePresence.js)6.33KB1.84KB
collaboration (useRealtimeSubscription.js)7.91KB2.01KB
components (index.js)441.87KB95.38KB
core (index.js)1.65KB0.59KB
create-plugin (index.js)9.28KB2.98KB
data-objectstack (index.js)113.70KB28.15KB
fields (index.js)202.54KB49.50KB
i18n (LocalizationContext.js)1.76KB0.96KB
i18n (currency.js)1.22KB0.64KB
i18n (i18n.js)4.32KB1.77KB
i18n (index.js)2.46KB0.96KB
i18n (pickLocalized.js)1.31KB0.67KB
i18n (provider.js)5.37KB1.72KB
i18n (useObjectLabel.js)21.15KB4.68KB
i18n (useSafeTranslation.js)2.68KB0.98KB
layout (index.js)38.45KB10.67KB
mobile (MobileProvider.js)0.92KB0.49KB
mobile (ResponsiveContainer.js)0.94KB0.38KB
mobile (breakpoints.js)1.51KB0.70KB
mobile (createOfflineDataSource.js)5.61KB1.74KB
mobile (index.js)1.50KB0.62KB
mobile (offlineQueue.js)3.91KB1.35KB
mobile (pwa.js)0.97KB0.49KB
mobile (serviceWorker.js)1.48KB0.62KB
mobile (serviceWorkerSource.js)3.41KB1.48KB
mobile (useBreakpoint.js)1.54KB0.65KB
mobile (useGesture.js)4.42KB1.27KB
mobile (useOfflineSync.js)1.99KB0.72KB
mobile (usePullToRefresh.js)2.53KB0.85KB
mobile (useResponsive.js)0.71KB0.42KB
mobile (useResponsiveConfig.js)1.36KB0.63KB
mobile (useSpecGesture.js)1.77KB0.77KB
mobile (useTouchTarget.js)1.01KB0.54KB
permissions (MePermissionsProvider.js)5.09KB1.84KB
permissions (PermissionContext.js)0.31KB0.25KB
permissions (PermissionGuard.js)0.89KB0.45KB
permissions (PermissionProvider.js)3.46KB1.03KB
permissions (evaluator.js)4.00KB1.23KB
permissions (index.js)0.91KB0.41KB
permissions (store.js)0.91KB0.42KB
permissions (useFieldPermissions.js)1.28KB0.52KB
permissions (usePermissions.js)1.50KB0.70KB
plugin-ai (index.js)15.71KB3.79KB
plugin-calendar (index.js)45.12KB12.34KB
plugin-charts (index.js)46.31KB13.06KB
plugin-chatbot (index.js)176.18KB42.05KB
plugin-dashboard (index.js)108.35KB26.87KB
plugin-designer (index.js)213.94KB43.03KB
plugin-detail (index.js)210.11KB50.70KB
plugin-editor (index.js)2.46KB1.10KB
plugin-form (index.js)104.26KB25.24KB
plugin-gantt (index.js)149.41KB37.18KB
plugin-grid (index.js)172.06KB45.46KB
plugin-kanban (index.js)48.16KB12.94KB
plugin-list (index.js)98.74KB23.30KB
plugin-map (index.js)16.80KB5.24KB
plugin-markdown (index.js)13.65KB4.67KB
plugin-report (index.js)37.82KB9.96KB
plugin-timeline (index.js)25.37KB7.20KB
plugin-tree (index.js)8.21KB2.76KB
plugin-view (index.js)85.51KB20.81KB
providers (DataSourceProvider.js)0.75KB0.39KB
providers (MetadataProvider.js)1.37KB0.59KB
providers (ThemeProvider.js)1.55KB0.67KB
providers (UploadProvider.js)11.71KB3.53KB
providers (index.js)0.44KB0.22KB
providers (types.js)0.01KB0.04KB
react-runtime (index.js)3.19KB1.38KB
react (LazyPluginLoader.js)3.77KB1.33KB
react (SchemaRenderer.js)18.23KB5.97KB
react (data-invalidation.js)5.05KB2.08KB
react (index.js)0.79KB0.43KB
sdui-parser (codegen.js)4.09KB1.74KB
sdui-parser (index.js)2.16KB0.94KB
sdui-parser (parse.js)10.04KB2.82KB
sdui-parser (types.js)0.29KB0.24KB
sdui-parser (validate.js)4.69KB1.48KB
tenant (TenantContext.js)0.31KB0.25KB
tenant (TenantGuard.js)1.04KB0.43KB
tenant (TenantProvider.js)2.76KB0.98KB
tenant (TenantScopedQuery.js)0.77KB0.44KB
tenant (index.js)0.75KB0.38KB
tenant (resolver.js)2.64KB0.76KB
tenant (useTenant.js)0.50KB0.32KB
tenant (useTenantBranding.js)0.62KB0.39KB
types (ai.js)0.20KB0.17KB
types (api-types.js)0.20KB0.18KB
types (app.js)2.87KB0.99KB
types (base.js)0.20KB0.18KB
types (blocks.js)0.20KB0.18KB
types (complex.js)0.20KB0.18KB
types (crud.js)0.20KB0.18KB
types (data-display.js)0.20KB0.18KB
types (data-protocol.js)0.20KB0.19KB
types (data.js)0.20KB0.18KB
types (designer.js)0.77KB0.41KB
types (disclosure.js)0.20KB0.18KB
types (feedback.js)0.20KB0.18KB
types (field-types.js)0.20KB0.18KB
types (form.js)0.20KB0.18KB
types (index.js)1.54KB0.68KB
types (layout.js)0.20KB0.18KB
types (mobile.js)0.20KB0.18KB
types (navigation.js)0.20KB0.18KB
types (objectql.js)0.20KB0.18KB
types (overlay.js)0.20KB0.18KB
types (permissions.js)0.20KB0.18KB
types (plugin-scope.js)0.20KB0.18KB
types (record-components.js)0.20KB0.19KB
types (registry.js)0.20KB0.18KB
types (reports.js)0.20KB0.18KB
types (spec-report.js)5.26KB1.96KB
types (tenant.js)0.20KB0.18KB
types (theme.js)0.20KB0.18KB
types (ui-action.js)0.75KB0.46KB
types (views.js)0.20KB0.18KB
types (widget.js)0.20KB0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-zhuang
os-zhuang merged commit e932576 into mainJul 14, 2026
10 checks passed
@os-zhuang
os-zhuang deleted the claude/ai-chat-cache-clear-on-logout branch July 14, 2026 06:07
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@os-zhuang