Skip to content

fix(plugin-chatbot): ask-decline shows a live pending indicator + earlier handoff card (#2458) - #2496

Merged
os-zhuang merged 1 commit into
mainfrom
claude/nervous-brattain-47db65
Jul 14, 2026
Merged

fix(plugin-chatbot): ask-decline shows a live pending indicator + earlier handoff card (#2458)#2496
os-zhuang merged 1 commit into
mainfrom
claude/nervous-brattain-47db65

Conversation

@os-zhuang

Copy link
Copy Markdown
Contributor

What & why

Item #3 of #2458 — the ask-decline latency feel. When the ask agent declines a build-shaped request, the ~20s before the "Open in Builder →" card is dominated by the LLM's time-to-tool-call (gpt-4, react planning). During that wait the chat could show dead air:

Investigation

  • The console (AiChatPage) drives the live stream through useObjectChatmapMessages, default processVisibility="summary".
  • The ask agent (cloud ask-agent.ts) is instructed to call suggest_builderfirst, then one short sentence — so the wait is LLM tool-call latency, not prose. The card can't render sooner; the win is the pending indicator.
  • The builderHandoff card (ChatbotEnhanced) already renders on tool.builderHandoff with no gate on prose / stream completion — so it surfaces at output-available, before the trailing sentence. Confirmed and now locked with a test.

Changes (ChatbotEnhanced.tsx)

  • Redefined isEmptyAssistantStreaming as "streaming turn with nothing visible yet": no real prose (whitespace-only and (called …) placeholders don't count), no rendered tool row (summary chip / detailed card), no shown reasoning (only surfaced in debug), no build/design panel → renders the existing ThinkingDots indicator (mirrors the existing streaming affordance, per the ticket).
  • The static "执行过程" note is now reserved for finished (re-hydrated) tool-call-only turns — #772 behaviour preserved, verified by a test.
  • The typing cursor now paints only beside real streaming prose (no lone cursor during the tool phase).

Goal 3 (prose need)

The ask agent already emits just "one short sentence" for a decline (cloud ask-agent.ts) — already minimal. No prompt change made; touching the P4 handoff contract was explicitly out of scope.

Tests

packages/plugin-chatbot/src/__tests__/ChatbotEnhanced.test.tsx (86 pass):

Browser proof

Rendered the realChatbotEnhanced (from source, console-default summary mode) through the exact ask-decline stream phases (a live gpt-4 rig is needed to reproduce the 20s wall-clock; the harness reproduces each phase deterministically):

  1. Wait / (called …) placeholder → live thinking indicator (Assistant is responding), no blank, no 执行过程.
  2. suggest_builderoutput-available, still streaming, no prose → full "Open in Builder →" card (prompt + actionable button).
  3. One-line prose fills in below the card afterward.

Follow-up (out of scope, flagged separately)

hydratedMessagesToChatMessages (app-shell AiChatPage) lifts draftReview/proposedPlan on reload but notbuilderHandoff/proposedChanges, so a reloaded ask-decline loses the card. Spawned as a separate task.

🤖 Generated with Claude Code

…lier handoff card (#2458)
When the `ask` agent declines a build-shaped request, the ~20s wait before the
"Open in Builder →" card is the LLM's time-to-tool-call. During it the chat
could show dead air: a blank bubble, or the static "执行过程" activity note when
the backend streamed a `(called …)` tool-call placeholder mid-stream.
`ChatbotEnhanced` now renders the existing `ThinkingDots` indicator whenever a
streaming assistant turn has nothing VISIBLE yet — whitespace-only content, a
`(called …)` placeholder, or reasoning hidden in `summary` mode. The static
"执行过程" note is kept only for FINISHED (re-hydrated) tool-call-only turns
(#772 preserved). The `builderHandoff` card already renders at `output-available`
with no prose gate, so it surfaces the instant the tool result lands; the typing
cursor now only paints beside real streaming prose.
Tests: card renders while streaming before prose; live dots (not 执行过程) for a
mid-stream placeholder; 执行过程 note preserved for a finished placeholder turn.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@vercel

vercelBot commented Jul 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
objectuiIgnoredIgnoredJul 14, 2026 2:32pm

Request Review

@os-zhuang
os-zhuang merged commit bfea27f into mainJul 14, 2026
10 checks passed
@os-zhuang
os-zhuang deleted the claude/nervous-brattain-47db65 branch July 14, 2026 14:32
@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

MetricValueBudget
Main entry (gzip)27.5 KB350 KB
Entry fileindex-DbBXMkxI.js
StatusPASS

📦 Bundle Size Report

PackageSizeGzipped
app-shell (index.js)7.84KB2.85KB
app-shell (runtime-config.js)7.42KB2.32KB
app-shell (types.js)0.01KB0.04KB
app-shell (urlParams.js)7.57KB2.97KB
auth (AuthContext.js)0.31KB0.24KB
auth (AuthGuard.js)1.17KB0.53KB
auth (AuthProvider.js)21.70KB4.21KB
auth (AuthShell.js)3.49KB1.40KB
auth (ForgotPasswordForm.js)12.12KB3.41KB
auth (LoginForm.js)17.12KB5.00KB
auth (PreviewBanner.js)0.90KB0.50KB
auth (RegisterForm.js)6.63KB2.15KB
auth (SocialSignInButtons.js)9.60KB3.89KB
auth (UserMenu.js)3.40KB1.22KB
auth (auth-gate-events.js)1.29KB0.66KB
auth (authStyles.js)5.04KB1.72KB
auth (createAuthClient.js)30.17KB7.28KB
auth (createAuthenticatedFetch.js)3.93KB1.55KB
auth (index.js)1.83KB0.79KB
auth (phone-identifier.js)1.11KB0.66KB
auth (types.js)0.59KB0.35KB
auth (useAuth.js)4.86KB0.85KB
auth (useIsWorkspaceAdmin.js)1.61KB0.85KB
collaboration (CommentThread.js)18.38KB4.49KB
collaboration (LiveCursors.js)3.17KB1.27KB
collaboration (PresenceAvatars.js)3.65KB1.42KB
collaboration (PresenceProvider.js)2.42KB0.96KB
collaboration (index.js)1.25KB0.53KB
collaboration (useCommentSearch.js)1.98KB0.88KB
collaboration (useConflictResolution.js)7.75KB1.86KB
collaboration (useMentionNotifications.js)1.81KB0.68KB
collaboration (usePresence.js)6.33KB1.84KB
collaboration (useRealtimeSubscription.js)7.91KB2.01KB
components (index.js)441.87KB95.38KB
core (index.js)1.69KB0.60KB
create-plugin (index.js)9.28KB2.98KB
data-objectstack (index.js)113.70KB28.15KB
fields (index.js)202.54KB49.50KB
i18n (LocalizationContext.js)1.76KB0.96KB
i18n (currency.js)1.22KB0.64KB
i18n (i18n.js)4.32KB1.77KB
i18n (index.js)2.46KB0.96KB
i18n (pickLocalized.js)1.70KB0.83KB
i18n (provider.js)5.37KB1.72KB
i18n (useObjectLabel.js)21.22KB4.69KB
i18n (useSafeTranslation.js)2.68KB0.98KB
layout (index.js)38.45KB10.67KB
mobile (MobileProvider.js)0.92KB0.49KB
mobile (ResponsiveContainer.js)0.94KB0.38KB
mobile (breakpoints.js)1.51KB0.70KB
mobile (createOfflineDataSource.js)5.61KB1.74KB
mobile (index.js)1.50KB0.62KB
mobile (offlineQueue.js)3.91KB1.35KB
mobile (pwa.js)0.97KB0.49KB
mobile (serviceWorker.js)1.48KB0.62KB
mobile (serviceWorkerSource.js)3.41KB1.48KB
mobile (useBreakpoint.js)1.54KB0.65KB
mobile (useGesture.js)4.42KB1.27KB
mobile (useOfflineSync.js)1.99KB0.72KB
mobile (usePullToRefresh.js)2.53KB0.85KB
mobile (useResponsive.js)0.71KB0.42KB
mobile (useResponsiveConfig.js)1.36KB0.63KB
mobile (useSpecGesture.js)1.77KB0.77KB
mobile (useTouchTarget.js)1.01KB0.54KB
permissions (MePermissionsProvider.js)5.09KB1.84KB
permissions (PermissionContext.js)0.31KB0.25KB
permissions (PermissionGuard.js)0.89KB0.45KB
permissions (PermissionProvider.js)3.46KB1.03KB
permissions (evaluator.js)4.00KB1.23KB
permissions (index.js)0.91KB0.41KB
permissions (store.js)0.91KB0.42KB
permissions (useFieldPermissions.js)1.28KB0.52KB
permissions (usePermissions.js)1.50KB0.70KB
plugin-ai (index.js)15.71KB3.79KB
plugin-calendar (index.js)45.12KB12.34KB
plugin-charts (index.js)46.31KB13.06KB
plugin-chatbot (index.js)176.30KB42.08KB
plugin-dashboard (index.js)108.35KB26.87KB
plugin-designer (index.js)213.94KB43.03KB
plugin-detail (index.js)210.51KB50.88KB
plugin-editor (index.js)2.46KB1.10KB
plugin-form (index.js)104.26KB25.24KB
plugin-gantt (index.js)149.17KB37.17KB
plugin-grid (index.js)172.52KB45.57KB
plugin-kanban (index.js)48.16KB12.94KB
plugin-list (index.js)98.99KB23.43KB
plugin-map (index.js)16.80KB5.24KB
plugin-markdown (index.js)13.65KB4.67KB
plugin-report (index.js)37.82KB9.96KB
plugin-timeline (index.js)25.37KB7.20KB
plugin-tree (index.js)8.36KB2.81KB
plugin-view (index.js)85.54KB20.82KB
providers (DataSourceProvider.js)0.75KB0.39KB
providers (MetadataProvider.js)1.37KB0.59KB
providers (ThemeProvider.js)1.55KB0.67KB
providers (UploadProvider.js)11.71KB3.53KB
providers (index.js)0.44KB0.22KB
providers (types.js)0.01KB0.04KB
react-runtime (index.js)3.19KB1.38KB
react (LazyPluginLoader.js)3.77KB1.33KB
react (SchemaRenderer.js)18.70KB6.09KB
react (data-invalidation.js)5.05KB2.08KB
react (index.js)0.79KB0.43KB
sdui-parser (codegen.js)4.09KB1.74KB
sdui-parser (index.js)2.16KB0.94KB
sdui-parser (parse.js)10.04KB2.82KB
sdui-parser (types.js)0.29KB0.24KB
sdui-parser (validate.js)4.69KB1.48KB
tenant (TenantContext.js)0.31KB0.25KB
tenant (TenantGuard.js)1.04KB0.43KB
tenant (TenantProvider.js)2.76KB0.98KB
tenant (TenantScopedQuery.js)0.77KB0.44KB
tenant (index.js)0.75KB0.38KB
tenant (resolver.js)2.64KB0.76KB
tenant (useTenant.js)0.50KB0.32KB
tenant (useTenantBranding.js)0.62KB0.39KB
types (ai.js)0.20KB0.17KB
types (api-types.js)0.20KB0.18KB
types (app.js)2.87KB0.99KB
types (base.js)0.20KB0.18KB
types (blocks.js)0.20KB0.18KB
types (complex.js)0.20KB0.18KB
types (crud.js)0.20KB0.18KB
types (data-display.js)0.20KB0.18KB
types (data-protocol.js)0.20KB0.19KB
types (data.js)0.20KB0.18KB
types (designer.js)0.77KB0.41KB
types (disclosure.js)0.20KB0.18KB
types (feedback.js)0.20KB0.18KB
types (field-types.js)0.20KB0.18KB
types (form.js)0.20KB0.18KB
types (index.js)1.54KB0.68KB
types (layout.js)0.20KB0.18KB
types (mobile.js)0.20KB0.18KB
types (navigation.js)0.20KB0.18KB
types (objectql.js)0.20KB0.18KB
types (overlay.js)0.20KB0.18KB
types (permissions.js)0.20KB0.18KB
types (plugin-scope.js)0.20KB0.18KB
types (record-components.js)0.20KB0.19KB
types (registry.js)0.20KB0.18KB
types (reports.js)0.20KB0.18KB
types (spec-report.js)5.26KB1.96KB
types (tenant.js)0.20KB0.18KB
types (theme.js)0.20KB0.18KB
types (ui-action.js)0.75KB0.46KB
types (views.js)0.20KB0.18KB
types (widget.js)0.20KB0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@os-zhuang