fix(app-shell): Studio Access matrix — history opens in-place sheet, breadcrumb stops escaping the pillar by os-zhuang · Pull Request #2599 · objectstack-ai/objectui

os-zhuang · 2026-07-16T12:36:38Z

Problem

The PermissionMatrixEditPage embedded in the Studio Access pillar (/studio/:packageId/access) reuses the metadata-admin chrome (PageShell) verbatim, and two of its navigation targets don't exist under Studio's router:

History button — navigate('./history?type=permission') resolves to /studio/:packageId/access/history. No route matches (/studio/:packageId/:tab is single-segment), so the app's catch-all (<Route path="*"> → /) dumps the user back on Home. Reproduced in a live browser (fresh showcase backend + console dev server): clicking 历史 in the Access pillar landed on the platform home page.
Breadcrumb — 元数据 › 权限集 links to /metadata, which is also unrouted at top level (metadata admin lives under /apps/:appName/…), so it too falls into the catch-all and yanks the user out of Studio.

Fix

An embedded switch on PageShell + PermissionMatrixEditPage, following the existing MetadataResourceEditPage#embedded precedent; the Studio AccessPillar passes embedded:

Embedded: History opens a right-side Sheet reusing the shared HistoryPanel (same panel the generic edit page uses). Read-only — no rollback action, since under a packageId the set is package metadata whose truth moves via draft + atomic Publish (ADR-0086 D6/D7); a rollback would write a live overlay behind the draft flow's back. The breadcrumb renders as plain text (权限集 › <name>), no /metadata links.
Standalone metadata-admin: unchanged — routed history page and linked crumbs still work.

Verification

Live browser (fresh --fresh showcase backend :4473 + worktree console :5473, package com.test.historyrepro, set sales_perms):
- Before: History → kicked to Home. After: History → in-place sheet showing the real event timeline (seq 1 · v1 · create by system), URL stays /studio/com.test.historyrepro/access.
- Breadcrumb now plain text; no link out of Studio.
New unit tests (PermissionMatrixEditor.embedded.test.tsx, 4 cases): embedded opens sheet without navigating; embedded breadcrumb has no /metadata links; standalone still navigates to ./history; standalone crumbs keep links.
vitest run over metadata-admin + studio-design: 103 files / 785 tests pass.
Note: pnpm --filter @object-ui/app-shell type-check currently fails on pre-existing unrelated errors (useAiUsage.ts, RecordDetailView.tsx — stale sibling dist types in a fresh worktree; the exports exist in those packages' src). None of the four changed files produce type errors.

🤖 Generated with Claude Code

vercel · 2026-07-16T12:36:44Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
objectui	Ignored		Jul 16, 2026 1:26pm

…breadcrumb stops escaping the pillar The PermissionMatrixEditPage embedded in the Studio Access pillar (/studio/:packageId/access) reused the metadata-admin chrome verbatim, and two of its navigation targets don't exist under Studio's router: - The History button navigated to ./history, resolving to /studio/:packageId/access/history — no such route, so the app's catch-all dumped the user back on Home (verified in a live browser). - The PageShell breadcrumb linked to /metadata (also unrouted at top level), yanking the user out of Studio. Fix: an `embedded` switch on PageShell + PermissionMatrixEditPage (same pattern as MetadataResourceEditPage). Embedded, History opens a right-side sheet reusing the shared HistoryPanel (read-only: no rollback, which would write a live overlay behind the package draft/publish flow, ADR-0086 D6/D7), and the breadcrumb renders as plain text. Standalone metadata-admin behavior is unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

github-actions · 2026-07-16T13:29:45Z

✅ Console Performance Budget

Metric	Value	Budget
Main entry (gzip)	27.6 KB	350 KB
Entry file	`index-C640zyzT.js`	—
Status	PASS	—

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (index.js)	8.17KB	2.95KB
app-shell (runtime-config.js)	7.42KB	2.32KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	7.57KB	2.97KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	1.17KB	0.53KB
auth (AuthProvider.js)	21.70KB	4.21KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	12.12KB	3.41KB
auth (LoginForm.js)	17.12KB	5.00KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.63KB	2.15KB
auth (SocialSignInButtons.js)	9.60KB	3.89KB
auth (UserMenu.js)	3.40KB	1.22KB
auth (auth-gate-events.js)	1.29KB	0.66KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	30.17KB	7.28KB
auth (createAuthenticatedFetch.js)	3.93KB	1.55KB
auth (index.js)	1.83KB	0.79KB
auth (phone-identifier.js)	1.11KB	0.66KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	4.86KB	0.85KB
auth (useIsWorkspaceAdmin.js)	1.61KB	0.85KB
collaboration (CommentThread.js)	18.38KB	4.49KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	3.65KB	1.42KB
collaboration (PresenceProvider.js)	2.42KB	0.96KB
collaboration (index.js)	1.25KB	0.53KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	446.37KB	96.66KB
core (index.js)	1.82KB	0.62KB
create-plugin (index.js)	9.28KB	2.98KB
data-objectstack (index.js)	115.42KB	28.53KB
fields (index.js)	208.25KB	50.87KB
i18n (LocalizationContext.js)	1.76KB	0.96KB
i18n (currency.js)	1.22KB	0.64KB
i18n (i18n.js)	4.32KB	1.77KB
i18n (index.js)	2.46KB	0.96KB
i18n (pickLocalized.js)	1.70KB	0.83KB
i18n (provider.js)	5.37KB	1.72KB
i18n (useObjectLabel.js)	21.22KB	4.69KB
i18n (useSafeTranslation.js)	2.68KB	0.98KB
layout (index.js)	38.45KB	10.67KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.74KB
mobile (index.js)	1.50KB	0.62KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	4.42KB	1.27KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.71KB	0.42KB
mobile (useResponsiveConfig.js)	1.36KB	0.63KB
mobile (useSpecGesture.js)	1.77KB	0.77KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	5.90KB	2.15KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	3.46KB	1.03KB
permissions (evaluator.js)	4.00KB	1.23KB
permissions (index.js)	0.91KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.52KB
permissions (usePermissions.js)	1.50KB	0.70KB
plugin-ai (index.js)	15.71KB	3.79KB
plugin-calendar (index.js)	45.12KB	12.34KB
plugin-charts (index.js)	46.31KB	13.06KB
plugin-chatbot (index.js)	176.76KB	42.28KB
plugin-dashboard (index.js)	117.25KB	29.14KB
plugin-designer (index.js)	213.89KB	43.03KB
plugin-detail (index.js)	212.12KB	51.60KB
plugin-editor (index.js)	2.46KB	1.10KB
plugin-form (index.js)	104.96KB	25.43KB
plugin-gantt (index.js)	149.18KB	37.17KB
plugin-grid (index.js)	172.00KB	45.43KB
plugin-kanban (index.js)	47.23KB	12.88KB
plugin-list (index.js)	97.69KB	23.10KB
plugin-map (index.js)	16.80KB	5.24KB
plugin-markdown (index.js)	13.65KB	4.67KB
plugin-report (index.js)	37.63KB	9.92KB
plugin-timeline (index.js)	25.37KB	7.20KB
plugin-tree (index.js)	8.36KB	2.81KB
plugin-view (index.js)	85.72KB	20.86KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.55KB	0.67KB
providers (UploadProvider.js)	11.71KB	3.53KB
providers (index.js)	0.44KB	0.22KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	3.19KB	1.38KB
react (LazyPluginLoader.js)	3.77KB	1.33KB
react (SchemaRenderer.js)	18.70KB	6.09KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	0.76KB	0.42KB
sdui-parser (codegen.js)	4.09KB	1.74KB
sdui-parser (index.js)	2.16KB	0.94KB
sdui-parser (parse.js)	10.04KB	2.82KB
sdui-parser (types.js)	0.29KB	0.24KB
sdui-parser (validate.js)	4.69KB	1.48KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	0.99KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	0.20KB	0.18KB
types (crud.js)	0.20KB	0.18KB
types (data-display.js)	0.20KB	0.18KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	0.77KB	0.41KB
types (disclosure.js)	0.20KB	0.18KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (index.js)	1.67KB	0.75KB
types (layout.js)	0.20KB	0.18KB
types (mobile.js)	0.20KB	0.18KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (record-semantics.js)	1.28KB	0.67KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (spec-report.js)	5.26KB	1.96KB
types (theme.js)	0.20KB	0.18KB
types (ui-action.js)	0.75KB	0.46KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

✅ Core packages should be < 50KB gzipped
✅ Component packages should be < 100KB gzipped
⚠️ Plugin packages should be < 150KB gzipped

…nt capabilities so the matrix hits the first screen (#2600 B1) (#2649) The Access pillar is called "Permission Matrix", but the editor opened with a name/label form plus the capability picker's option chips, pushing the matrix below the fold. Two low-frequency, high-chrome sections now start collapsed: - Identity (name/label) collapses to a one-line summary (label · provenance · default/read-only badges) and expands on click. The api-name already lives in the PageShell breadcrumb, so the summary carries the human label only. - System capabilities: a zero-grant WRITABLE set rendered every option as an outline chip, which read as already-owned. It now shows an explicit "none granted · add" affordance; granted sets and read-only sets keep the inline picker as before. Read-only packages, the dirty/guard contracts (#2588/#2606), the history sheet and breadcrumb (#2599) are all unaffected. Adds PermissionMatrixEditor.basics.test.tsx and updates the settle points of the existing matrix/guard suites (identity is now summary text, not an input). Co-authored-by: Jack Zhuang <277994282+os-zhuang@users.noreply.github.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

This was referenced Jul 16, 2026
[UX] Studio Access 权限矩阵活栈走查收敛:3 个编辑安全缺陷(已开修)+ 设计迭代清单 #2600
Closed
fix(studio): confirm before header SPA nav discards unsaved pillar edits (#2600) #2606
Merged

xuyushun441-sys force-pushed the claude/sad-bell-452feb branch from 523a0d1 to 07c1185Compare July 16, 2026 13:26

github-actionsBot added the tests label Jul 16, 2026

os-zhuang merged commit 770e405 into mainJul 16, 2026
10 checks passed

os-zhuang deleted the claude/sad-bell-452feb branch July 16, 2026 13:35

This was referenced Jul 16, 2026
fix(app-shell): guard unsaved OWD overview rows in the Access rail and Studio header nav (#2600 follow-up) #2610
Merged
feat(access): Studio permission matrix — first screen sees the matrix (#2600 B1) #2649
Merged

Navigation Menu

Uh oh!

fix(app-shell): Studio Access matrix — history opens in-place sheet, breadcrumb stops escaping the pillar - #2599

fix(app-shell): Studio Access matrix — history opens in-place sheet, breadcrumb stops escaping the pillar#2599
os-zhuang merged 1 commit into
mainfrom
claude/sad-bell-452feb

os-zhuang commented Jul 16, 2026

Uh oh!

vercelBot commented Jul 16, 2026•
edited
Loading

Uh oh!

github-actionsBot commented Jul 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

os-zhuang commented Jul 16, 2026

Problem

Fix

Verification

Uh oh!

vercelBot commented Jul 16, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actionsBot commented Jul 16, 2026

✅ Console Performance Budget

📦 Bundle Size Report

Size Limits

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vercelBot commented Jul 16, 2026•
edited
Loading