Skip to content

fix(i18n): drop try/catch-around-hook in createSafeTranslation / useSafeTranslate - #2605

Merged
os-zhuang merged 1 commit into
mainfrom
claude/clever-fermat-flca90
Jul 16, 2026
Merged

fix(i18n): drop try/catch-around-hook in createSafeTranslation / useSafeTranslate#2605
os-zhuang merged 1 commit into
mainfrom
claude/clever-fermat-flca90

Conversation

@os-zhuang

@os-zhuangos-zhuang commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

What

The last known rules-of-hooks violation of the class fixed in #2595/#2596: @object-ui/i18n's createSafeTranslation (the factory under useDetailTranslation, useFieldTranslation, form/filter/sort builders, MetricWidget, ModalForm…) and its sibling useSafeTranslate wrapped useObjectTranslation() in try/catch inside the returned hook. The factory closure escapes eslint's static detection, but the runtime risk is identical — a throw after the hook ran would desync hook order on the next render.

useObjectTranslation is provider-safe (optional context read + react-i18next global-instance fallback), so the guard is removed. The real fallback behavior is unchanged and now test-locked:

  • createSafeTranslation: the testKey probe still returns the English defaults map (with {{placeholder}} interpolation) when translations aren't configured;
  • useSafeTranslate: per-key t(key) === key detection still returns the call-site fallback, key-chain form included.

Bonus: the fallback t is now a stable per-factory reference (previously a fresh closure every render), so downstream useMemo/useCallback deps stop invalidating every render in the no-translations case — the same stability concern ListView documented for its old module-level fallback.

Verification

  • New useSafeTranslation.test.tsx: no-provider defaults, placeholder interpolation, unknown-key passthrough, stable-reference across renders, key-chain fallback
  • vitest i18n + plugin-detail + fields (main consumers): 656 ✓
  • eslint clean on touched files; turbo run type-check @object-ui/i18n ✓

Refs #2595 / #2596 (completes the hooks-violation sweep — no known instances remain).

🤖 Generated with Claude Code

https://claude.ai/code/session_016wpaFMPowSn4nAWsjeGZib

Generated by Claude Code

@claude
fix(i18n): drop try/catch-around-hook in createSafeTranslation / useS…
da1e793
…afeTranslate
The last known rules-of-hooks violation of the class fixed in #2595/#2596 —
the factory closure escaped the static lint, but the runtime risk is the
same: a throw after useObjectTranslation ran would desync hook order on the
next render. The hook is provider-safe, and the real fallback behavior is
carried by the testKey probe (createSafeTranslation) and per-key
t(key) === key detection (useSafeTranslate), both unchanged and now locked
by tests (no-provider defaults, placeholder interpolation, key-chain form).
The fallback t is now a stable per-factory reference, so downstream memo
deps stop invalidating every render in the no-translations case.
Verification: vitest i18n + plugin-detail + fields 656 ✓; eslint 0 errors;
turbo type-check @object-ui/i18n ✓.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016wpaFMPowSn4nAWsjeGZib
@vercel

vercelBot commented Jul 16, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
objectuiIgnoredIgnoredJul 16, 2026 1:20pm

Request Review

@github-actions

github-actionsBot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

MetricValueBudget
Main entry (gzip)27.7 KB350 KB
Entry fileindex-BvMGxWn_.js—
StatusPASS—

📦 Bundle Size Report

PackageSizeGzipped
app-shell (index.js)8.17KB2.95KB
app-shell (runtime-config.js)7.42KB2.32KB
app-shell (types.js)0.01KB0.04KB
app-shell (urlParams.js)7.57KB2.97KB
auth (AuthContext.js)0.31KB0.24KB
auth (AuthGuard.js)1.17KB0.53KB
auth (AuthProvider.js)21.70KB4.21KB
auth (AuthShell.js)3.49KB1.40KB
auth (ForgotPasswordForm.js)12.12KB3.41KB
auth (LoginForm.js)17.12KB5.00KB
auth (PreviewBanner.js)0.90KB0.50KB
auth (RegisterForm.js)6.63KB2.15KB
auth (SocialSignInButtons.js)9.60KB3.89KB
auth (UserMenu.js)3.40KB1.22KB
auth (auth-gate-events.js)1.29KB0.66KB
auth (authStyles.js)5.04KB1.72KB
auth (createAuthClient.js)30.17KB7.28KB
auth (createAuthenticatedFetch.js)3.93KB1.55KB
auth (index.js)1.83KB0.79KB
auth (phone-identifier.js)1.11KB0.66KB
auth (types.js)0.59KB0.35KB
auth (useAuth.js)4.86KB0.85KB
auth (useIsWorkspaceAdmin.js)1.61KB0.85KB
collaboration (CommentThread.js)18.38KB4.49KB
collaboration (LiveCursors.js)3.17KB1.27KB
collaboration (PresenceAvatars.js)3.65KB1.42KB
collaboration (PresenceProvider.js)2.42KB0.96KB
collaboration (index.js)1.25KB0.53KB
collaboration (useCommentSearch.js)1.98KB0.88KB
collaboration (useConflictResolution.js)7.75KB1.86KB
collaboration (useMentionNotifications.js)1.81KB0.68KB
collaboration (usePresence.js)6.33KB1.84KB
collaboration (useRealtimeSubscription.js)7.91KB2.01KB
components (index.js)446.26KB96.59KB
core (index.js)1.82KB0.62KB
create-plugin (index.js)9.28KB2.98KB
data-objectstack (index.js)115.42KB28.53KB
fields (index.js)207.90KB50.76KB
i18n (LocalizationContext.js)1.76KB0.96KB
i18n (currency.js)1.22KB0.64KB
i18n (i18n.js)4.32KB1.77KB
i18n (index.js)2.46KB0.96KB
i18n (pickLocalized.js)1.70KB0.83KB
i18n (provider.js)5.37KB1.72KB
i18n (useObjectLabel.js)21.22KB4.69KB
i18n (useSafeTranslation.js)2.87KB1.28KB
layout (index.js)38.45KB10.67KB
mobile (MobileProvider.js)0.92KB0.49KB
mobile (ResponsiveContainer.js)0.94KB0.38KB
mobile (breakpoints.js)1.51KB0.70KB
mobile (createOfflineDataSource.js)5.61KB1.74KB
mobile (index.js)1.50KB0.62KB
mobile (offlineQueue.js)3.91KB1.35KB
mobile (pwa.js)0.97KB0.49KB
mobile (serviceWorker.js)1.48KB0.62KB
mobile (serviceWorkerSource.js)3.41KB1.48KB
mobile (useBreakpoint.js)1.54KB0.65KB
mobile (useGesture.js)4.42KB1.27KB
mobile (useOfflineSync.js)1.99KB0.72KB
mobile (usePullToRefresh.js)2.53KB0.85KB
mobile (useResponsive.js)0.71KB0.42KB
mobile (useResponsiveConfig.js)1.36KB0.63KB
mobile (useSpecGesture.js)1.77KB0.77KB
mobile (useTouchTarget.js)1.01KB0.54KB
permissions (MePermissionsProvider.js)5.90KB2.15KB
permissions (PermissionContext.js)0.31KB0.25KB
permissions (PermissionGuard.js)0.89KB0.45KB
permissions (PermissionProvider.js)3.46KB1.03KB
permissions (evaluator.js)4.00KB1.23KB
permissions (index.js)0.91KB0.41KB
permissions (store.js)0.91KB0.42KB
permissions (useFieldPermissions.js)1.28KB0.52KB
permissions (usePermissions.js)1.50KB0.70KB
plugin-ai (index.js)15.71KB3.79KB
plugin-calendar (index.js)45.12KB12.34KB
plugin-charts (index.js)46.31KB13.06KB
plugin-chatbot (index.js)176.76KB42.28KB
plugin-dashboard (index.js)117.25KB29.14KB
plugin-designer (index.js)213.89KB43.03KB
plugin-detail (index.js)211.10KB51.37KB
plugin-editor (index.js)2.46KB1.10KB
plugin-form (index.js)104.96KB25.43KB
plugin-gantt (index.js)149.18KB37.17KB
plugin-grid (index.js)172.00KB45.43KB
plugin-kanban (index.js)47.17KB12.85KB
plugin-list (index.js)97.68KB23.10KB
plugin-map (index.js)16.80KB5.24KB
plugin-markdown (index.js)13.65KB4.67KB
plugin-report (index.js)37.63KB9.92KB
plugin-timeline (index.js)25.37KB7.20KB
plugin-tree (index.js)8.36KB2.81KB
plugin-view (index.js)85.72KB20.86KB
providers (DataSourceProvider.js)0.75KB0.39KB
providers (MetadataProvider.js)1.37KB0.59KB
providers (ThemeProvider.js)1.55KB0.67KB
providers (UploadProvider.js)11.71KB3.53KB
providers (index.js)0.44KB0.22KB
providers (types.js)0.01KB0.04KB
react-runtime (index.js)3.19KB1.38KB
react (LazyPluginLoader.js)3.77KB1.33KB
react (SchemaRenderer.js)18.70KB6.09KB
react (data-invalidation.js)5.05KB2.08KB
react (index.js)0.76KB0.42KB
sdui-parser (codegen.js)4.09KB1.74KB
sdui-parser (index.js)2.16KB0.94KB
sdui-parser (parse.js)10.04KB2.82KB
sdui-parser (types.js)0.29KB0.24KB
sdui-parser (validate.js)4.69KB1.48KB
types (ai.js)0.20KB0.17KB
types (api-types.js)0.20KB0.18KB
types (app.js)2.87KB0.99KB
types (base.js)0.20KB0.18KB
types (blocks.js)0.20KB0.18KB
types (complex.js)0.20KB0.18KB
types (crud.js)0.20KB0.18KB
types (data-display.js)0.20KB0.18KB
types (data-protocol.js)0.20KB0.19KB
types (data.js)0.20KB0.18KB
types (designer.js)0.77KB0.41KB
types (disclosure.js)0.20KB0.18KB
types (feedback.js)0.20KB0.18KB
types (field-types.js)0.20KB0.18KB
types (form.js)0.20KB0.18KB
types (index.js)1.67KB0.75KB
types (layout.js)0.20KB0.18KB
types (mobile.js)0.20KB0.18KB
types (navigation.js)0.20KB0.18KB
types (objectql.js)0.20KB0.18KB
types (overlay.js)0.20KB0.18KB
types (permissions.js)0.20KB0.18KB
types (plugin-scope.js)0.20KB0.18KB
types (record-components.js)0.20KB0.19KB
types (record-semantics.js)1.28KB0.67KB
types (registry.js)0.20KB0.18KB
types (reports.js)0.20KB0.18KB
types (spec-report.js)5.26KB1.96KB
types (theme.js)0.20KB0.18KB
types (ui-action.js)0.75KB0.46KB
types (views.js)0.20KB0.18KB
types (widget.js)0.20KB0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-zhuang
os-zhuang marked this pull request as ready for review July 16, 2026 13:41
@os-zhuang
os-zhuang merged commit 23d65c3 into mainJul 16, 2026
14 of 15 checks passed
@os-zhuang
os-zhuang deleted the claude/clever-fermat-flca90 branch July 16, 2026 13:41
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@os-zhuang@claude