Skip to content

fix(form+detail): single-file children stay inline grids; drop non-spec attachment (#2654, #2655) - #2656

Merged
os-zhuang merged 2 commits into
mainfrom
claude/field-file-inline-grid-bug-o5bmrr
Jul 18, 2026
Merged

fix(form+detail): single-file children stay inline grids; drop non-spec attachment (#2654, #2655)#2656
os-zhuang merged 2 commits into
mainfrom
claude/field-file-inline-grid-bug-o5bmrr

Conversation

@os-zhuang

@os-zhuangos-zhuang commented Jul 18, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Two follow-ups to the upload-in-grid work (#2360 / #2585), plus a codified live-verification spec for the underlying feature.

#2654 — a single file field no longer forces a per-row form

Now that file/image/avatar fields render a compact upload cell in the line-item grid, the smart inlineEdit heuristic shouldn't push a child with one attachment column into the per-row form.

resolveInlineMode splits the old catch-all FORM_ONLY_TYPES into two tiers:

  • FORM_ONLY_TYPES (textarea, richtext, html, markdown, rich-text, json, location, address) — a single one still tips to form (these genuinely read poorly in a grid cell).
  • GRID_CAPABLE_RICH_TYPES (file, image, avatar) — render in-grid now, so a lone one stays a grid; they only tip to form when several rich fields pile up (RICH_FIELD_FORM_THRESHOLD, default 2 → a cramped row).

An explicit inlineEdit: 'grid' | 'form' still wins over the heuristic. Net effect: "attach a receipt per expense line" now defaults to the inline grid instead of the form.

#2655 — attachment is not a spec field type → renderer stops modelling it

Confirmed against @objectstack/spec: the media field types are file / image / avatar / video / audio — there is no attachment type (it appears only in a display-name hint list). No framework example declares type: 'attachment'.

Per contract-first (AGENTS.md #0.1 — don't fossilize a non-spec dialect in the renderer), removed the stray attachment handling from the three renderer-side spots this issue named:

  • fieldTypeToColumnType — dropped the case 'attachment' (was mapping it to a file column).
  • resolveInlineMode's type set — removed attachment.
  • RelatedList auto-column SKIP_TYPES — removed attachment.

Out of scope (other subsystems, left untouched): DataModelDesigner, view-config-utils, InterfaceListPage also mention attachment but aren't part of these issues.

live e2e — codifies the #2360 dogfood pass

Adds e2e/live/grid-file-upload.spec.ts next to the sibling showcase_invoice live specs: the Receipt file field auto-derives a grid column, the cell is a real input[type=file] upload control (not a text input), uploading shows a chip, and the resolved file object persists on the line in the atomic /api/v1/batch. Live-only (needs the storage service + a real backend) — runs under pnpm test:e2e:live, not the mocked PR e2e job, matching how the existing live specs are gated. This turns the one-off manual verification into a repeatable, reviewed regression procedure.

Tests

  • deriveMasterDetail.test.ts: single file/image child → grid; two file fields → form; file + textarea → form; fieldTypeToColumnType('attachment') === 'text' (no special-casing) + explicit file-family mapping coverage.
  • Full @object-ui/plugin-form + @object-ui/plugin-detail suites pass (46 files / 437 tests). turbo type-check green; touched files carry no new lint errors. New live spec typechecks and is picked up by playwright.live.config.ts.

Docs updated (content/docs/fields/grid.mdx) and a changeset added (plugin-form minor, plugin-detail patch).

Closes#2654
Closes#2655

🤖 Generated with Claude Code

https://claude.ai/code/session_01H5tsBSEhsDZmdcHBvfymYC

@claude
fix(form+detail): single-file children stay inline grids; drop non-sp…
76d29b8
…ec attachment (#2654, #2655)
Follow-ups to the upload-in-grid work (#2360).
#2654 — file/image/avatar render a compact upload cell in the grid now, so a
child object with a single such field no longer flips the smart inlineEdit
default to a per-row form. resolveInlineMode splits FORM_ONLY_TYPES: truly
form-only types (textarea/richtext/html/markdown/json/location/address) still
tip to form alone, while file-family types only tip when several rich fields
pile up (RICH_FIELD_FORM_THRESHOLD, default 2). Explicit inlineEdit still wins.
#2655 — attachment is not a @objectstack/spec field type (spec media types are
file/image/avatar/video/audio), so the renderer no longer models it: removed
from fieldTypeToColumnType, the inline-mode heuristic, and RelatedList's
auto-column SKIP_TYPES. Contract-first cleanup (AGENTS.md #0.1).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01H5tsBSEhsDZmdcHBvfymYC
@vercel

vercelBot commented Jul 18, 2026•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
objectuiIgnoredIgnoredJul 18, 2026 6:29am

Request Review

@github-actions

github-actionsBot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

MetricValueBudget
Main entry (gzip)28.1 KB350 KB
Entry fileindex-I9XarVd4.js—
StatusPASS—

📦 Bundle Size Report

PackageSizeGzipped
app-shell (index.js)8.17KB2.95KB
app-shell (runtime-config.js)7.42KB2.32KB
app-shell (types.js)0.01KB0.04KB
app-shell (urlParams.js)7.57KB2.97KB
auth (AuthContext.js)0.31KB0.24KB
auth (AuthGuard.js)1.17KB0.53KB
auth (AuthProvider.js)21.70KB4.21KB
auth (AuthShell.js)3.49KB1.40KB
auth (ForgotPasswordForm.js)12.12KB3.41KB
auth (LoginForm.js)17.86KB5.29KB
auth (PreviewBanner.js)0.90KB0.50KB
auth (RegisterForm.js)6.43KB2.09KB
auth (SocialSignInButtons.js)9.60KB3.89KB
auth (UserMenu.js)3.40KB1.22KB
auth (auth-gate-events.js)1.29KB0.66KB
auth (authStyles.js)5.04KB1.72KB
auth (createAuthClient.js)33.74KB8.53KB
auth (createAuthenticatedFetch.js)3.93KB1.55KB
auth (index.js)1.83KB0.79KB
auth (phone-identifier.js)1.11KB0.66KB
auth (types.js)0.59KB0.35KB
auth (useAuth.js)4.86KB0.85KB
auth (useIsWorkspaceAdmin.js)1.61KB0.85KB
collaboration (CommentThread.js)18.38KB4.49KB
collaboration (LiveCursors.js)3.17KB1.27KB
collaboration (PresenceAvatars.js)3.65KB1.42KB
collaboration (PresenceProvider.js)2.42KB0.96KB
collaboration (index.js)1.25KB0.53KB
collaboration (useCommentSearch.js)1.98KB0.88KB
collaboration (useConflictResolution.js)7.75KB1.86KB
collaboration (useMentionNotifications.js)1.81KB0.68KB
collaboration (usePresence.js)6.33KB1.84KB
collaboration (useRealtimeSubscription.js)7.91KB2.01KB
components (index.js)450.03KB97.83KB
core (index.js)1.82KB0.62KB
create-plugin (index.js)9.28KB2.98KB
data-objectstack (index.js)115.42KB28.53KB
fields (index.js)208.34KB50.90KB
i18n (LocalizationContext.js)1.76KB0.96KB
i18n (currency.js)1.22KB0.64KB
i18n (i18n.js)4.32KB1.77KB
i18n (index.js)2.46KB0.96KB
i18n (pickLocalized.js)1.70KB0.83KB
i18n (provider.js)5.37KB1.72KB
i18n (useObjectLabel.js)21.22KB4.69KB
i18n (useSafeTranslation.js)2.87KB1.28KB
layout (index.js)38.45KB10.67KB
mobile (MobileProvider.js)0.92KB0.49KB
mobile (ResponsiveContainer.js)0.94KB0.38KB
mobile (breakpoints.js)1.51KB0.70KB
mobile (createOfflineDataSource.js)5.61KB1.74KB
mobile (index.js)1.50KB0.62KB
mobile (offlineQueue.js)3.91KB1.35KB
mobile (pwa.js)0.97KB0.49KB
mobile (serviceWorker.js)1.48KB0.62KB
mobile (serviceWorkerSource.js)3.41KB1.48KB
mobile (useBreakpoint.js)1.54KB0.65KB
mobile (useGesture.js)4.42KB1.27KB
mobile (useOfflineSync.js)1.99KB0.72KB
mobile (usePullToRefresh.js)2.53KB0.85KB
mobile (useResponsive.js)0.71KB0.42KB
mobile (useResponsiveConfig.js)1.36KB0.63KB
mobile (useSpecGesture.js)1.77KB0.77KB
mobile (useTouchTarget.js)1.01KB0.54KB
permissions (MePermissionsProvider.js)5.90KB2.15KB
permissions (PermissionContext.js)0.31KB0.25KB
permissions (PermissionGuard.js)0.89KB0.45KB
permissions (PermissionProvider.js)3.46KB1.03KB
permissions (evaluator.js)4.00KB1.23KB
permissions (index.js)0.91KB0.41KB
permissions (store.js)0.91KB0.42KB
permissions (useFieldPermissions.js)1.28KB0.52KB
permissions (usePermissions.js)1.50KB0.70KB
plugin-ai (index.js)15.71KB3.79KB
plugin-calendar (index.js)45.12KB12.34KB
plugin-charts (index.js)46.31KB13.06KB
plugin-chatbot (index.js)179.58KB42.81KB
plugin-dashboard (index.js)117.25KB29.14KB
plugin-designer (index.js)213.89KB43.03KB
plugin-detail (index.js)213.28KB51.94KB
plugin-editor (index.js)2.46KB1.10KB
plugin-form (index.js)105.08KB25.47KB
plugin-gantt (index.js)149.18KB37.17KB
plugin-grid (index.js)173.23KB45.75KB
plugin-kanban (index.js)47.23KB12.88KB
plugin-list (index.js)98.22KB23.21KB
plugin-map (index.js)16.80KB5.24KB
plugin-markdown (index.js)13.65KB4.67KB
plugin-report (index.js)37.63KB9.92KB
plugin-timeline (index.js)25.37KB7.20KB
plugin-tree (index.js)8.36KB2.81KB
plugin-view (index.js)85.72KB20.86KB
providers (DataSourceProvider.js)0.75KB0.39KB
providers (MetadataProvider.js)1.37KB0.59KB
providers (ThemeProvider.js)1.55KB0.67KB
providers (UploadProvider.js)11.71KB3.53KB
providers (index.js)0.44KB0.22KB
providers (types.js)0.01KB0.04KB
react-runtime (index.js)3.19KB1.38KB
react (LazyPluginLoader.js)3.77KB1.33KB
react (SchemaRenderer.js)18.70KB6.09KB
react (data-invalidation.js)5.05KB2.08KB
react (index.js)0.76KB0.42KB
sdui-parser (codegen.js)4.09KB1.74KB
sdui-parser (index.js)2.16KB0.94KB
sdui-parser (parse.js)10.04KB2.82KB
sdui-parser (types.js)0.29KB0.24KB
sdui-parser (validate.js)4.69KB1.48KB
types (ai.js)0.20KB0.17KB
types (api-types.js)0.20KB0.18KB
types (app.js)2.87KB0.99KB
types (base.js)0.20KB0.18KB
types (blocks.js)0.20KB0.18KB
types (complex.js)0.20KB0.18KB
types (crud.js)0.20KB0.18KB
types (data-display.js)0.20KB0.18KB
types (data-protocol.js)0.20KB0.19KB
types (data.js)0.20KB0.18KB
types (designer.js)0.77KB0.41KB
types (disclosure.js)0.20KB0.18KB
types (feedback.js)0.20KB0.18KB
types (field-types.js)0.20KB0.18KB
types (form.js)0.20KB0.18KB
types (index.js)1.67KB0.75KB
types (layout.js)0.20KB0.18KB
types (mobile.js)0.20KB0.18KB
types (navigation.js)0.20KB0.18KB
types (objectql.js)0.20KB0.18KB
types (overlay.js)0.20KB0.18KB
types (permissions.js)0.20KB0.18KB
types (plugin-scope.js)0.20KB0.18KB
types (record-components.js)0.20KB0.19KB
types (record-semantics.js)1.28KB0.67KB
types (registry.js)0.20KB0.18KB
types (reports.js)0.20KB0.18KB
types (spec-report.js)5.26KB1.96KB
types (theme.js)0.20KB0.18KB
types (ui-action.js)0.75KB0.46KB
types (views.js)0.20KB0.18KB
types (widget.js)0.20KB0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@claude
test(e2e): live spec for file upload in the inline line-item grid (#2360
d1d3de2
)
Codifies the dogfood pass that shipped #2360 as a repeatable live e2e next to
the sibling showcase_invoice specs: the Receipt file field auto-derives a grid
column, the cell is a real input[type=file] upload control (not a text input),
uploading shows a chip, and the resolved file object persists on the line in
the atomic /api/v1/batch. Live-only (needs the storage service); runs under
`pnpm test:e2e:live`, not the mocked PR e2e job.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01H5tsBSEhsDZmdcHBvfymYC
@github-actions

github-actionsBot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

MetricValueBudget
Main entry (gzip)28.1 KB350 KB
Entry fileindex-I9XarVd4.js—
StatusPASS—

📦 Bundle Size Report

PackageSizeGzipped
app-shell (index.js)8.17KB2.95KB
app-shell (runtime-config.js)7.42KB2.32KB
app-shell (types.js)0.01KB0.04KB
app-shell (urlParams.js)7.57KB2.97KB
auth (AuthContext.js)0.31KB0.24KB
auth (AuthGuard.js)1.17KB0.53KB
auth (AuthProvider.js)21.70KB4.21KB
auth (AuthShell.js)3.49KB1.40KB
auth (ForgotPasswordForm.js)12.12KB3.41KB
auth (LoginForm.js)17.86KB5.29KB
auth (PreviewBanner.js)0.90KB0.50KB
auth (RegisterForm.js)6.43KB2.09KB
auth (SocialSignInButtons.js)9.60KB3.89KB
auth (UserMenu.js)3.40KB1.22KB
auth (auth-gate-events.js)1.29KB0.66KB
auth (authStyles.js)5.04KB1.72KB
auth (createAuthClient.js)33.74KB8.53KB
auth (createAuthenticatedFetch.js)3.93KB1.55KB
auth (index.js)1.83KB0.79KB
auth (phone-identifier.js)1.11KB0.66KB
auth (types.js)0.59KB0.35KB
auth (useAuth.js)4.86KB0.85KB
auth (useIsWorkspaceAdmin.js)1.61KB0.85KB
collaboration (CommentThread.js)18.38KB4.49KB
collaboration (LiveCursors.js)3.17KB1.27KB
collaboration (PresenceAvatars.js)3.65KB1.42KB
collaboration (PresenceProvider.js)2.42KB0.96KB
collaboration (index.js)1.25KB0.53KB
collaboration (useCommentSearch.js)1.98KB0.88KB
collaboration (useConflictResolution.js)7.75KB1.86KB
collaboration (useMentionNotifications.js)1.81KB0.68KB
collaboration (usePresence.js)6.33KB1.84KB
collaboration (useRealtimeSubscription.js)7.91KB2.01KB
components (index.js)450.03KB97.83KB
core (index.js)1.82KB0.62KB
create-plugin (index.js)9.28KB2.98KB
data-objectstack (index.js)115.42KB28.53KB
fields (index.js)208.34KB50.90KB
i18n (LocalizationContext.js)1.76KB0.96KB
i18n (currency.js)1.22KB0.64KB
i18n (i18n.js)4.32KB1.77KB
i18n (index.js)2.46KB0.96KB
i18n (pickLocalized.js)1.70KB0.83KB
i18n (provider.js)5.37KB1.72KB
i18n (useObjectLabel.js)21.22KB4.69KB
i18n (useSafeTranslation.js)2.87KB1.28KB
layout (index.js)38.45KB10.67KB
mobile (MobileProvider.js)0.92KB0.49KB
mobile (ResponsiveContainer.js)0.94KB0.38KB
mobile (breakpoints.js)1.51KB0.70KB
mobile (createOfflineDataSource.js)5.61KB1.74KB
mobile (index.js)1.50KB0.62KB
mobile (offlineQueue.js)3.91KB1.35KB
mobile (pwa.js)0.97KB0.49KB
mobile (serviceWorker.js)1.48KB0.62KB
mobile (serviceWorkerSource.js)3.41KB1.48KB
mobile (useBreakpoint.js)1.54KB0.65KB
mobile (useGesture.js)4.42KB1.27KB
mobile (useOfflineSync.js)1.99KB0.72KB
mobile (usePullToRefresh.js)2.53KB0.85KB
mobile (useResponsive.js)0.71KB0.42KB
mobile (useResponsiveConfig.js)1.36KB0.63KB
mobile (useSpecGesture.js)1.77KB0.77KB
mobile (useTouchTarget.js)1.01KB0.54KB
permissions (MePermissionsProvider.js)5.90KB2.15KB
permissions (PermissionContext.js)0.31KB0.25KB
permissions (PermissionGuard.js)0.89KB0.45KB
permissions (PermissionProvider.js)3.46KB1.03KB
permissions (evaluator.js)4.00KB1.23KB
permissions (index.js)0.91KB0.41KB
permissions (store.js)0.91KB0.42KB
permissions (useFieldPermissions.js)1.28KB0.52KB
permissions (usePermissions.js)1.50KB0.70KB
plugin-ai (index.js)15.71KB3.79KB
plugin-calendar (index.js)45.12KB12.34KB
plugin-charts (index.js)46.31KB13.06KB
plugin-chatbot (index.js)179.58KB42.81KB
plugin-dashboard (index.js)117.25KB29.14KB
plugin-designer (index.js)213.89KB43.03KB
plugin-detail (index.js)213.28KB51.94KB
plugin-editor (index.js)2.46KB1.10KB
plugin-form (index.js)105.08KB25.47KB
plugin-gantt (index.js)149.18KB37.17KB
plugin-grid (index.js)173.23KB45.75KB
plugin-kanban (index.js)47.23KB12.88KB
plugin-list (index.js)98.22KB23.21KB
plugin-map (index.js)16.80KB5.24KB
plugin-markdown (index.js)13.65KB4.67KB
plugin-report (index.js)37.63KB9.92KB
plugin-timeline (index.js)25.37KB7.20KB
plugin-tree (index.js)8.36KB2.81KB
plugin-view (index.js)85.72KB20.86KB
providers (DataSourceProvider.js)0.75KB0.39KB
providers (MetadataProvider.js)1.37KB0.59KB
providers (ThemeProvider.js)1.55KB0.67KB
providers (UploadProvider.js)11.71KB3.53KB
providers (index.js)0.44KB0.22KB
providers (types.js)0.01KB0.04KB
react-runtime (index.js)3.19KB1.38KB
react (LazyPluginLoader.js)3.77KB1.33KB
react (SchemaRenderer.js)18.70KB6.09KB
react (data-invalidation.js)5.05KB2.08KB
react (index.js)0.76KB0.42KB
sdui-parser (codegen.js)4.09KB1.74KB
sdui-parser (index.js)2.16KB0.94KB
sdui-parser (parse.js)10.04KB2.82KB
sdui-parser (types.js)0.29KB0.24KB
sdui-parser (validate.js)4.69KB1.48KB
types (ai.js)0.20KB0.17KB
types (api-types.js)0.20KB0.18KB
types (app.js)2.87KB0.99KB
types (base.js)0.20KB0.18KB
types (blocks.js)0.20KB0.18KB
types (complex.js)0.20KB0.18KB
types (crud.js)0.20KB0.18KB
types (data-display.js)0.20KB0.18KB
types (data-protocol.js)0.20KB0.19KB
types (data.js)0.20KB0.18KB
types (designer.js)0.77KB0.41KB
types (disclosure.js)0.20KB0.18KB
types (feedback.js)0.20KB0.18KB
types (field-types.js)0.20KB0.18KB
types (form.js)0.20KB0.18KB
types (index.js)1.67KB0.75KB
types (layout.js)0.20KB0.18KB
types (mobile.js)0.20KB0.18KB
types (navigation.js)0.20KB0.18KB
types (objectql.js)0.20KB0.18KB
types (overlay.js)0.20KB0.18KB
types (permissions.js)0.20KB0.18KB
types (plugin-scope.js)0.20KB0.18KB
types (record-components.js)0.20KB0.19KB
types (record-semantics.js)1.28KB0.67KB
types (registry.js)0.20KB0.18KB
types (reports.js)0.20KB0.18KB
types (spec-report.js)5.26KB1.96KB
types (theme.js)0.20KB0.18KB
types (ui-action.js)0.75KB0.46KB
types (views.js)0.20KB0.18KB
types (widget.js)0.20KB0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-zhuang
os-zhuang marked this pull request as ready for review July 18, 2026 06:37
@os-zhuang
os-zhuang merged commit 9d4a429 into mainJul 18, 2026
14 checks passed
@os-zhuang
os-zhuang deleted the claude/field-file-inline-grid-bug-o5bmrr branch July 18, 2026 06:37
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

plugintests

Projects

None yet

Milestone

No milestone

2 participants

@os-zhuang@claude