Skip to content

feat(access): localize curated capability labels client-side (#2600 B5 follow-up) - #2657

Merged
os-zhuang merged 1 commit into
mainfrom
feat/access-b5-capability-labels
Jul 18, 2026
Merged

feat(access): localize curated capability labels client-side (#2600 B5 follow-up)#2657
os-zhuang merged 1 commit into
mainfrom
feat/access-b5-capability-labels

Conversation

@os-zhuang

Copy link
Copy Markdown
Contributor

What

Follow-up to #2653 (group headers). The capability chip labels (Manage Metadata, Studio Access, …) are served in English by the sys_capability registry, so they appeared in English even in a Chinese UI.

Why not framework: I explored making the framework registry serve locale-aware labels, but it has no record-data i18n convention — the schema-translation bundles localize object/field schema only, and the labels are plain record data on the generic /api/v1/data endpoint. A backend fix would mean a new pattern (a read middleware + a translation store + a locale-source decision), disproportionate for the issue's lowest-priority item. The curated platform capabilities are a fixed, known set, so localizing them on the client is the proportionate fix.

Change

  • CapabilityMultiSelectField resolves labels for the 7 curated platform caps via capability.label.<name> (dots → underscores); package-/admin-authored capabilities keep their registry-served label.
  • Keys added to useFieldTranslation defaults + en/zh bundles (nested under the existing top-level capability key, so locale-parity is unaffected; other locales fall back to en).

Test note

The toggle-off test now re-queries the chip at click time: the label resolves through i18n, so an async translation-settle can re-render the chips between findBy and fireEvent.click, detaching the awaited node (a re-queried node clicks fine — verified the onChange fires). Added a curated-vs-registry label test.

Verify (live, Chinese UI)

Capability picker chips render localized: 管理元数据 / 管理平台设置 / 管理用户 / 访问 Setup / 访问 Studio / 管理组织用户 / 保存设置 — no raw keys, no flicker.

Tests

CapabilityMultiSelectField (10) + i18n locale-parity + useFieldTranslation107 tests green.

🤖 Generated with Claude Code

…5 follow-up)
Follow-up to #2653 (which localized the picker's group headers). The capability
chip *labels* (Manage Metadata, Studio Access, …) are served in English by the
sys_capability registry. Framework registry localization turned out to require a
new record-data i18n pattern (no existing convention), which is disproportionate
for this — the curated platform capabilities are a FIXED, known set, so localize
just those on the client:
- CapabilityMultiSelectField resolves labels for the 7 curated platform caps via
`capability.label.<name>` (dots → underscores); package-/admin-authored
capabilities keep their registry-served label.
- Added the keys to useFieldTranslation defaults + en/zh bundles (others fall
back to en; nested under the existing top-level `capability` key so locale
parity is unaffected).
Also made the toggle-off test re-query the chip at click time: the label now
resolves through i18n, so an async translation-settle can re-render the chips
between findBy and click — asserting on a re-queried node avoids a detached-node
race. Adds a curated-vs-registry label test.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@vercel

vercelBot commented Jul 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
objectuiIgnoredIgnoredJul 18, 2026 6:31am

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

MetricValueBudget
Main entry (gzip)28.1 KB350 KB
Entry fileindex-BOthlP3E.js
StatusPASS

📦 Bundle Size Report

PackageSizeGzipped
app-shell (index.js)8.17KB2.95KB
app-shell (runtime-config.js)7.42KB2.32KB
app-shell (types.js)0.01KB0.04KB
app-shell (urlParams.js)7.57KB2.97KB
auth (AuthContext.js)0.31KB0.24KB
auth (AuthGuard.js)1.17KB0.53KB
auth (AuthProvider.js)21.70KB4.21KB
auth (AuthShell.js)3.49KB1.40KB
auth (ForgotPasswordForm.js)12.12KB3.41KB
auth (LoginForm.js)17.86KB5.29KB
auth (PreviewBanner.js)0.90KB0.50KB
auth (RegisterForm.js)6.43KB2.09KB
auth (SocialSignInButtons.js)9.60KB3.89KB
auth (UserMenu.js)3.40KB1.22KB
auth (auth-gate-events.js)1.29KB0.66KB
auth (authStyles.js)5.04KB1.72KB
auth (createAuthClient.js)33.74KB8.53KB
auth (createAuthenticatedFetch.js)3.93KB1.55KB
auth (index.js)1.83KB0.79KB
auth (phone-identifier.js)1.11KB0.66KB
auth (types.js)0.59KB0.35KB
auth (useAuth.js)4.86KB0.85KB
auth (useIsWorkspaceAdmin.js)1.61KB0.85KB
collaboration (CommentThread.js)18.38KB4.49KB
collaboration (LiveCursors.js)3.17KB1.27KB
collaboration (PresenceAvatars.js)3.65KB1.42KB
collaboration (PresenceProvider.js)2.42KB0.96KB
collaboration (index.js)1.25KB0.53KB
collaboration (useCommentSearch.js)1.98KB0.88KB
collaboration (useConflictResolution.js)7.75KB1.86KB
collaboration (useMentionNotifications.js)1.81KB0.68KB
collaboration (usePresence.js)6.33KB1.84KB
collaboration (useRealtimeSubscription.js)7.91KB2.01KB
components (index.js)450.03KB97.83KB
core (index.js)1.82KB0.62KB
create-plugin (index.js)9.28KB2.98KB
data-objectstack (index.js)115.42KB28.53KB
fields (index.js)208.98KB51.09KB
i18n (LocalizationContext.js)1.76KB0.96KB
i18n (currency.js)1.22KB0.64KB
i18n (i18n.js)4.32KB1.77KB
i18n (index.js)2.46KB0.96KB
i18n (pickLocalized.js)1.70KB0.83KB
i18n (provider.js)5.37KB1.72KB
i18n (useObjectLabel.js)21.22KB4.69KB
i18n (useSafeTranslation.js)2.87KB1.28KB
layout (index.js)38.45KB10.67KB
mobile (MobileProvider.js)0.92KB0.49KB
mobile (ResponsiveContainer.js)0.94KB0.38KB
mobile (breakpoints.js)1.51KB0.70KB
mobile (createOfflineDataSource.js)5.61KB1.74KB
mobile (index.js)1.50KB0.62KB
mobile (offlineQueue.js)3.91KB1.35KB
mobile (pwa.js)0.97KB0.49KB
mobile (serviceWorker.js)1.48KB0.62KB
mobile (serviceWorkerSource.js)3.41KB1.48KB
mobile (useBreakpoint.js)1.54KB0.65KB
mobile (useGesture.js)4.42KB1.27KB
mobile (useOfflineSync.js)1.99KB0.72KB
mobile (usePullToRefresh.js)2.53KB0.85KB
mobile (useResponsive.js)0.71KB0.42KB
mobile (useResponsiveConfig.js)1.36KB0.63KB
mobile (useSpecGesture.js)1.77KB0.77KB
mobile (useTouchTarget.js)1.01KB0.54KB
permissions (MePermissionsProvider.js)5.90KB2.15KB
permissions (PermissionContext.js)0.31KB0.25KB
permissions (PermissionGuard.js)0.89KB0.45KB
permissions (PermissionProvider.js)3.46KB1.03KB
permissions (evaluator.js)4.00KB1.23KB
permissions (index.js)0.91KB0.41KB
permissions (store.js)0.91KB0.42KB
permissions (useFieldPermissions.js)1.28KB0.52KB
permissions (usePermissions.js)1.50KB0.70KB
plugin-ai (index.js)15.71KB3.79KB
plugin-calendar (index.js)45.12KB12.34KB
plugin-charts (index.js)46.31KB13.06KB
plugin-chatbot (index.js)179.58KB42.81KB
plugin-dashboard (index.js)117.25KB29.14KB
plugin-designer (index.js)213.89KB43.03KB
plugin-detail (index.js)213.30KB51.94KB
plugin-editor (index.js)2.46KB1.10KB
plugin-form (index.js)105.03KB25.46KB
plugin-gantt (index.js)149.18KB37.17KB
plugin-grid (index.js)173.23KB45.75KB
plugin-kanban (index.js)47.23KB12.88KB
plugin-list (index.js)98.22KB23.21KB
plugin-map (index.js)16.80KB5.24KB
plugin-markdown (index.js)13.65KB4.67KB
plugin-report (index.js)37.63KB9.92KB
plugin-timeline (index.js)25.37KB7.20KB
plugin-tree (index.js)8.36KB2.81KB
plugin-view (index.js)85.72KB20.86KB
providers (DataSourceProvider.js)0.75KB0.39KB
providers (MetadataProvider.js)1.37KB0.59KB
providers (ThemeProvider.js)1.55KB0.67KB
providers (UploadProvider.js)11.71KB3.53KB
providers (index.js)0.44KB0.22KB
providers (types.js)0.01KB0.04KB
react-runtime (index.js)3.19KB1.38KB
react (LazyPluginLoader.js)3.77KB1.33KB
react (SchemaRenderer.js)18.70KB6.09KB
react (data-invalidation.js)5.05KB2.08KB
react (index.js)0.76KB0.42KB
sdui-parser (codegen.js)4.09KB1.74KB
sdui-parser (index.js)2.16KB0.94KB
sdui-parser (parse.js)10.04KB2.82KB
sdui-parser (types.js)0.29KB0.24KB
sdui-parser (validate.js)4.69KB1.48KB
types (ai.js)0.20KB0.17KB
types (api-types.js)0.20KB0.18KB
types (app.js)2.87KB0.99KB
types (base.js)0.20KB0.18KB
types (blocks.js)0.20KB0.18KB
types (complex.js)0.20KB0.18KB
types (crud.js)0.20KB0.18KB
types (data-display.js)0.20KB0.18KB
types (data-protocol.js)0.20KB0.19KB
types (data.js)0.20KB0.18KB
types (designer.js)0.77KB0.41KB
types (disclosure.js)0.20KB0.18KB
types (feedback.js)0.20KB0.18KB
types (field-types.js)0.20KB0.18KB
types (form.js)0.20KB0.18KB
types (index.js)1.67KB0.75KB
types (layout.js)0.20KB0.18KB
types (mobile.js)0.20KB0.18KB
types (navigation.js)0.20KB0.18KB
types (objectql.js)0.20KB0.18KB
types (overlay.js)0.20KB0.18KB
types (permissions.js)0.20KB0.18KB
types (plugin-scope.js)0.20KB0.18KB
types (record-components.js)0.20KB0.19KB
types (record-semantics.js)1.28KB0.67KB
types (registry.js)0.20KB0.18KB
types (reports.js)0.20KB0.18KB
types (spec-report.js)5.26KB1.96KB
types (theme.js)0.20KB0.18KB
types (ui-action.js)0.75KB0.46KB
types (views.js)0.20KB0.18KB
types (widget.js)0.20KB0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@os-zhuang