Skip to content

feat(app-shell): DeclaredActionsBar — server-declared actions in the approvals inbox (#2678 P2-4) - #2692

Merged
os-zhuang merged 1 commit into
mainfrom
claude/enterprise-delegation-ooo-proxy-1v3m8l
Jul 19, 2026
Merged

feat(app-shell): DeclaredActionsBar — server-declared actions in the approvals inbox (#2678 P2-4)#2692
os-zhuang merged 1 commit into
mainfrom
claude/enterprise-delegation-ooo-proxy-1v3m8l

Conversation

@os-zhuang

Copy link
Copy Markdown
Contributor

Frontend half of #2678 P2-4. Backend half (declared approval_approve/approval_reject/approval_reassign on sys_approval_request) merged as framework#3282.

What

DeclaredActionsBar (new, packages/app-shell/src/views/) — a reusable component that renders + executes an object's server-declared actions for any (objectName, record, location):

  • Object metadata (and its actions[]) from the app-shell MetadataProvider (or an explicit actions prop).
  • Execution reuses the console action runtime end-to-end: the _rowRecord dispatch shape ObjectGrid uses (so {id} in type:'api' targets resolves from the record), generic param/confirm/result dialogs, visible CEL fail-closed, refreshAfteronDone.
  • No matching actions → renders nothing (no orphan divider).

Approvals inbox: the drawer mounts the bar additively under an "Actions" divider — the three declared decision actions render and execute with zero inbox-specific per-action code. The hardcoded composer stays for now; a follow-up retires it once the declared set covers everything.

Why

This is the structural fix from the #2678 audit: the inbox was a 1961-line hand-written page where every new approval capability meant new buttons. With this bar + framework#3282, decision capabilities ship as backend metadata — enterprise act-as (cloud#861) included — and render on any surface that mounts the bar.

Verification

  • Browser, against a live backend (framework main incl. fix(console): un-invert the validation sample's condition and drop 4 silently-stripped keys #3282, Vite console): the drawer shows the declared Approve/Reject/Reassign under "Actions"; clicking declared Approve opened the generic param dialog, collected the comment, executed /api/v1/approvals/requests/{id}/approve, and the per_group request held exactly as the hardcoded path does (audit row: approve · "Approved via declared SDUI action"; progress manager ✓ 1/1, finance 0/1).
  • 5 new unit tests (location filtering, visible gating, dispatch, graceful degrade, label); app-shell suite green; console build clean; eslint delta zero.

Refs

#2678 (P2-4) · framework#3282 (backend half, merged)

🤖 Generated with Claude Code


Generated by Claude Code

…ctions on bespoke pages (#2678 P2-4)
The generic missing piece behind the "hand-edit the inbox per feature"
anti-pattern: a reusable bar that renders + executes an object's DECLARED
actions for any (objectName, record, location), reusing the console action
runtime end-to-end (param/confirm/result dialogs, {id} target interpolation
via the _rowRecord dispatch shape ObjectGrid uses, visible CEL fail-closed,
refreshAfter -> onDone). Object metadata comes from the app-shell
MetadataProvider (or an explicit `actions` prop); no matching actions renders
nothing.
Mounted additively in the approvals inbox drawer under an "Actions" divider:
the three sys_approval_request actions the backend now declares
(framework#3282) render and execute with zero inbox-specific per-action code.
Browser-verified against a live backend: declared Approve collected its
comment param in the generic dialog, executed the REST route, and the
per_group request advanced exactly as the hardcoded button would. A follow-up
can retire the hardcoded buttons once the declared set covers them all.
Tests: 5 new for the bar (location filtering, visible gating, execution
dispatch, graceful degrade, label rendering); app-shell suite green; console
build clean; eslint delta zero.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016ypkQikZ55oWUHUnMebwXA
@vercel

vercelBot commented Jul 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
objectuiIgnoredIgnoredJul 19, 2026 4:04pm

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

MetricValueBudget
Main entry (gzip)28.0 KB350 KB
Entry fileindex-CcEFjRSt.js
StatusPASS

📦 Bundle Size Report

PackageSizeGzipped
app-shell (index.js)8.19KB2.96KB
app-shell (runtime-config.js)7.42KB2.32KB
app-shell (types.js)0.01KB0.04KB
app-shell (urlParams.js)7.57KB2.97KB
auth (AuthContext.js)0.31KB0.24KB
auth (AuthGuard.js)1.17KB0.53KB
auth (AuthProvider.js)21.70KB4.21KB
auth (AuthShell.js)3.49KB1.40KB
auth (ForgotPasswordForm.js)12.12KB3.41KB
auth (LoginForm.js)17.86KB5.29KB
auth (PreviewBanner.js)0.90KB0.50KB
auth (RegisterForm.js)6.43KB2.09KB
auth (SocialSignInButtons.js)9.60KB3.89KB
auth (UserMenu.js)3.40KB1.22KB
auth (auth-gate-events.js)1.29KB0.66KB
auth (authStyles.js)5.04KB1.72KB
auth (createAuthClient.js)33.74KB8.53KB
auth (createAuthenticatedFetch.js)3.93KB1.55KB
auth (index.js)1.83KB0.79KB
auth (phone-identifier.js)1.11KB0.66KB
auth (types.js)0.59KB0.35KB
auth (useAuth.js)4.86KB0.85KB
auth (useIsWorkspaceAdmin.js)1.61KB0.85KB
collaboration (CommentThread.js)18.38KB4.49KB
collaboration (LiveCursors.js)3.17KB1.27KB
collaboration (PresenceAvatars.js)3.65KB1.42KB
collaboration (PresenceProvider.js)2.42KB0.96KB
collaboration (index.js)1.25KB0.53KB
collaboration (useCommentSearch.js)1.98KB0.88KB
collaboration (useConflictResolution.js)7.75KB1.86KB
collaboration (useMentionNotifications.js)1.81KB0.68KB
collaboration (usePresence.js)6.33KB1.84KB
collaboration (useRealtimeSubscription.js)7.91KB2.01KB
components (index.js)450.03KB97.83KB
core (index.js)1.82KB0.62KB
create-plugin (index.js)9.28KB2.98KB
data-objectstack (index.js)115.42KB28.53KB
fields (index.js)208.98KB51.09KB
i18n (LocalizationContext.js)1.76KB0.96KB
i18n (currency.js)1.22KB0.64KB
i18n (i18n.js)4.32KB1.77KB
i18n (index.js)2.46KB0.96KB
i18n (pickLocalized.js)1.70KB0.83KB
i18n (provider.js)5.37KB1.72KB
i18n (useObjectLabel.js)21.22KB4.69KB
i18n (useSafeTranslation.js)2.87KB1.28KB
layout (index.js)38.45KB10.67KB
mobile (MobileProvider.js)0.92KB0.49KB
mobile (ResponsiveContainer.js)0.94KB0.38KB
mobile (breakpoints.js)1.51KB0.70KB
mobile (createOfflineDataSource.js)5.61KB1.74KB
mobile (index.js)1.50KB0.62KB
mobile (offlineQueue.js)3.91KB1.35KB
mobile (pwa.js)0.97KB0.49KB
mobile (serviceWorker.js)1.48KB0.62KB
mobile (serviceWorkerSource.js)3.41KB1.48KB
mobile (useBreakpoint.js)1.54KB0.65KB
mobile (useGesture.js)4.42KB1.27KB
mobile (useOfflineSync.js)1.99KB0.72KB
mobile (usePullToRefresh.js)2.53KB0.85KB
mobile (useResponsive.js)0.71KB0.42KB
mobile (useResponsiveConfig.js)1.36KB0.63KB
mobile (useSpecGesture.js)1.77KB0.77KB
mobile (useTouchTarget.js)1.01KB0.54KB
permissions (MePermissionsProvider.js)5.90KB2.15KB
permissions (PermissionContext.js)0.31KB0.25KB
permissions (PermissionGuard.js)0.89KB0.45KB
permissions (PermissionProvider.js)3.46KB1.03KB
permissions (evaluator.js)4.00KB1.23KB
permissions (index.js)0.91KB0.41KB
permissions (store.js)0.91KB0.42KB
permissions (useFieldPermissions.js)1.28KB0.52KB
permissions (usePermissions.js)1.50KB0.70KB
plugin-ai (index.js)15.71KB3.79KB
plugin-calendar (index.js)45.12KB12.34KB
plugin-charts (index.js)46.31KB13.06KB
plugin-chatbot (index.js)179.58KB42.81KB
plugin-dashboard (index.js)117.37KB29.18KB
plugin-designer (index.js)213.43KB42.95KB
plugin-detail (index.js)213.56KB51.99KB
plugin-editor (index.js)2.46KB1.10KB
plugin-form (index.js)105.08KB25.47KB
plugin-gantt (index.js)162.24KB39.49KB
plugin-grid (index.js)174.72KB46.05KB
plugin-kanban (index.js)47.23KB12.88KB
plugin-list (index.js)98.22KB23.21KB
plugin-map (index.js)16.80KB5.24KB
plugin-markdown (index.js)13.65KB4.67KB
plugin-report (index.js)37.81KB9.98KB
plugin-timeline (index.js)25.37KB7.20KB
plugin-tree (index.js)8.36KB2.81KB
plugin-view (index.js)85.72KB20.86KB
providers (DataSourceProvider.js)0.75KB0.39KB
providers (MetadataProvider.js)1.37KB0.59KB
providers (ThemeProvider.js)1.55KB0.67KB
providers (UploadProvider.js)11.71KB3.53KB
providers (index.js)0.44KB0.22KB
providers (types.js)0.01KB0.04KB
react-runtime (index.js)3.19KB1.38KB
react (LazyPluginLoader.js)3.77KB1.33KB
react (SchemaRenderer.js)18.70KB6.09KB
react (data-invalidation.js)5.05KB2.08KB
react (index.js)0.76KB0.42KB
sdui-parser (codegen.js)4.09KB1.74KB
sdui-parser (index.js)2.16KB0.94KB
sdui-parser (parse.js)10.04KB2.82KB
sdui-parser (types.js)0.29KB0.24KB
sdui-parser (validate.js)4.69KB1.48KB
types (ai.js)0.20KB0.17KB
types (api-types.js)0.20KB0.18KB
types (app.js)2.87KB0.99KB
types (base.js)0.20KB0.18KB
types (blocks.js)0.20KB0.18KB
types (complex.js)0.20KB0.18KB
types (crud.js)0.20KB0.18KB
types (data-display.js)0.20KB0.18KB
types (data-protocol.js)0.20KB0.19KB
types (data.js)0.20KB0.18KB
types (designer.js)0.77KB0.41KB
types (disclosure.js)0.20KB0.18KB
types (feedback.js)0.20KB0.18KB
types (field-types.js)0.20KB0.18KB
types (form.js)0.20KB0.18KB
types (index.js)1.67KB0.75KB
types (layout.js)0.20KB0.18KB
types (mobile.js)0.20KB0.18KB
types (navigation.js)0.20KB0.18KB
types (objectql.js)0.20KB0.18KB
types (overlay.js)0.20KB0.18KB
types (permissions.js)0.20KB0.18KB
types (plugin-scope.js)0.20KB0.18KB
types (record-components.js)0.20KB0.19KB
types (record-semantics.js)1.28KB0.67KB
types (registry.js)0.20KB0.18KB
types (reports.js)0.20KB0.18KB
types (spec-report.js)5.26KB1.96KB
types (theme.js)0.20KB0.18KB
types (ui-action.js)0.75KB0.46KB
types (views.js)0.20KB0.18KB
types (widget.js)0.20KB0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-zhuang
os-zhuang marked this pull request as ready for review July 19, 2026 16:20
@os-zhuang
os-zhuang merged commit ce86822 into mainJul 19, 2026
14 checks passed
@os-zhuang
os-zhuang deleted the claude/enterprise-delegation-ooo-proxy-1v3m8l branch July 19, 2026 16:20
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@os-zhuang@claude