Skip to content

fix(list): keep injected owner_id out of leading auto-derived list columns - #2702

Merged
os-zhuang merged 1 commit into
mainfrom
claude/showcase-owner-id-lists-6gxw6y
Jul 19, 2026
Merged

fix(list): keep injected owner_id out of leading auto-derived list columns#2702
os-zhuang merged 1 commit into
mainfrom
claude/showcase-owner-id-lists-6gxw6y

Conversation

@os-zhuang

@os-zhuangos-zhuang commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

Problem

Many showcase list pages (e.g. showcase_field_zoo at /_console/apps/com.example.showcase/showcase_field_zoo) render Owner as the very first column, which is unexpected.

Root cause

Two independent behaviors combine:

  1. Framework (applySystemFields) auto-injects owner_id on user-authored business objects and spreads its injected system/audit/ownership fields to the front of the field map. owner_id is stamped system: true but is deliberately non-hidden / non-readonly (ownership is reassignable).
  2. objectui default-column derivation (used when an object has no explicit list view) excluded "system" fields via hardcoded name sets in ObjectGrid and InterfaceListPage that never listed owner_id. So it slipped through and — being first in field order — became column Implement visual designer for Object UI schemas #1.

Fix (stable — keys off the system flag)

Classify system fields through a shared isSystemManagedField(name, field) helper in @object-ui/types that branches on the spec system flag (the single source of truth stamped by the registry, per field.zod.ts: "Tools that surface system fields separately from author-declared business fields should branch on this flag"), with a name-set fallback covering the ownership/tenancy FKs.

  • ObjectGrid: system fields (incl. owner_id) are pushed to the end of the auto-derived columns instead of leading.
  • InterfaceListPage.defaultColumnsFromObject: excluded from the auto-derived business columns.
  • Declares system?: boolean on the @object-ui/types field metadata.

Because it keys off the system flag, future framework-injected fields are handled automatically — no name list to keep in sync.

Verification

  • Unit — new @object-ui/types classifier tests (system-fields.test.ts) + defaultColumnsFromObject tests against a field-zoo-shaped object; existing column-features / mobileCardLookupDisplay grid suites still pass.
  • Browser (Chromium via Playwright) — rendered the real ObjectGrid through its server-backed derivation with the framework's injected metadata shape (owner_id first, system: true). Auto-derived columns are now Name, Email, Number, Select, Date, Owner — Owner last, business fields lead, audit/org columns excluded.

Affected packages

@object-ui/types, @object-ui/plugin-grid, @object-ui/app-shell (patch; changeset included).

🤖 Generated with Claude Code

https://claude.ai/code/session_01NMcdh2cNs165TSF4ub61oy

Generated by Claude Code

@claude
fix(list): keep injected owner_id out of leading auto-derived list co…
cc83bd0
…lumns
View-less objects derive their default list columns from the object's field
order. The framework's applySystemFields spreads injected system/audit/ownership
fields to the FRONT of that order and stamps them `system: true`; owner_id is
deliberately non-hidden and non-readonly (ownership is reassignable), so the old
name-based exclusion lists in ObjectGrid and InterfaceListPage — which never
listed owner_id — let it through as column #1 on many showcase list pages
(e.g. showcase_field_zoo).
Default-column derivation now classifies system fields via a shared
isSystemManagedField helper that branches on the spec `system` flag (the single
source of truth stamped by the registry) with a name-set fallback covering the
ownership/tenancy FKs. owner_id is pushed to the end (ObjectGrid) / excluded
from the business columns (InterfaceListPage), and future injected fields are
covered without editing a name list. Declares the `system` flag on the
@object-ui/types field metadata; adds unit tests and a changeset.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NMcdh2cNs165TSF4ub61oy
@vercel

vercelBot commented Jul 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
objectuiIgnoredIgnoredJul 19, 2026 5:18pm

Request Review

@github-actions

github-actionsBot commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

MetricValueBudget
Main entry (gzip)28.0 KB350 KB
Entry fileindex-BNYW5T8Q.js—
StatusPASS—

📦 Bundle Size Report

PackageSizeGzipped
app-shell (index.js)8.19KB2.96KB
app-shell (runtime-config.js)7.42KB2.32KB
app-shell (types.js)0.01KB0.04KB
app-shell (urlParams.js)7.57KB2.97KB
auth (AuthContext.js)0.31KB0.24KB
auth (AuthGuard.js)1.17KB0.53KB
auth (AuthProvider.js)21.70KB4.21KB
auth (AuthShell.js)3.49KB1.40KB
auth (ForgotPasswordForm.js)12.12KB3.41KB
auth (LoginForm.js)17.86KB5.29KB
auth (PreviewBanner.js)0.90KB0.50KB
auth (RegisterForm.js)6.43KB2.09KB
auth (SocialSignInButtons.js)9.60KB3.89KB
auth (UserMenu.js)3.40KB1.22KB
auth (auth-gate-events.js)1.29KB0.66KB
auth (authStyles.js)5.04KB1.72KB
auth (createAuthClient.js)33.74KB8.53KB
auth (createAuthenticatedFetch.js)3.93KB1.55KB
auth (index.js)1.83KB0.79KB
auth (phone-identifier.js)1.11KB0.66KB
auth (types.js)0.59KB0.35KB
auth (useAuth.js)4.86KB0.85KB
auth (useIsWorkspaceAdmin.js)1.61KB0.85KB
collaboration (CommentThread.js)18.38KB4.49KB
collaboration (LiveCursors.js)3.17KB1.27KB
collaboration (PresenceAvatars.js)3.65KB1.42KB
collaboration (PresenceProvider.js)2.42KB0.96KB
collaboration (index.js)1.25KB0.53KB
collaboration (useCommentSearch.js)1.98KB0.88KB
collaboration (useConflictResolution.js)7.75KB1.86KB
collaboration (useMentionNotifications.js)1.81KB0.68KB
collaboration (usePresence.js)6.33KB1.84KB
collaboration (useRealtimeSubscription.js)7.91KB2.01KB
components (index.js)450.03KB97.83KB
core (index.js)1.82KB0.62KB
create-plugin (index.js)9.28KB2.98KB
data-objectstack (index.js)120.81KB30.10KB
fields (index.js)208.98KB51.09KB
i18n (LocalizationContext.js)1.76KB0.96KB
i18n (currency.js)1.22KB0.64KB
i18n (i18n.js)4.32KB1.77KB
i18n (index.js)2.46KB0.96KB
i18n (pickLocalized.js)1.70KB0.83KB
i18n (provider.js)5.37KB1.72KB
i18n (useObjectLabel.js)21.22KB4.69KB
i18n (useSafeTranslation.js)2.87KB1.28KB
layout (index.js)38.45KB10.67KB
mobile (MobileProvider.js)0.92KB0.49KB
mobile (ResponsiveContainer.js)0.94KB0.38KB
mobile (breakpoints.js)1.51KB0.70KB
mobile (createOfflineDataSource.js)5.61KB1.74KB
mobile (index.js)1.50KB0.62KB
mobile (offlineQueue.js)3.91KB1.35KB
mobile (pwa.js)0.97KB0.49KB
mobile (serviceWorker.js)1.48KB0.62KB
mobile (serviceWorkerSource.js)3.41KB1.48KB
mobile (useBreakpoint.js)1.54KB0.65KB
mobile (useGesture.js)4.42KB1.27KB
mobile (useOfflineSync.js)1.99KB0.72KB
mobile (usePullToRefresh.js)2.53KB0.85KB
mobile (useResponsive.js)0.71KB0.42KB
mobile (useResponsiveConfig.js)1.36KB0.63KB
mobile (useSpecGesture.js)1.77KB0.77KB
mobile (useTouchTarget.js)1.01KB0.54KB
permissions (MePermissionsProvider.js)5.90KB2.15KB
permissions (PermissionContext.js)0.31KB0.25KB
permissions (PermissionGuard.js)0.89KB0.45KB
permissions (PermissionProvider.js)3.46KB1.03KB
permissions (evaluator.js)4.00KB1.23KB
permissions (index.js)0.91KB0.41KB
permissions (store.js)0.91KB0.42KB
permissions (useFieldPermissions.js)1.28KB0.52KB
permissions (usePermissions.js)1.50KB0.70KB
plugin-ai (index.js)15.71KB3.79KB
plugin-calendar (index.js)45.12KB12.34KB
plugin-charts (index.js)46.31KB13.06KB
plugin-chatbot (index.js)179.58KB42.81KB
plugin-dashboard (index.js)117.37KB29.18KB
plugin-designer (index.js)213.43KB42.95KB
plugin-detail (index.js)213.56KB51.99KB
plugin-editor (index.js)2.46KB1.10KB
plugin-form (index.js)102.94KB24.95KB
plugin-gantt (index.js)162.24KB39.49KB
plugin-grid (index.js)174.57KB46.01KB
plugin-kanban (index.js)47.23KB12.88KB
plugin-list (index.js)98.22KB23.21KB
plugin-map (index.js)16.80KB5.24KB
plugin-markdown (index.js)13.65KB4.67KB
plugin-report (index.js)37.81KB9.98KB
plugin-timeline (index.js)25.37KB7.20KB
plugin-tree (index.js)8.36KB2.81KB
plugin-view (index.js)85.72KB20.86KB
providers (DataSourceProvider.js)0.75KB0.39KB
providers (MetadataProvider.js)1.37KB0.59KB
providers (ThemeProvider.js)1.55KB0.67KB
providers (UploadProvider.js)11.71KB3.53KB
providers (index.js)0.44KB0.22KB
providers (types.js)0.01KB0.04KB
react-runtime (index.js)3.19KB1.38KB
react (LazyPluginLoader.js)3.77KB1.33KB
react (SchemaRenderer.js)18.70KB6.09KB
react (data-invalidation.js)5.05KB2.08KB
react (index.js)0.76KB0.42KB
sdui-parser (codegen.js)4.09KB1.74KB
sdui-parser (index.js)2.16KB0.94KB
sdui-parser (parse.js)10.04KB2.82KB
sdui-parser (types.js)0.29KB0.24KB
sdui-parser (validate.js)4.69KB1.48KB
types (ai.js)0.20KB0.17KB
types (api-types.js)0.20KB0.18KB
types (app.js)2.87KB0.99KB
types (base.js)0.20KB0.18KB
types (blocks.js)0.20KB0.18KB
types (complex.js)0.20KB0.18KB
types (crud.js)0.20KB0.18KB
types (data-display.js)0.20KB0.18KB
types (data-protocol.js)0.20KB0.19KB
types (data.js)0.20KB0.18KB
types (designer.js)0.77KB0.41KB
types (disclosure.js)0.20KB0.18KB
types (feedback.js)0.20KB0.18KB
types (field-types.js)0.20KB0.18KB
types (form.js)0.20KB0.18KB
types (index.js)1.97KB0.93KB
types (layout.js)0.20KB0.18KB
types (mobile.js)0.20KB0.18KB
types (navigation.js)0.20KB0.18KB
types (objectql.js)0.20KB0.18KB
types (overlay.js)0.20KB0.18KB
types (permissions.js)0.20KB0.18KB
types (plugin-scope.js)0.20KB0.18KB
types (record-components.js)0.20KB0.19KB
types (record-semantics.js)1.28KB0.67KB
types (registry.js)0.20KB0.18KB
types (reports.js)0.20KB0.18KB
types (spec-report.js)5.26KB1.96KB
types (system-fields.js)2.39KB1.17KB
types (theme.js)0.20KB0.18KB
types (ui-action.js)0.75KB0.46KB
types (views.js)0.20KB0.18KB
types (widget.js)0.20KB0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-zhuang
os-zhuang merged commit 2b17339 into mainJul 19, 2026
14 checks passed
@os-zhuang
os-zhuang deleted the claude/showcase-owner-id-lists-6gxw6y branch July 19, 2026 17:34
This was referenced Jul 19, 2026
Merged
Closed
Merged
os-zhuang added a commit that referenced this pull request Jul 21, 2026
@os-zhuang@claude
fix(list): keep injected owner_id out of auto-generated list columns (#…
e56a9fd
…2777) (#2779)
ObjectView renders an object's default "所有记录" list (and prefills the
"Add View" dialog) from field order when the object declares no explicit
list view. Both paths carried their own name-based SYSTEM_FIELDS set that —
like the pre-#2702 lists in ObjectGrid / InterfaceListPage — never listed
owner_id. Since applySystemFields spreads injected system/audit/ownership
fields to the FRONT of the field map and owner_id is deliberately non-hidden
/ non-readonly (ownership is reassignable), it leaked through as the leading
raw-id column on every view-less object (e.g. showcase_invoice), redundant
with the business owner (Field.user) column.
Derive both paths through a single shared defaultListColumnsFromObject helper
that classifies system fields via isSystemManagedField from @object-ui/types
(the classifier #2702 introduced) — branching on the spec `system` flag with
a name-set fallback covering the ownership/tenancy FKs. Auto-derived lists
lead with business fields again and pick up future injected fields without
editing a name list. Adds a red/green unit test + changeset.
Closes#2777.
Co-authored-by: Jack Zhuang <277994282+os-zhuang@users.noreply.github.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
@github-actionsgithub-actionsBot mentioned this pull request Jul 21, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

package: typesplugintests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@os-zhuang@claude