Skip to content

refactor(managedBy): consolidate lifecycle-bucket logic into one shared source of truth - #2712

Merged
os-zhuang merged 1 commit into
mainfrom
claude/managedby-taxonomy-split-yder9o
Jul 20, 2026
Merged

refactor(managedBy): consolidate lifecycle-bucket logic into one shared source of truth#2712
os-zhuang merged 1 commit into
mainfrom
claude/managedby-taxonomy-split-yder9o

Conversation

@os-zhuang

@os-zhuangos-zhuang commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Follows framework ADR-0103 (the managedBy: 'system' taxonomy split) and the Console copy work in #2705. Eliminates the hand-mirrored bucket logic that ADR-0103's whole design had to work around.

Problem

The object-lifecycle managedBy bucket taxonomy was hand-mirrored in several places, kept "in lockstep" by comments:

  • app-shell/utils/crudAffordances.ts — the canonical ManagedByBucket union + DEFAULTS matrix + resolveCrudAffordances.
  • app-shell/components/ManagedByBadge.tsx — its ownBucket union, isWriteOptedIn, and the ADR-0103 writable-system derivation.
  • plugin-detail/renderers/record-details.tsx — its ownNON_EDITABLE_BUCKETS set (a comment explains it's duplicated because plugin-detail can't depend on app-shell).

And the schema type was open-ended — managedBy?: 'platform' | 'better-auth' | (string & {}) — so config / system / append-only slipped through the escape hatch and an unknown value silently defaulted to fully-editable platform.

Change (behavior-preserving)

Single source of truth, split by the dependency graph (plugin-detail can only reach @object-ui/types and @object-ui/core, both React-free):

  • @object-ui/types owns the closed ManagedByBucket union + MANAGED_BY_BUCKETS, and ObjectSchema.managedBy is tightened to it — unknown buckets are now a compile error, not a silent fallthrough.
  • @object-ui/core owns the runtime logic: resolveCrudAffordances, isWriteOptedIn, isSystemWritable, isObjectInlineEditable.
  • app-shell/utils/crudAffordances.ts becomes a thin re-export of @object-ui/core (existing ./crudAffordances imports keep working); ManagedByBadge consumes the shared isSystemWritable; record-details.tsx replaces the hand-mirrored NON_EDITABLE_BUCKETS with isObjectInlineEditable (which is exactly the resolved edit affordance — verified equivalent bucket-by-bucket).

Translated copy (badge variants, empty-state messages) stays in app-shell — only the booleans and the union move down.

Verification

  • Full dependency-graph build typechecks (29/29 packages) — the tightened type and rewired imports compile everywhere.
  • resolveCrudAffordances / rowCrudAffordances / ObjectForm.managedEdit / managedByEmptyState existing suites stay green (37 tests through the re-export shim); plugin-detail suite 237 pass.
  • New @object-ui/coremanagedBy.test.ts adds direct coverage, including the previously-untested isSystemWritable derivation.

Scope notes

  • The tightening is compile-safe: the only non-bucket managedBy strings in the repo (package/admin/user) belong to the unrelated permission-set provenance vocabulary, which is not typed against ObjectSchema.managedBy.

🤖 Generated with Claude Code

Generated by Claude Code

@claude
refactor(managedBy): consolidate lifecycle-bucket logic into one shar…
f2800b7
…ed source of truth
The managedBy bucket taxonomy was hand-mirrored across crudAffordances.ts,
ManagedByBadge.tsx (own Bucket union + isWriteOptedIn + writable-system
derivation), and plugin-detail record-details.tsx (NON_EDITABLE_BUCKETS,
duplicated because it can't depend on app-shell) — a drift risk. The schema
managedBy type was also open-ended ((string & {})), so unknown buckets slipped
through and silently defaulted to fully-editable.
- @object-ui/types owns the closed ManagedByBucket union (+ MANAGED_BY_BUCKETS);
ObjectSchema.managedBy is tightened to it (unknown buckets now a type error).
- @object-ui/core owns the React-free runtime logic (resolveCrudAffordances,
isWriteOptedIn, isSystemWritable, isObjectInlineEditable), reachable by every
UI package including plugin-detail.
- app-shell crudAffordances.ts is now a re-export shim; ManagedByBadge uses the
shared isSystemWritable; record-details uses isObjectInlineEditable in place of
the hand-mirrored NON_EDITABLE_BUCKETS.
Behavior-preserving: full-graph build typechecks; existing affordance/edit-gate
tests stay green; new core unit tests cover the logic incl. the previously
untested isSystemWritable. Follows framework ADR-0103.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Fp9yZxRQ3mb7p4vVwqFXKE
@vercel

vercelBot commented Jul 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
objectuiIgnoredIgnoredJul 20, 2026 2:09am

Request Review

@github-actions

github-actionsBot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

MetricValueBudget
Main entry (gzip)28.0 KB350 KB
Entry fileindex-WGku3tz_.js—
StatusPASS—

📦 Bundle Size Report

PackageSizeGzipped
app-shell (index.js)8.19KB2.96KB
app-shell (runtime-config.js)7.42KB2.32KB
app-shell (types.js)0.01KB0.04KB
app-shell (urlParams.js)7.57KB2.97KB
auth (AuthContext.js)0.31KB0.24KB
auth (AuthGuard.js)1.17KB0.53KB
auth (AuthProvider.js)21.70KB4.21KB
auth (AuthShell.js)3.49KB1.40KB
auth (ForgotPasswordForm.js)12.12KB3.41KB
auth (LoginForm.js)17.86KB5.29KB
auth (PreviewBanner.js)0.90KB0.50KB
auth (RegisterForm.js)6.43KB2.09KB
auth (SocialSignInButtons.js)9.60KB3.89KB
auth (UserMenu.js)3.40KB1.22KB
auth (auth-gate-events.js)1.29KB0.66KB
auth (authStyles.js)5.04KB1.72KB
auth (createAuthClient.js)33.74KB8.53KB
auth (createAuthenticatedFetch.js)3.93KB1.55KB
auth (index.js)1.83KB0.79KB
auth (phone-identifier.js)1.11KB0.66KB
auth (types.js)0.59KB0.35KB
auth (useAuth.js)4.86KB0.85KB
auth (useIsWorkspaceAdmin.js)1.61KB0.85KB
collaboration (CommentThread.js)18.38KB4.49KB
collaboration (LiveCursors.js)3.17KB1.27KB
collaboration (PresenceAvatars.js)3.65KB1.42KB
collaboration (PresenceProvider.js)2.42KB0.96KB
collaboration (index.js)1.25KB0.53KB
collaboration (useCommentSearch.js)1.98KB0.88KB
collaboration (useConflictResolution.js)7.75KB1.86KB
collaboration (useMentionNotifications.js)1.81KB0.68KB
collaboration (usePresence.js)6.33KB1.84KB
collaboration (useRealtimeSubscription.js)7.91KB2.01KB
components (index.js)450.03KB97.83KB
core (index.js)1.86KB0.63KB
create-plugin (index.js)9.28KB2.98KB
data-objectstack (index.js)120.81KB30.10KB
fields (index.js)209.35KB51.19KB
i18n (LocalizationContext.js)1.76KB0.96KB
i18n (currency.js)1.22KB0.64KB
i18n (i18n.js)4.32KB1.77KB
i18n (index.js)2.46KB0.96KB
i18n (pickLocalized.js)1.70KB0.83KB
i18n (provider.js)5.37KB1.72KB
i18n (useObjectLabel.js)21.22KB4.69KB
i18n (useSafeTranslation.js)2.87KB1.28KB
layout (index.js)38.45KB10.67KB
mobile (MobileProvider.js)0.92KB0.49KB
mobile (ResponsiveContainer.js)0.94KB0.38KB
mobile (breakpoints.js)1.51KB0.70KB
mobile (createOfflineDataSource.js)5.61KB1.74KB
mobile (index.js)1.50KB0.62KB
mobile (offlineQueue.js)3.91KB1.35KB
mobile (pwa.js)0.97KB0.49KB
mobile (serviceWorker.js)1.48KB0.62KB
mobile (serviceWorkerSource.js)3.41KB1.48KB
mobile (useBreakpoint.js)1.54KB0.65KB
mobile (useGesture.js)4.42KB1.27KB
mobile (useOfflineSync.js)1.99KB0.72KB
mobile (usePullToRefresh.js)2.53KB0.85KB
mobile (useResponsive.js)0.71KB0.42KB
mobile (useResponsiveConfig.js)1.36KB0.63KB
mobile (useSpecGesture.js)1.77KB0.77KB
mobile (useTouchTarget.js)1.01KB0.54KB
permissions (MePermissionsProvider.js)5.90KB2.15KB
permissions (PermissionContext.js)0.31KB0.25KB
permissions (PermissionGuard.js)0.89KB0.45KB
permissions (PermissionProvider.js)3.46KB1.03KB
permissions (evaluator.js)4.00KB1.23KB
permissions (index.js)0.91KB0.41KB
permissions (store.js)0.91KB0.42KB
permissions (useFieldPermissions.js)1.28KB0.52KB
permissions (usePermissions.js)1.50KB0.70KB
plugin-ai (index.js)15.71KB3.79KB
plugin-calendar (index.js)45.12KB12.34KB
plugin-charts (index.js)46.31KB13.06KB
plugin-chatbot (index.js)179.58KB42.81KB
plugin-dashboard (index.js)113.58KB28.77KB
plugin-designer (index.js)213.43KB42.95KB
plugin-detail (index.js)213.25KB51.88KB
plugin-editor (index.js)2.46KB1.10KB
plugin-form (index.js)102.94KB24.95KB
plugin-gantt (index.js)162.24KB39.49KB
plugin-grid (index.js)174.50KB46.00KB
plugin-kanban (index.js)47.23KB12.88KB
plugin-list (index.js)98.22KB23.21KB
plugin-map (index.js)16.80KB5.24KB
plugin-markdown (index.js)13.65KB4.67KB
plugin-report (index.js)37.81KB9.98KB
plugin-timeline (index.js)25.37KB7.20KB
plugin-tree (index.js)8.36KB2.81KB
plugin-view (index.js)85.72KB20.86KB
providers (DataSourceProvider.js)0.75KB0.39KB
providers (MetadataProvider.js)1.37KB0.59KB
providers (ThemeProvider.js)1.55KB0.67KB
providers (UploadProvider.js)11.71KB3.53KB
providers (index.js)0.44KB0.22KB
providers (types.js)0.01KB0.04KB
react-runtime (index.js)3.19KB1.38KB
react (LazyPluginLoader.js)3.77KB1.33KB
react (SchemaRenderer.js)18.70KB6.09KB
react (data-invalidation.js)5.05KB2.08KB
react (index.js)0.76KB0.42KB
sdui-parser (codegen.js)4.09KB1.74KB
sdui-parser (index.js)2.16KB0.94KB
sdui-parser (parse.js)10.04KB2.82KB
sdui-parser (types.js)0.29KB0.24KB
sdui-parser (validate.js)4.69KB1.48KB
types (ai.js)0.20KB0.17KB
types (api-types.js)0.20KB0.18KB
types (app.js)2.87KB0.99KB
types (base.js)0.20KB0.18KB
types (blocks.js)0.20KB0.18KB
types (complex.js)0.20KB0.18KB
types (crud.js)0.20KB0.18KB
types (data-display.js)0.20KB0.18KB
types (data-protocol.js)0.20KB0.19KB
types (data.js)0.20KB0.18KB
types (designer.js)0.77KB0.41KB
types (disclosure.js)0.20KB0.18KB
types (feedback.js)0.20KB0.18KB
types (field-types.js)0.20KB0.18KB
types (form.js)0.20KB0.18KB
types (index.js)2.02KB0.95KB
types (layout.js)0.20KB0.18KB
types (managed-by.js)0.17KB0.17KB
types (mobile.js)0.20KB0.18KB
types (navigation.js)0.20KB0.18KB
types (objectql.js)0.20KB0.18KB
types (overlay.js)0.20KB0.18KB
types (permissions.js)0.20KB0.18KB
types (plugin-scope.js)0.20KB0.18KB
types (record-components.js)0.20KB0.19KB
types (record-semantics.js)1.28KB0.67KB
types (registry.js)0.20KB0.18KB
types (reports.js)0.20KB0.18KB
types (spec-report.js)5.26KB1.96KB
types (system-fields.js)2.39KB1.17KB
types (theme.js)0.20KB0.18KB
types (ui-action.js)0.75KB0.46KB
types (views.js)0.20KB0.18KB
types (widget.js)0.20KB0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-zhuang
os-zhuang marked this pull request as ready for review July 20, 2026 02:32
@os-zhuang
os-zhuang merged commit 6d4fbe6 into mainJul 20, 2026
14 checks passed
@os-zhuang
os-zhuang deleted the claude/managedby-taxonomy-split-yder9o branch July 20, 2026 02:32
@os-zhuangos-zhuang mentioned this pull request Jul 20, 2026
Merged
os-zhuang added a commit that referenced this pull request Jul 20, 2026
@os-zhuang@claude
refactor(managedBy): one parser for the userActions override shape (c…
0a3710b
…ompletes #2712, framework#3343) (#2724)
#2712 consolidated the bucket union + affordance set mirrors but left four
surfaces still parsing the `userActions.{create,edit,delete}` override shape by
hand. They now all route through the shared @object-ui/core policy — no package
re-implements the boolean / #2614-object-form parse locally.
- core: promote internal `normalizeOverride` to exported `normalizeUserAction`
(the one parser) + add `userActionPredicates` for per-record predicate extraction.
- app-shell/managedByEmptyState: writable-`system` create check + local
`EmptyStateUserActions` → `resolveCrudAffordances({ managedBy, userActions }).create`.
- plugin-grid/rowCrudAffordances: local `isOptedOut`/`predicatesOf` + duplicated
types fold into `normalizeUserAction`; historical type names stay re-exported.
- plugin-detail/RelatedList: inline `predicatesOf` → `userActionPredicates`.
- plugin-form/ObjectForm: hand-rolled `managedBy !== 'platform'` blanket lock +
userActions unlock → resolved affordance for the mode (edit/create), the same
`resolveCrudAffordances` contract detail (`isObjectInlineEditable`) and grid use.
Behavior-preserving for platform/system/append-only/better-auth, with one
deliberate alignment: an admin-editable `config` object (sys_webhook,
sys_permission_set) is now editable in ObjectForm — it was over-locked as
non-`platform` while detail/grid already treated it as editable (config resolves
edit:true). New unit coverage for the shared parser + the config/create-mode form
gate; all existing affordance/edit-gate tests stay green.
Co-authored-by: Jack Zhuang <277994282+os-zhuang@users.noreply.github.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

package: corepackage: typesplugintests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@os-zhuang@claude