Uh oh!
There was an error while loading. Please reload this page.
docs(studio): sync capability-flag comments and restore label with spec #2377 removals - #2799
Merged
Merged
Conversation
#2377 removals framework#2377 (ADR-0049 enforce-or-remove, closed by framework#3414) removed enable.trash / enable.mru from the spec entirely — ObjectCapabilities is now .strict(), so authoring them is a parse error — and corrected enable.searchable to LIVE (global-search opt-out). objectui never rendered these toggles or shipped i18n keys for them, so only the surrounding prose had drifted: - ObjectSettingsPanel comment no longer calls searchable/trash/mru 'dead'; it now states trash/mru are removed (strict-rejected) and searchable is live but not yet surfaced. - The capabilities test keeps its absence assertions (they now also guard against authoring strict-rejected keys) with an updated rationale. - perm.action.restore label stops promising a recycle bin that never existed: 'Restore deleted records (reserved — deletes are hard today)' (en + zh), matching the platform's real hard-delete contract. ObjectSettingsPanel (12) + PermissionMatrixEditor.basics + studio-locale i18n tests green. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RRCHNGhKw8uVhA3ghXKDpA
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
os-zhuang
marked this pull request as ready for review
July 24, 2026 13:10
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to framework#2377 (ADR-0049 enforce-or-remove, closed by framework#3414), which removed
enable.trash/enable.mrufrom the spec entirely (ObjectCapabilitiesis now.strict()— authoring them is a parse error) and correctedenable.searchableto LIVE (global-search opt-out).Good news first: objectui needs no functional change — the Studio settings panel never rendered these toggles and no i18n bundle ever carried their keys. What had drifted was the surrounding prose:
ObjectSettingsPanel.tsxheader comment no longer callssearchable/trash/mru"dead": it now statestrash/mruare removed (strict-rejected on save) andsearchableis live but not yet surfaced.ObjectSettingsPanel.test.tsxkeeps its absence assertions (cap-trash/cap-mru/cap-searchablemust not render — they now also guard against authoring strict-rejected keys) with an updated rationale comment.perm.action.restorelabel stops promising a recycle bin that never existed:Restore deleted records (reserved — deletes are hard today)(en + zh), matching the platform's real hard-delete contract (framework#3414 removed the same false affordance from the API skill).Possible follow-up (not in this PR)
enable.searchableis now confirmed live (explicitfalseopts an object out of cross-object search). Whether Studio should surface acap-searchabletoggle is a product call — the plumbing inObjectSettingsPanelmakes it a one-lineCAPABILITIESentry + two i18n keys if wanted.Verification
ObjectSettingsPanel.test.tsx— 12 passedPermissionMatrixEditor.basics+studio-locale.i18n— 8 passed🤖 Generated with Claude Code
https://claude.ai/code/session_01RRCHNGhKw8uVhA3ghXKDpA
Generated by Claude Code