Skip to content

feat(report)!: drop SpecReportColumn/SpecReportGrouping re-exports + retire legacy ReportViewer chart fallback (#3463) - #2816

Merged
os-zhuang merged 1 commit into
mainfrom
chore/3463-retire-reportviewer-fallback
Jul 25, 2026
Merged

feat(report)!: drop SpecReportColumn/SpecReportGrouping re-exports + retire legacy ReportViewer chart fallback (#3463)#2816
os-zhuang merged 1 commit into
mainfrom
chore/3463-retire-reportviewer-fallback

Conversation

@os-zhuang

Copy link
Copy Markdown
Contributor

Companion to framework PR objectstack-ai/objectstack#3488. Refs objectstack-ai/objectstack#3463 (item 2 — the objectui-side retirement).

Context

Upstream @objectstack/spec removed the dead ReportColumnSchema / ReportGroupingSchema and the unread report chart.groupBy (framework #3488). This PR drops their objectui mirrors and retires the now-orphaned legacy report chart path. Independent of the spec bump: objectui keeps compiling against published spec 16.x — it only stops re-exporting the removed symbols.

What changed

  • types — removed the SpecReportColumn / SpecReportColumnInput / SpecReportGrouping / SpecReportGroupingInput type re-exports and the SpecReportColumnSchema / SpecReportGroupingSchema value re-exports from @object-ui/types. The live report shape is dataset-bound: SpecReport with dataset + values (measure names) + rows/columns (dimension names).
  • app-shellReportView now renders every report through the spec ReportRenderer dispatcher (dataset → DatasetReportRenderer, stored pre-9.0 JSON → presentation bridge, pre-spec { data, columns }LegacyReportRenderer). Deleted the ReportViewer last-resort branch, the mapReportForViewer spec→legacy chart-section adapter (the sole producer of xAxisField/yAxisFields), and the now-dead data-fetch loading flag. No shipped report metadata reached the removed branch — the Studio inspector only ever writes the dataset-bound shape.
  • plugin-report — removed the ReportViewer chart-section branch. It read the invented xAxisField/yAxisFields (never the spec's xAxis/yAxis) and was only fed by the deleted mapReportForViewer. ReportViewer itself is retained — its table/summary/text sections still back the report-viewer registered component and the pre-9.0 presentation bridge.

Net: −248 / +10 lines across 5 files.

Migration

Nothing an author writes changes. TypeScript consumers importing SpecReportColumn* / SpecReportGrouping* from @object-ui/types have no replacement type — model report columns as the dataset's measure names and grouping as its dimension names.

Verification

  • turbo build (types → plugin-report → app-shell + deps, 60 tasks) clean; app-shell builds via tsc.
  • turbo type-check across @object-ui/types + all dependents — 60/60 clean.
  • plugin-report 45 tests + the spec-ui-schema-reexports test pass.
  • Browser-verified against the showcase backend (Vite served the worktree source directly): the summary (Hours by Status), matrix (Status × Priority, with server totals), and joined (Task Overview) reports all render correctly through DatasetReportRenderer; /api/v1/meta/report + /api/v1/analytics/dataset/query all 200.

🤖 Generated with Claude Code

…retire the legacy ReportViewer chart fallback (#3463)
Cross-repo close-out of the ADR-0021 report cleanup (framework #3463). Upstream
@objectstack/spec removed the dead ReportColumnSchema / ReportGroupingSchema and
the unread report chart.groupBy; this drops their objectui mirrors and the
now-orphaned legacy report chart path.
- types: removed the SpecReportColumn / SpecReportColumnInput / SpecReportGrouping
/ SpecReportGroupingInput type re-exports and the SpecReportColumnSchema /
SpecReportGroupingSchema value re-exports (they aliased the deleted upstream
symbols). The live shape is dataset-bound: SpecReport with dataset + values
(measure names) + rows/columns (dimension names).
- app-shell: ReportView now renders every report through the spec ReportRenderer
dispatcher (dataset -> DatasetReportRenderer, stored pre-9.0 JSON -> bridge,
pre-spec { data, columns } -> LegacyReportRenderer). Deleted the ReportViewer
last-resort branch, the mapReportForViewer spec->legacy chart-section adapter
(sole producer of xAxisField/yAxisFields), and the now-dead data-fetch loading
flag. No shipped report metadata reached the removed branch.
- plugin-report: removed the ReportViewer chart-section branch. It read the
invented xAxisField/yAxisFields (never the spec's xAxis/yAxis) and was only
fed by the deleted mapReportForViewer. ReportViewer itself is retained -- its
table/summary/text sections back the report-viewer component + pre-9.0 bridge.
Browser-verified against the showcase backend: the summary, matrix and joined
reports all render through DatasetReportRenderer unchanged.
Refs #3463
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@vercel

vercelBot commented Jul 25, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
objectuiIgnoredIgnoredJul 25, 2026 3:07am

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

MetricValueBudget
Main entry (gzip)28.0 KB350 KB
Entry fileindex-BS5dWsYg.js
StatusPASS

📦 Bundle Size Report

PackageSizeGzipped
app-shell (index.js)8.19KB2.96KB
app-shell (runtime-config.js)7.42KB2.32KB
app-shell (types.js)0.01KB0.04KB
app-shell (urlParams.js)7.57KB2.97KB
auth (AuthContext.js)0.31KB0.24KB
auth (AuthGuard.js)1.17KB0.53KB
auth (AuthProvider.js)21.70KB4.21KB
auth (AuthShell.js)3.49KB1.40KB
auth (ForgotPasswordForm.js)12.12KB3.41KB
auth (LoginForm.js)17.86KB5.29KB
auth (PreviewBanner.js)0.90KB0.50KB
auth (RegisterForm.js)6.43KB2.09KB
auth (SocialSignInButtons.js)9.60KB3.89KB
auth (UserMenu.js)3.40KB1.22KB
auth (auth-gate-events.js)1.29KB0.66KB
auth (authStyles.js)5.04KB1.72KB
auth (createAuthClient.js)33.74KB8.53KB
auth (createAuthenticatedFetch.js)4.37KB1.69KB
auth (index.js)1.83KB0.79KB
auth (phone-identifier.js)1.11KB0.66KB
auth (types.js)0.59KB0.35KB
auth (useAuth.js)4.86KB0.85KB
auth (useIsWorkspaceAdmin.js)1.61KB0.85KB
collaboration (CommentThread.js)18.38KB4.49KB
collaboration (LiveCursors.js)3.17KB1.27KB
collaboration (PresenceAvatars.js)3.65KB1.42KB
collaboration (PresenceProvider.js)2.79KB1.13KB
collaboration (index.js)1.25KB0.53KB
collaboration (useCommentSearch.js)1.98KB0.88KB
collaboration (useConflictResolution.js)7.75KB1.86KB
collaboration (useMentionNotifications.js)1.81KB0.68KB
collaboration (usePresence.js)6.33KB1.84KB
collaboration (useRealtimeSubscription.js)7.91KB2.01KB
components (index.js)450.70KB98.15KB
core (index.js)1.86KB0.63KB
create-plugin (index.js)9.28KB2.98KB
data-objectstack (index.js)127.29KB31.96KB
fields (index.js)211.69KB51.79KB
i18n (LocalizationContext.js)1.76KB0.96KB
i18n (currency.js)1.22KB0.64KB
i18n (i18n.js)4.32KB1.77KB
i18n (index.js)2.46KB0.96KB
i18n (pickLocalized.js)1.70KB0.83KB
i18n (provider.js)5.37KB1.72KB
i18n (useObjectLabel.js)25.17KB5.80KB
i18n (useSafeTranslation.js)2.87KB1.28KB
layout (index.js)38.45KB10.67KB
mobile (MobileProvider.js)0.92KB0.49KB
mobile (ResponsiveContainer.js)0.94KB0.38KB
mobile (breakpoints.js)1.51KB0.70KB
mobile (createOfflineDataSource.js)5.61KB1.74KB
mobile (index.js)1.50KB0.62KB
mobile (offlineQueue.js)3.91KB1.35KB
mobile (pwa.js)0.97KB0.49KB
mobile (serviceWorker.js)1.48KB0.62KB
mobile (serviceWorkerSource.js)3.41KB1.48KB
mobile (useBreakpoint.js)1.54KB0.65KB
mobile (useGesture.js)4.42KB1.27KB
mobile (useOfflineSync.js)1.99KB0.72KB
mobile (usePullToRefresh.js)2.53KB0.85KB
mobile (useResponsive.js)0.71KB0.42KB
mobile (useResponsiveConfig.js)1.36KB0.63KB
mobile (useSpecGesture.js)1.77KB0.77KB
mobile (useTouchTarget.js)1.01KB0.54KB
permissions (MePermissionsProvider.js)5.90KB2.15KB
permissions (PermissionContext.js)0.31KB0.25KB
permissions (PermissionGuard.js)0.89KB0.45KB
permissions (PermissionProvider.js)3.46KB1.03KB
permissions (evaluator.js)4.00KB1.23KB
permissions (index.js)0.91KB0.41KB
permissions (store.js)0.91KB0.42KB
permissions (useFieldPermissions.js)1.28KB0.52KB
permissions (usePermissions.js)1.50KB0.70KB
plugin-ai (index.js)15.71KB3.79KB
plugin-calendar (index.js)45.37KB12.48KB
plugin-charts (index.js)46.90KB13.26KB
plugin-chatbot (index.js)179.53KB42.79KB
plugin-dashboard (index.js)108.71KB28.00KB
plugin-designer (index.js)210.92KB42.69KB
plugin-detail (index.js)214.78KB52.42KB
plugin-editor (index.js)2.46KB1.10KB
plugin-form (index.js)103.47KB25.10KB
plugin-gantt (index.js)162.33KB39.53KB
plugin-grid (index.js)175.05KB46.03KB
plugin-kanban (index.js)47.82KB13.18KB
plugin-list (index.js)98.59KB23.27KB
plugin-map (index.js)16.80KB5.24KB
plugin-markdown (index.js)13.65KB4.67KB
plugin-report (index.js)37.07KB9.81KB
plugin-timeline (index.js)25.37KB7.20KB
plugin-tree (index.js)8.36KB2.81KB
plugin-view (index.js)85.70KB20.87KB
providers (DataSourceProvider.js)0.75KB0.39KB
providers (MetadataProvider.js)1.37KB0.59KB
providers (ThemeProvider.js)1.55KB0.67KB
providers (UploadProvider.js)11.71KB3.53KB
providers (index.js)0.44KB0.22KB
providers (types.js)0.01KB0.04KB
react-runtime (index.js)3.19KB1.38KB
react (LazyPluginLoader.js)3.77KB1.33KB
react (SchemaRenderer.js)18.70KB6.09KB
react (data-invalidation.js)5.05KB2.08KB
react (index.js)1.00KB0.55KB
sdui-parser (codegen.js)4.09KB1.74KB
sdui-parser (index.js)2.16KB0.94KB
sdui-parser (parse.js)10.04KB2.82KB
sdui-parser (types.js)0.29KB0.24KB
sdui-parser (validate.js)4.69KB1.48KB
types (ai.js)0.20KB0.17KB
types (api-types.js)0.20KB0.18KB
types (app.js)2.87KB0.99KB
types (base.js)0.20KB0.18KB
types (blocks.js)0.20KB0.18KB
types (complex.js)0.20KB0.18KB
types (crud.js)0.20KB0.18KB
types (data-display.js)0.20KB0.18KB
types (data-protocol.js)0.20KB0.19KB
types (data.js)0.20KB0.18KB
types (designer.js)0.77KB0.41KB
types (disclosure.js)0.20KB0.18KB
types (feedback.js)0.20KB0.18KB
types (field-types.js)0.20KB0.18KB
types (form.js)0.20KB0.18KB
types (index.js)1.97KB0.93KB
types (layout.js)0.20KB0.18KB
types (managed-by.js)0.19KB0.18KB
types (mobile.js)0.20KB0.18KB
types (navigation.js)0.20KB0.18KB
types (objectql.js)0.20KB0.18KB
types (overlay.js)0.20KB0.18KB
types (permissions.js)0.20KB0.18KB
types (plugin-scope.js)0.20KB0.18KB
types (record-components.js)0.20KB0.19KB
types (record-semantics.js)1.28KB0.67KB
types (registry.js)0.20KB0.18KB
types (reports.js)0.20KB0.18KB
types (spec-report.js)5.04KB1.93KB
types (system-fields.js)2.39KB1.17KB
types (theme.js)0.20KB0.18KB
types (ui-action.js)0.75KB0.46KB
types (views.js)0.20KB0.18KB
types (widget.js)0.20KB0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-zhuang
os-zhuang merged commit 059a052 into mainJul 25, 2026
14 checks passed
@os-zhuang
os-zhuang deleted the chore/3463-retire-reportviewer-fallback branch July 25, 2026 03:20
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@os-zhuang