fix(attachments): read the storage service's new error envelope so gated downloads keep their friendly copy (objectstack#3675) by os-zhuang · Pull Request #2869 · objectstack-ai/objectui

os-zhuang · 2026-07-27T14:30:10Z

Paired with objectstack-ai/objectstack#3687 (closes objectstack#3675). This PR is load-bearing for that one — without it, the server-side change silently degrades a user-facing message.

What breaks without this

RecordAttachmentsPanel maps the server's fail-closed 40x codes (AUTH_REQUIRED, ATTACHMENT_DOWNLOAD_DENIED) to human copy. Its download handler read the code off the top level of the error body:

code=(awaitres.json())?.code;

The storage service has moved that code into the envelope its contract declares — { success: false, error: { code, message } } — so the top-level read now returns undefined, friendlyError matches nothing, and every gated download falls through to the generic:

Download failed (403)

instead of:

You don't have access to download this attachment.

Silent, and only on the 401/403 paths — exactly the paths a user hits when something is already going wrong.

The fix

constbody=(awaitres.json())as{code?: string;error?: {code?: string}}|null;code=body?.error?.code??body?.code;

Both dialects on purpose. The console ships independently of the server it talks to, so a current console must keep understanding an older one; tolerance is the right answer here rather than a synchronized cutover, and it makes the merge order of the two PRs irrelevant. This mirrors what the success branch two lines below has always done: body?.url ?? body?.data?.url.

Tests

The two existing tests mocked the old server shape, so they would have kept passing while the real thing regressed — stale fiction, not coverage. They now mock what the server actually sends, and a third case covers the legacy shape so the tolerance is an asserted property rather than an accident.

Mutation-checked: reverting the fix to body?.code fails the two new-envelope cases and passes the legacy one, which is the intended discrimination.

packages/app-shell — 143 files, 1195 tests passed.

Not changed

The upload path (UploadProvider) needed nothing: it stringifies the whole body into the error message, so friendlyError's raw.includes(code) fallback matches either shape. Verified rather than assumed.

🤖 Generated with Claude Code

https://claude.ai/code/session_01K35y3ovfWtCkBHYFCqUfAt

Generated by Claude Code

…ted downloads keep their friendly copy (objectstack#3675) `RecordAttachmentsPanel` maps the server's fail-closed 40x codes (`AUTH_REQUIRED`, `ATTACHMENT_DOWNLOAD_DENIED`) to human copy by reading `code` off the error body. It read the TOP LEVEL only. The storage service has moved that code into the envelope its contract declares — `{ success: false, error: { code, message } }` — so the top-level read now returns `undefined` and every gated download would have degraded from "You don't have access to download this attachment." to the generic "Download failed (403)". The download handler now reads `body?.error?.code ?? body?.code`, mirroring how the success branch two lines below already reads `body?.url ?? body?.data?.url`. Both dialects on purpose: the console ships independently of the server it talks to, so a current console must keep understanding an older one — tolerance is the right answer here, not a synchronized cutover. The two existing tests now mock what the server actually sends, and a third covers the legacy shape so the tolerance is an asserted property rather than an accident. Mutation-checked: dropping the nested read fails the two new-envelope cases. The upload path needed no change — it stringifies the whole body into the error message, so its substring match survives either shape. Co-Authored-By: Claude <noreply@anthropic.com>

vercel · 2026-07-27T14:30:17Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
objectui	Ignored		Jul 27, 2026 2:30pm

github-actions · 2026-07-27T14:34:17Z

✅ Console Performance Budget

Metric	Value	Budget
Main entry (gzip)	28.0 KB	350 KB
Entry file	`index-BKJ1QSOo.js`	—
Status	PASS	—

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (index.js)	8.20KB	2.97KB
app-shell (runtime-config.js)	7.42KB	2.32KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	7.57KB	2.97KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	1.17KB	0.53KB
auth (AuthProvider.js)	21.70KB	4.21KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	12.12KB	3.41KB
auth (LoginForm.js)	17.86KB	5.29KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.43KB	2.09KB
auth (SocialSignInButtons.js)	9.60KB	3.89KB
auth (UserMenu.js)	3.40KB	1.22KB
auth (auth-gate-events.js)	1.29KB	0.66KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	33.74KB	8.53KB
auth (createAuthenticatedFetch.js)	4.37KB	1.69KB
auth (index.js)	1.83KB	0.79KB
auth (phone-identifier.js)	1.11KB	0.66KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	4.86KB	0.85KB
auth (useIsWorkspaceAdmin.js)	1.61KB	0.85KB
collaboration (CommentThread.js)	18.38KB	4.49KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	3.65KB	1.42KB
collaboration (PresenceProvider.js)	2.79KB	1.13KB
collaboration (index.js)	1.25KB	0.53KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	450.91KB	98.17KB
core (index.js)	2.12KB	0.77KB
create-plugin (index.js)	9.28KB	2.98KB
data-objectstack (index.js)	127.29KB	31.96KB
fields (index.js)	218.37KB	53.54KB
i18n (LocalizationContext.js)	1.76KB	0.96KB
i18n (currency.js)	1.22KB	0.64KB
i18n (i18n.js)	4.32KB	1.77KB
i18n (index.js)	2.46KB	0.96KB
i18n (pickLocalized.js)	1.70KB	0.83KB
i18n (provider.js)	5.37KB	1.72KB
i18n (useObjectLabel.js)	25.17KB	5.80KB
i18n (useSafeTranslation.js)	2.87KB	1.28KB
layout (index.js)	38.45KB	10.67KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.74KB
mobile (index.js)	1.50KB	0.62KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	4.42KB	1.27KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.71KB	0.42KB
mobile (useResponsiveConfig.js)	1.36KB	0.63KB
mobile (useSpecGesture.js)	1.77KB	0.77KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	6.84KB	2.42KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	3.67KB	1.12KB
permissions (evaluator.js)	4.00KB	1.23KB
permissions (index.js)	0.91KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.52KB
permissions (usePermissions.js)	1.55KB	0.71KB
plugin-ai (index.js)	15.71KB	3.79KB
plugin-calendar (index.js)	45.37KB	12.48KB
plugin-charts (index.js)	47.20KB	13.35KB
plugin-chatbot (index.js)	179.53KB	42.79KB
plugin-dashboard (index.js)	109.60KB	28.33KB
plugin-designer (index.js)	210.92KB	42.69KB
plugin-detail (index.js)	215.28KB	52.50KB
plugin-editor (index.js)	2.46KB	1.10KB
plugin-form (index.js)	103.47KB	25.10KB
plugin-gantt (index.js)	162.33KB	39.53KB
plugin-grid (index.js)	178.24KB	46.72KB
plugin-kanban (index.js)	47.82KB	13.18KB
plugin-list (index.js)	98.71KB	23.32KB
plugin-map (index.js)	16.80KB	5.24KB
plugin-markdown (index.js)	13.65KB	4.67KB
plugin-report (index.js)	37.07KB	9.81KB
plugin-timeline (index.js)	25.37KB	7.20KB
plugin-tree (index.js)	8.36KB	2.81KB
plugin-view (index.js)	85.70KB	20.87KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.55KB	0.67KB
providers (UploadProvider.js)	11.71KB	3.53KB
providers (index.js)	0.44KB	0.22KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	3.19KB	1.38KB
react (LazyPluginLoader.js)	3.77KB	1.33KB
react (SchemaRenderer.js)	18.70KB	6.09KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	1.00KB	0.55KB
sdui-parser (codegen.js)	4.09KB	1.74KB
sdui-parser (index.js)	2.16KB	0.94KB
sdui-parser (parse.js)	10.04KB	2.82KB
sdui-parser (types.js)	0.29KB	0.24KB
sdui-parser (validate.js)	4.69KB	1.48KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	0.99KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	0.20KB	0.18KB
types (crud.js)	0.20KB	0.18KB
types (data-display.js)	0.20KB	0.18KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	0.77KB	0.41KB
types (disclosure.js)	0.20KB	0.18KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (index.js)	1.86KB	0.91KB
types (layout.js)	0.20KB	0.18KB
types (managed-by.js)	0.19KB	0.18KB
types (mobile.js)	0.20KB	0.18KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (record-semantics.js)	1.28KB	0.67KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (spec-report.js)	5.04KB	1.93KB
types (system-fields.js)	2.39KB	1.17KB
types (theme.js)	0.20KB	0.18KB
types (ui-action.js)	0.75KB	0.46KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

✅ Core packages should be < 50KB gzipped
✅ Component packages should be < 100KB gzipped
⚠️ Plugin packages should be < 150KB gzipped

github-actionsBot added the tests label Jul 27, 2026

os-zhuang mentioned this pull request Jul 27, 2026
fix(service-storage,service-i18n): emit the declared error envelope, not a bare { error } (#3675) objectstack-ai/objectstack#3687
Merged

os-zhuang marked this pull request as ready for review July 27, 2026 14:43

os-zhuang merged commit 70941e8 into mainJul 27, 2026
14 checks passed

os-zhuang deleted the claude/route-audit-tranche-3-service-wsxqaf branch July 27, 2026 14:43

Navigation Menu

Uh oh!

fix(attachments): read the storage service's new error envelope so gated downloads keep their friendly copy (objectstack#3675) - #2869

fix(attachments): read the storage service's new error envelope so gated downloads keep their friendly copy (objectstack#3675)#2869
os-zhuang merged 1 commit into
mainfrom
claude/route-audit-tranche-3-service-wsxqaf

os-zhuang commented Jul 27, 2026

Uh oh!

vercelBot commented Jul 27, 2026

Uh oh!

github-actionsBot commented Jul 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

os-zhuang commented Jul 27, 2026

What breaks without this

The fix

Tests

Not changed

Uh oh!

vercelBot commented Jul 27, 2026

Uh oh!

github-actionsBot commented Jul 27, 2026

✅ Console Performance Budget

📦 Bundle Size Report

Size Limits

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants