Skip to content

Add passWithNoTests to vitest configurations - #297

Merged
hotlong merged 2 commits into
copilot/fix-issue-in-object-uifrom
copilot/check-workflow-success
Jan 31, 2026
Merged

Add passWithNoTests to vitest configurations#297
hotlong merged 2 commits into
copilot/fix-issue-in-object-uifrom
copilot/check-workflow-success

Conversation

CopilotAI commented Jan 31, 2026

Copy link
Copy Markdown
Contributor

Vitest exits with code 1 when no test files are found, failing CI for 10+ packages that have test scripts but no tests yet (create-plugin, plugin-calendar, plugin-chatbot, etc.).

Changes

  • Added passWithNoTests: true to root vitest.config.mts
  • Added test sections with passWithNoTests: true to 17 package-level vite.config.ts files

Packages without their own vite.config.ts already inherit from root config. Packages with vite.config.ts needed explicit test sections since vite config takes precedence over vitest config.

// packages/plugin-*/vite.config.tsexportdefaultdefineConfig({// ... build configtest: {passWithNoTests: true,},});
Original prompt

引用: https://github.com/objectstack-ai/objectui/actions/runs/21540165902/job/62073421138#step:7:1


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@vercel

vercelBot commented Jan 31, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
objectuiReadyReadyPreview, CommentJan 31, 2026 6:47am
objectui-componentsReadyReadyPreview, CommentJan 31, 2026 6:47am
objectui-crm-appReadyReadyPreview, CommentJan 31, 2026 6:47am

Request Review

Add passWithNoTests: true to all vitest configurations to allow packages without test files to pass CI. This affects:
- Root vitest.config.mts
- All package-level vite.config.ts files with test sections
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
CopilotAI changed the title [WIP] Check success of workflow executionAdd passWithNoTests to vitest configurationsJan 31, 2026
CopilotAI requested a review from hotlongJanuary 31, 2026 06:44
@hotlong
hotlong marked this pull request as ready for review January 31, 2026 07:04
CopilotAI review requested due to automatic review settings January 31, 2026 07:04
@hotlong
hotlong merged commit 829cb97 into copilot/fix-issue-in-object-uiJan 31, 2026
8 checks passed

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request addresses CI failures caused by Vitest exiting with code 1 when no test files are found. The solution adds passWithNoTests: true configuration to prevent test failures in packages that have test scripts but no actual tests yet.

Changes:

  • Added passWithNoTests: true to the root vitest.config.mts file
  • Added test sections with passWithNoTests: true to 17 package-level vite.config.ts files

Reviewed changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.

Show a summary per file
FileDescription
vitest.config.mtsAdded passWithNoTests: true to root test configuration
packages/components/vite.config.tsAdded passWithNoTests: true to existing test section
packages/fields/vite.config.tsAdded passWithNoTests: true to existing test section
packages/layout/vite.config.tsCreated test section with passWithNoTests: true
packages/plugin-aggrid/vite.config.tsCreated test section with passWithNoTests: true
packages/plugin-calendar/vite.config.tsCreated test section with passWithNoTests: true
packages/plugin-charts/vite.config.tsCreated test section with passWithNoTests: true
packages/plugin-chatbot/vite.config.tsCreated test section with passWithNoTests: true
packages/plugin-dashboard/vite.config.tsCreated test section with passWithNoTests: true
packages/plugin-editor/vite.config.tsCreated test section with passWithNoTests: true
packages/plugin-form/vite.config.tsCreated test section with passWithNoTests: true
packages/plugin-gantt/vite.config.tsCreated test section with passWithNoTests: true
packages/plugin-grid/vite.config.tsCreated test section with passWithNoTests: true
packages/plugin-kanban/vite.config.tsCreated test section with passWithNoTests: true
packages/plugin-map/vite.config.tsCreated test section with passWithNoTests: true
packages/plugin-markdown/vite.config.tsCreated test section with passWithNoTests: true
packages/plugin-timeline/vite.config.tsCreated test section with passWithNoTests: true
packages/plugin-view/vite.config.tsCreated test section with passWithNoTests: true

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@hotlong