fix(deps): 模态表单里 lookup 搜索框聚焦即被夺回——补丁修复 focus-scope 栈驱逐竞态 (#3183) by baozhoutao · Pull Request #3184 · objectstack-ai/objectui

baozhoutao · 2026-08-02T06:48:12Z

问题

产线构建的 console(如 @objectstack/console@17.0.0-rc.1)中,新建/编辑记录的模态表单里 lookup 字段无法搜索:

快捷下拉的搜索框拿不到焦点——点击/聚焦瞬间被同步拽回「选择...」触发按钮,列表永不过滤;
「浏览全部」弹出的 Record Picker 表格弹窗同样无法搜索。

仅产线 bundle 复现,vite dev(HMR)正常,因此现有测试与日常开发均未暴露。Closes#3183。

根因

@radix-ui/react-focus-scope@1.1.16(上游最新 rc 同样存在)的栈驱逐竞态:

焦点栈管理 effect 的 cleanup 用 setTimeout(0) 延迟执行 focusScopesStack.remove(scope);
当该 effect 因 container ref 抖动在组件未卸载时重跑,顺序变成「重跑先 add → 旧 cleanup 的延时 remove 后执行」,刚加回去的 scope 被永久踢出栈;
此后 Dialog 的焦点陷阱监听器仍然活着,但没有任何弹层能 pause 它 → 弹层内输入框的焦点永远被同步夺回。

排查过程(服务端排除、浏览器插桩、fiber 状态挖掘)详见 #3183。

修复

pnpm patch(patches/@radix-ui__react-focus-scope.patch):

effect 重跑(scope 仍存活)时,clearTimeout 取消上一次 cleanup 挂起的延时驱逐;
真实卸载路径不变(autofocus-on-unmount 派发 + 栈移除照旧)。

验证

回归测试 packages/components/src/__tests__/dialog-popover-focus-scope.test.tsx:用「asChild 子元素换 key → container ref 重挂 → effect 必然重跑」确定性复现竞态,未打补丁必红、打补丁转绿(已双向验证);另附 Dialog+Popover 集成用例与陷阱恢复用例。
真机:os-tianshun-ehr rc.1 后端 + 修复后产线 console,下拉搜索 zzz→「未找到选项」、Dev→正确过滤;Record Picker 弹窗搜索恢复;showcase 后端 + 修复版产线构建同样验证通过。

备注

pnpm patch 只作用于本仓构建产物(console bundle,即产品发货路径);直接从 npm 消费 @object-ui/components 的第三方需等上游修复。
上游 radix-ui/primitives 最新版本仍未修复该竞态,补丁需保留至上游修复;升级 radix 时须确认并迁移补丁。

🤖 Generated with Claude Code

vercel · 2026-08-02T06:48:19Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
objectui	Ignored		Aug 2, 2026 6:48am

github-actions · 2026-08-02T06:51:29Z

✅ Console Performance Budget

Metric	Value	Budget
Main entry (gzip)	28.1 KB	350 KB
Entry file	`index-K-4WOhdq.js`	—
Status	PASS	—

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (index.js)	8.45KB	3.08KB
app-shell (runtime-config.js)	7.42KB	2.32KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	7.57KB	2.97KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	1.17KB	0.53KB
auth (AuthProvider.js)	22.10KB	4.37KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	12.12KB	3.41KB
auth (LoginForm.js)	17.86KB	5.29KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.43KB	2.09KB
auth (SocialSignInButtons.js)	9.60KB	3.89KB
auth (UserMenu.js)	3.40KB	1.22KB
auth (auth-gate-events.js)	1.29KB	0.66KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	35.76KB	9.11KB
auth (createAuthenticatedFetch.js)	4.37KB	1.69KB
auth (index.js)	2.35KB	1.07KB
auth (org-roles.js)	6.66KB	2.78KB
auth (phone-identifier.js)	1.11KB	0.66KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	4.91KB	0.87KB
auth (useIsWorkspaceAdmin.js)	1.61KB	0.85KB
collaboration (CommentThread.js)	18.38KB	4.49KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	3.65KB	1.42KB
collaboration (PresenceProvider.js)	2.79KB	1.13KB
collaboration (index.js)	1.25KB	0.53KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	475.95KB	104.41KB
core (index.js)	2.25KB	0.80KB
create-plugin (index.js)	9.28KB	2.98KB
data-objectstack (index.js)	136.20KB	34.74KB
fields (index.js)	223.45KB	54.66KB
i18n (LocalizationContext.js)	1.76KB	0.96KB
i18n (currency.js)	1.22KB	0.64KB
i18n (i18n.js)	4.32KB	1.77KB
i18n (index.js)	2.46KB	0.96KB
i18n (pickLocalized.js)	1.70KB	0.83KB
i18n (provider.js)	5.37KB	1.72KB
i18n (useObjectLabel.js)	26.14KB	6.07KB
i18n (useSafeTranslation.js)	3.26KB	1.44KB
layout (index.js)	38.44KB	10.66KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.74KB
mobile (index.js)	1.50KB	0.62KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	6.96KB	1.98KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.71KB	0.42KB
mobile (useResponsiveConfig.js)	1.36KB	0.63KB
mobile (useSpecGesture.js)	4.05KB	1.53KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	8.75KB	3.06KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	3.67KB	1.12KB
permissions (evaluator.js)	4.41KB	1.44KB
permissions (index.js)	0.91KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.52KB
permissions (usePermissions.js)	1.55KB	0.71KB
plugin-ai (index.js)	15.71KB	3.79KB
plugin-calendar (index.js)	44.90KB	12.35KB
plugin-charts (index.js)	60.53KB	17.12KB
plugin-chatbot (index.js)	180.09KB	42.72KB
plugin-dashboard (index.js)	111.86KB	28.81KB
plugin-designer (index.js)	210.51KB	42.50KB
plugin-detail (index.js)	224.52KB	54.98KB
plugin-editor (index.js)	2.46KB	1.10KB
plugin-form (index.js)	111.38KB	26.93KB
plugin-gantt (index.js)	162.26KB	39.53KB
plugin-grid (index.js)	184.69KB	48.91KB
plugin-kanban (index.js)	47.82KB	13.18KB
plugin-list (index.js)	104.87KB	25.31KB
plugin-map (index.js)	16.80KB	5.24KB
plugin-markdown (index.js)	13.65KB	4.67KB
plugin-report (index.js)	40.47KB	10.57KB
plugin-timeline (index.js)	25.76KB	7.32KB
plugin-tree (index.js)	8.34KB	2.82KB
plugin-view (index.js)	83.54KB	20.39KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.90KB	0.85KB
providers (UploadProvider.js)	11.71KB	3.53KB
providers (index.js)	0.44KB	0.22KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	5.67KB	2.37KB
react (LazyPluginLoader.js)	3.77KB	1.33KB
react (SchemaRenderer.js)	19.28KB	6.38KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	1.02KB	0.55KB
sdui-parser (codegen.js)	4.09KB	1.74KB
sdui-parser (index.js)	4.47KB	2.03KB
sdui-parser (parse.js)	10.04KB	2.82KB
sdui-parser (types.js)	0.29KB	0.24KB
sdui-parser (validate.js)	4.69KB	1.48KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	0.99KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	0.20KB	0.18KB
types (crud.js)	0.20KB	0.18KB
types (data-display.js)	0.20KB	0.18KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	1.87KB	0.85KB
types (disclosure.js)	0.20KB	0.18KB
types (error-code.js)	1.54KB	0.88KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (http-retry.js)	4.32KB	2.02KB
types (index.js)	2.46KB	1.21KB
types (layout.js)	0.20KB	0.18KB
types (managed-by.js)	0.19KB	0.18KB
types (mobile.js)	0.20KB	0.18KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (record-semantics.js)	1.28KB	0.67KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (spec-report.js)	5.05KB	1.93KB
types (system-fields.js)	3.33KB	1.54KB
types (theme.js)	0.20KB	0.18KB
types (ui-action.js)	3.40KB	1.71KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

✅ Core packages should be < 50KB gzipped
✅ Component packages should be < 100KB gzipped
⚠️ Plugin packages should be < 150KB gzipped

产线 console 里,新建/编辑模态中 lookup 快捷下拉的搜索框和 Record Picker 表格弹窗都无法输入:焦点在 focusout 阶段就被外层 Dialog 的 FocusScope 同步拽回触发按钮,列表永不过滤("新建记录时 lookup 无法搜索")。根因是 @radix-ui/react-focus-scope@1.1.16(上游最新 rc 同样存在)的竞态: 栈管理 effect 的 cleanup 用 setTimeout(0) 延迟执行 focusScopesStack.remove(scope)。当该 effect 因 container ref 抖动在组件未卸载时重跑,顺序变成"重跑先 add → 旧 cleanup 的延时 remove 后执行", 刚加回去的 scope 被永久踢出栈——dialog 的陷阱监听器还活着,却再也没有弹层能 pause 它。vite dev 不触发该抖动,所以只有产线 bundle 复现。 pnpm patch:effect 重跑(scope 存活)时取消挂起的延时驱逐;真实卸载路径 (autofocus-on-unmount + 栈移除)不变。回归测试用 asChild 子元素换 key 确定性复现竞态:未打补丁必红。已在 rc.1 后端 + 修复后产线 console 真机验证下拉与表格弹窗搜索均恢复。 Closes#3183 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

os-zhuang · 2026-08-02T12:39:27Z

已重新开发并合并

…说明 (objectstack-ai#3200) * fix(deps): 模态表单里 lookup 搜索框聚焦即被夺回——补丁修复 focus-scope 栈驱逐竞态 (objectstack-ai#3183) 产线 console 里,新建/编辑模态中 lookup 快捷下拉的搜索框和 Record Picker 表格弹窗都无法输入:焦点在 focusout 阶段就被外层 Dialog 的 FocusScope 同步拽回触发按钮,列表永不过滤("新建记录时 lookup 无法搜索")。根因是 @radix-ui/react-focus-scope@1.1.16(上游最新 rc 同样存在)的竞态: 栈管理 effect 的 cleanup 用 setTimeout(0) 延迟执行 focusScopesStack.remove(scope)。当该 effect 因 container ref 抖动在组件未卸载时重跑,顺序变成"重跑先 add → 旧 cleanup 的延时 remove 后执行", 刚加回去的 scope 被永久踢出栈——dialog 的陷阱监听器还活着,却再也没有弹层能 pause 它。vite dev 不触发该抖动,所以只有产线 bundle 复现。 pnpm patch:effect 重跑(scope 存活)时取消挂起的延时驱逐;真实卸载路径 (autofocus-on-unmount + 栈移除)不变。回归测试用 asChild 子元素换 key 确定性复现竞态:未打补丁必红。已在 rc.1 后端 + 修复后产线 console 真机验证下拉与表格弹窗搜索均恢复。 Closesobjectstack-ai#3183 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * docs(deps): 记录 focus-scope 补丁的存废条件,并把 changeset/注释改回英文合并 main 后的补充: - 新增 patches/README.md —— 本仓首次引入 pnpm patchedDependencies,而「为什么打、什么时候删」此前只写在 PR 描述里,合并后即消失。README 记下上游 issue、删除条件 (上游在 effect 重跑时取消挂起的驱逐)、编辑/删除补丁的操作,以及「版本号一变补丁失配就直接让 pnpm install 失败」这一刻意为之的响亮失败。 - changeset 与测试文件顶部注释里的中文改为英文 —— AGENTS.md 准则 #-1 要求代码注释与文档(changeset 会进 CHANGELOG,随 npm 发布)一律英文。 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NUhj4LiXcXGT93m3683KFK --------- Co-authored-by: 包周涛 <baozhoutao@hotoa.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

github-actionsBot added configuration dependencies package: components tests labels Aug 2, 2026

os-zhuang enabled auto-merge August 2, 2026 07:49

os-zhuang disabled auto-merge August 2, 2026 07:49

os-zhuang mentioned this pull request Aug 2, 2026
fix(deps): #3184 可合并版 —— focus-scope 栈驱逐竞态补丁,解冲突 + 补丁存废说明 #3200
Merged

os-zhuang closed this Aug 2, 2026

xuyushun441-sys mentioned this pull request Aug 3, 2026
console 产线构建:模态表单里 lookup 搜索框无法聚焦/输入——focus-scope 栈竞态把 dialog scope 踢出栈 #3183
Closed

Navigation Menu

Uh oh!

fix(deps): 模态表单里 lookup 搜索框聚焦即被夺回——补丁修复 focus-scope 栈驱逐竞态 (#3183) - #3184

fix(deps): 模态表单里 lookup 搜索框聚焦即被夺回——补丁修复 focus-scope 栈驱逐竞态 (#3183)#3184
baozhoutao wants to merge 1 commit into
mainfrom
claude/lookup-search-new-record-a5cbae

baozhoutao commented Aug 2, 2026

Uh oh!

vercelBot commented Aug 2, 2026

Uh oh!

github-actionsBot commented Aug 2, 2026

Uh oh!

os-zhuang commented Aug 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

baozhoutao commented Aug 2, 2026

问题

根因

修复

验证

备注

Uh oh!

vercelBot commented Aug 2, 2026

Uh oh!

github-actionsBot commented Aug 2, 2026

✅ Console Performance Budget

📦 Bundle Size Report

Size Limits

Uh oh!

os-zhuang commented Aug 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants