Skip to content

feat(types,core,app-shell)!: follow the managedBy: 'system''system-data' retirement (objectstack#3355) - #3214

Merged
os-zhuang merged 1 commit into
mainfrom
claude/issue-3355-retire-managedby-system
Aug 2, 2026
Merged

feat(types,core,app-shell)!: follow the managedBy: 'system''system-data' retirement (objectstack#3355)#3214
os-zhuang merged 1 commit into
mainfrom
claude/issue-3355-retire-managedby-system

Conversation

@os-zhuang

Copy link
Copy Markdown
Contributor

UI 侧配套 PR,对应 framework 的 objectstack-ai/objectstack#3355 / objectstack-ai/objectstack#4660两边需要一起合ManagedByBucket 是 framework 枚举的镜像,单独合任何一边都会让联合类型与 spec 失配。

背景

ADR-0103 在 v16 加法式拆分了被重载的 managedBy: 'system':引擎自有对象迁到显式的 engine-owned,admin/user 可写的 8 个留在 system。于是幸存的那个值恰好在描述已经搬走的那一半。protocol 17 把残留改名 system-data(schema 归平台,data 归 admin/用户),退役裸 system

这个 PR 真正删掉的是一层"推导"

因为 v16 的 system 同时兼任引擎自有默认值和可写集合,UI 有三处必须在渲染时从 userActions反推语义。桶名现在自己说清楚了,三处都改为直接读值:

位置v16(推导)v17(直读)
isSystemWritable()探测 userActions 里是否有任一 opted-in 写入managedBy === 'system-data'
ManagedByBadge派生一个合成的 'system-writable' variant keyvariant map 与桶联合 1:1
resolveManagedByEmptyState()用解析后的 create affordance 判断该显示"自动产生条目"还是 New 按钮system-data 按定义落到通用空状态;engine-owned 保留自动产生的文案

badge 那一条附带一个结构性收益:variant map 重新与联合类型一一对应,新增桶变成编译错误而不是静默 fallthrough——这正是 objectui#2712 当初关闭联合类型想要的性质,v16 的合成 key 把它撕开了一个口子。

i18n 键刻意不动systemsystemWritable),所以没有任何语言包需要改。engine-owned 继续复用 system 这个(不是退役的桶),文案一字未改。

Breaking(UI API)

ManagedByBadgeuserActions prop 与导出的 ManagedByUserActions 接口移除

桶名现在独自决定 variant,这个 prop 已经变成没有任何读者的元数据——正是 framework 那边这次改动要消灭的缺陷。把它保留成"接受但忽略"的 prop,等于在上一层原样复制一遍同一个缺陷,所以直接删。仓内 3 个调用点已同步(RecordDetailViewObjectViewRecordFormPage),下游只需删掉这个 prop,无其他改动。

MANAGED_BY_BUCKETS / ManagedByBucket 不再包含 'system'

关于跨仓时序

objectui 依赖已发布的 @objectstack/spec ^17.0.0-rc.1,其中还没有 system-data。这不影响运行时正确性:resolveCrudAffordances 委派给 spec,未知桶回落到 platform 默认行 {create,import,edit,delete,exportCsv: true},与新的 system-data逐位相同。等 framework 发版后回落路径消失,结果不变。

验证

pnpm turbo run build --filter=@object-ui/app-shell... --filter=@object-ui/plugin-detail...
Tasks: 29 successful, 29 total
npx vitest run packages/app-shell packages/core packages/types packages/plugin-detail
Test Files 375 passed (375)
Tests 4263 passed | 1 skipped (4264)

🤖 Generated with Claude Code

https://claude.ai/code/session_012C2cd7tL8QDoZ2QKN3djJ5


Generated by Claude Code

…tem-data'` retirement (objectstack#3355)
The UI half of the framework's protocol-17 retirement, landing with it so the
closed `ManagedByBucket` union stays a mirror rather than a fork.
What this deletes is a derivation. v16's `system` doubled as both the
engine-owned default and the writable set, so three surfaces had to RECOVER the
distinction from `userActions` at render time — `isSystemWritable`, the badge's
synthetic `'system-writable'` variant key, and the empty-state resolver's
`create`-affordance probe. The bucket now states it, so all three read the value
instead of inferring it, and the badge's variant map is 1:1 with the union again
(a new bucket becomes a compile error, not a fallthrough).
i18n keys are deliberately unchanged (`system`, `systemWritable`), so no locale
bundle moves.
BREAKING: `ManagedByBadge`'s `userActions` prop and the `ManagedByUserActions`
export are removed — the bucket selects the variant now, and keeping an accepted
-but-ignored prop would reproduce, one layer up, the dead-metadata defect this
change exists to remove.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012C2cd7tL8QDoZ2QKN3djJ5
@vercel

vercelBot commented Aug 2, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
objectuiIgnoredIgnoredAug 2, 2026 3:13pm

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

MetricValueBudget
Main entry (gzip)28.1 KB350 KB
Entry fileindex-Cpmi7KSF.js
StatusPASS

📦 Bundle Size Report

PackageSizeGzipped
app-shell (index.js)8.47KB3.09KB
app-shell (runtime-config.js)7.42KB2.32KB
app-shell (types.js)0.01KB0.04KB
app-shell (urlParams.js)7.57KB2.97KB
auth (AuthContext.js)0.31KB0.24KB
auth (AuthGuard.js)1.17KB0.53KB
auth (AuthProvider.js)22.10KB4.37KB
auth (AuthShell.js)3.49KB1.40KB
auth (ForgotPasswordForm.js)12.12KB3.41KB
auth (LoginForm.js)17.86KB5.29KB
auth (PreviewBanner.js)0.90KB0.50KB
auth (RegisterForm.js)6.43KB2.09KB
auth (SocialSignInButtons.js)9.60KB3.89KB
auth (UserMenu.js)3.40KB1.22KB
auth (auth-gate-events.js)1.29KB0.66KB
auth (authStyles.js)5.04KB1.72KB
auth (createAuthClient.js)35.76KB9.11KB
auth (createAuthenticatedFetch.js)4.37KB1.69KB
auth (index.js)2.35KB1.07KB
auth (org-roles.js)6.66KB2.78KB
auth (phone-identifier.js)1.11KB0.66KB
auth (types.js)0.59KB0.35KB
auth (useAuth.js)4.91KB0.87KB
auth (useIsWorkspaceAdmin.js)1.61KB0.85KB
collaboration (CommentThread.js)18.38KB4.49KB
collaboration (LiveCursors.js)3.17KB1.27KB
collaboration (PresenceAvatars.js)3.65KB1.42KB
collaboration (PresenceProvider.js)2.79KB1.13KB
collaboration (index.js)1.25KB0.53KB
collaboration (useCommentSearch.js)1.98KB0.88KB
collaboration (useConflictResolution.js)7.75KB1.86KB
collaboration (useMentionNotifications.js)1.81KB0.68KB
collaboration (usePresence.js)6.33KB1.84KB
collaboration (useRealtimeSubscription.js)7.91KB2.01KB
components (index.js)476.12KB104.47KB
core (index.js)2.25KB0.80KB
create-plugin (index.js)9.28KB2.98KB
data-objectstack (index.js)136.20KB34.74KB
fields (index.js)223.45KB54.66KB
i18n (LocalizationContext.js)1.76KB0.96KB
i18n (currency.js)1.22KB0.64KB
i18n (i18n.js)4.32KB1.77KB
i18n (index.js)2.46KB0.96KB
i18n (pickLocalized.js)1.70KB0.83KB
i18n (provider.js)5.37KB1.72KB
i18n (useObjectLabel.js)26.14KB6.07KB
i18n (useSafeTranslation.js)3.26KB1.44KB
layout (index.js)38.47KB10.67KB
mobile (MobileProvider.js)0.92KB0.49KB
mobile (ResponsiveContainer.js)0.94KB0.38KB
mobile (breakpoints.js)1.51KB0.70KB
mobile (createOfflineDataSource.js)5.61KB1.74KB
mobile (index.js)1.50KB0.62KB
mobile (offlineQueue.js)3.91KB1.35KB
mobile (pwa.js)0.97KB0.49KB
mobile (serviceWorker.js)1.48KB0.62KB
mobile (serviceWorkerSource.js)3.41KB1.48KB
mobile (useBreakpoint.js)1.54KB0.65KB
mobile (useGesture.js)6.96KB1.98KB
mobile (useOfflineSync.js)1.99KB0.72KB
mobile (usePullToRefresh.js)2.53KB0.85KB
mobile (useResponsive.js)0.71KB0.42KB
mobile (useResponsiveConfig.js)1.36KB0.63KB
mobile (useSpecGesture.js)4.05KB1.53KB
mobile (useTouchTarget.js)1.01KB0.54KB
permissions (MePermissionsProvider.js)8.75KB3.06KB
permissions (PermissionContext.js)0.31KB0.25KB
permissions (PermissionGuard.js)0.89KB0.45KB
permissions (PermissionProvider.js)3.67KB1.12KB
permissions (evaluator.js)4.41KB1.44KB
permissions (index.js)0.91KB0.41KB
permissions (store.js)0.91KB0.42KB
permissions (useFieldPermissions.js)1.28KB0.52KB
permissions (usePermissions.js)1.55KB0.71KB
plugin-ai (index.js)15.71KB3.79KB
plugin-calendar (index.js)44.90KB12.35KB
plugin-charts (index.js)60.53KB17.12KB
plugin-chatbot (index.js)180.09KB42.72KB
plugin-dashboard (index.js)111.87KB28.82KB
plugin-designer (index.js)210.51KB42.50KB
plugin-detail (index.js)230.17KB56.73KB
plugin-editor (index.js)2.46KB1.10KB
plugin-form (index.js)111.39KB26.93KB
plugin-gantt (index.js)162.26KB39.53KB
plugin-grid (index.js)185.10KB49.04KB
plugin-kanban (index.js)47.82KB13.18KB
plugin-list (index.js)104.88KB25.32KB
plugin-map (index.js)16.80KB5.24KB
plugin-markdown (index.js)13.65KB4.67KB
plugin-report (index.js)40.48KB10.57KB
plugin-timeline (index.js)25.76KB7.32KB
plugin-tree (index.js)8.34KB2.82KB
plugin-view (index.js)83.54KB20.39KB
providers (DataSourceProvider.js)0.75KB0.39KB
providers (MetadataProvider.js)1.37KB0.59KB
providers (ThemeProvider.js)1.90KB0.85KB
providers (UploadProvider.js)11.71KB3.53KB
providers (index.js)0.44KB0.22KB
providers (types.js)0.01KB0.04KB
react-runtime (index.js)5.67KB2.37KB
react (LazyPluginLoader.js)3.77KB1.33KB
react (SchemaRenderer.js)19.28KB6.38KB
react (data-invalidation.js)5.05KB2.08KB
react (index.js)1.02KB0.55KB
react (spec-input.js)0.20KB0.18KB
sdui-parser (codegen.js)4.09KB1.74KB
sdui-parser (index.js)4.47KB2.03KB
sdui-parser (parse.js)10.04KB2.82KB
sdui-parser (types.js)0.29KB0.24KB
sdui-parser (validate.js)4.69KB1.48KB
types (ai.js)0.20KB0.17KB
types (api-types.js)0.20KB0.18KB
types (app.js)2.87KB0.99KB
types (base.js)0.20KB0.18KB
types (blocks.js)0.20KB0.18KB
types (complex.js)0.20KB0.18KB
types (crud.js)0.20KB0.18KB
types (data-display.js)0.20KB0.18KB
types (data-protocol.js)0.20KB0.19KB
types (data.js)0.20KB0.18KB
types (designer.js)1.87KB0.85KB
types (disclosure.js)0.20KB0.18KB
types (error-code.js)1.54KB0.88KB
types (feedback.js)0.20KB0.18KB
types (field-types.js)0.20KB0.18KB
types (form.js)0.20KB0.18KB
types (http-retry.js)4.32KB2.02KB
types (index.js)2.46KB1.21KB
types (layout.js)0.20KB0.18KB
types (managed-by.js)0.19KB0.18KB
types (mobile.js)0.20KB0.18KB
types (navigation.js)0.20KB0.18KB
types (objectql.js)0.20KB0.18KB
types (overlay.js)0.20KB0.18KB
types (permissions.js)0.20KB0.18KB
types (plugin-scope.js)0.20KB0.18KB
types (record-components.js)0.20KB0.19KB
types (record-semantics.js)1.28KB0.67KB
types (registry.js)0.20KB0.18KB
types (reports.js)0.20KB0.18KB
types (spec-report.js)5.05KB1.93KB
types (system-fields.js)3.33KB1.54KB
types (theme.js)0.20KB0.18KB
types (ui-action.js)3.40KB1.71KB
types (views.js)0.20KB0.18KB
types (widget.js)0.20KB0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-zhuang
os-zhuang marked this pull request as ready for review August 2, 2026 16:10
@os-zhuang
os-zhuang added this pull request to the merge queueAug 2, 2026
Merged via the queue into main with commit 444457cAug 2, 2026
16 checks passed
@os-zhuang
os-zhuang deleted the claude/issue-3355-retire-managedby-system branch August 2, 2026 16:10
akarma-synetal pushed a commit to akarma-synetal/objectui that referenced this pull request Aug 10, 2026
…eryDataset (objectstack-ai#3813) (objectstack-ai#3824)
The runtime half of the hand-picked-envelope family objectstack-ai#3613/objectstack-ai#3752 fixed on the type
face. queryDataset rebuilds its result by picking keys off the REST payload one by
one, and drillRanges was never in the list — so the analytics service's objectstack-ai#1752
date-range drill sidecar was dropped by the only real adapter in this repo, while
five consumer sites were already reading it (DatasetWidget.tsx:471/:593,
DatasetReportRenderer.tsx:316/:431/:855).
The effect was a MISSING drill, not a degraded one. A dateGranularity dimension
groups a span of records into one bucket, which equality filters cannot express,
so service-analytics excludes date dims from dimensionFields/drillRawRows and
sends a half-open [gte, lt) range per row instead (analytics-service.ts:807+).
For a chart or report grouped only by time, drillRanges is therefore the only
thing that can make canDrill = !!object && (drillDims.length > 0 ||
!!drillRanges?.length) true — dropped, the whole drill entry point disappeared.
A mixed date + non-date grouping kept its drill but lost the time bound, so
clicking June's bar opened every month (a superset).
Neither side's tests could see it: the dashboard/report suites mock their own data
source and feed drillRanges in directly, and the adapter's suite never asserted the
key. The new tests mock the envelope the SERVER actually sends — bare (res.json,
no success/data wrapper), carrying sql, and for a date-only grouping carrying
object + drillRanges and NO dimensionFields/drillRawRows — then assert the key
arrives verbatim and row-aligned, that the consumers' own canDrill predicate is
true, and that the shared buildDatasetDrillFilter scopes the list to the clicked
bucket (both halves for a mixed grouping).
The entry type is @object-ui/core's DatasetDrillRange BY REFERENCE, not a local
{ field, gte, lt } copy: it is the single in-repo declaration of the shape (what
buildDatasetDrillFilter accepts and what both renderers type their state with) and
@objectstack/spec does not own it yet, so a restatement would be a third dialect.
drillRawTotals (objectstack-ai#3214) is deliberately NOT added: zero consumers in this repo, so
passing it through would add a declared-but-unexercised key with no user-facing
effect. Filed separately as a finding.
Claude-Session: https://claude.ai/code/session_01GTRjn8xBqp75dk7kFupVRt
Co-authored-by: Claude <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@os-zhuang@claude