Uh oh!
There was an error while loading. Please reload this page.
docs(layout): app-shell 的 Header Bar / Content Area 两处数值按 AppShell.tsx 现状改写 (#3914) - #3945
Merged
Merged
Conversation
…AppShell.tsx (#3914) The Header Bar height was documented as "64px / 4rem" (that is `h-16`), but the header has been `h-14` (3.5rem / 56px). The Content Area padding was documented as "4 on mobile, 6 on desktop", but it is a three-step scale (`p-3` / `sm:p-4` / `md:p-6`) and the mobile-only `pb-20` bottom padding was not documented at all. Docs follow the code here; AppShell.tsx is unchanged. Phrasing reuses the drift-resistant style #3786 established for page-header's Styling section: name the Tailwind class as the primary fact and state the breakpoint coverage explicitly, so a reader can check the claim against the source. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GTRjn8xBqp75dk7kFupVRt
The latest updates on your projects. Learn more about Vercel for GitHub. |
yinlianghui
commented
Aug 9, 2026
CollaboratorAuthor
✅ 验收通过(objectui 分片 PM,session 实物核验:head Generated by Claude Code |
yinlianghui
marked this pull request as ready for review
August 9, 2026 13:46
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#3914
docs-only。文档向代码对齐,未改
packages/layout/src/AppShell.tsx。前提复核(origin/main @
ebb579dbb)两处不符都仍然成立,行号与 issue 一致(用
git grep origin/main复核,非工作树):content/docs/layout/app-shell.mdx:64=- Fixed height (64px / 4rem)content/docs/layout/app-shell.mdx:71=- Responsive padding (4 on mobile, 6 on desktop)packages/layout/src/AppShell.tsx:249header 类含h-14(= 3.5rem = 56px);h-1[0-9]在该文件唯一命中此行,没有别处覆盖成 64px(h-16不存在)packages/layout/src/AppShell.tsx:257main 类为flex-1 min-w-0 overflow-auto p-3 sm:p-4 md:p-6 pb-20 sm:pb-4 md:pb-6改了什么(2 行 → 3 行)
64px / 4rem→h-14(3.5rem / 56px),并写明「每个断点都是这个高度,没有响应式变体」。p-3/sm:p-4/md:p-6),另起一条补上此前完全未记的移动端pb-20(5rem)。pb-20的用途不是猜的:移动端底部有一条fixed bottom-0 ... sm:hidden的底栏(packages/app-shell/src/layout/AppSidebar.tsx:744、packages/layout/src/AppSchemaRenderer.tsx:217),它的可见断点与pb-20 sm:pb-4的生效断点正好互补 —— 底栏只在 sm 以下出现,加高的底部留白也只在 sm 以下生效。措辞取向(照抄 #3786 的抗漂移写法)
参照 #3786 给
page-header.mdx的 Styling → Container 立的写法:把 Tailwind 类名本身作为首要事实、数值只作括注,并显式交代断点覆盖面(「at every breakpoint — there is no responsive variant」)。这样读者能拿文档里的类名直接去源码里对,而不是拿一个孤立数字无从验证 —— 这正是 issue 里点名的失效模式。验证
node scripts/check-doc-links.mjs→Links are valid across 7 scan roots.(exit 0)pnpm exec turbo run type-check --concurrency=2→78 successful, 78 total(exit 0);因 docs-only 不触及任何 TS 输入,这一轮 78/78 全为 turbo 缓存命中,所以另跑了一次强制编译取真实输出:--filter @object-ui/site --force→28 successful, 28 total / Cached: 0(@object-ui/site是content/docs的消费者,见apps/site/source.config.ts:6)node scripts/check-changeset-presence.mjs→No source of a released package changed in this range, so no changeset is owed.(exit 0)—— 按门自身判定,docs-only 不欠 changesetgrep -naP零命中;改动文件不含fable;⛔ 未碰content/docs/releases/顺手记下、不在本 PR 修的同文件/同组件漂移
按 Prime Directive #10 单独开卡,不夹带进这个 PR:
app-shell.mdx三处声称 AppShell 自带 sidebar toggle /SidebarTrigger,但packages/layout的 AppShell 从不渲染它 #3946 —— 同一页三处(:62、:106、:251)声称 AppShell 自带 sidebar toggle /SidebarTrigger,但git grep -c SidebarTrigger origin/main -- packages/layout/src是 0 命中,header 只渲染{navbar}。修法涉及「文档向代码对齐 vs 代码补 toggle」的取舍,不是换措辞能定,故留给维护者。AppShell.tsx导入了Sidebar却从不使用(dead import,现有 lint 未拦) #3947(finding)——AppShell.tsx:2-6导入了Sidebar却从不使用(dead import,现有 lint 未拦)。🤖 Generated with Claude Code
https://claude.ai/code/session_01GTRjn8xBqp75dk7kFupVRt