Skip to content

test(filter-parity): re-anchor the two filter-operator parity guards on pivots vocabulary growth cannot cancel (#3641) - #4100

Merged
yinlianghui merged 1 commit into
mainfrom
claude/issue-3641-filter-parity-discrimination
Aug 10, 2026
Merged

test(filter-parity): re-anchor the two filter-operator parity guards on pivots vocabulary growth cannot cancel (#3641)#4100
yinlianghui merged 1 commit into
mainfrom
claude/issue-3641-filter-parity-discrimination

Conversation

@yinlianghui

Copy link
Copy Markdown
Collaborator

Fixes#3641

Test-only. mapOperator and FILTER_OPERATOR_ALIASES are byte for byte as they are on main — verified with git diff --quiet origin/main on both production files.

Premise re-measured before implementing

Re-measured against the workspace's resolved @objectstack/spec@17.0.0-rc.5, since the vocabularies could have moved again since the card was filed. They had not:

spec version: 17.0.0-rc.5
VIEW_FILTER_OPERATORS count: 19
VALID_AST_OPERATORS size: 51
view ops ABSENT from VALID_AST_OPERATORS: 0 []

So the header claim "8 of the 19 canonical view operators are absent from the AST set" is measured at 0 of 19, and both guards were satisfiable by doing nothing. VALID_AST_OPERATORS is derived upstream from AST_OPERATOR_MAP, and it grew until it spelled every canonical view operator verbatim — before and after among them, which is the exact pair whose missing bridge entries caused the silent full-table read these files were written for (objectstack#3948).

What changed

packages/plugin-list/src/__tests__/filter-operator-ast-parity.test.ts — the spine is now EXPECTED_AST_TARGET, one row per canonical view operator naming the exact spelling mapOperator must emit. Each row is justified by naming the switch arm that produces it, read off ListView.tsx rather than captured from output (a capture would fossilise a bug if one existed). Two rows are pinned as identity (is_empty / is_not_empty) because they fall through default: return op; that is only safe while the AST gate accepts those spellings, so it is asserted rather than assumed — and asserting a fixed pair of literals can only go red, never be cancelled by growth.

A totality ratchet fails in both directions when the pinned rows and the spec vocabulary stop lining up: a spec addition lands red instead of as quiet slack (the growth direction this card is about), and so does a retirement (#3628 / #3601, the mirror image). The legacy-alias sweep is re-anchored on the same table with no second hand-written list — an alias the spec folds to a canonical operator must reach the wire as whatever that canonical operator does.

packages/data-objectstack/src/filter-operator-ast-parity.test.ts — the coverage sweep no longer mirrors production's ?? op tail. That tail is correct in production and stays there; reproducing it in the assertion is what cancelled it, because the value it falls back to is the raw view spelling and those are all AST-valid now. The sweep asserts the mapping row exists, resolving exactly as normalizeFilterOperator does minus that tail.

Header notes — the stale count is replaced by what the guarantee now rests on. No count of the overlap is stated anywhere in either file, deliberately: a hand-written number beside a vocabulary that moves is what rotted here in the first place.

The membership and isFilterAST() sweeps are kept as a secondary check, per the card's scope note. They still name why a wrong target matters; they are just no longer what gives the files their teeth. Nothing was retired.

Reverse verification

Both degradations were applied in-worktree and reverted; the direction was predicted before running.

1. mapOperator degraded to identity — 16 failed / 44 passed. The 14 non-identity pin rows went red, before and after among them:

mapOperator(equals) emits exactly =
mapOperator(not_equals) emits exactly !=
... mapOperator(before) emits exactly <
... mapOperator(after) emits exactly >
also bridges every legacy alias the spec still folds, onto the same target
emits `nin`, never the spaced `not in`, which no spec vocabulary defines

Both membership-based sweeps (%s maps to an AST-valid operator and the isFilterAST gate) stayed green under the identity function — the card's claim demonstrated empirically rather than by inspection.

2. One FILTER_OPERATOR_ALIASES row deletedstarts_with chosen deliberately over before, which the dedicated date-comparison test already pins, so the proof is unconfounded. New assertion: red with exactly ["starts_with"]. Then, with the same row still deleted, the old?? op assertion body was temporarily restored: 5 passed (5), fully green. That is the blindness proven directly rather than argued.

Restored state re-verified: production files identical to origin/main, both suites green.

Upstream probe (out of scope, reported not acted on)

The card asks whether before / after actually compile to WHERE clauses, or whether this is another silent full-table. Verdict: they compile. Not a silent full-table, so no objectstack-side card is warranted.

@objectstack/driver-sql@17.0.0-rc.5 was pulled from npm and inspected. The driver no longer compiles the array form at all — parseFilterAST() lowers it at the engine and protocol doors (objectstack#5158), and a filter array reaching the driver anyway is refused with a 400 rather than skipped. Measuring the lowering directly on the workspace spec:

canonicalAstOperator(before) = "<" parseFilterAST([["close_date","before","2024-01-01"]]) = {"close_date":{"$lt":"2024-01-01"}}
canonicalAstOperator(after) = ">" parseFilterAST([["close_date","after","2024-01-01"]]) = {"close_date":{"$gt":"2024-01-01"}}

and the driver's own compiler, package/dist/index.mjs:4709:

case ">":case "$gt":
returnbinary(">");
...
case"<":
case"$lt":
returnbinary("<");

End to end: before becomes $lt becomes a real < predicate. This confirms by runtime measurement what the triage comment read statically, and it does not make the objectui bridge redundant — the adapter still emits the array form, and an unmapped operator is still a broken query.

One consequence worth recording: the driver's 400 refusal means the historical "no WHERE clause, no error, every row returned" framing may no longer describe today's cost of a missing row. What the protocol door does with an array the AST gate rejects is not measurable from this repo, so both file headers now state that openly and leave it open rather than asserting either outcome — the point being that both are a broken query.

Verification

pnpm exec vitest run packages/plugin-list/... packages/data-objectstack/... -> 2 files, 65 tests passed
pnpm exec vitest run packages/data-objectstack packages/plugin-list -> 50 files, 793 tests passed
pnpm --filter @object-ui/plugin-list --filter @object-ui/data-objectstack type-check -> Done, Done
pnpm exec eslint (the two test files) -> exit 0
BASE=origin/main node scripts/check-changeset-presence.mjs -> exit 0

All vitest runs are from the repo root with repo-root paths (objectui#3378).

Changeset

check-changeset-presence.mjs arbitrated and it does not treat test-only as exempt by default — it flagged both files and demanded a declaration. Its sanctioned pass for "this releases nothing" is a changeset with an EMPTY frontmatter, which is what .changeset/filter-operator-parity-discrimination-3641.md carries; the gate then reports Every one of them has an EMPTY frontmatter — declared as releasing nothing, which is the explicit exemption and a complete answer to this gate.

No skip-changeset label was applied: per scripts/__tests__/ci-cd-pipeline-doc.test.ts:184 (objectui#3724) that label and its workflow "never [were] real" in this repo.


Generated by Claude Code

…so vocabulary growth cannot cancel the guards (#3641)
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017Qqyix2QcnpUC9XeYVDzx3
@vercel

vercelBot commented Aug 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
objectuiIgnoredIgnoredAug 10, 2026 9:33am

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

MetricValueBudget
Main entry (gzip)28.3 KB350 KB
Entry fileindex-CF5C3utx.js
StatusPASS

📦 Bundle Size Report

PackageSizeGzipped
app-shell (index.js)8.66KB3.13KB
app-shell (runtime-config.js)7.42KB2.32KB
app-shell (types.js)0.01KB0.04KB
app-shell (urlParams.js)7.57KB2.97KB
auth (AuthContext.js)0.31KB0.24KB
auth (AuthGuard.js)1.17KB0.53KB
auth (AuthProvider.js)22.10KB4.37KB
auth (AuthShell.js)3.49KB1.40KB
auth (ForgotPasswordForm.js)12.21KB3.45KB
auth (LoginForm.js)18.13KB5.39KB
auth (PreviewBanner.js)0.90KB0.50KB
auth (RegisterForm.js)6.64KB2.21KB
auth (SocialSignInButtons.js)9.60KB3.89KB
auth (UserMenu.js)3.40KB1.22KB
auth (auth-gate-events.js)1.29KB0.66KB
auth (authStyles.js)5.04KB1.72KB
auth (createAuthClient.js)35.76KB9.11KB
auth (createAuthenticatedFetch.js)4.37KB1.69KB
auth (index.js)2.35KB1.07KB
auth (org-roles.js)6.66KB2.78KB
auth (phone-identifier.js)1.11KB0.66KB
auth (types.js)0.59KB0.35KB
auth (useAuth.js)4.91KB0.87KB
auth (useIsWorkspaceAdmin.js)1.61KB0.85KB
collaboration (CommentThread.js)26.07KB7.56KB
collaboration (LiveCursors.js)3.17KB1.27KB
collaboration (PresenceAvatars.js)6.49KB2.64KB
collaboration (PresenceProvider.js)2.79KB1.13KB
collaboration (index.js)1.65KB0.73KB
collaboration (useCollaborationTranslation.js)6.05KB2.52KB
collaboration (useCommentSearch.js)1.98KB0.88KB
collaboration (useConflictResolution.js)7.75KB1.86KB
collaboration (useMentionNotifications.js)1.81KB0.68KB
collaboration (usePresence.js)6.33KB1.84KB
collaboration (useRealtimeSubscription.js)7.91KB2.01KB
components (index.js)484.15KB106.78KB
core (index.js)3.04KB1.15KB
create-plugin (index.js)10.08KB3.26KB
data-objectstack (index.js)140.66KB36.25KB
fields (index.js)229.40KB56.93KB
i18n (LocalizationContext.js)1.76KB0.96KB
i18n (currency.js)1.22KB0.64KB
i18n (i18n.js)4.32KB1.77KB
i18n (index.js)2.65KB1.06KB
i18n (pickLocalized.js)1.70KB0.83KB
i18n (provider.js)9.48KB3.27KB
i18n (useObjectLabel.js)27.59KB6.63KB
i18n (useSafeTranslation.js)4.52KB1.96KB
layout (index.js)38.87KB10.80KB
mobile (MobileProvider.js)0.92KB0.49KB
mobile (ResponsiveContainer.js)0.94KB0.38KB
mobile (breakpoints.js)1.51KB0.70KB
mobile (createOfflineDataSource.js)5.61KB1.74KB
mobile (index.js)1.50KB0.62KB
mobile (offlineQueue.js)3.91KB1.35KB
mobile (pwa.js)0.97KB0.49KB
mobile (serviceWorker.js)1.48KB0.62KB
mobile (serviceWorkerSource.js)3.41KB1.48KB
mobile (useBreakpoint.js)1.54KB0.65KB
mobile (useGesture.js)6.96KB1.98KB
mobile (useOfflineSync.js)1.99KB0.72KB
mobile (usePullToRefresh.js)2.53KB0.85KB
mobile (useResponsive.js)0.71KB0.42KB
mobile (useResponsiveConfig.js)1.36KB0.63KB
mobile (useSpecGesture.js)4.32KB1.64KB
mobile (useTouchTarget.js)1.01KB0.54KB
permissions (MePermissionsProvider.js)8.75KB3.06KB
permissions (PermissionContext.js)0.31KB0.25KB
permissions (PermissionGuard.js)0.89KB0.45KB
permissions (PermissionProvider.js)3.67KB1.12KB
permissions (evaluator.js)4.41KB1.44KB
permissions (index.js)0.91KB0.41KB
permissions (store.js)0.91KB0.42KB
permissions (useFieldPermissions.js)1.28KB0.52KB
permissions (usePermissions.js)1.55KB0.71KB
plugin-ai (index.js)15.71KB3.79KB
plugin-calendar (index.js)45.23KB12.45KB
plugin-charts (index.js)61.49KB17.48KB
plugin-chatbot (index.js)180.33KB42.79KB
plugin-dashboard (index.js)118.50KB30.66KB
plugin-designer (index.js)210.51KB42.51KB
plugin-detail (index.js)237.80KB59.48KB
plugin-editor (index.js)2.46KB1.10KB
plugin-form (index.js)114.58KB27.68KB
plugin-gantt (index.js)162.81KB39.67KB
plugin-grid (index.js)187.85KB49.83KB
plugin-kanban (index.js)48.60KB13.41KB
plugin-list (index.js)109.96KB26.64KB
plugin-map (index.js)17.00KB5.32KB
plugin-markdown (index.js)13.72KB4.69KB
plugin-report (index.js)40.58KB10.58KB
plugin-timeline (index.js)26.21KB7.52KB
plugin-tree (index.js)8.50KB2.88KB
plugin-view (index.js)84.03KB20.55KB
providers (DataSourceProvider.js)0.75KB0.39KB
providers (MetadataProvider.js)1.37KB0.59KB
providers (ThemeProvider.js)1.90KB0.85KB
providers (UploadProvider.js)11.71KB3.53KB
providers (index.js)0.44KB0.22KB
providers (types.js)0.01KB0.04KB
react-runtime (index.js)5.67KB2.37KB
react (LazyPluginLoader.js)3.77KB1.33KB
react (SchemaRenderer.js)23.71KB7.95KB
react (data-invalidation.js)5.05KB2.08KB
react (index.js)1.23KB0.66KB
react (spec-input.js)0.20KB0.18KB
sdui-parser (codegen.js)4.09KB1.74KB
sdui-parser (index.js)4.47KB2.03KB
sdui-parser (parse.js)10.04KB2.82KB
sdui-parser (types.js)0.29KB0.24KB
sdui-parser (validate.js)4.69KB1.48KB
types (ai.js)0.20KB0.17KB
types (api-types.js)0.20KB0.18KB
types (app.js)2.87KB0.99KB
types (base.js)0.20KB0.18KB
types (blocks.js)0.20KB0.18KB
types (complex.js)0.20KB0.18KB
types (crud.js)0.20KB0.18KB
types (data-display.js)0.20KB0.18KB
types (data-protocol.js)0.20KB0.19KB
types (data.js)0.20KB0.18KB
types (designer.js)1.87KB0.85KB
types (disclosure.js)0.20KB0.18KB
types (error-code.js)1.54KB0.88KB
types (feedback.js)0.20KB0.18KB
types (field-types.js)0.20KB0.18KB
types (form.js)0.20KB0.18KB
types (http-retry.js)4.32KB2.02KB
types (index.js)2.71KB1.34KB
types (layout.js)0.20KB0.18KB
types (managed-by.js)0.19KB0.18KB
types (mobile.js)2.59KB1.31KB
types (navigation.js)0.20KB0.18KB
types (objectql.js)0.20KB0.18KB
types (overlay.js)0.20KB0.18KB
types (permissions.js)0.20KB0.18KB
types (plugin-scope.js)0.20KB0.18KB
types (record-components.js)0.20KB0.19KB
types (record-semantics.js)1.28KB0.67KB
types (registry.js)0.20KB0.18KB
types (reports.js)0.20KB0.18KB
types (spec-report.js)5.05KB1.93KB
types (system-fields.js)3.33KB1.54KB
types (theme.js)0.20KB0.18KB
types (ui-action.js)3.40KB1.71KB
types (views.js)0.20KB0.18KB
types (widget.js)0.20KB0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@yinlianghui
yinlianghui marked this pull request as ready for review August 10, 2026 09:42
@yinlianghui
yinlianghui added this pull request to the merge queueAug 10, 2026
Merged via the queue into main with commit c869162Aug 10, 2026
21 checks passed
@yinlianghui
yinlianghui deleted the claude/issue-3641-filter-parity-discrimination branch August 10, 2026 09:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

2 participants

@yinlianghui@claude