Skip to content

test(plugin-charts): serve ObjectChart's option-color probe from a double, not the network - #4115

Merged
yinlianghui merged 1 commit into
mainfrom
claude/issue-4106-charts-dashboard-net-escape
Aug 10, 2026
Merged

test(plugin-charts): serve ObjectChart's option-color probe from a double, not the network#4115
yinlianghui merged 1 commit into
mainfrom
claude/issue-4106-charts-dashboard-net-escape

Conversation

@yinlianghui

Copy link
Copy Markdown
Collaborator

Fixes#4106

Test-only. Product code is untouched.

Premise: reproduced, still valid

On origin/main @ 877385a76, both packages' suites from the repo root:

pnpm exec vitest run packages/plugin-charts/ packages/plugin-dashboard/ --maxWorkers=2
Test Files 53 passed (53)
Tests 439 passed (439)
$ grep -c ECONNREFUSED stderr => 24
$ wc -l stderr => 96

Green suite, polluted stderr — the fail-open shape the card described. 96 stderr lines / 8 per error block = 12 escaped requests, 2 ECONNREFUSED lines each = 24. The arithmetic closes before any bisecting starts.

The bisect: one effect, two call sites, 100% of the noise

Per the card's inherited method (and PR #4105's worked example), I instrumented fetch / XMLHttpRequest / EventSource / WebSocket in the root setup file and attributed every escape to its test file rather than bisecting file by file.

escaping filelive requestsendpoint
plugin-charts/src/ObjectChart.drillNavigate.test.tsx4/api/v1/meta/object/opportunity
plugin-charts/src/__tests__/ObjectChart.compareTo.test.tsx4/api/v1/meta/object/deal
plugin-charts/src/ObjectChart.elementDataSource.test.tsx3/api/v1/meta/object/account
plugin-charts/src/ObjectChart.datasetMeasureLabel.test.tsx1/api/v1/meta/dataset/showcase_task_metrics
total12

12 requests x 2 lines = the 24 ECONNREFUSED lines exactly. All attributed, 0 unexplained.

Two findings worth stating plainly, because both differ from what the card assumed:

  1. The root cause is confirmed different from plugin-detail 测试套件里有测试向 127.0.0.1:3000 发起真实网络请求(ECONNREFUSED 噪音,未走 MSW) #3339. Nothing here touches useRecordEditable or /api/v1/security/explain. Every escape is ObjectChart's category option-color effect (ObjectChart.tsx:328), which reads the globalfetch at two call sites: line 344 (/api/v1/meta/dataset/..., to learn a dataset's underlying object) and line 352 (/api/v1/meta/object/..., for the field options). The effect is best-effort and swallows every rejection — which is exactly why the suites stayed green while stderr filled up.

  2. plugin-dashboard emits zero live requests. The card named both packages, but attribution puts all 12 in plugin-charts. plugin-dashboard resolves the same /api/v1/meta/object/... document in DatasetWidget, and its suite already answers it from a double (DatasetWidget.relabel.test.tsx:70) — which is why it is silent. Nothing to fix there; it is the precedent this PR follows.

Per-file counts are explained too, not just the total: elementDataSource renders 4 tests but its unresolvable-view case never resolves an objectName, so it makes 3 probes; datasetMeasureLabel's single dataset probe fails, so the second (object) hop never runs.

The fix

A recording test double scoped to the four escaping files, following the sibling package's existing pattern and #4105's.

{} as the default answer reproduces the failed request's observable outcome exactly: buildOptionColorMap(undefined) and buildDimensionLabelMap(undefined) both return null (packages/core/src/utils/chart-series.ts:198,275), which is the same state the swallowed rejection's catch branch already set. No existing assertion changes meaning.

No global error swallowing. The double records every URL it is handed, and each file's afterEach fails on anything outside its one expected endpoint — so a NEW escape becomes a failing assertion instead of fresh stderr noise. That guard covers every test in those files, not just the ones that probe today.

Product fallbacks untouched — but the global-fetch read is a genuine product bug, so per the card it is reported rather than silently fixed here: filed as #4114 (ObjectChart never consults SchemaRendererContext.apiFetch, though it already reads that context at line 253, so a hosted console's auth/base-URL channel is bypassed for these two metadata reads). ObjectChart.elementDataSource.test.tsx is the demonstration case — it mounts a real SchemaRendererProvider and the probe still escapes.

No MSW harness stood up, per the card.

Keeping the assertions meaningful

The escaped request was asserted by nobody, and because it always failed, the effect's success path had never once executed in this package's suite. New file ObjectChart.optionColors.test.tsx gives it real coverage from the component's own wiring (the map builders are unit-tested one level down in @object-ui/core; what is new is that ObjectChart asks for the right documents, in the right order, and feeds the results to the renderer):

  • an object-bound chart probes its object once and the option colors reach the renderer as categoryColors, keyed by both stored value and display label;
  • a dataset-bound chart makes two hops in order — the definition names the object, only then can that object's options be read — and the resulting value/label map is applied to the rows;
  • the best-effort contract itself: no options means no categoryColors and no failure.

Verification

Acceptance bar, the card's own command:

Test Files 54 passed (54) # 53 + the new file
Tests 442 passed (442) # 439 + 3 new
$ grep -c ECONNREFUSED stderr => 0
$ wc -l stderr => 0 # stderr entirely empty

Reverse verification, both directions predicted before running:

  1. Fix removed (git checkout origin/main -- on the four files, new file held aside) — noise returns at exactly 24ECONNREFUSED, and the suite is still green at 439 tests. Confirms the doubles are what stop it, and that the escape never had a test watching it.
  2. New assertion is load-bearing — breaking the product (buildOptionColorMap(undefined) at line 355, so field options are never read) turns it red: AssertionError: expected undefined to be truthy, 1 failed | 2 passed. The other two stay green as predicted, since dimension labels come from a different builder and the no-options case expects undefined either way. Restored afterwards; git diff HEAD -- packages/plugin-charts/src/ObjectChart.tsx is empty.

Gates: pnpm --filter @object-ui/plugin-charts type-check green (after pnpm --filter '@object-ui/plugin-charts^...' build — the fresh-worktree dependency closure), eslint on all five files 0 errors (15 pre-existing no-explicit-any warnings, same style as the surrounding mocks), control-byte self-scan clean. scripts/check-changeset-presence.mjs arbitrated and required the empty-frontmatter changeset for a test-only change — its sanctioned pass, not a workaround; check-changeset-no-major.mjs green. (skip-changeset is not a real label in this repo, per objectui#3724.)

Deliberately not in this PR


Generated by Claude Code

…uble, not the network
Fixes objectui#4106.
Test-only. Product code is untouched.
All 12 real-network escapes in the plugin-charts / plugin-dashboard suites come
from one call site pair in ObjectChart's category option-color effect, which
reads /api/v1/meta/dataset/<dataset> and /api/v1/meta/object/<object> off the
GLOBAL fetch. Under happy-dom those are real requests to the default origin;
the effect swallows the rejection by design (best-effort), so the suites stayed
green while stderr filled with `connect ECONNREFUSED 127.0.0.1:3000`.
Answer the probe from a recording double in the four escaping files, and give
its previously-unasserted request shape and success path real coverage.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017Qqyix2QcnpUC9XeYVDzx3
@vercel

vercelBot commented Aug 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
objectuiIgnoredIgnoredAug 10, 2026 10:47am

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

MetricValueBudget
Main entry (gzip)28.3 KB350 KB
Entry fileindex-BG4s-BOk.js
StatusPASS

📦 Bundle Size Report

PackageSizeGzipped
app-shell (index.js)8.66KB3.13KB
app-shell (runtime-config.js)7.42KB2.32KB
app-shell (types.js)0.01KB0.04KB
app-shell (urlParams.js)7.57KB2.97KB
auth (AuthContext.js)0.31KB0.24KB
auth (AuthGuard.js)1.17KB0.53KB
auth (AuthProvider.js)22.10KB4.37KB
auth (AuthShell.js)3.49KB1.40KB
auth (ForgotPasswordForm.js)12.21KB3.45KB
auth (LoginForm.js)18.13KB5.39KB
auth (PreviewBanner.js)0.90KB0.50KB
auth (RegisterForm.js)6.64KB2.21KB
auth (SocialSignInButtons.js)9.60KB3.89KB
auth (UserMenu.js)3.40KB1.22KB
auth (auth-gate-events.js)1.29KB0.66KB
auth (authStyles.js)5.04KB1.72KB
auth (createAuthClient.js)35.76KB9.11KB
auth (createAuthenticatedFetch.js)4.37KB1.69KB
auth (index.js)2.35KB1.07KB
auth (org-roles.js)6.66KB2.78KB
auth (phone-identifier.js)1.11KB0.66KB
auth (types.js)0.59KB0.35KB
auth (useAuth.js)4.91KB0.87KB
auth (useIsWorkspaceAdmin.js)1.61KB0.85KB
collaboration (CommentThread.js)26.07KB7.56KB
collaboration (LiveCursors.js)3.17KB1.27KB
collaboration (PresenceAvatars.js)6.49KB2.64KB
collaboration (PresenceProvider.js)2.79KB1.13KB
collaboration (index.js)1.65KB0.73KB
collaboration (useCollaborationTranslation.js)6.05KB2.52KB
collaboration (useCommentSearch.js)1.98KB0.88KB
collaboration (useConflictResolution.js)7.75KB1.86KB
collaboration (useMentionNotifications.js)1.81KB0.68KB
collaboration (usePresence.js)6.33KB1.84KB
collaboration (useRealtimeSubscription.js)7.91KB2.01KB
components (index.js)484.15KB106.78KB
core (index.js)3.04KB1.15KB
create-plugin (index.js)10.08KB3.26KB
data-objectstack (index.js)140.66KB36.25KB
fields (index.js)229.40KB56.93KB
i18n (LocalizationContext.js)1.76KB0.96KB
i18n (currency.js)1.22KB0.64KB
i18n (i18n.js)4.32KB1.77KB
i18n (index.js)2.65KB1.06KB
i18n (pickLocalized.js)1.70KB0.83KB
i18n (provider.js)9.48KB3.27KB
i18n (useObjectLabel.js)27.59KB6.63KB
i18n (useSafeTranslation.js)4.52KB1.96KB
layout (index.js)38.87KB10.80KB
mobile (MobileProvider.js)0.92KB0.49KB
mobile (ResponsiveContainer.js)0.94KB0.38KB
mobile (breakpoints.js)1.51KB0.70KB
mobile (createOfflineDataSource.js)5.61KB1.74KB
mobile (index.js)1.50KB0.62KB
mobile (offlineQueue.js)3.91KB1.35KB
mobile (pwa.js)0.97KB0.49KB
mobile (serviceWorker.js)1.48KB0.62KB
mobile (serviceWorkerSource.js)3.41KB1.48KB
mobile (useBreakpoint.js)1.54KB0.65KB
mobile (useGesture.js)6.96KB1.98KB
mobile (useOfflineSync.js)1.99KB0.72KB
mobile (usePullToRefresh.js)2.53KB0.85KB
mobile (useResponsive.js)0.71KB0.42KB
mobile (useResponsiveConfig.js)1.36KB0.63KB
mobile (useSpecGesture.js)4.32KB1.64KB
mobile (useTouchTarget.js)1.01KB0.54KB
permissions (MePermissionsProvider.js)8.75KB3.06KB
permissions (PermissionContext.js)0.31KB0.25KB
permissions (PermissionGuard.js)0.89KB0.45KB
permissions (PermissionProvider.js)3.67KB1.12KB
permissions (evaluator.js)4.41KB1.44KB
permissions (index.js)0.91KB0.41KB
permissions (store.js)0.91KB0.42KB
permissions (useFieldPermissions.js)1.28KB0.52KB
permissions (usePermissions.js)1.55KB0.71KB
plugin-ai (index.js)15.71KB3.79KB
plugin-calendar (index.js)45.23KB12.45KB
plugin-charts (index.js)61.49KB17.48KB
plugin-chatbot (index.js)180.33KB42.79KB
plugin-dashboard (index.js)118.50KB30.66KB
plugin-designer (index.js)210.51KB42.51KB
plugin-detail (index.js)237.80KB59.48KB
plugin-editor (index.js)2.46KB1.10KB
plugin-form (index.js)114.58KB27.68KB
plugin-gantt (index.js)162.81KB39.67KB
plugin-grid (index.js)188.04KB49.91KB
plugin-kanban (index.js)48.60KB13.41KB
plugin-list (index.js)110.04KB26.67KB
plugin-map (index.js)17.00KB5.32KB
plugin-markdown (index.js)13.72KB4.69KB
plugin-report (index.js)40.58KB10.58KB
plugin-timeline (index.js)26.21KB7.52KB
plugin-tree (index.js)8.50KB2.88KB
plugin-view (index.js)84.03KB20.55KB
providers (DataSourceProvider.js)0.75KB0.39KB
providers (MetadataProvider.js)1.37KB0.59KB
providers (ThemeProvider.js)1.90KB0.85KB
providers (UploadProvider.js)11.71KB3.53KB
providers (index.js)0.44KB0.22KB
providers (types.js)0.01KB0.04KB
react-runtime (index.js)5.67KB2.37KB
react (LazyPluginLoader.js)3.77KB1.33KB
react (SchemaRenderer.js)23.71KB7.95KB
react (data-invalidation.js)5.05KB2.08KB
react (index.js)1.23KB0.66KB
react (spec-input.js)0.20KB0.18KB
sdui-parser (codegen.js)4.09KB1.74KB
sdui-parser (index.js)4.47KB2.03KB
sdui-parser (parse.js)10.04KB2.82KB
sdui-parser (types.js)0.29KB0.24KB
sdui-parser (validate.js)4.69KB1.48KB
types (ai.js)0.20KB0.17KB
types (api-types.js)0.20KB0.18KB
types (app.js)2.87KB0.99KB
types (base.js)0.20KB0.18KB
types (blocks.js)0.20KB0.18KB
types (complex.js)0.20KB0.18KB
types (crud.js)0.20KB0.18KB
types (data-display.js)0.20KB0.18KB
types (data-protocol.js)0.20KB0.19KB
types (data.js)0.20KB0.18KB
types (designer.js)1.87KB0.85KB
types (disclosure.js)0.20KB0.18KB
types (error-code.js)1.54KB0.88KB
types (feedback.js)0.20KB0.18KB
types (field-types.js)0.20KB0.18KB
types (form.js)0.20KB0.18KB
types (http-retry.js)4.32KB2.02KB
types (index.js)2.71KB1.34KB
types (layout.js)0.20KB0.18KB
types (managed-by.js)0.19KB0.18KB
types (mobile.js)2.59KB1.31KB
types (navigation.js)0.20KB0.18KB
types (objectql.js)0.20KB0.18KB
types (overlay.js)0.20KB0.18KB
types (permissions.js)0.20KB0.18KB
types (plugin-scope.js)0.20KB0.18KB
types (record-components.js)0.20KB0.19KB
types (record-semantics.js)1.28KB0.67KB
types (registry.js)0.20KB0.18KB
types (reports.js)0.20KB0.18KB
types (spec-report.js)5.05KB1.93KB
types (system-fields.js)3.33KB1.54KB
types (theme.js)0.20KB0.18KB
types (ui-action.js)3.40KB1.71KB
types (views.js)0.20KB0.18KB
types (widget.js)0.20KB0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

plugin-charts / plugin-dashboard 测试套件仍有真实网络逃逸(ECONNREFUSED) — 根因与 #3339 不同,需独立定位

2 participants

@yinlianghui@claude