fix(i18n): fail on an inline defaultValue that contradicts its en value, and align the 43 that do (#3810)

[yinlianghui]

Fixes#3810

Option B + A per the delegated ruling on the card, measurement first. Option C (banning inline defaults on existing keys) is not taken.

The measurement, which decided the shape

The extended check, run over the whole repo before anything was fixed:

Scanned 1476 files, 3492 t()/tt() call sites: 2365 pack-backed (2314/2314 literal keys resolve), ...
Inline defaults: 851 literal (804 match their en value, 4 not comparable), 57 computed (report-only).
43 inline defaultValues contradict the en value of a key that EXISTS (38 distinct keys)

43 sites in 19 files. Small enough to fix in this PR, so the rule lands hard, with no baseline — no ratchet file, no debt, a new divergence is red on the day it is written. That is the branch the ruling asked for, and the census is what chose it: the card measured auth (8) and later comments measured console (1) and perm/home (4); the remaining ~1700 call sites had never been scanned, and they held 30 more.

Distribution — the card's guess that divergence clusters rather than spreads holds:

file	sites
packages/app-shell/src/console/organizations/OrganizationsPage.tsx	9
apps/console/src/pages/auth/RegisterPage.tsx	5
apps/console/src/pages/auth/ForgotPasswordPage.tsx	4
packages/app-shell/src/console/home/HomePage.tsx	4
apps/console/src/pages/auth/{LoginPage,VerifyEmailPromptPage}.tsx	2 + 2
14 further files	1-2 each

All 8 rows the card tables are confirmed against current origin/main (line numbers had shifted by one or two after #3546 slice three; the en values and the call-site texts are byte-identical to the card). Both sites of the repeated auth.verifyEmail.resendFailed key are covered. RegisterPage.tsx adds 5 more auth-family sites the card did not list — same namespace, same class.

The gate (B)

scripts/check-i18n-call-site-keys.mjs gains a third failure class, default-value-drift: when a call site carries a literaldefaultValue and the key resolves to an en leaf, the two must be equal byte for byte. collectEnKeys now returns leaf values as well as paths (folding the one 'a' + 'b' concatenation in en.ts), which is the only new machinery — the call-site half was already parsed.

Kept deliberately narrow, and each abstention is counted rather than silently dropped:

• A key en does not define is not reported here. That is missing-key's territory, and the two classes stay disjoint so either report reads on its own — pinned by a test asserting the finding list for such a call site is exactly ['missing-key'].
• Not judged, counted instead: a computed default (defaultValue: label), a key that is dynamic or denotes several literals, a returnObjects subtree, and the plural families (detail.showEmptyRelated resolves through _one/_other; there is no single form to compare against). Today: 57 computed, 4 not comparable.
• Failure output prints both strings with every non-ASCII byte escaped, because six of the 43 differed only by ... against U+2026 and are invisible otherwise.

The hint text points the fix at the call site and explicitly forbids editing en.ts to silence it.

The alignment (A)

All 43 call sites now repeat the pack value byte for byte. packages/i18n/src/locales/en.ts is untouched — verified by check:i18n-drift, which reports 0 en value(s) changed. Rows 3 and 6 of the card's table (the ellipsis-only pair) align to the pack's ..., per the card-specific clause; the pack's own typography mixing is not this card's business.

One correction to the card's premise

The card says the dead defaults are invisible to users. That is exact with an I18nProvider mounted, which is every console screen — but not universally. With no provider and no initialised i18next instance, react-i18next's not-ready t returns the defaultValue:

// react-i18next 17.0.11, dist/es/useTranslation.jsconstnotReadyT=(k,optsOrDefaultValue)=>{if(isString(optsOrDefaultValue))returnoptsOrDefaultValue;if(isObject(optsOrDefaultValue)&&isString(optsOrDefaultValue.defaultValue))returnoptsOrDefaultValue.defaultValue;

So on a provider-less host the inline string was the rendered one, for the sites whose hook is useObjectTranslation directly; sites reached through a createSafeTranslation hook take a third path that ignores the inline default altogether and renders the raw key (#3865). Either way this PR converges the two hosts on the sentence the pack serves, and the changeset is a patch on that basis rather than "no user-visible change at all". It does not weaken the finding — it sharpens the second cost the card names, since two hosts of the same component were rendering two different sentences.

Verification

• pnpm exec vitest run scripts/__tests__/check-i18n-call-site-keys.test.ts — 34 passed (9 new).
• Reverse verification: with the rule reverted (git checkout -- of the script, patch re-applied after), 7 of the 9 new tests go red. The two that stay green are the ones that should: the disjointness test (it guards against the rule OVER-firing, so removing the rule cannot make it fail) and the "main carries no drift" stock assertion. Before the alignment the gate itself exited 1 with the 43 findings — the census output above is that red run.
• pnpm exec vitest run packages/app-shell/ — 318 files, 2964 passed, 1 skipped.
• pnpm exec vitest run apps/console/ — 29 files, 300 passed.
• pnpm exec vitest run packages/plugin-list/ packages/plugin-detail/ — 91 files, 948 passed.
• pnpm exec vitest run scripts/ packages/i18n/ — 62 files, 1139 passed.
• pnpm check:i18n-keys — exit 0, Every in-scope call-site key resolves against the en pack (2921 keys), and every literal inline defaultValue matches the value the pack serves.
• pnpm check:i18n-drift — 0 en value(s) changed. node scripts/check-control-bytes.mjs — OK (3966 files).
• turbo run type-check and lint for app-shell / console / plugin-list / plugin-detail — 38 type-check tasks successful, lint 0 errors.
• check-changeset-presence / -fixed / -no-major — all green.

Out of scope, filed separately

Two classes this census surfaced that the ruling did not take. Both are filed rather than smuggled in here:

• [finding] The same dead i18n fallback spelled t(key) || 'English' — 24 sites, all on keys en defines, and #3810's new rule cannot see any of them #4117 — the same dead fallback spelled t(key) || 'English' / ?? 'English'. Measured first-hand: 24 sites, 18 distinct keys, 4 files, all 24 on keys en defines, and this PR's rule cannot see one of them (they carry no options argument). Five diverge in text; the || spelling is also strictly worse than defaultValue on a provider-less host, where it renders a raw key.
• The report config panel is titled "Title" and the empty state says "Object Not Found" — call sites asking for a key whose value is not the copy for that slot #4118 — sites where the divergence is evidence the call site is asking for the wrong key, so the copy users read today is wrong. ReportConfigPanel asks for report.editor.title, which is the Title field's label in the report editor form, for the panel's heading and aria-label: the panel is titled "Title" and the landmark is announced as "Title". Six more of the same shape.

Aligning both groups' call sites here is right regardless (the pack is what renders); whether the pack holds the right copy for each slot is a separate judgement, which is what #4118 is for.

A third, narrower one is recorded as a comment on the existing #3845 rather than a new card: home.welcome passes a product argument to an en value with no {{product}} hole, so i18next drops it — a second instance of that card's class, in a different namespace.

---

Generated by Claude Code

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
objectui	Ignored		Aug 10, 2026 11:07am

[github-actions]

✅ Console Performance Budget

Metric	Value	Budget
Main entry (gzip)	28.3 KB	350 KB
Entry file	index-BFagPtuH.js	—
Status	PASS	—

---

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (index.js)	8.66KB	3.13KB
app-shell (runtime-config.js)	7.42KB	2.32KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	7.57KB	2.97KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	1.17KB	0.53KB
auth (AuthProvider.js)	22.10KB	4.37KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	12.21KB	3.45KB
auth (LoginForm.js)	18.13KB	5.39KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.64KB	2.21KB
auth (SocialSignInButtons.js)	9.60KB	3.89KB
auth (UserMenu.js)	3.40KB	1.22KB
auth (auth-gate-events.js)	1.29KB	0.66KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	35.76KB	9.11KB
auth (createAuthenticatedFetch.js)	4.37KB	1.69KB
auth (index.js)	2.35KB	1.07KB
auth (org-roles.js)	6.66KB	2.78KB
auth (phone-identifier.js)	1.11KB	0.66KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	4.91KB	0.87KB
auth (useIsWorkspaceAdmin.js)	1.61KB	0.85KB
collaboration (CommentThread.js)	26.07KB	7.56KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	6.49KB	2.64KB
collaboration (PresenceProvider.js)	2.79KB	1.13KB
collaboration (index.js)	1.65KB	0.73KB
collaboration (useCollaborationTranslation.js)	6.05KB	2.52KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	485.06KB	107.21KB
core (index.js)	3.04KB	1.15KB
create-plugin (index.js)	10.08KB	3.26KB
data-objectstack (index.js)	140.66KB	36.25KB
fields (index.js)	229.40KB	56.93KB
i18n (LocalizationContext.js)	1.76KB	0.96KB
i18n (currency.js)	1.22KB	0.64KB
i18n (i18n.js)	4.32KB	1.77KB
i18n (index.js)	2.65KB	1.06KB
i18n (pickLocalized.js)	1.70KB	0.83KB
i18n (provider.js)	9.48KB	3.27KB
i18n (useObjectLabel.js)	27.59KB	6.63KB
i18n (useSafeTranslation.js)	4.52KB	1.96KB
layout (index.js)	38.87KB	10.80KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.74KB
mobile (index.js)	1.50KB	0.62KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	6.96KB	1.98KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.71KB	0.42KB
mobile (useResponsiveConfig.js)	1.36KB	0.63KB
mobile (useSpecGesture.js)	4.32KB	1.64KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	8.75KB	3.06KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	3.67KB	1.12KB
permissions (evaluator.js)	4.41KB	1.44KB
permissions (index.js)	0.91KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.52KB
permissions (usePermissions.js)	1.55KB	0.71KB
plugin-ai (index.js)	15.71KB	3.79KB
plugin-calendar (index.js)	45.23KB	12.45KB
plugin-charts (index.js)	61.49KB	17.48KB
plugin-chatbot (index.js)	180.33KB	42.79KB
plugin-dashboard (index.js)	118.50KB	30.66KB
plugin-designer (index.js)	210.51KB	42.51KB
plugin-detail (index.js)	237.80KB	59.48KB
plugin-editor (index.js)	2.46KB	1.10KB
plugin-form (index.js)	114.58KB	27.68KB
plugin-gantt (index.js)	162.81KB	39.67KB
plugin-grid (index.js)	188.04KB	49.91KB
plugin-kanban (index.js)	48.60KB	13.41KB
plugin-list (index.js)	110.04KB	26.67KB
plugin-map (index.js)	17.00KB	5.32KB
plugin-markdown (index.js)	13.72KB	4.69KB
plugin-report (index.js)	40.58KB	10.58KB
plugin-timeline (index.js)	26.21KB	7.52KB
plugin-tree (index.js)	8.50KB	2.88KB
plugin-view (index.js)	84.03KB	20.55KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.90KB	0.85KB
providers (UploadProvider.js)	11.71KB	3.53KB
providers (index.js)	0.44KB	0.22KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	5.67KB	2.37KB
react (LazyPluginLoader.js)	3.77KB	1.33KB
react (SchemaRenderer.js)	23.71KB	7.95KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	1.23KB	0.66KB
react (spec-input.js)	0.20KB	0.18KB
sdui-parser (codegen.js)	4.09KB	1.74KB
sdui-parser (index.js)	4.47KB	2.03KB
sdui-parser (parse.js)	10.04KB	2.82KB
sdui-parser (types.js)	0.29KB	0.24KB
sdui-parser (validate.js)	4.69KB	1.48KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	0.99KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	0.20KB	0.18KB
types (crud.js)	0.20KB	0.18KB
types (data-display.js)	0.20KB	0.18KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	1.87KB	0.85KB
types (disclosure.js)	0.20KB	0.18KB
types (error-code.js)	1.54KB	0.88KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (http-retry.js)	4.32KB	2.02KB
types (index.js)	2.71KB	1.34KB
types (layout.js)	0.20KB	0.18KB
types (managed-by.js)	0.19KB	0.18KB
types (mobile.js)	2.59KB	1.31KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (record-semantics.js)	1.28KB	0.67KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (spec-report.js)	5.05KB	1.93KB
types (system-fields.js)	3.33KB	1.54KB
types (theme.js)	0.20KB	0.18KB
types (ui-action.js)	3.40KB	1.71KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

• ✅ Core packages should be < 50KB gzipped
• ✅ Component packages should be < 100KB gzipped
• ⚠️ Plugin packages should be < 150KB gzipped