Skip to content

feat(app-shell): build the language menu from the app's locale list - #4260

Merged
yinlianghui merged 1 commit into
mainfrom
claude/issue-4039-locale-menu-from-app
Aug 11, 2026
Merged

feat(app-shell): build the language menu from the app's locale list#4260
yinlianghui merged 1 commit into
mainfrom
claude/issue-4039-locale-menu-from-app

Conversation

@yinlianghui

Copy link
Copy Markdown
Collaborator

Fixes#4039

Implements the binding INTERSECTION ruling on the card: the switcher offers (the app's GET /api/v1/i18n/locales response) ∩ (what the renderer can resolve). The hardcoded ten survive only as the offline/no-backend fallback, and PR #3376's restore validation widens in this same PR, as the card's own warning required.

Premise check (verified on tip, before implementing)

All three parts of the premise held:

  • LocaleSwitcher.tsx did build its menu from a module-level LANGUAGES constant — the ten built-in codes, never consulting the app.
  • The restore validation's bound was what fix(i18n): 语言选择写入 localStorage 并在启动时恢复,刷新不再退回 en #3376 landed: isKnownLanguage = built-in packs ∪ config.resources.
  • No client accessor existed for /api/v1/i18n/locales (only /i18n/translations/:locale, via apps/console/src/loadLanguage.ts), so adding a minimal one was in scope per the dispatch. It mirrors that sibling exactly.

The two sides of the intersection, as implemented

App side — a new loadLocales prop on I18nProvider, wired the same way as the existing loadLanguage: the app owns the transport, the provider owns what is done with the answer. apps/console/src/loadLocales.ts reads the real producer contract — GetLocalesResponseSchema declares { data: { locales: [{ code, label, isDefault }] } }, emitted through the shared toLocaleDescriptors by both serving surfaces.

Renderer side — built-in packs, config.resources, and the locales a wired dynamic loader can fetch. That last clause is load-bearing rather than generous: the console wires loadLanguage and no config.resources at all, so its app packs live behind GET /api/v1/i18n/translations/:locale. Without it the intersection in the real product would collapse to appLocales ∩ the built-in ten, and the card's first failure direction (an app shipping th) could never close.

One predicate serves both sides.canResolveLanguage is simultaneously the menu's right-hand side and the restore bound, so the two cannot drift apart — the lockstep is structural, not a convention someone has to remember. Reverse verification 2 below demonstrates this by construction.

Lockstep: the restore validation

A locale the user can now pick was a locale the old bound rejected, so the preference would have been purged on the next reload — the exact next bug objectstack#5418 predicted this fix would mint. The bound is widened, not removed:

Labels, loading, fallback

Built-in native names are kept where they exist (中文, 日本語, … unchanged); everything else is named by Intl.DisplayNames in its own locale. The endpoint's own label is deliberately not used for displaytoLocaleDescriptors sets label: code, so a server label would put th in the menu where ไทย belongs. No new i18n keys are added: check:i18n-drift reports 0 en values changed, 0 keys added.

While the list is in flight the switcher renders nothing, following the closest existing idiom in the same folder (AppSwitcher, WorkspaceSwitcher both return null for data they do not have yet) — so the ten never flash past on an app that ships two. No backend, a failed endpoint, or an answer with nothing this renderer can produce all fall back to the built-in ten: the menu is never empty.

Reverse verification

1 — revert the switcher alone (git checkout origin/main -- LocaleSwitcher.tsx): predicted RED on the intersection and loading pins. Confirmed, 4 failed / 5 passed:

× offers an app-shipped locale outside the built-in ten, named by Intl.DisplayNames
× offers an app-shipped locale supplied through config.resources
× shows ONLY what the app ships — the phantom eight are gone
× renders nothing until the app has answered — no flash of the fallback ten

The 5 that stayed green are expected to stay green and were predicted to: the two fallback pins and the built-in-native-name control cannot go red by reverting the switcher, because the offline fallback is the old behaviour. Reported rather than manufactured into a red.

2 — revert the validation widening alone (canResolveLanguage's loader clause only, switcher intact): predicted RED on the restore pins. Confirmed, 4 failed / 8 passed:

× restores an app-shipped locale that has no built-in pack
× restores it in the BOOTSTRAP language, not as a late correction
× leaves the stored locale alone when the app answers with nothing
× is the app list ∩ what this renderer can resolve

I predicted three; the fourth is the informative one. offerableLanguages went red too because the same predicate feeds the menu — which is the lockstep proven by construction: you cannot revert the restore half without also shrinking the menu half.

One honest non-red: still drops a stale app locale when the app no longer ships it stays green under the narrow bound, because it reaches the same end state through the bootstrap purge instead of the self-heal.

Tests

New: LocaleSwitcher.appLocales.test.tsx (9), provider-app-locale-restore.test.tsx (12, incl. a StrictMode single-request pin — main.tsx mounts under React.StrictMode and an inline prop identity changes every render), loadLocales.test.ts (7).

packages/i18n/ Test Files 38 passed Tests 661 passed
packages/app-shell/ Test Files 342 passed Tests 3250 passed | 1 skipped
type-check (i18n + app-shell + console, turbo) 37 successful, 37 total
lint (same three) 3 successful, 0 errors
check:control-bytes OK (3965 tracked text files) + control-byte self-scan on every touched file: clean
check:i18n-keys OK check:i18n-drift 0 en values changed, 0 keys added
changeset:check OK

Changeset: .changeset/locale-menu-from-app-4039.md (@object-ui/i18n minor, @object-ui/app-shell + @object-ui/console patch). No skip-changeset.


Generated by Claude Code

…4039)
The console's LocaleSwitcher built its items from a module-level LANGUAGES
constant — exactly the ten codes @object-ui/i18n ships packs for — and never
asked the app which locales it actually ships, even though
GET /api/v1/i18n/locales has been serving that list all along.
The menu is now the intersection: the app's own locale list against what the
renderer can resolve (built-in packs, config.resources, and the locales a wired
dynamic loader can fetch). Both failure directions close at once — an
app-shipped locale outside the ten becomes offerable, and locales the app does
not ship stop being offered.
The restore validation from PR #3376 widens in lockstep, because otherwise this
change would have minted the next bug: a locale the user can now pick was a
locale that bound rejected, so the preference would be purged on the next
reload. The bound stays honest — only well-formed BCP-47 tags, only for apps
that wired a loader — and the app's own list adjudicates it once it lands.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017Qqyix2QcnpUC9XeYVDzx3
@vercel

vercelBot commented Aug 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
objectuiIgnoredIgnoredAug 11, 2026 9:23am

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

MetricValueBudget
Main entry (gzip)28.5 KB350 KB
Entry fileindex-Dw6XJf9k.js
StatusPASS

📦 Bundle Size Report

PackageSizeGzipped
app-shell (index.js)8.88KB3.25KB
app-shell (runtime-config.js)7.42KB2.32KB
app-shell (types.js)0.01KB0.04KB
app-shell (urlParams.js)7.57KB2.97KB
auth (AuthContext.js)0.31KB0.24KB
auth (AuthGuard.js)1.17KB0.53KB
auth (AuthProvider.js)22.10KB4.37KB
auth (AuthShell.js)3.49KB1.40KB
auth (ForgotPasswordForm.js)12.21KB3.45KB
auth (LoginForm.js)18.13KB5.39KB
auth (PreviewBanner.js)0.90KB0.50KB
auth (RegisterForm.js)6.64KB2.21KB
auth (SocialSignInButtons.js)9.60KB3.89KB
auth (UserMenu.js)3.40KB1.22KB
auth (auth-gate-events.js)1.29KB0.66KB
auth (authStyles.js)5.04KB1.72KB
auth (createAuthClient.js)35.76KB9.11KB
auth (createAuthenticatedFetch.js)4.37KB1.69KB
auth (index.js)2.35KB1.07KB
auth (org-roles.js)6.66KB2.78KB
auth (phone-identifier.js)1.11KB0.66KB
auth (types.js)0.59KB0.35KB
auth (useAuth.js)4.91KB0.87KB
auth (useIsWorkspaceAdmin.js)1.61KB0.85KB
collaboration (CommentThread.js)26.07KB7.56KB
collaboration (LiveCursors.js)3.17KB1.27KB
collaboration (PresenceAvatars.js)6.49KB2.64KB
collaboration (PresenceProvider.js)2.79KB1.13KB
collaboration (index.js)1.65KB0.73KB
collaboration (useCollaborationTranslation.js)6.05KB2.52KB
collaboration (useCommentSearch.js)1.98KB0.88KB
collaboration (useConflictResolution.js)7.75KB1.86KB
collaboration (useMentionNotifications.js)1.81KB0.68KB
collaboration (usePresence.js)6.33KB1.84KB
collaboration (useRealtimeSubscription.js)7.91KB2.01KB
components (index.js)488.62KB108.26KB
core (index.js)3.04KB1.15KB
create-plugin (index.js)10.08KB3.26KB
data-objectstack (index.js)144.34KB37.61KB
fields (index.js)228.45KB56.62KB
i18n (LocalizationContext.js)1.76KB0.96KB
i18n (currency.js)1.22KB0.64KB
i18n (i18n.js)4.32KB1.77KB
i18n (index.js)2.65KB1.06KB
i18n (pickLocalized.js)1.70KB0.83KB
i18n (provider.js)16.38KB5.47KB
i18n (useObjectLabel.js)27.59KB6.63KB
i18n (useSafeTranslation.js)4.52KB1.96KB
layout (index.js)38.98KB10.85KB
mobile (MobileProvider.js)0.92KB0.49KB
mobile (ResponsiveContainer.js)0.94KB0.38KB
mobile (breakpoints.js)1.51KB0.70KB
mobile (createOfflineDataSource.js)5.61KB1.74KB
mobile (index.js)1.50KB0.62KB
mobile (offlineQueue.js)3.91KB1.35KB
mobile (pwa.js)0.97KB0.49KB
mobile (serviceWorker.js)1.48KB0.62KB
mobile (serviceWorkerSource.js)3.41KB1.48KB
mobile (useBreakpoint.js)1.54KB0.65KB
mobile (useGesture.js)6.96KB1.98KB
mobile (useOfflineSync.js)1.99KB0.72KB
mobile (usePullToRefresh.js)2.53KB0.85KB
mobile (useResponsive.js)0.71KB0.42KB
mobile (useResponsiveConfig.js)1.36KB0.63KB
mobile (useSpecGesture.js)4.32KB1.64KB
mobile (useTouchTarget.js)1.01KB0.54KB
permissions (MePermissionsProvider.js)8.75KB3.06KB
permissions (PermissionContext.js)0.31KB0.25KB
permissions (PermissionGuard.js)0.89KB0.45KB
permissions (PermissionProvider.js)3.67KB1.12KB
permissions (evaluator.js)4.41KB1.44KB
permissions (index.js)0.91KB0.41KB
permissions (store.js)0.91KB0.42KB
permissions (useFieldPermissions.js)1.28KB0.52KB
permissions (usePermissions.js)1.55KB0.71KB
plugin-ai (index.js)15.71KB3.79KB
plugin-calendar (index.js)45.23KB12.45KB
plugin-charts (index.js)61.52KB17.49KB
plugin-chatbot (index.js)180.33KB42.79KB
plugin-dashboard (index.js)118.58KB30.71KB
plugin-designer (index.js)210.91KB42.67KB
plugin-detail (index.js)238.88KB59.71KB
plugin-editor (index.js)2.46KB1.10KB
plugin-form (index.js)114.58KB27.68KB
plugin-gantt (index.js)164.14KB39.98KB
plugin-grid (index.js)187.97KB49.90KB
plugin-kanban (index.js)48.60KB13.41KB
plugin-list (index.js)110.31KB26.76KB
plugin-map (index.js)17.00KB5.32KB
plugin-markdown (index.js)13.72KB4.69KB
plugin-report (index.js)40.58KB10.58KB
plugin-timeline (index.js)26.21KB7.52KB
plugin-tree (index.js)8.50KB2.88KB
plugin-view (index.js)84.03KB20.55KB
providers (DataSourceProvider.js)0.75KB0.39KB
providers (MetadataProvider.js)1.37KB0.59KB
providers (ThemeProvider.js)1.90KB0.85KB
providers (UploadProvider.js)11.71KB3.53KB
providers (index.js)0.44KB0.22KB
providers (types.js)0.01KB0.04KB
react-runtime (index.js)5.67KB2.37KB
react (LazyPluginLoader.js)3.77KB1.33KB
react (SchemaRenderer.js)23.71KB7.96KB
react (data-invalidation.js)5.05KB2.08KB
react (index.js)1.23KB0.66KB
react (spec-input.js)0.20KB0.18KB
sdui-parser (codegen.js)4.09KB1.74KB
sdui-parser (index.js)4.47KB2.03KB
sdui-parser (parse.js)10.04KB2.82KB
sdui-parser (types.js)0.29KB0.24KB
sdui-parser (validate.js)4.69KB1.48KB
types (ai.js)0.20KB0.17KB
types (api-types.js)0.20KB0.18KB
types (app.js)2.87KB0.99KB
types (base.js)0.20KB0.18KB
types (blocks.js)0.20KB0.18KB
types (complex.js)0.20KB0.18KB
types (crud.js)0.20KB0.18KB
types (dashboard-filter-alias.js)6.23KB2.74KB
types (data-display.js)0.20KB0.18KB
types (data-protocol.js)0.20KB0.19KB
types (data.js)0.20KB0.18KB
types (designer.js)1.87KB0.85KB
types (disclosure.js)0.20KB0.18KB
types (error-code.js)1.54KB0.88KB
types (feedback.js)0.20KB0.18KB
types (field-types.js)0.20KB0.18KB
types (form.js)0.20KB0.18KB
types (http-retry.js)4.32KB2.02KB
types (index.js)3.05KB1.52KB
types (layout.js)0.20KB0.18KB
types (managed-by.js)0.19KB0.18KB
types (mobile.js)2.59KB1.31KB
types (navigation.js)0.20KB0.18KB
types (objectql.js)0.20KB0.18KB
types (overlay.js)0.20KB0.18KB
types (permissions.js)0.20KB0.18KB
types (plugin-scope.js)0.20KB0.18KB
types (record-components.js)0.20KB0.19KB
types (record-semantics.js)1.28KB0.67KB
types (registry.js)0.20KB0.18KB
types (reports.js)0.20KB0.18KB
types (spec-report.js)5.05KB1.93KB
types (system-fields.js)3.33KB1.54KB
types (theme.js)0.20KB0.18KB
types (ui-action.js)3.40KB1.71KB
types (views.js)0.20KB0.18KB
types (widget.js)0.20KB0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@yinlianghui
yinlianghui marked this pull request as ready for review August 11, 2026 09:38
@yinlianghui
yinlianghui added this pull request to the merge queueAug 11, 2026
Merged via the queue into main with commit 66fb4faAug 11, 2026
21 checks passed
@yinlianghui
yinlianghui deleted the claude/issue-4039-locale-menu-from-app branch August 11, 2026 09:39
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

console: the language menu is a hardcoded list of 10 codes — it never asks the app which locales it actually ships

2 participants

@yinlianghui@claude