refactor(list): converge ListViewBlock onto the shared ElementDataSourceGate

[yinlianghui]

Fixes#4038

ListViewBlock carried objectstack#5576's original inline copy of the dataSource precedence table. objectstack#6953 lifted the same table into @object-ui/react (useElementDataSourceSchema / ElementDataSourceGate) for the other eight object-bound blocks, deliberately not touching ListViewBlock — refactoring already-merged code inside a wiring PR would have been an out-of-scope regression surface. That left one table with two implementations: list-view on the private copy, everything else on the shared one. This PR deletes the private copy.

What landed

The useMemo mapping block (~45 lines) and the two hand-rolled status panels are gone. ListViewBlock now contributes only the part that is genuinely its own — the names of the keys ListView reads:

constLIST_VIEW_DATA_SOURCE: ElementDataSourceMapping={columns: true,filter: true,sort: true,limit: 'pagination.pageSize',viewType: true,};

exactly the shape the card proposed. The gate's mapping vocabulary supported it as-is — columns / filter / sort / viewType are booleans and 'pagination.pageSize' is already one of the three ElementDataSourceLimitKey spellings — so the shared gate needed no change, additive or otherwise. The only edit under packages/react/ is a doc comment that this PR falsified: it said ListViewBlock "still carries its own copy... a change to the rules below belongs in both places", which stops being true here.

The shared panels render with the list-view testId prefix, so list-view-datasource-error and list-view-resolving-view are unchanged down to the byte, and the error heading is passed through as errorTitle (the original sentence, verbatim). The adapter bridge (#3144) is untouched: the block still resolves the adapter off SchemaRendererContext itself, because ListView needs it as a prop and the gate cannot supply that.

The acceptance criterion — the card's own tripwire

objectstack#5576's suite passes untouched, zero assertion edits. Mechanically:

$ git diff --name-only origin/main -- packages/plugin-list/src/__tests__/ListView.elementDataSource.test.tsx
(no output)

and its 13 cases green, e.g.

✓ list-view — dataSource: { object, view } (objectstack#5576) > AND-combines the binding filter with the view’s, never replacing it
✓ list-view — dataSource: { object, view } (objectstack#5576) > lets the binding’s own sort and limit override the view’s
✓ list-view — an unresolvable dataSource.view fails loudly > never falls back to an unfiltered query for the object

Had any single case needed adapting, that would have meant the two implementations actually disagreed — a defect to re-grade, not a refactor detail to absorb — and this PR would not exist.

New pins, and what can actually turn them red

packages/plugin-list/src/__tests__/ListView.sharedGate.test.tsx (17 cases), split deliberately:

• 4 seam pins — that the mapping, the testId prefix, the error heading and the resolved adapter are handed to the shared gate. These are what fail if the block ever re-forks its own copy.
• 13 mapping-table pins — each key's routing through the gate on the list-view element: object, columns (including an authored-but-empty list counting as unauthored), the AND-composition of component + view + binding filters, both sort directions, the row cap landing on pagination.pageSize (and not on a flat limit/pageSize), viewType only when undeclared, and the unbound schema passing through by reference. These guard the five-line constant the refactor left behind, where a mistake is now cheap to make and invisible to review.

The shared loading panel is asserted for the first time by either implementation — list-view-resolving-view previously appeared only in the block's own source.

Reverse verification

Prediction was recorded before running: reverting ListViewBlock.tsx to the private copy should turn the seam pins that read what the block hands the gate RED, while everything behavioural stays GREEN — because the two implementations are semantically identical, which is the card's whole premise.

revert ListViewBlock.tsx	result
3 seam pins reading the gate's props	RED (gate never rendered)
4th seam pin (loading panel DOM)	GREEN — private copy emits the same testId
13 mapping-table pins	GREEN
objectstack#5576's 13 cases	GREEN

Tests 3 failed | 27 passed (30)

Confirmed as predicted, then restored. Note the second row of that table is the interesting one: the behavioural pins passing against both implementations is empirical confirmation of the card's equivalence premise, not a gap in the pins.

Evidence

$ pnpm exec vitest run packages/plugin-list/ packages/react/ --maxWorkers=2
Test Files 61 passed (61)
Tests 896 passed (896)

Baseline on main before the change: packages/plugin-list/ was 25 files / 394 tests; after, 26 files / 411 (the 17 new cases). The card's "60 files / 826 cases" was measured pre-repo-split and does not match this tree's count in either direction — reporting what this tree actually runs.

$ pnpm --filter @object-ui/plugin-list --filter @object-ui/react type-check
packages/react type-check: Done
packages/plugin-list type-check: Done
$ pnpm --filter @object-ui/plugin-list --filter @object-ui/react lint
packages/react lint: ✖ 322 problems (0 errors, 322 warnings)
packages/plugin-list lint: ✖ 355 problems (0 errors, 355 warnings)
$ node scripts/check-control-bytes.mjs
✅ check-control-bytes: OK (scanned 3923 tracked text file(s); skipped 85 binary).

Build closure (pnpm --filter '@object-ui/plugin-list^...' build) run first, so tsc read fresh .d.ts rather than stale artefacts. No i18n keys are involved: the panel copy is passed through as the original sentences, exactly as before.

Changeset: @object-ui/plugin-list patch. Not skip-changeset (#3724) — this is package source, and the changeset records a refactor with no behaviour change in either direction.

---

Generated by Claude Code

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
objectui	Ignored		Aug 11, 2026 9:52am

[github-actions]

✅ Console Performance Budget

Metric	Value	Budget
Main entry (gzip)	28.5 KB	350 KB
Entry file	index-B2LSvw1t.js	—
Status	PASS	—

---

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (index.js)	8.88KB	3.25KB
app-shell (runtime-config.js)	7.42KB	2.32KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	7.57KB	2.97KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	1.17KB	0.53KB
auth (AuthProvider.js)	22.10KB	4.37KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	12.21KB	3.45KB
auth (LoginForm.js)	18.13KB	5.39KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.64KB	2.21KB
auth (SocialSignInButtons.js)	9.60KB	3.89KB
auth (UserMenu.js)	3.40KB	1.22KB
auth (auth-gate-events.js)	1.29KB	0.66KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	35.76KB	9.11KB
auth (createAuthenticatedFetch.js)	4.37KB	1.69KB
auth (index.js)	2.35KB	1.07KB
auth (org-roles.js)	6.66KB	2.78KB
auth (phone-identifier.js)	1.11KB	0.66KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	4.91KB	0.87KB
auth (useIsWorkspaceAdmin.js)	1.61KB	0.85KB
collaboration (CommentThread.js)	26.07KB	7.56KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	6.49KB	2.64KB
collaboration (PresenceProvider.js)	2.79KB	1.13KB
collaboration (index.js)	1.65KB	0.73KB
collaboration (useCollaborationTranslation.js)	6.05KB	2.52KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	488.62KB	108.26KB
core (index.js)	3.04KB	1.15KB
create-plugin (index.js)	10.08KB	3.26KB
data-objectstack (index.js)	150.04KB	39.79KB
fields (index.js)	228.45KB	56.62KB
i18n (LocalizationContext.js)	1.76KB	0.96KB
i18n (currency.js)	1.22KB	0.64KB
i18n (i18n.js)	4.32KB	1.77KB
i18n (index.js)	2.65KB	1.06KB
i18n (pickLocalized.js)	1.70KB	0.83KB
i18n (provider.js)	16.38KB	5.47KB
i18n (useObjectLabel.js)	27.59KB	6.63KB
i18n (useSafeTranslation.js)	4.52KB	1.96KB
layout (index.js)	38.98KB	10.85KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.74KB
mobile (index.js)	1.50KB	0.62KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	6.96KB	1.98KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.71KB	0.42KB
mobile (useResponsiveConfig.js)	1.36KB	0.63KB
mobile (useSpecGesture.js)	4.32KB	1.64KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	8.75KB	3.06KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	3.67KB	1.12KB
permissions (evaluator.js)	4.41KB	1.44KB
permissions (index.js)	0.91KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.52KB
permissions (usePermissions.js)	1.55KB	0.71KB
plugin-ai (index.js)	15.71KB	3.79KB
plugin-calendar (index.js)	45.23KB	12.45KB
plugin-charts (index.js)	61.52KB	17.49KB
plugin-chatbot (index.js)	180.33KB	42.79KB
plugin-dashboard (index.js)	118.58KB	30.71KB
plugin-designer (index.js)	210.91KB	42.67KB
plugin-detail (index.js)	238.88KB	59.71KB
plugin-editor (index.js)	2.46KB	1.10KB
plugin-form (index.js)	114.58KB	27.68KB
plugin-gantt (index.js)	164.14KB	39.98KB
plugin-grid (index.js)	187.97KB	49.90KB
plugin-kanban (index.js)	48.60KB	13.41KB
plugin-list (index.js)	109.18KB	26.48KB
plugin-map (index.js)	17.00KB	5.32KB
plugin-markdown (index.js)	13.72KB	4.69KB
plugin-report (index.js)	40.58KB	10.58KB
plugin-timeline (index.js)	26.21KB	7.52KB
plugin-tree (index.js)	8.50KB	2.88KB
plugin-view (index.js)	84.03KB	20.55KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.90KB	0.85KB
providers (UploadProvider.js)	11.71KB	3.53KB
providers (index.js)	0.44KB	0.22KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	5.67KB	2.37KB
react (LazyPluginLoader.js)	3.77KB	1.33KB
react (SchemaRenderer.js)	23.71KB	7.96KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	1.23KB	0.66KB
react (spec-input.js)	0.20KB	0.18KB
sdui-parser (codegen.js)	4.09KB	1.74KB
sdui-parser (index.js)	4.47KB	2.03KB
sdui-parser (parse.js)	10.04KB	2.82KB
sdui-parser (types.js)	0.29KB	0.24KB
sdui-parser (validate.js)	4.69KB	1.48KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	0.99KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	0.20KB	0.18KB
types (crud.js)	0.20KB	0.18KB
types (dashboard-filter-alias.js)	6.23KB	2.74KB
types (data-display.js)	0.20KB	0.18KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	1.87KB	0.85KB
types (disclosure.js)	0.20KB	0.18KB
types (error-code.js)	1.54KB	0.88KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (http-retry.js)	4.32KB	2.02KB
types (index.js)	3.05KB	1.52KB
types (layout.js)	0.20KB	0.18KB
types (managed-by.js)	0.19KB	0.18KB
types (mobile.js)	2.59KB	1.31KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (record-semantics.js)	1.28KB	0.67KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (spec-report.js)	5.05KB	1.93KB
types (system-fields.js)	3.33KB	1.54KB
types (theme.js)	0.20KB	0.18KB
types (ui-action.js)	3.40KB	1.71KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

• ✅ Core packages should be < 50KB gzipped
• ✅ Component packages should be < 100KB gzipped
• ⚠️ Plugin packages should be < 150KB gzipped