Uh oh!
There was an error while loading. Please reload this page.
fix(auth): type-check its tests (#4040 tranche 1) - #4274
Merged
Conversation
`packages/auth` gains a `tsconfig.test.json` on the objectui#3032 template, chained from its `type-check` script after the existing narrow typetests project, so all eleven test files are compiled. Both declared code-tier errors were real. `AuthProvider.test.tsx`'s `createMockClient` returned `AuthClient` while implementing 8 of its ~38 methods — the double is right, the claim was not — so it is asserted at the one seam the way this package's three other mock-client factories already do. `createAuthClient.test.ts` had an unread `input` parameter on a fetch double. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017Qqyix2QcnpUC9XeYVDzx3
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
yinlianghui
marked this pull request as ready for review
August 11, 2026 11:22
Uh oh!
There was an error while loading. Please reload this page.
yinlianghui pushed a commit
that referenced
this pull request
Aug 11, 2026
…#4274, chatbot removal is this PR's)
yinlianghui pushed a commit
that referenced
this pull request
Aug 11, 2026
…#4274, gantt removal is this PR's)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #4040 — tranche 1, package 2 of 5. One package per PR, per the 裁决 on objectstack-ai/objectstack#4118 (PM, 2026-08-03):
Measured before / after
TEST_DEBT4cb0562b5)Before:
Both were real code-tier defects — nothing reclassified as config here.
1. A mock that claimed to be an
AuthClientand was notcreateMockClientis annotated: AuthClientand implements 8 of that interface's ~38methods. The double itself is the right call —
AuthProviderreaches only those 8 on thepaths under test, and stubbing thirty unreached methods would be noise. The claim was
not: an unchecked test asserting a type it does not satisfy is precisely the "reads as
evidence" failure #4040 is about.
Resolved the way this package's three other mock-client factories already do it —
LoginForm.test.tsx:36,identifier-trim.test.tsx:29,SocialSignInButtons.test.tsx:29all end
} as unknown as AuthClient;.AuthProvider.test.tsxwas the one that predatedthe convention. No public type changed, and no method was stubbed to make an assertion
pass.
2.
TS6133on an unread fetch-double parameternoUnusedParametersis on repo-wide;_inputis the sanctioned spelling.Discrimination proof — the new project can fail
A
tsconfig.test.jsonthat exists but compiles nothing is the objectui#3009 shape and thethird failure mode the 4118 thread names, so the new project itself is what needs its
discrimination shown. Appending a provably-false line to
src/__tests__/AuthProvider.test.tsxand re-running:
Reverted immediately; the probe is not in the diff.
Note on the existing narrow project
tsconfig.typetests.json(objectui#3181) compilesauth-spec-parity.test.tsalone — therescue for a package whose whole test tree was in debt. It stays chained and now overlaps
the full project, at the cost of one extra compile of one file. Retiring the narrow
projects once their package leaves
TEST_DEBTis a real cleanup but it is not thistranche's scope, and it is reported to the PM as a finding rather than smuggled in here.
Verification
TEST_DEBTshrinks by exactly this package's line; no other entry is touched.Generated by Claude Code