Skip to content

fix(auth): type-check its tests (#4040 tranche 1) - #4274

Merged
yinlianghui merged 1 commit into
mainfrom
claude/issue-4040-auth
Aug 11, 2026
Merged

fix(auth): type-check its tests (#4040 tranche 1)#4274
yinlianghui merged 1 commit into
mainfrom
claude/issue-4040-auth

Conversation

@yinlianghui

Copy link
Copy Markdown
Collaborator

Part of #4040 — tranche 1, package 2 of 5. One package per PR, per the 裁决 on objectstack-ai/objectstack#4118 (PM, 2026-08-03):

小包先行,core(80)/react(76)最后;
每包独立 PR;守卫类 PR 必须附 pre-fix 代码报红的运行记录(判别力证明,防「绿灯守卫从未真正跑过」——已发现的第三种失败模式:tsconfig.test.json 存在但没人跑);
TEST_DEBT 条目随包清零,只减不增。

Measured before / after

code-tier errors
declared in TEST_DEBT2
measured on this branch's base (4cb0562b5)2
after0

Before:

src/__tests__/AuthProvider.test.tsx(15,3): error TS2322: Type '{ signIn: ((credentials: SignInCredentials) => Promise< { user: AuthUser; session: AuthClientSession; } >) | Mock< ... >; ... 37 more ...; listUserInvitations?: (() => Promise< AuthInvitation[] >) | undefined; }' is not assignable to type 'AuthClient'.
Types of property 'sendVerificationEmail' are incompatible.
Type '((email: string, callbackURL?: string | undefined) => Promise< void >) | undefined' is not assignable to type '(email: string, callbackURL?: string | undefined) => Promise< void >'.
Type 'undefined' is not assignable to type '(email: string, callbackURL?: string | undefined) => Promise< void >'.
src/__tests__/createAuthClient.test.ts(154,33): error TS6133: 'input' is declared but its value is never read.

Both were real code-tier defects — nothing reclassified as config here.

1. A mock that claimed to be an AuthClient and was not

createMockClient is annotated : AuthClient and implements 8 of that interface's ~38
methods. The double itself is the right call — AuthProvider reaches only those 8 on the
paths under test, and stubbing thirty unreached methods would be noise. The claim was
not: an unchecked test asserting a type it does not satisfy is precisely the "reads as
evidence" failure #4040 is about.

Resolved the way this package's three other mock-client factories already do it —
LoginForm.test.tsx:36, identifier-trim.test.tsx:29, SocialSignInButtons.test.tsx:29
all end } as unknown as AuthClient;. AuthProvider.test.tsx was the one that predated
the convention. No public type changed, and no method was stubbed to make an assertion
pass.

2. TS6133 on an unread fetch-double parameter

noUnusedParameters is on repo-wide; _input is the sanctioned spelling.

Discrimination proof — the new project can fail

A tsconfig.test.json that exists but compiles nothing is the objectui#3009 shape and the
third failure mode the 4118 thread names, so the new project itself is what needs its
discrimination shown. Appending a provably-false line to src/__tests__/AuthProvider.test.tsx
and re-running:

$ npx tsc -p tsconfig.test.json
src/__tests__/AuthProvider.test.tsx(331,7): error TS2322: Type 'string' is not assignable to type 'number'.
EXIT:2

Reverted immediately; the probe is not in the diff.

Note on the existing narrow project

tsconfig.typetests.json (objectui#3181) compiles auth-spec-parity.test.ts alone — the
rescue for a package whose whole test tree was in debt. It stays chained and now overlaps
the full project, at the cost of one extra compile of one file. Retiring the narrow
projects once their package leaves TEST_DEBT is a real cleanup but it is not this
tranche's scope, and it is reported to the PM as a finding rather than smuggled in here.

Verification

$ pnpm --filter @object-ui/auth type-check
> tsc --noEmit && tsc -p tsconfig.typetests.json && tsc -p tsconfig.test.json
EXIT:0
$ pnpm exec vitest run packages/auth --maxWorkers=2 # from the repo root, per objectui#3378
Test Files 11 passed (11)
Tests 142 passed (142)
$ node scripts/check-type-check-coverage.mjs
type-check coverage: 43/45 via `type-check`, 1 via their own build, 0 known-broken (0 errors outstanding), 1 not compiled.
test type-check coverage: 26/40 packages compile their tests, 14 declared debt (238 errors outstanding), 10 with a narrow type-assertion project.
$ node scripts/check-changeset-presence.mjs
2 source file(s) of 1 released package(s) changed, and this change declares 1 changeset(s) ... EMPTY frontmatter — declared as releasing nothing.

TEST_DEBT shrinks by exactly this package's line; no other entry is touched.


Generated by Claude Code

`packages/auth` gains a `tsconfig.test.json` on the objectui#3032 template,
chained from its `type-check` script after the existing narrow typetests
project, so all eleven test files are compiled.
Both declared code-tier errors were real. `AuthProvider.test.tsx`'s
`createMockClient` returned `AuthClient` while implementing 8 of its ~38
methods — the double is right, the claim was not — so it is asserted at the one
seam the way this package's three other mock-client factories already do.
`createAuthClient.test.ts` had an unread `input` parameter on a fetch double.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017Qqyix2QcnpUC9XeYVDzx3
@vercel

vercelBot commented Aug 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
objectuiIgnoredIgnoredAug 11, 2026 10:21am

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

MetricValueBudget
Main entry (gzip)28.5 KB350 KB
Entry fileindex-iQj67-Vn.js
StatusPASS

📦 Bundle Size Report

PackageSizeGzipped
app-shell (index.js)8.88KB3.25KB
app-shell (runtime-config.js)7.42KB2.32KB
app-shell (types.js)0.01KB0.04KB
app-shell (urlParams.js)7.57KB2.97KB
auth (AuthContext.js)0.31KB0.24KB
auth (AuthGuard.js)1.17KB0.53KB
auth (AuthProvider.js)22.10KB4.37KB
auth (AuthShell.js)3.49KB1.40KB
auth (ForgotPasswordForm.js)12.21KB3.45KB
auth (LoginForm.js)18.13KB5.39KB
auth (PreviewBanner.js)0.90KB0.50KB
auth (RegisterForm.js)6.64KB2.21KB
auth (SocialSignInButtons.js)9.60KB3.89KB
auth (UserMenu.js)3.40KB1.22KB
auth (auth-gate-events.js)1.29KB0.66KB
auth (authStyles.js)5.04KB1.72KB
auth (createAuthClient.js)35.76KB9.11KB
auth (createAuthenticatedFetch.js)4.37KB1.69KB
auth (index.js)2.35KB1.07KB
auth (org-roles.js)6.66KB2.78KB
auth (phone-identifier.js)1.11KB0.66KB
auth (types.js)0.59KB0.35KB
auth (useAuth.js)4.91KB0.87KB
auth (useIsWorkspaceAdmin.js)1.61KB0.85KB
collaboration (CommentThread.js)26.07KB7.56KB
collaboration (LiveCursors.js)3.17KB1.27KB
collaboration (PresenceAvatars.js)6.49KB2.64KB
collaboration (PresenceProvider.js)2.79KB1.13KB
collaboration (index.js)1.65KB0.73KB
collaboration (useCollaborationTranslation.js)6.05KB2.52KB
collaboration (useCommentSearch.js)1.98KB0.88KB
collaboration (useConflictResolution.js)7.75KB1.86KB
collaboration (useMentionNotifications.js)1.81KB0.68KB
collaboration (usePresence.js)6.33KB1.84KB
collaboration (useRealtimeSubscription.js)7.91KB2.01KB
components (index.js)488.62KB108.26KB
core (index.js)3.04KB1.15KB
create-plugin (index.js)10.08KB3.26KB
data-objectstack (index.js)150.04KB39.79KB
fields (index.js)228.45KB56.62KB
i18n (LocalizationContext.js)1.76KB0.96KB
i18n (currency.js)1.22KB0.64KB
i18n (i18n.js)4.32KB1.77KB
i18n (index.js)2.65KB1.06KB
i18n (pickLocalized.js)1.70KB0.83KB
i18n (provider.js)16.38KB5.47KB
i18n (useObjectLabel.js)27.59KB6.63KB
i18n (useSafeTranslation.js)4.52KB1.96KB
layout (index.js)38.98KB10.85KB
mobile (MobileProvider.js)0.92KB0.49KB
mobile (ResponsiveContainer.js)0.94KB0.38KB
mobile (breakpoints.js)1.51KB0.70KB
mobile (createOfflineDataSource.js)5.61KB1.74KB
mobile (index.js)1.50KB0.62KB
mobile (offlineQueue.js)3.91KB1.35KB
mobile (pwa.js)0.97KB0.49KB
mobile (serviceWorker.js)1.48KB0.62KB
mobile (serviceWorkerSource.js)3.41KB1.48KB
mobile (useBreakpoint.js)1.54KB0.65KB
mobile (useGesture.js)6.96KB1.98KB
mobile (useOfflineSync.js)1.99KB0.72KB
mobile (usePullToRefresh.js)2.53KB0.85KB
mobile (useResponsive.js)0.71KB0.42KB
mobile (useResponsiveConfig.js)1.36KB0.63KB
mobile (useSpecGesture.js)4.32KB1.64KB
mobile (useTouchTarget.js)1.01KB0.54KB
permissions (MePermissionsProvider.js)8.75KB3.06KB
permissions (PermissionContext.js)0.31KB0.25KB
permissions (PermissionGuard.js)0.89KB0.45KB
permissions (PermissionProvider.js)3.67KB1.12KB
permissions (evaluator.js)4.41KB1.44KB
permissions (index.js)0.91KB0.41KB
permissions (store.js)0.91KB0.42KB
permissions (useFieldPermissions.js)1.28KB0.52KB
permissions (usePermissions.js)1.55KB0.71KB
plugin-ai (index.js)15.71KB3.79KB
plugin-calendar (index.js)45.23KB12.45KB
plugin-charts (index.js)61.73KB17.54KB
plugin-chatbot (index.js)180.33KB42.79KB
plugin-dashboard (index.js)118.67KB30.75KB
plugin-designer (index.js)210.91KB42.67KB
plugin-detail (index.js)238.88KB59.71KB
plugin-editor (index.js)2.46KB1.10KB
plugin-form (index.js)114.58KB27.68KB
plugin-gantt (index.js)164.14KB39.98KB
plugin-grid (index.js)187.97KB49.90KB
plugin-kanban (index.js)48.60KB13.41KB
plugin-list (index.js)109.18KB26.48KB
plugin-map (index.js)17.00KB5.32KB
plugin-markdown (index.js)13.72KB4.69KB
plugin-report (index.js)40.58KB10.58KB
plugin-timeline (index.js)26.21KB7.52KB
plugin-tree (index.js)8.50KB2.88KB
plugin-view (index.js)84.03KB20.55KB
providers (DataSourceProvider.js)0.75KB0.39KB
providers (MetadataProvider.js)1.37KB0.59KB
providers (ThemeProvider.js)1.90KB0.85KB
providers (UploadProvider.js)11.71KB3.53KB
providers (index.js)0.44KB0.22KB
providers (types.js)0.01KB0.04KB
react-runtime (index.js)5.67KB2.37KB
react (LazyPluginLoader.js)3.77KB1.33KB
react (SchemaRenderer.js)23.71KB7.96KB
react (data-invalidation.js)5.05KB2.08KB
react (index.js)1.23KB0.66KB
react (spec-input.js)0.20KB0.18KB
sdui-parser (codegen.js)4.09KB1.74KB
sdui-parser (index.js)4.47KB2.03KB
sdui-parser (parse.js)10.04KB2.82KB
sdui-parser (types.js)0.29KB0.24KB
sdui-parser (validate.js)4.69KB1.48KB
types (ai.js)0.20KB0.17KB
types (api-types.js)0.20KB0.18KB
types (app.js)2.87KB0.99KB
types (base.js)0.20KB0.18KB
types (blocks.js)0.20KB0.18KB
types (complex.js)0.20KB0.18KB
types (crud.js)0.20KB0.18KB
types (dashboard-filter-alias.js)6.23KB2.74KB
types (data-display.js)0.20KB0.18KB
types (data-protocol.js)0.20KB0.19KB
types (data.js)0.20KB0.18KB
types (designer.js)1.87KB0.85KB
types (disclosure.js)0.20KB0.18KB
types (error-code.js)1.54KB0.88KB
types (feedback.js)0.20KB0.18KB
types (field-types.js)0.20KB0.18KB
types (form.js)0.20KB0.18KB
types (http-retry.js)4.32KB2.02KB
types (index.js)3.05KB1.52KB
types (layout.js)0.20KB0.18KB
types (managed-by.js)0.19KB0.18KB
types (mobile.js)2.59KB1.31KB
types (navigation.js)0.20KB0.18KB
types (objectql.js)0.20KB0.18KB
types (overlay.js)0.20KB0.18KB
types (permissions.js)0.20KB0.18KB
types (plugin-scope.js)0.20KB0.18KB
types (record-components.js)0.20KB0.19KB
types (record-semantics.js)1.28KB0.67KB
types (registry.js)0.20KB0.18KB
types (reports.js)0.20KB0.18KB
types (spec-report.js)5.05KB1.93KB
types (system-fields.js)3.33KB1.54KB
types (theme.js)0.20KB0.18KB
types (ui-action.js)3.40KB1.71KB
types (views.js)0.20KB0.18KB
types (widget.js)0.20KB0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@yinlianghui
yinlianghui marked this pull request as ready for review August 11, 2026 11:22
@yinlianghui
yinlianghui added this pull request to the merge queueAug 11, 2026
Merged via the queue into main with commit 421c145Aug 11, 2026
21 checks passed
@yinlianghui
yinlianghui deleted the claude/issue-4040-auth branch August 11, 2026 11:22
yinlianghui pushed a commit that referenced this pull request Aug 11, 2026
yinlianghui pushed a commit that referenced this pull request Aug 11, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@yinlianghui@claude