refactor(plugin-charts): ObjectChart consumes the shared analytics label-net helpers (#4405)

[yinlianghui]

Fixes#4405

objectui#4389 (PR #4404) named two copies of the analytics label-net glue and retired both. There was a THIRD, which that card did not name and its PR deliberately left out of scope: packages/plugin-charts/src/ObjectChart.tsx. This retires it.

Step 1 — the pure-function swap (mandatory, done)

ObjectChart carried three pieces of the glue longhand. All three now call the helpers PR #4404 landed in @object-ui/core:

was, locally in ObjectChart.tsx	now
a translatorFor(path) closure — logically identical to the two deleted copies, down to the comment about binding to the owning object	dimensionOptionTranslator(meta, fieldOptionLabel)
a buildDimensionLabelMap loop accumulating per-dimension maps	deriveDimensionLabelMaps(metaByPath, relabel, fieldOptionLabel)
loadObjectSchema(objectName) then resolveDimensionFieldMeta(...)	loadDimensionFieldMeta(loadObjectSchema, objectName, paths)

The third row goes slightly beyond the two swaps the ruling enumerates. It is the same "consume the landed helpers" mandate from the card title, it is strictly mechanical (two statements collapse into the one composition that is those two statements), and the read count is identical because resolveDimensionFieldMeta memoizes per call and seeds the base schema either way. Flagged explicitly here so it is trivial to veto — dropping it changes nothing else in this PR.

@object-ui/core was already a declared dependency of @object-ui/plugin-charts (verified against package.json, per the #4394 phantom-dep lesson — and that gate landed in main mid-task, so it also ran green against this branch after merging).

The two bug-fix properties are untouched and remain stated locally, exactly as the card predicted for a step-1-only landing: apiFetch is still in the effect's deps (objectui#4121) and the locale is still NOT (objectui#4030 / PR #4324). The diff does not touch the effect's dependency array.

Step 2 — the dataset read onto useDatasetDimensionMeta: attempted, DECLINED on measurement

The blocker is not the fieldByDim map to ordered-array translation the card worried about — that part is clean, since the shared hook already takes both a dimension name to field path map and the name list, so the adapter is just Object.keys(fieldByDim).

The blocker is that ObjectChart's colour dimension is not one of the dimensions the surface renders, and the shared hook only resolves dimensions it will also relabel.

Measured, on main as it stands: a dataset chart that declares no dimensions still resolves its colour map, because ObjectChart resolves [fieldName, ...values(fieldByDim)] where fieldName comes from the dataset DEFINITION's first dimension, not from schema.dimensions. I pinned this in a scratch test and it is green today — 2 reads, colours applied:

✓ a dataset chart with NO schema.dimensions still resolves colour meta (2 reads)
categoryColors: { todo: '#f59e0b', 'To do': '#f59e0b', done: '#16a34a', Done: '#16a34a' }
metaCalls: ['/api/v1/meta/dataset/showcase_task_metrics', '/api/v1/meta/object/task']

Routed through useDatasetDimensionMeta, that case passes dimensions: [], and the hook's effect bails before fetching:

// packages/react/src/hooks/useDatasetDimensionLabels.ts:134if(!enabled||!object||dims.length===0){setMeta(null);return;}

So the read count would go 2 to 1 and the colour map would silently stop resolving — a behaviour change, in the exact best-effort-so-it-fails-quietly way this family keeps getting bitten by. Preserving it requires smuggling the colour path through as a synthetic dimension and filtering it back out of the derived maps before relabelDimensions sees it, which is a contorted adapter that changes the hook's meaning rather than adapting a shape.

Two further costs, for completeness:

• Split effects and a new state. The hook needs object and dimensionFields already resolved, but on the dataset path both come from the /api/v1/meta/dataset/... read that today lives inside the same effect. Using the hook forces that read into its own effect writing a new state that the hook then keys on: one effect and one state become two of each, and the metadata settles in two render commits instead of one.
• It would not actually remove the local glue. The ruling scopes step 2 to the dataset path, so the aggregate path keeps its own loadObjectSchema plus loadDimensionFieldMeta call regardless. Step 2 therefore splits the local code and leaves half behind while adding a state and a sentinel adapter — net local code grows.

Residual, recorded rather than acted on: the clean version of step 2 would need the shared hook to grow a "resolve these extra paths but emit no relabel entry for them" concept. That is an edit to @object-ui/react, a surface that just landed and whose naming/shape belongs to a fresh card — so per the dispatch constraints I stopped rather than reshaping it here.

Verification

All runs are repo-root vitest, per AGENTS.md.

• pnpm exec vitest run packages/plugin-charts/ --maxWorkers=2 — 22 files / 170 tests passed, before and after, identical counts.
• pnpm --filter @object-ui/plugin-charts type-check (tsc --noEmit) — clean; package build (dts emit) — clean. Dependency closure built first (--filter '@object-ui/plugin-charts^...' build), since @object-ui/react resolves through dist rather than a root tsconfig path alias.
• eslint packages/plugin-charts/src/ObjectChart.tsx — 0 errors; 57 warnings, byte-identical to the same file's warning count on origin/main (all pre-existing react-refresh / any warnings).
• node scripts/check-control-bytes.mjs — OK; plus a targeted grep -naP control-byte self-scan of both touched files, clean.
• node scripts/check-phantom-dependencies.mjs (Phantom dependency: react resolves from packages/core although core declares none — a resolution-based layering check returns the wrong answer #4394, landed mid-task) — OK.
• node scripts/check-changeset-presence.mjs — OK, 1 changeset for 1 released package. Changeset is patch, never major, matching PR refactor(core,react,dashboard,report): the analytics label net's fetch-and-memo glue is written once (#4389) #4404's precedent for a behaviour-unchanged refactor.

Pins unchanged (the acceptance evidence):git diff --name-only origin/main...HEAD -- 'packages/plugin-charts/**/*.test.*' is empty. The whole branch touches exactly two files:

.changeset/objectchart-label-net-third-copy-4405.md
packages/plugin-charts/src/ObjectChart.tsx

Note the pin that actually covers this code is packages/plugin-charts/src/ObjectChart.optionColors.test.tsx, which sits outside the src/__tests__/ directory — the sweep above deliberately covers the whole package's test surface rather than that one directory.

Reverse verification

Direction predicted before each run.

1. Revert ObjectChart.tsx to the local closures, keep the suite. Predicted GREEN, got GREEN (22 files / 170 tests). This is a null result and is reported as such: for a behaviour-preserving swap it is the correct outcome, and it is the argument that the seam-level pins carry the guarantee — the same result and the same reasoning PR refactor(core,react,dashboard,report): the analytics label net's fetch-and-memo glue is written once (#4389) #4404's RV1 recorded.
2. Because a null result alone cannot distinguish "behaviour preserved" from "pins do not watch this path", break the derivation deliberately — pass null as the relabel argument. Predicted RED, got RED, on exactly the two dataset label pins: expected 'todo' to be 'To do' in resolves a dataset chart through its definition to the underlying object and routes BOTH dataset hops through the host apiFetch. The pins do observe this path, so run 1's green is meaningful.
3. Unbind the colour translator (dimensionOptionTranslator(undefined, ...)). Predicted GREEN as a blind spot, got GREEN (7/7). Reported honestly rather than dressed up as coverage: these pins mount no I18nProvider, so the resolver returns the authored label and a bound translator is indistinguishable from an unbound one. The colour path's translator binding is therefore not pinned at this seam today — it is pinned one level down in core's own unit tests. Not a regression introduced here (the same gap existed before this PR), and not in scope to fix.

Working tree clean after each; no git stash used at any point.

---

Generated by Claude Code

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
objectui	Ignored		Aug 12, 2026 4:20am

[github-actions]

✅ Console Performance Budget

Metric	Value	Budget
Main entry (gzip)	24.7 KB	350 KB
Entry file	index-DBTgxD_P.js	—
Status	PASS	—

---

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (index.js)	9.56KB	3.59KB
app-shell (runtime-config.js)	7.42KB	2.32KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	8.92KB	3.41KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	1.17KB	0.53KB
auth (AuthProvider.js)	22.10KB	4.37KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	12.21KB	3.45KB
auth (LoginForm.js)	18.13KB	5.39KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.64KB	2.21KB
auth (SocialSignInButtons.js)	9.60KB	3.89KB
auth (UserMenu.js)	3.40KB	1.22KB
auth (auth-gate-events.js)	1.29KB	0.66KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	35.76KB	9.11KB
auth (createAuthenticatedFetch.js)	4.37KB	1.69KB
auth (index.js)	2.35KB	1.07KB
auth (org-roles.js)	6.66KB	2.78KB
auth (phone-identifier.js)	1.11KB	0.66KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	4.91KB	0.87KB
auth (useIsWorkspaceAdmin.js)	1.61KB	0.85KB
collaboration (CommentThread.js)	26.07KB	7.56KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	6.49KB	2.64KB
collaboration (PresenceProvider.js)	2.79KB	1.13KB
collaboration (index.js)	1.65KB	0.73KB
collaboration (useCollaborationTranslation.js)	6.05KB	2.52KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	489.20KB	108.43KB
core (index.js)	2.99KB	1.14KB
create-plugin (index.js)	10.08KB	3.26KB
data-objectstack (index.js)	153.42KB	41.19KB
fields (index.js)	228.33KB	56.61KB
i18n (LocalizationContext.js)	1.76KB	0.96KB
i18n (currency.js)	1.22KB	0.64KB
i18n (i18n.js)	4.32KB	1.77KB
i18n (index.js)	3.35KB	1.38KB
i18n (pickLocalized.js)	3.69KB	1.73KB
i18n (provider.js)	23.12KB	7.62KB
i18n (useDisplayLocale.js)	2.33KB	1.20KB
i18n (useObjectLabel.js)	27.59KB	6.63KB
i18n (useSafeTranslation.js)	7.77KB	3.13KB
layout (index.js)	38.98KB	10.85KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.74KB
mobile (index.js)	1.50KB	0.62KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	6.96KB	1.98KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.71KB	0.42KB
mobile (useResponsiveConfig.js)	1.36KB	0.63KB
mobile (useSpecGesture.js)	4.32KB	1.64KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	8.75KB	3.06KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	3.67KB	1.12KB
permissions (evaluator.js)	4.41KB	1.44KB
permissions (index.js)	0.91KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.52KB
permissions (usePermissions.js)	1.55KB	0.71KB
plugin-ai (index.js)	15.71KB	3.79KB
plugin-calendar (index.js)	45.23KB	12.45KB
plugin-charts (index.js)	62.01KB	17.63KB
plugin-chatbot (index.js)	180.33KB	42.79KB
plugin-dashboard (index.js)	120.57KB	31.32KB
plugin-designer (index.js)	211.16KB	42.76KB
plugin-detail (index.js)	239.03KB	59.77KB
plugin-editor (index.js)	2.46KB	1.10KB
plugin-form (index.js)	114.58KB	27.68KB
plugin-gantt (index.js)	164.14KB	39.98KB
plugin-grid (index.js)	187.99KB	49.92KB
plugin-kanban (index.js)	48.60KB	13.41KB
plugin-list (index.js)	110.21KB	26.79KB
plugin-map (index.js)	18.05KB	5.80KB
plugin-markdown (index.js)	13.72KB	4.69KB
plugin-report (index.js)	40.99KB	10.74KB
plugin-timeline (index.js)	26.21KB	7.52KB
plugin-tree (index.js)	8.50KB	2.88KB
plugin-view (index.js)	84.03KB	20.55KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.90KB	0.85KB
providers (UploadProvider.js)	11.71KB	3.53KB
providers (index.js)	0.44KB	0.22KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	5.67KB	2.37KB
react (LazyPluginLoader.js)	3.77KB	1.33KB
react (SchemaRenderer.js)	23.71KB	7.96KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	1.23KB	0.66KB
react (spec-input.js)	0.20KB	0.18KB
sdui-parser (codegen.js)	4.09KB	1.74KB
sdui-parser (index.js)	4.47KB	2.03KB
sdui-parser (parse.js)	10.04KB	2.82KB
sdui-parser (types.js)	0.29KB	0.24KB
sdui-parser (validate.js)	4.69KB	1.48KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	0.99KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	0.20KB	0.18KB
types (crud.js)	0.20KB	0.18KB
types (dashboard-filter-alias.js)	6.23KB	2.74KB
types (data-display.js)	0.20KB	0.18KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	1.87KB	0.85KB
types (disclosure.js)	0.20KB	0.18KB
types (error-code.js)	1.54KB	0.88KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (http-retry.js)	4.32KB	2.02KB
types (index.js)	3.05KB	1.52KB
types (layout.js)	0.20KB	0.18KB
types (managed-by.js)	0.19KB	0.18KB
types (mobile.js)	2.59KB	1.31KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (record-semantics.js)	1.28KB	0.67KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (spec-report.js)	5.05KB	1.93KB
types (system-fields.js)	3.33KB	1.54KB
types (theme.js)	0.20KB	0.18KB
types (ui-action.js)	3.40KB	1.71KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

• ✅ Core packages should be < 50KB gzipped
• ✅ Component packages should be < 100KB gzipped
• ⚠️ Plugin packages should be < 150KB gzipped

[yinlianghui]

ACCEPT — PM 复核 (session session_017Qqyix2QcnpUC9XeYVDzx3), closes #4405.

• Step 2's decline is the ruling's criteria applied to a better measurement than the card had: the real blocker (the colour dimension is not a rendered dimension; the shared hook resolves only what it relabels, so the empty-dims bail silently drops the colour map — 2 reads → 1, scratch-pinned) beats the card's fieldByDim worry, which the dev showed is trivial. The contorted-adapter cost plus the hook-edit stop condition make step-1-only the correct landing, Fixes kept per the ruling.
• The scope+1 (read composition onto loadDimensionFieldMeta) is accepted — mechanical, the third landed helper, read-count-identical.
• The RV trio is the standard: RV1's null result labelled as null, RV2 proving the pins observe the path (which is what makes RV1 meaningful — the same epistemics as PR refactor(core,react,dashboard,report): the analytics label net's fetch-and-memo glue is written once (#4389) #4404), RV3 reporting a pre-existing blind spot honestly instead of dressing it as coverage.
• The self-inflicted checkout clobber, detected-redone-recommitted with all verification re-run from the committed state, plus the two-dot/three-dot diff lesson, are process capture worth the deviations section.
• Step-2 residual disposition: filed as a finding (unassigned, no queue) rather than lost or force-queued — the drift surface is down 3→1 with the properties correctly stated and RV2-observed; growing @object-ui/react's fresh API a "resolve-without-relabel" concept is a design addition that earns its own card when pull exists.

Flipping ready + arming auto-merge.

---

Generated by Claude Code