Skip to content

data-objectstack: retire the four remaining v3.0.0 Deep Integration modules - #4711

Merged
yinlianghui merged 1 commit into
mainfrom
claude/issue-4241-v3-banner-retirement-sweep
Aug 15, 2026
Merged

data-objectstack: retire the four remaining v3.0.0 Deep Integration modules#4711
yinlianghui merged 1 commit into
mainfrom
claude/issue-4241-v3-banner-retirement-sweep

Conversation

@yinlianghui

Copy link
Copy Markdown
Collaborator

Fixes#4241

What

packages/data-objectstack/src/index.ts's // v3.0.0 Deep Integration modules banner introduced five modules. #4152 / PR #4239 already retired the first, CloudOperations, for fabricating success against a client namespace that does not exist. This retires the other four, all measured with zero code consumers outside this package (across packages/, apps/, examples/, .ts/.tsx, excluding node_modules) — on the family rule from #4241's 2026-08-11 triage promotion, which inherits #4152's ruling for the siblings:

  • src/integration.tsIntegrationManager and its types
  • src/security.tsSecurityManager and its types
  • src/studio.tscreateDefaultCanvasConfig / snapToGrid / calculateAutoLayout and their types
  • src/contracts.tsvalidatePluginContract / generateContractManifest and their types

Not a repeat of #4152's urgency limb — none of these four fabricated anything (SecurityManager.generateCSPHeader() really composes a header, snapToGrid really snaps). What they shared with CloudOperations was only the no-consumer limb. Re-measured on this branch; the two apparent hits were homonyms, not consumers — PageDesigner.tsx has its own local snapToGrid callback with no import from this package, and the SecurityManager hits outside data-objectstack are CHANGELOG.md prose.

Same shape as #4152 / PR #4239

  • Delete the four module files.
  • Delete their re-exports from index.ts; the // v3.0.0 Deep Integration modules banner had nothing left under it once all four were gone, so it's removed rather than retitled (its adjacent note about CloudOperations's retirement stays fully documented in cloud-surface-retired-4152.pin.test.ts, so nothing is lost).
  • v3-compat.test.ts: removed the four modules' describe blocks and their imports. The file is not an empty shell — one block (PaginatedResult API) never depended on any of the five retired modules — so it stays, retitled to stop claiming a v3.
  • Added v3-deep-integration-retired-4241.pin.test.ts, a negative pin in the shape of cloud-surface-retired-4152.pin.test.ts: it reads both the runtime export list (catches the 7 class/function exports) and index.ts's source text (the only instrument that can catch a returning export type, for the 23 type-only exports).

A consumer the issue's premise didn't name

While removing security.ts I found spec-symbol-batch6.test.ts (objectui#3160 / objectstack#4115 ledger batch 6) imports SecurityManagerPolicy from ./security — a real in-package reference beyond the "index.ts re-export and v3-compat.test.ts" the issue described. It's a compile-time collision guard verifying SecurityManagerPolicy doesn't overlap the spec's unrelated SecurityPolicy, not a functional consumer, so it doesn't change the zero-external-consumer conclusion — but it needed its own edit (import, RENAMES entry, describe block, header prose) to keep compiling once the type it guards is gone. Not a fork: mechanical cleanup required by the sanctioned deletion, same category as updating v3-compat.test.ts.

Verification

  • pnpm --filter '@object-ui/data-objectstack^...' build (dependency closure) — green
  • pnpm exec vitest run packages/data-objectstack/ --maxWorkers=237 test files, 523 tests, all passing, re-run at the final commit
  • pnpm --filter '@object-ui/data-objectstack' type-check — clean, re-run at the final commit
  • pnpm --filter '@object-ui/data-objectstack' lint — 0 errors (392 pre-existing warnings, unrelated to this change)
  • pnpm --filter '@object-ui/data-objectstack' build — rebuilt dist/index.d.ts; grepped it for the four retired names, 0 hits
  • Reverse verification: added a scratch file importing the retired IntegrationManager from @object-ui/data-objectstack in packages/plugin-designer, ran tsc --noEmit, confirmed TS2305: Module '"@object-ui/data-objectstack"' has no exported member 'IntegrationManager' against the rebuilt .d.ts, then removed the scratch file — proves the rebuild was read, not a cached one
  • Downstream consumer sweep (prefix direction — consumers of this package): pnpm exec turbo run type-check --filter='...@object-ui/data-objectstack' --concurrency=269/69 tasks successful (includes app-shell, plugin-calendar, plugin-designer, plugin-form, plugin-grid, plugin-kanban, plugin-timeline, react, apps/console, and their own dependency/build chains)
  • node scripts/check-changeset-presence.mjs — ✅ declares .changeset/retire-v3-deep-integration-modules-4241.md
  • node scripts/check-changeset-no-major.mjs — ✅ no major bump declared
  • Self-scan for raw control bytes on every changed file — clean

All of the above re-run at the final commit 7ccd74239.

Changeset

minor on @object-ui/data-objectstack, matching PR #4239's precedent (this repo's version policy: objectui's own breaking changes never declare major). Body lists all removed exports FROM → TO form.


Generated by Claude Code

…ion modules
IntegrationManager, SecurityManager, the studio canvas helpers
(createDefaultCanvasConfig / snapToGrid / calculateAutoLayout), and the
contract helpers (validatePluginContract / generateContractManifest) had
zero code consumers outside this package, measured across packages/, apps/
and examples/. Same criterion #4152/PR #4239 used to retire CloudOperations,
the fifth module under the same banner.
- Delete contracts.ts, integration.ts, security.ts, studio.ts
- Delete their re-exports and the now-empty "v3.0.0 Deep Integration
modules" banner from index.ts
- Retitle v3-compat.test.ts (one non-v3 block, PaginatedResult API, survives
so the file is not an empty shell)
- Fix spec-symbol-batch6.test.ts, which guarded SecurityManagerPolicy's name
against colliding with the spec's unrelated SecurityPolicy — a
consumer the issue's zero-consumer measurement didn't name
- Add v3-deep-integration-retired-4241.pin.test.ts, a negative pin in the
shape of cloud-surface-retired-4152.pin.test.ts
Fixes#4241
Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RnQd8iMMUwXQEV1crFmQiQ
@vercel

vercelBot commented Aug 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
objectuiIgnoredIgnoredAug 15, 2026 2:56pm

Request Review

@yinlianghuiClaude

Copy link
Copy Markdown
CollaboratorAuthor

Review verdict: ACCEPT (reviewer of record, PM session session_01RnQd8iMMUwXQEV1crFmQiQ).

Verified against this PR, not the report — and per the deletion-class rule I re-ran the reference-face check myself on current main: all six primary symbols have zero hits outside packages/data-objectstack across packages//apps//examples/, and the two snapToGrid survivors are the known homonyms (the types/designer.ts boolean key, and PageDesigner.tsx's local callback in a file with no import from this package). Body's only closing keyword is Fixes #4241. The unnamed in-package consumer (spec-symbol-batch6.test.ts) is correctly classified: a compile-time collision guard for a type being deleted is coverage of the deleted thing, not a load-bearing consumer, so absorbing its edit was right and the zero-external-consumer conclusion stands. The reverse verification is the strong form (scratch import failing with TS2305 against the freshly rebuilt .d.ts proves the reading was of the rebuild, not a cache), the downstream sweep answers both checklist questions (prefix direction = consumers, closure built first, 69/69), and the changeset is minor on the PR #4239 precedent with the no-major gate green. Banner removal rather than retitle is the stronger fix and loses nothing (the retirement history lives in the pin tests). Local gates pinned to 7ccd74239, matching this PR's current head.

Will flip ready + enable auto-merge once Lint, Type Check, and Test shards 1–4 conclude success on this head.


Generated by Claude Code

@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

MetricValueBudget
Main entry (gzip)24.7 KB350 KB
Entry fileindex-CWaHiCE9.js
StatusPASS

📦 Bundle Size Report

PackageSizeGzipped
app-shell (index.js)9.56KB3.59KB
app-shell (runtime-config.js)7.42KB2.32KB
app-shell (types.js)0.01KB0.04KB
app-shell (urlParams.js)8.92KB3.41KB
auth (AuthContext.js)0.31KB0.24KB
auth (AuthGuard.js)1.17KB0.53KB
auth (AuthProvider.js)25.13KB5.40KB
auth (AuthShell.js)3.49KB1.40KB
auth (ForgotPasswordForm.js)12.21KB3.45KB
auth (LoginForm.js)18.13KB5.39KB
auth (PreviewBanner.js)0.90KB0.50KB
auth (RegisterForm.js)6.64KB2.21KB
auth (SocialSignInButtons.js)9.60KB3.89KB
auth (UserMenu.js)3.40KB1.22KB
auth (auth-gate-events.js)1.29KB0.66KB
auth (authStyles.js)5.04KB1.72KB
auth (createAuthClient.js)38.46KB10.17KB
auth (createAuthenticatedFetch.js)6.34KB2.43KB
auth (index.js)2.35KB1.07KB
auth (org-roles.js)6.66KB2.78KB
auth (phone-identifier.js)1.11KB0.66KB
auth (types.js)0.59KB0.35KB
auth (useAuth.js)5.02KB0.88KB
auth (useIsWorkspaceAdmin.js)1.61KB0.85KB
collaboration (CommentThread.js)26.07KB7.56KB
collaboration (LiveCursors.js)3.17KB1.27KB
collaboration (PresenceAvatars.js)6.49KB2.64KB
collaboration (PresenceProvider.js)2.79KB1.13KB
collaboration (index.js)1.65KB0.73KB
collaboration (useCollaborationTranslation.js)6.05KB2.52KB
collaboration (useCommentSearch.js)1.98KB0.88KB
collaboration (useConflictResolution.js)7.75KB1.86KB
collaboration (useMentionNotifications.js)1.81KB0.68KB
collaboration (usePresence.js)6.33KB1.84KB
collaboration (useRealtimeSubscription.js)7.91KB2.01KB
components (index.js)489.91KB108.67KB
core (index.js)3.79KB1.52KB
create-plugin (index.js)10.08KB3.26KB
data-objectstack (index.js)154.13KB42.23KB
fields (index.js)230.37KB57.17KB
i18n (LocalizationContext.js)1.76KB0.96KB
i18n (currency.js)1.22KB0.64KB
i18n (i18n.js)4.32KB1.77KB
i18n (index.js)3.35KB1.38KB
i18n (pickLocalized.js)3.69KB1.73KB
i18n (provider.js)23.12KB7.62KB
i18n (useDisplayLocale.js)2.84KB1.45KB
i18n (useObjectLabel.js)27.59KB6.63KB
i18n (useSafeTranslation.js)7.77KB3.13KB
layout (index.js)38.98KB10.85KB
mobile (MobileProvider.js)0.92KB0.49KB
mobile (ResponsiveContainer.js)0.94KB0.38KB
mobile (breakpoints.js)1.51KB0.70KB
mobile (createOfflineDataSource.js)5.61KB1.74KB
mobile (index.js)1.50KB0.62KB
mobile (offlineQueue.js)3.91KB1.35KB
mobile (pwa.js)0.97KB0.49KB
mobile (serviceWorker.js)1.48KB0.62KB
mobile (serviceWorkerSource.js)3.41KB1.48KB
mobile (useBreakpoint.js)1.54KB0.65KB
mobile (useGesture.js)6.96KB1.98KB
mobile (useOfflineSync.js)1.99KB0.72KB
mobile (usePullToRefresh.js)2.53KB0.85KB
mobile (useResponsive.js)0.71KB0.42KB
mobile (useResponsiveConfig.js)1.36KB0.63KB
mobile (useSpecGesture.js)4.32KB1.64KB
mobile (useTouchTarget.js)1.01KB0.54KB
permissions (MePermissionsProvider.js)8.75KB3.06KB
permissions (PermissionContext.js)0.31KB0.25KB
permissions (PermissionGuard.js)0.89KB0.45KB
permissions (PermissionProvider.js)3.67KB1.12KB
permissions (evaluator.js)4.41KB1.44KB
permissions (index.js)0.91KB0.41KB
permissions (store.js)0.91KB0.42KB
permissions (useFieldPermissions.js)1.28KB0.52KB
permissions (usePermissions.js)1.55KB0.71KB
plugin-ai (index.js)15.75KB3.80KB
plugin-calendar (index.js)46.86KB12.91KB
plugin-charts (index.js)64.44KB18.28KB
plugin-chatbot (index.js)181.21KB43.14KB
plugin-dashboard (index.js)121.90KB31.76KB
plugin-designer (index.js)212.39KB42.83KB
plugin-detail (index.js)239.93KB60.01KB
plugin-editor (index.js)2.46KB1.10KB
plugin-form (index.js)114.72KB27.70KB
plugin-gantt (index.js)164.30KB40.02KB
plugin-grid (index.js)192.10KB51.24KB
plugin-kanban (index.js)52.74KB14.53KB
plugin-list (index.js)111.14KB26.92KB
plugin-map (index.js)18.16KB5.81KB
plugin-markdown (index.js)13.72KB4.69KB
plugin-report (index.js)41.38KB11.09KB
plugin-timeline (index.js)26.68KB7.66KB
plugin-tree (index.js)8.50KB2.88KB
plugin-view (index.js)83.81KB20.49KB
providers (DataSourceProvider.js)0.75KB0.39KB
providers (MetadataProvider.js)1.37KB0.59KB
providers (ThemeProvider.js)1.90KB0.85KB
providers (UploadProvider.js)11.71KB3.53KB
providers (index.js)0.44KB0.22KB
providers (types.js)0.01KB0.04KB
react-runtime (index.js)5.67KB2.37KB
react (LazyPluginLoader.js)3.77KB1.33KB
react (SchemaRenderer.js)27.64KB9.44KB
react (data-invalidation.js)5.05KB2.08KB
react (index.js)1.28KB0.68KB
react (schema-input.js)1.45KB0.83KB
react (spec-input.js)0.20KB0.18KB
sdui-parser (codegen.js)4.09KB1.74KB
sdui-parser (index.js)4.47KB2.03KB
sdui-parser (parse.js)10.04KB2.82KB
sdui-parser (types.js)0.29KB0.24KB
sdui-parser (validate.js)4.69KB1.48KB
types (ai.js)0.20KB0.17KB
types (api-types.js)0.20KB0.18KB
types (app.js)2.87KB0.99KB
types (base.js)0.20KB0.18KB
types (blocks.js)0.20KB0.18KB
types (complex.js)0.20KB0.18KB
types (crud.js)0.20KB0.18KB
types (dashboard-filter-alias.js)6.23KB2.74KB
types (data-display.js)0.20KB0.18KB
types (data-protocol.js)0.20KB0.19KB
types (data.js)0.20KB0.18KB
types (designer.js)1.87KB0.85KB
types (disclosure.js)0.20KB0.18KB
types (error-code.js)1.54KB0.88KB
types (feedback.js)0.20KB0.18KB
types (field-types.js)0.20KB0.18KB
types (form.js)0.20KB0.18KB
types (http-retry.js)4.32KB2.02KB
types (index.js)3.05KB1.52KB
types (layout.js)0.20KB0.18KB
types (managed-by.js)0.19KB0.18KB
types (mobile.js)2.59KB1.31KB
types (navigation.js)0.20KB0.18KB
types (objectql.js)0.20KB0.18KB
types (overlay.js)0.20KB0.18KB
types (permissions.js)0.20KB0.18KB
types (plugin-scope.js)0.20KB0.18KB
types (record-components.js)0.20KB0.19KB
types (record-semantics.js)1.28KB0.67KB
types (registry.js)0.20KB0.18KB
types (reports.js)0.20KB0.18KB
types (spec-report.js)5.05KB1.93KB
types (system-fields.js)3.33KB1.54KB
types (theme.js)0.20KB0.18KB
types (ui-action.js)3.40KB1.71KB
types (views.js)0.20KB0.18KB
types (widget.js)0.20KB0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@yinlianghui
yinlianghui marked this pull request as ready for review August 15, 2026 15:44
@yinlianghui
yinlianghui added this pull request to the merge queueAug 15, 2026
Merged via the queue into main with commit a8411adAug 15, 2026
21 checks passed
@yinlianghui
yinlianghui deleted the claude/issue-4241-v3-banner-retirement-sweep branch August 15, 2026 15:45
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[finding] The other four "v3.0.0 Deep Integration modules" in data-objectstack have no consumer outside their own tests either

2 participants

@yinlianghui@claude