test(data-objectstack): re-point v3-compat's vacuous PaginatedResult block at real ObjectStackAdapter.find()

[yinlianghui]

Fixes#4712

What was wrong

packages/data-objectstack/src/v3-compat.test.ts's PaginatedResult API block asserted only on an inline object literal it constructed itself, with no import from ./index or anywhere else in the package:

constresult={data: [{id: '1'}],total: 10,page: 1,pageSize: 5,hasMore: true};expect(result.data).toHaveLength(1);expect(result.total).toBe(10);expect(result.hasMore).toBe(true);

This passes unconditionally regardless of what production code does — it is unreachable from any real query path and cannot fail in a way that signals anything about the codebase (dormant/tautological coverage).

Measurement (route A vs B)

• grep -rn "PaginatedResult" under packages/ finds no interface, type, or export literally named PaginatedResult anywhere in this repo (only prose hits in CHANGELOG.md referencing an old upstream @objectstack v3.0.0 migration note).
• The real production shape the block's comment was gesturing at is QueryResult (generic over T), exported from @object-ui/types (packages/types/src/data.ts:109) with exactly the data/total/page/pageSize/hasMore fields the literal hand-copied.
• QueryResult is returned by ObjectStackAdapter.find() (packages/data-objectstack/src/index.ts:1418), via the private normalizeQueryResult() (index.ts:2565), which computes total (total ?? count ?? records.length), the hasMore fallback (prefers the server's hasMore, else records.length === $top), and page (floor($skip / $top) + 1).
• That computation had zero coverage anywhere else in this package — queryDataset.test.ts and listViews.test.ts (cited by the issue) exercise other parts of the adapter's return shape but never total/hasMore/page/pageSize on .find().

⇒ Route A: a real production surface exists to pin, and it was genuinely uncovered, so the block is re-pointed rather than deleted.

What changed

The block now constructs an ObjectStackAdapter with a mocked fetch (same pattern as orderby-serialization.test.ts / queryDataset.test.ts in this package) and drives the realfind() to normalizeQueryResult() path:

• normalizes a server records/total/hasMore envelope into the returned QueryResult (data/total/hasMore/pageSize/page)
• computes page from $skip/$top
• falls back to the page-local hasMore estimate (records.length === $top) when the server omits it
• reports hasMore: false for a short (non-full) page with no server hint

Positive control (route A requires one)

Before pushing, I temporarily hardcoded hasMore = false and page = 1 in normalizeQueryResult() as an uncommitted local edit (reverted afterward with git checkout against the already-committed branch, pointed at packages/data-objectstack/src/index.ts — the fix commit went in first per this repo's reverse-verification discipline), and re-ran the suite:

FAIL packages/data-objectstack/src/v3-compat.test.ts (4 tests | 3 failed)
× normalizes the server records/total/hasMore envelope into QueryResult
× computes page from $skip/$top
× falls back to a page-local hasMore estimate when the server omits it

3 of 4 new assertions went red (the 4th — "reports hasMore false for a short page" — stayed green because the mutation coincidentally also produced hasMore: false, which is expected and not a gap: that test is there to guard against hasMore defaulting to true, the opposite direction). Reverting restored all 4 green, confirming the block now actually exercises and can detect drift in production code, unlike the block it replaces.

Tests

At final commit 820b4d716:

pnpm --filter '@object-ui/data-objectstack^...' build # deps built (types, core)
pnpm exec vitest run packages/data-objectstack/ --maxWorkers=2
Test Files 37 passed (37)
Tests 526 passed (526)
pnpm --filter @object-ui/data-objectstack type-check # tsc --noEmit — clean
pnpm --filter @object-ui/data-objectstack lint # 0 errors, 396 pre-existing no-explicit-any warnings (unrelated to this change)
node scripts/check-changeset-presence.mjs # empty-frontmatter changeset declared
node scripts/check-changeset-no-major.mjs # pass
node scripts/check-control-bytes.mjs # pass, 4237 files scanned

Changeset

Test-only change — added .changeset/paginated-result-vacuous-block-4712.md with empty frontmatter (declares "releases nothing", the repo's explicit first-class pass for internal-only changes).

---

Generated by Claude Code

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
objectui	Ignored		Aug 15, 2026 3:55pm

[github-actions]

✅ Console Performance Budget

Metric	Value	Budget
Main entry (gzip)	24.7 KB	350 KB
Entry file	index-CB9xsYbE.js	—
Status	PASS	—

---

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (index.js)	9.56KB	3.59KB
app-shell (runtime-config.js)	7.42KB	2.32KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	8.92KB	3.41KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	1.17KB	0.53KB
auth (AuthProvider.js)	25.13KB	5.40KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	12.21KB	3.45KB
auth (LoginForm.js)	18.13KB	5.39KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.64KB	2.21KB
auth (SocialSignInButtons.js)	9.60KB	3.89KB
auth (UserMenu.js)	3.40KB	1.22KB
auth (auth-gate-events.js)	1.29KB	0.66KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	38.46KB	10.17KB
auth (createAuthenticatedFetch.js)	6.34KB	2.43KB
auth (index.js)	2.35KB	1.07KB
auth (org-roles.js)	6.66KB	2.78KB
auth (phone-identifier.js)	1.11KB	0.66KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	5.02KB	0.88KB
auth (useIsWorkspaceAdmin.js)	1.61KB	0.85KB
collaboration (CommentThread.js)	26.07KB	7.56KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	6.49KB	2.64KB
collaboration (PresenceProvider.js)	2.79KB	1.13KB
collaboration (index.js)	1.65KB	0.73KB
collaboration (useCollaborationTranslation.js)	6.05KB	2.52KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	489.91KB	108.67KB
core (index.js)	3.79KB	1.52KB
create-plugin (index.js)	10.08KB	3.26KB
data-objectstack (index.js)	154.13KB	42.23KB
fields (index.js)	230.37KB	57.17KB
i18n (LocalizationContext.js)	1.76KB	0.96KB
i18n (currency.js)	1.22KB	0.64KB
i18n (i18n.js)	4.32KB	1.77KB
i18n (index.js)	3.35KB	1.38KB
i18n (pickLocalized.js)	3.69KB	1.73KB
i18n (provider.js)	23.12KB	7.62KB
i18n (useDisplayLocale.js)	2.84KB	1.45KB
i18n (useObjectLabel.js)	27.59KB	6.63KB
i18n (useSafeTranslation.js)	7.77KB	3.13KB
layout (index.js)	38.98KB	10.85KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.74KB
mobile (index.js)	1.50KB	0.62KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	6.96KB	1.98KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.71KB	0.42KB
mobile (useResponsiveConfig.js)	1.36KB	0.63KB
mobile (useSpecGesture.js)	4.32KB	1.64KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	8.75KB	3.06KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	3.67KB	1.12KB
permissions (evaluator.js)	4.41KB	1.44KB
permissions (index.js)	0.91KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.52KB
permissions (usePermissions.js)	1.55KB	0.71KB
plugin-ai (index.js)	15.75KB	3.80KB
plugin-calendar (index.js)	46.86KB	12.91KB
plugin-charts (index.js)	64.44KB	18.28KB
plugin-chatbot (index.js)	181.21KB	43.14KB
plugin-dashboard (index.js)	121.90KB	31.76KB
plugin-designer (index.js)	212.39KB	42.83KB
plugin-detail (index.js)	239.86KB	59.99KB
plugin-editor (index.js)	2.46KB	1.10KB
plugin-form (index.js)	114.72KB	27.70KB
plugin-gantt (index.js)	164.30KB	40.02KB
plugin-grid (index.js)	192.10KB	51.24KB
plugin-kanban (index.js)	52.74KB	14.53KB
plugin-list (index.js)	111.14KB	26.92KB
plugin-map (index.js)	18.16KB	5.81KB
plugin-markdown (index.js)	13.72KB	4.69KB
plugin-report (index.js)	41.38KB	11.09KB
plugin-timeline (index.js)	26.68KB	7.66KB
plugin-tree (index.js)	8.50KB	2.88KB
plugin-view (index.js)	83.81KB	20.49KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.90KB	0.85KB
providers (UploadProvider.js)	11.71KB	3.53KB
providers (index.js)	0.44KB	0.22KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	5.67KB	2.37KB
react (LazyPluginLoader.js)	3.77KB	1.33KB
react (SchemaRenderer.js)	27.64KB	9.44KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	1.28KB	0.68KB
react (schema-input.js)	1.45KB	0.83KB
react (spec-input.js)	0.20KB	0.18KB
sdui-parser (codegen.js)	4.09KB	1.74KB
sdui-parser (index.js)	4.47KB	2.03KB
sdui-parser (parse.js)	10.04KB	2.82KB
sdui-parser (types.js)	0.29KB	0.24KB
sdui-parser (validate.js)	4.69KB	1.48KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	0.99KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	0.20KB	0.18KB
types (crud.js)	0.20KB	0.18KB
types (dashboard-filter-alias.js)	6.23KB	2.74KB
types (data-display.js)	0.20KB	0.18KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	1.87KB	0.85KB
types (disclosure.js)	0.20KB	0.18KB
types (error-code.js)	1.54KB	0.88KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (http-retry.js)	4.32KB	2.02KB
types (index.js)	3.05KB	1.52KB
types (layout.js)	0.20KB	0.18KB
types (managed-by.js)	0.19KB	0.18KB
types (mobile.js)	2.59KB	1.31KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (record-semantics.js)	1.28KB	0.67KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (spec-report.js)	5.05KB	1.93KB
types (system-fields.js)	3.33KB	1.54KB
types (theme.js)	0.20KB	0.18KB
types (ui-action.js)	3.40KB	1.71KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

• ✅ Core packages should be < 50KB gzipped
• ✅ Component packages should be < 100KB gzipped
• ⚠️ Plugin packages should be < 150KB gzipped

[yinlianghui]

Review verdict: ACCEPT (reviewer of record, PM session session_01RnQd8iMMUwXQEV1crFmQiQ).

Verified against this PR, not the report: two changed files, Fixes #4712 the only closing keyword. Route A is the right call and the measurement earns it — no PaginatedResult export exists to pin, but the block's hand-copied literal was shadowing QueryResult, whose normalizeQueryResult() computation (total coalescing, hasMore server-else-page-local fallback, page from $skip/$top) had zero coverage anywhere in the package, so the re-point converts tautological green into the package's only pin on that math. The positive control is honest in the useful way: 3 of 4 assertions red under the mutation, with the fourth's survival explained directionally (it guards the opposite default) rather than glossed. Reverse-verification hygiene followed (fix committed first, mutation uncommitted, restore verified). Local gates pinned to 820b4d716, matching this PR's current head.

Will flip ready + enable auto-merge once Lint, Type Check, and Test shards 1–4 conclude success on this head.

---

Generated by Claude Code