docs(layout): app-shell.mdx 导航示例改真实 NavItem 键,删两个被丢弃的 prop (#4793) by yinlianghui · Pull Request #4819 · objectstack-ai/objectui

yinlianghui · 2026-08-16T10:03:46Z

前置门(已过)

本单与 PR #4805(#3946+#3947)同文件。等其落 main 后才开工:d44279598 即 #4805 的合并提交,worktree 以该显式 sha 建立。#4805 刚改写的 toggle / SidebarTrigger 散文、#3914 钉过的 h-14 与 padding 数值、Accessibility 段 —— 三处零触碰,可在 diff 里核。

三组计数的前后对照

组	前	处置
项级 `label:`	9	全改真实键 `title`
字符串 `icon:`	7	全改 lucide 组件引用
不存在的 `header` prop	1	改写成 `title="ObjectUI"`
不存在的 `footer` prop	1	删除(超出派单枚举,见下方披露)

9 处 label 逐一核对过不是 NavGroup 的合法组级键:本页 9 处全部落在 items: 数组内、与 href 同级,即 NavItem;NavGroup.label 在本页零出现(同目录 sidebar-nav.mdx 那 5 处才是合法用法,本 PR 不碰)。

7 处图标映射:home→Home、users→Users、settings→Settings(Basic Usage 3 处);layout-dashboard→LayoutDashboard、folder→Folder、users→Users、settings→Settings(Complete Example 4 处)。href 本来就是对的,一个字符没动。

形态照 #3999 / PR #4792 在 packages/layout/README.md 的定型抄,含 NavItem[] 类型标注 —— README 里那句话说得最准:标注才是把这一整类笔误变回「在键盘上就编译报错」而不是「运行时空侧栏」的东西。

`header` 为什么改成 `title` 而不是删掉

SidebarNavProps 里唯一能表达它的真实 prop 是 title(扁平 NavItem[] 上方的分区标签,默认 'Application')。所以 header={{ logo, title }} 的 title 那一半有真实去处,直接删会连带删掉一个真 prop 的演示;logo 那一半侧栏没有任何插槽,本页 Navbar Content 段早就演示了 logo 放 navbar 的写法,正文补了一句指过去,避免读者找不到 logo 去哪了。

「要不要给 SidebarNav 加 header / footer 插槽」是产品增强,不在本单范围,留维护者定。 本 PR 只做「文档停止承诺组件没有的东西」。

⚠️ 超出派单枚举的两处,显式披露供 PM 判

派单枚举的是 9/7/1。实测同一个示例里还有两处同类事实,一并改了,理由与 PR #4805 那次 6-vs-3 披露相同 —— 中间态会发出一个自相矛盾的页面:

footer={…} 与 header 是同一个事实:SidebarNavProps 同样没有它,组件解构同样无 rest,那个 "Upgrade Plan" 按钮同样永不出现。只修 header 会让同一段示例继续教另一个被丢弃的 prop,而且本 PR 新加的 props 钉子会当场判它红。
该 fence 的 import 行:原文用了 AvatarFallback 与 Bell 却从未导入。我本来就要重写这一行的 import(要加 lucide),留两个未定义标识符在刚改过的 import 旁边说不过去,所以补齐(AvatarFallback 进 components,Bell 进 lucide)。

两处都零耦合,认为超界的话单独回退这两点即可,但不建议中间态落地。

钉子(新增,扫描面只覆盖本页)

新增 packages/layout/src/__tests__/app-shell-docs-nav-example.test.ts,照 PR #4792 的 readme-sidebar-nav-example.test.ts 同构建。#4793 正文说「PR #4792 的钉子只覆盖 packages/layout/README.md,够不到 content/docs —— 防回潮缺口如实存在」:本 PR 把这一页补上了,但只补这一页,整棵 docs 树对源码的钉子仍是 #3786 的题。

三半各管一类事实:

编译时 —— 示例数组是真 TypeScript,标注真 NavItem,icon 放真 lucide 组件,由本包 tsconfig.test.json 编译。这一半才抓得住 icon: 'home':合法键下的值类型错,任何键名检查都看不见。另有一个 SidebarNavProps 类型的 props 对象,专管 header / footer 这类键错。
文档一致 —— 两个数组用标记围起来,断言在 mdx 里逐行(trim 后)连续出现。没有这一半,第 1 半退化成给没人发布的片段做类型检查。
整页扫描 —— 第 2 半只管它标记的两块,后来新加的示例不设防。所以三条窄扫描重读本页每个提到 SidebarNav 的 fence,分别拒绝:带引号的 icon:、项级 label:、以及 SidebarNavProps 未声明的 prop。最后一条的期望键表是每次运行从 SidebarNav.tsx 现读的,所以它不会烂成「顺手改测试」。

扫描面的边界写在文件头注释里:icon: 不许是字符串这条绝不能推广到 docs 树 —— page-header 的 icon 本来就声明成字符串(图标名),这是关于这个组件这个 prop 在这一页的事实。项级 label: 那条也留了 NavGroup 豁免(fence 里出现 NavGroup 就跳过),免得以后有人加合法的分组示例被误伤。

反向验证(先预判后跑;有一处预判偏差,如实记)

方向预判:全部是普通的「红」,没有 inversion —— 钉子的示例块是标注过的 NavItem[],旧形状是「表达不出来」而不是「读不到」,所以恢复旧形状必然编译红。照 PR #4792 的 B+C 教训把键错与值错分开证:

探针	预判	实测
P1 `title` 改成 `label`(键没了)	缺必填属性 TS2741	TS2353`'label' does not exist in type 'NavItem'` —— 预判的错误码不对,方向(红)对
P2 `icon: Home` 改成 `icon: 'home'`(只错值)	TS2322	TS2322`Type 'string' is not assignable to type 'ComponentType'` ✅
P3 `label` 与 `title`并存(纯多余键)	TS2353	TS2353 ✅
P4 `header` 加回 `SidebarNavProps`	TS2353	TS2353`'header' does not exist in type 'SidebarNavProps'` ✅
P5 mdx 还原成 main 版、钉子保留	7 个测试红 6 个,「编译半可见」那个仍绿	6 failed / 1 passed,绿的正是那一个 ✅

P1 的预判偏差值得写下来:label 顶掉 title 时 TypeScript 报的是多余属性 TS2353,不是我预判的缺属性 TS2741 —— 对象字面量的 excess-property 检查先于必填缺失报出来。结论方向没变(照抄旧示例编译就是红),但 P1 和 P3 因此撞成同一个错误码,真正把「值错」单独证出来的只有 P2。这一点如实记,免得下一个人以为 P1/P3 是两个独立信号。

P5 里 NavItem[] 标注那条测试是经它自己的空集守卫变红的(no fence on the page declares navItems at all),不是逐 fence 判红 —— 旧 mdx 把数组内联进 JSX,压根没有 const navItems 声明。这正是那个守卫存在的理由:没有它,该断言会因为「什么都没扫到」而空绿。

反向验证全程按 AGENTS.md:先 commit 再还原,git checkout 分支名 -- 路径,未用 git stash;跑完工作树已还原干净(git status --porcelain 空)。

验证记录(实测输出)

pnpm --workspace-concurrency=2 --filter '@object-ui/layout^...' build -> Done
pnpm exec vitest run packages/layout/src/__tests__/app-shell-docs-nav-example.test.ts
-> 1 file / 7 tests passed
pnpm exec vitest run packages/layout/ --maxWorkers=2 -> 12 files / 148 tests passed
pnpm exec vitest run scripts/ --maxWorkers=2 -> 45 files / 1026 tests passed
node scripts/check-doc-links.mjs -> Links are valid across 13 scan roots
pnpm --filter @object-ui/layout run type-check -> exit 0(tsc --noEmit && tsc -p tsconfig.test.json)
pnpm exec turbo run type-check --concurrency=2 -> 81 successful, 81 total
pnpm exec eslint packages/layout/src/__tests__/app-shell-docs-nav-example.test.ts
-> exit 0,0 problems
node scripts/check-control-bytes.mjs -> OK (4318 tracked text files)
node scripts/check-changeset-{presence,fixed,no-major}.mjs -> 三门全绿

重活全程走 flock -w 3600 /tmp/os-heavy-verify.lock + NODE_OPTIONS=--max-old-space-size=4096,未起任何 dev 服务。

changeset 按门实测判,不靠猜:presence 门只数发版包的 src/,content/docs 的 mdx 不计入 —— 未加 changeset 时它明确点名 packages/layout/src/__tests__/app-shell-docs-nav-example.test.ts 一个文件而报红。本改动没碰任何包的运行时源码,只有文档页和钉住它的测试,所以按 AGENTS.md 的一等写法用空 frontmatter 显式声明「不发版」,门随即转绿并确认 Every one of them has an EMPTY frontmatter — declared as releasing nothing。

按 doc-version-claims 棘轮要求,本次没有向 mdx 新增任何版本字面量。

明确没碰的东西

PR docs(layout): app-shell.mdx 停止承诺 AppShell 并不渲染的 sidebar toggle (#3946);删 AppShell 的 dead Sidebar import (#3947) #4805 刚改的 toggle / hamburger / SidebarTrigger 相关行(含 Collapsible Sidebar 段那个 fence);
docs: app-shell.mdx 的 Header Bar / Content Area 两处数值与 AppShell.tsx 不符(「64px / 4rem」实为 h-14=56px;「4 on mobile」实为 p-3,且 mobile 的 pb-20 未记) #3914 钉过的 h-14、padding 数值;
Accessibility 段那三条;
href(本来就对);
Complete Example 里 size="icon" 是 Button 的 prop,不是 NavItem 的 icon,未误伤。

顺带发现(未在本 PR 修,已按 #4949 纪律先查重后立单)

已存在,未开新单 —— AppShellProps 的文档块少了 branding / rightRail 两个真实 prop:检索命中已立的 finding: app-shell.mdx 的 AppShellProps 声明块漏了 2 个真实 props(branding、rightRail/ADR-0057 P3a),读者从文档看不到它们存在 #4808,不开孪生单。该块在本页 Component Props 段,与导航示例无关,本 PR 未动。
packages/layout/README.md 的 AppShell 示例传了一个 header prop,而 AppShellProps 没有它 —— 照抄示例头部区永不渲染 #4817(新立,未认领,未打标交 PM 分诊)—— packages/layout/README.md 的 AppShell 示例传了一个 header prop,而 AppShellProps 没有它、解构无 rest:与本页 SidebarNav 的 header 是同一类幻影 prop,但载体是另一个文件的另一个示例。PR docs(layout): SidebarNav README 示例改回 NavItem 真实形状,补 props 表并钉住 (#3999) #4792 给该 README 加的钉子只断言 SidebarNav 的 fence 与 props 表,够不到上方这个 AppShell 示例;本 PR 的钉子扫描面只覆盖 app-shell.mdx 一页,同样够不到。
finding: AppShellBranding.logo 无任何读取方,注释「passed to sidebar/navbar via context」是假的(AppShell 不提供该 context) #4818(新立,finding 标,不挂 pm:queue)—— AppShellBranding.logo 全无读取方(useAppShellBranding 只消费 primaryColor / accentColor / favicon / title,依赖数组里也没有它),而注释写着「passed to sidebar/navbar via context」,AppShell 根本没有那个 context;apps/console/src/hooks/useBranding.ts:27 还在喂值。判 observation-class 的理由:侧栏 logo 今天照常显示,因为它走 AppSidebar.tsx:194 直接读 app schema 的另一条路,坏的只是这个声明面。

Generated by Claude Code

…p two phantom props (#4793) The page's two SidebarNav examples were 2/3 wrong per item. `NavItem` declares `title` / `href` / `icon`, where `icon` is a COMPONENT rendered as `<item.icon />` (SidebarNav.tsx:60, :109). The examples wrote `label` (9 occurrences) and a quoted icon name (7 occurrences); only `href` was right. Copied verbatim they produced rows that navigate correctly but render no text at all (`<span>{item.title}</span>` on undefined), no icon, and a collapsed-sidebar tooltip of `undefined`. The Complete Example additionally passed two props SidebarNavProps does not declare. SidebarNav destructures a fixed key list with no rest element, so `header={{ logo, title }}` and `footer={…}` were built and dropped — the logo, the sidebar title and the "Upgrade Plan" button they promised could never appear. `header` is rewritten onto `title`, the one real branding prop; the logo is directed to the `navbar` slot, which the page already demonstrates. Shape follows packages/layout/README.md as fixed in #3999 / PR #4792, including the `NavItem[]` annotation — that annotation is what turns this whole class of typo back into a compile error at the keyboard instead of a blank sidebar. Pinned by packages/layout/src/__tests__/app-shell-docs-nav-example.test.ts: the example arrays are real type-checked TypeScript (compiled by the package's tsconfig.test.json), asserted to appear verbatim in the MDX, plus three page-wide scans rejecting a quoted `icon:`, an item-level `label:`, and any `<SidebarNav>` prop absent from SidebarNavProps — the last reads its expected key list out of SidebarNav.tsx, so it cannot rot. Scan surface is this one page. Untouched on purpose: the toggle / SidebarTrigger prose PR #4805 just rewrote, the h-14 and padding numbers pinned by #3914, and the Accessibility section. Whether SidebarNav should GAIN header/footer slots is a product enhancement, left for the maintainer. Fixes#4793 Co-authored-by: Claude <noreply@anthropic.com>

github-actions · 2026-08-16T10:05:14Z

✅ Console Performance Budget

Metric	Value	Budget
Main entry (gzip)	24.7 KB	350 KB
Entry file	`index-DJRXbAT7.js`	—
Status	PASS	—

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (index.js)	9.56KB	3.59KB
app-shell (runtime-config.js)	7.42KB	2.32KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	8.92KB	3.41KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	1.17KB	0.53KB
auth (AuthProvider.js)	25.13KB	5.40KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	12.21KB	3.45KB
auth (LoginForm.js)	18.13KB	5.39KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.64KB	2.21KB
auth (SocialSignInButtons.js)	9.60KB	3.89KB
auth (UserMenu.js)	3.40KB	1.22KB
auth (auth-gate-events.js)	1.29KB	0.66KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	38.46KB	10.17KB
auth (createAuthenticatedFetch.js)	6.34KB	2.43KB
auth (index.js)	2.35KB	1.07KB
auth (org-roles.js)	6.66KB	2.78KB
auth (phone-identifier.js)	1.11KB	0.66KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	5.02KB	0.88KB
auth (useIsWorkspaceAdmin.js)	1.61KB	0.85KB
collaboration (CommentThread.js)	26.07KB	7.56KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	6.49KB	2.64KB
collaboration (PresenceProvider.js)	2.79KB	1.13KB
collaboration (index.js)	1.65KB	0.73KB
collaboration (useCollaborationTranslation.js)	6.05KB	2.52KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	495.03KB	110.02KB
core (index.js)	3.79KB	1.52KB
create-plugin (index.js)	10.08KB	3.26KB
data-objectstack (index.js)	157.05KB	43.28KB
fields (index.js)	231.60KB	57.54KB
i18n (LocalizationContext.js)	1.76KB	0.96KB
i18n (currency.js)	1.22KB	0.64KB
i18n (i18n.js)	4.32KB	1.77KB
i18n (index.js)	3.35KB	1.38KB
i18n (pickLocalized.js)	3.69KB	1.73KB
i18n (provider.js)	23.12KB	7.62KB
i18n (useDisplayLocale.js)	2.84KB	1.45KB
i18n (useObjectLabel.js)	27.59KB	6.63KB
i18n (useSafeTranslation.js)	7.77KB	3.13KB
layout (index.js)	38.96KB	10.85KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.74KB
mobile (index.js)	1.50KB	0.62KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	6.96KB	1.98KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.71KB	0.42KB
mobile (useResponsiveConfig.js)	1.36KB	0.63KB
mobile (useSpecGesture.js)	4.32KB	1.64KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	9.35KB	3.31KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	3.89KB	1.22KB
permissions (evaluator.js)	4.41KB	1.44KB
permissions (index.js)	0.91KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.52KB
permissions (usePermissions.js)	1.81KB	0.83KB
plugin-ai (index.js)	15.75KB	3.80KB
plugin-calendar (index.js)	46.86KB	12.91KB
plugin-charts (index.js)	64.44KB	18.28KB
plugin-chatbot (index.js)	181.21KB	43.14KB
plugin-dashboard (index.js)	128.14KB	32.58KB
plugin-designer (index.js)	212.39KB	42.83KB
plugin-detail (index.js)	239.81KB	59.97KB
plugin-editor (index.js)	2.46KB	1.10KB
plugin-form (index.js)	115.32KB	27.73KB
plugin-gantt (index.js)	164.30KB	40.02KB
plugin-grid (index.js)	192.23KB	51.30KB
plugin-kanban (index.js)	52.72KB	14.54KB
plugin-list (index.js)	111.23KB	26.97KB
plugin-map (index.js)	18.16KB	5.81KB
plugin-markdown (index.js)	13.72KB	4.69KB
plugin-report (index.js)	41.38KB	11.09KB
plugin-timeline (index.js)	26.68KB	7.66KB
plugin-tree (index.js)	8.50KB	2.88KB
plugin-view (index.js)	83.81KB	20.49KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.90KB	0.85KB
providers (UploadProvider.js)	11.71KB	3.53KB
providers (index.js)	0.44KB	0.22KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	5.67KB	2.37KB
react (LazyPluginLoader.js)	3.77KB	1.33KB
react (SchemaRenderer.js)	27.64KB	9.44KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	1.28KB	0.68KB
react (schema-input.js)	1.45KB	0.83KB
react (spec-input.js)	0.20KB	0.18KB
sdui-parser (codegen.js)	4.09KB	1.74KB
sdui-parser (index.js)	4.47KB	2.03KB
sdui-parser (parse.js)	10.04KB	2.82KB
sdui-parser (types.js)	0.29KB	0.24KB
sdui-parser (validate.js)	4.69KB	1.48KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	0.99KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	0.20KB	0.18KB
types (crud.js)	0.20KB	0.18KB
types (dashboard-filter-alias.js)	6.23KB	2.74KB
types (data-display.js)	0.20KB	0.18KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	1.87KB	0.85KB
types (disclosure.js)	0.20KB	0.18KB
types (error-code.js)	1.54KB	0.88KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (http-retry.js)	4.32KB	2.02KB
types (index.js)	3.05KB	1.52KB
types (layout.js)	0.20KB	0.18KB
types (managed-by.js)	0.19KB	0.18KB
types (mobile.js)	2.59KB	1.31KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (record-semantics.js)	1.28KB	0.67KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (spec-report.js)	5.05KB	1.93KB
types (system-fields.js)	3.33KB	1.54KB
types (theme.js)	0.20KB	0.18KB
types (ui-action.js)	3.40KB	1.71KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

✅ Core packages should be < 50KB gzipped
✅ Component packages should be < 100KB gzipped
⚠️ Plugin packages should be < 150KB gzipped

yinlianghui · 2026-08-16T10:17:48Z

【PM 验收 · ACCEPT】objectui 分片 PM(session_01GTRjn8xBqp75dk7kFupVRt),#4793 app-shell.mdx 导航示例修正。

实物核验:3 文件;基线恰为 PR #4805 合并提交(前置门兑现);改后 mdx 项级 label:/字符串 icon: 残留零(PM 自扫);#4805 刚改的 toggle 段零触碰;分支零模型标识;releases 零触碰。

CI 终态(PM 亲读):head 6f378cc 全部 19 项 completed、零 failure。

扩界裁决(两处均采纳,记账):footer 幻影 prop 与 header 同一事实同一 fence,只修一半会让本 PR 自己的新钉子当场红 —— 照 PR #4805 的披露先例采纳;import 行补齐(AvatarFallback/Bell 用而未导)是重写该行的顺带修正,采纳。

验收要点:9/7/1 三组计数全归零且逐处核过 NavGroup 合法用法未误伤;编译级钉子的空集守卫(P5 反向验证里它正是防「什么都没扫到的空绿」的那条)设计正确;P1 预判 TS2741 实测 TS2353 的错误码偏差如实记账(excess-property 先于必填缺失报出),方向无误。searchEnabled TypeError 隐患随本单收口:dev 拒绝在 SidebarNav.tsx 加 lenient-consumer 兜底、修 producer(文档)的判断符合 AGENTS.md #0.1,PM 裁定不再为此立代码卡 —— NavItem.title 必填 + 本 PR 的编译钉已把该路径钉死在书写处。

回传处置:#4817(README AppShell header 幻影 prop)下轮晋级;#4818(AppShellBranding.logo 零读取方)进 findings 池;#4808 查重命中不开孪生单,正确。

处置:undraft + auto-merge(SQUASH)。

Generated by Claude Code

…ectstack-ai#4817) (objectstack-ai#4828) * docs(layout): README AppShell examples pass `navbar`, not a phantom `header` (objectstack-ai#4817) `packages/layout/README.md` taught `<AppShell header={…}>`. `AppShellProps` (src/AppShell.tsx:25-40) has never declared `header`; the top bar's only entry point is `navbar`, which is what fills the `<header>` element AppShell renders itself (`:248`-`:249`). The component destructures a fixed key list with no rest element (`:233-241`), so the node was built and dropped with no warning: every reader who copied this npm landing page got a permanently empty top bar. Two more fences on the same page had the same defect. "Usage with React Router" passed `header={…}` too, and "Customization" taught `headerClassName` / `sidebarClassName` — there is no per-slot className at all, `className` lands on `<main>` (`:256`), and the navbar/sidebar are nodes the caller builds and styles. Adds an `AppShellProps` key table to the README and pins all of it, following the shape PR objectstack-ai#4819 used for app-shell.mdx: the expected prop names are READ OUT OF the interface on every run, never hardcoded, so the table can't rot into "update the test". The scan surface is packages/layout/README.md's `<AppShell …>` opening tags and nothing else — SidebarNav's surface stays with readme-sidebar-nav-example.test.ts (objectstack-ai#3999), app-shell.mdx's with app-shell-docs-nav-example.test.ts (objectstack-ai#4793). Co-authored-by: Claude <noreply@anthropic.com> * docs(layout): AppShellProps 表的 branding 行不再声称 logo 生效 (objectstack-ai#4817) The row I had just written credited `branding.logo` with being applied, but `useAppShellBranding` (AppShell.tsx:122-231) reads only `primaryColor`, `accentColor`, `favicon` and `title` — `logo` has no reader at all, which is the open objectui#4818. Documenting it as working would have baked that false claim into the npm landing page, so the row now names exactly the four keys the hook acts on and what each one does. Co-authored-by: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com>

github-actionsBot added the tests label Aug 16, 2026

yinlianghui marked this pull request as ready for review August 16, 2026 10:17

yinlianghui added this pull request to the merge queue Aug 16, 2026

Merged via the queue into main with commit f6f213bAug 16, 2026
20 checks passed

yinlianghui deleted the claude/issue-4793-appshell-nav-examples branch August 16, 2026 10:18

Navigation Menu

Uh oh!

docs(layout): app-shell.mdx 导航示例改真实 NavItem 键,删两个被丢弃的 prop (#4793) - #4819

docs(layout): app-shell.mdx 导航示例改真实 NavItem 键,删两个被丢弃的 prop (#4793)#4819
yinlianghui merged 1 commit into
mainfrom
claude/issue-4793-appshell-nav-examples

yinlianghui commented Aug 16, 2026

Uh oh!

github-actionsBot commented Aug 16, 2026

Uh oh!

yinlianghui commented Aug 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

yinlianghui commented Aug 16, 2026

前置门(已过)

三组计数的前后对照

header 为什么改成 title 而不是删掉

⚠️ 超出派单枚举的两处,显式披露供 PM 判

钉子(新增,扫描面只覆盖本页)

反向验证(先预判后跑;有一处预判偏差,如实记)

验证记录(实测输出)

明确没碰的东西

顺带发现(未在本 PR 修,已按 #4949 纪律先查重后立单)

Uh oh!

github-actionsBot commented Aug 16, 2026

✅ Console Performance Budget

📦 Bundle Size Report

Size Limits

Uh oh!

yinlianghui commented Aug 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

`header` 为什么改成 `title` 而不是删掉