test(fields): pin 'user' in FORM_WIDGET_TYPES to close one-way blindness by os-support-ai · Pull Request #5277 · objectstack-ai/objectui

os-support-ai · 2026-08-18T23:57:54Z

What

packages/fields/src/field-type-coverage.test.ts is the regression guard for
the field-type to renderer mapping tables. It pins two lists — one for the form
half (FORM_WIDGET_TYPES, via mapFieldTypeToFormType) and one for the cell/
read half (CELL_RENDERER_TYPES, via getCellRenderer). CELL_RENDERER_TYPES
already pinned 'user'; FORM_WIDGET_TYPES did not. That asymmetry meant
deleting user: 'field:user' from field-type-alias.ts would make only the
cell half of the guard go red, while the form half silently fell back to
field:text via mapFieldTypeToFormType's || 'field:text' tail — the exact
one-way blindness the guard's own header says it exists to prevent.

Adds 'user' to FORM_WIDGET_TYPES (one line). owner is intentionally left
out — it was already retired (#4814 ruling A′; tombstone at
field-type-alias.ts:74-81), and re-adding it to FORM_WIDGET_TYPES would
reassert a retired key and contradict the opposite-direction pin in
__tests__/owner-retired.test.tsx.

Reverse verification (the point of this card)

Prediction (before running):getCellRenderer('user') resolves through an
independent registration (registerFieldRenderer('user', UserCellRenderer) in
index.tsx, plus a literal map entry), which never consults
field-type-alias.ts's typeMap. So deleting user: 'field:user' from
field-type-alias.ts should turn only the newly-added form-half assertion red
— the cell half (already pinned) should stay green, since it never depended on
this alias table.

Observed: with user: 'field:user' deleted and the fix applied, exactly 1
test failed —

x maps "user" to a dedicated form widget (not field:text)
AssertionError: expected 'field:text' not to be 'field:text'
Tests 1 failed | 87 passed (88)

— matching the prediction: only the form-half 'user' assertion went red;
all 87 others, including the cell-half 'user' test, stayed green. The alias
line was restored immediately after (git checkout -- packages/fields/src/field-type-alias.ts),
confirmed clean via git status/git diff --stat.

Scope

File surface: packages/fields/src/field-type-coverage.test.ts only (plus an
empty-frontmatter changeset, confirmed required by
node scripts/check-changeset-presence.mjs). field-type-alias.ts was read
and temporarily mutated only for the ablation above, then restored — it ships
unchanged.

Tests

All run from the repo root, all against HEAD 07d895cfd:

pnpm exec vitest run packages/fields/src/field-type-coverage.test.ts — 88/88 passed.
pnpm exec vitest run packages/fields/ (full package suite, exercises owner-retired.test.tsx alongside this change) — 107 files / 1802 tests, all passed.
pnpm --filter '@object-ui/fields^...' build (dependency closure — required before type-check, otherwise stale/missing dist gives false TS2307 "cannot find module" errors unrelated to this change)
pnpm --filter @object-ui/fields type-check — clean.
pnpm --filter @object-ui/fields lint — 0 errors, 839 pre-existing warnings (none touch field-type-coverage.test.ts or the changeset).
node scripts/check-control-bytes.mjs — OK.
node scripts/check-changeset-presence.mjs — OK (declares the empty-frontmatter changeset above).

Generated by Claude Code

field-type-coverage.test.ts asserts CELL_RENDERER_TYPES includes 'user' but FORM_WIDGET_TYPES did not, so deleting the user: 'field:user' alias in field-type-alias.ts made only the cell half red while the form half silently fell back to field:text via the `|| 'field:text'` tail. Fixes#4855

Part of #4855 — test-only change to field-type-coverage.test.ts; no published behaviour changes.

github-actions · 2026-08-19T00:00:20Z

✅ Console Performance Budget

Metric	Value	Budget
Main entry (gzip)	25.3 KB	350 KB
Entry file	`index-BRSufyDS.js`	—
Status	PASS	—

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (index.js)	9.83KB	3.70KB
app-shell (runtime-config.js)	7.42KB	2.32KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	8.92KB	3.41KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	1.17KB	0.53KB
auth (AuthProvider.js)	29.33KB	7.05KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	12.21KB	3.45KB
auth (LoginForm.js)	18.13KB	5.39KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.64KB	2.21KB
auth (SocialSignInButtons.js)	9.60KB	3.89KB
auth (UserMenu.js)	3.40KB	1.22KB
auth (auth-gate-events.js)	1.29KB	0.66KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	40.21KB	10.79KB
auth (createAuthenticatedFetch.js)	6.34KB	2.43KB
auth (index.js)	2.71KB	1.22KB
auth (invitation-status.js)	1.22KB	0.70KB
auth (org-roles.js)	6.66KB	2.78KB
auth (phone-identifier.js)	1.11KB	0.66KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	5.02KB	0.88KB
auth (useIsWorkspaceAdmin.js)	1.61KB	0.85KB
collaboration (CommentThread.js)	26.07KB	7.56KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	6.49KB	2.64KB
collaboration (PresenceProvider.js)	2.79KB	1.13KB
collaboration (index.js)	1.65KB	0.73KB
collaboration (useCollaborationTranslation.js)	6.05KB	2.52KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	506.17KB	113.33KB
core (index.js)	4.11KB	1.62KB
create-plugin (index.js)	10.08KB	3.26KB
data-objectstack (index.js)	159.80KB	44.34KB
fields (index.js)	237.07KB	59.46KB
i18n (LocalizationContext.js)	1.76KB	0.96KB
i18n (currency.js)	1.22KB	0.64KB
i18n (i18n.js)	4.28KB	1.75KB
i18n (index.js)	3.42KB	1.39KB
i18n (pickLocalized.js)	3.69KB	1.73KB
i18n (provider.js)	23.13KB	7.63KB
i18n (useDisplayLocale.js)	2.85KB	1.45KB
i18n (useObjectLabel.js)	29.43KB	7.15KB
i18n (useSafeTranslation.js)	7.77KB	3.13KB
layout (index.js)	39.16KB	10.97KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.74KB
mobile (index.js)	1.50KB	0.62KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	6.96KB	1.98KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.71KB	0.42KB
mobile (useResponsiveConfig.js)	1.36KB	0.63KB
mobile (useSpecGesture.js)	4.32KB	1.64KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	9.35KB	3.31KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	4.42KB	1.42KB
permissions (evaluator.js)	5.12KB	1.74KB
permissions (index.js)	0.91KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.52KB
permissions (usePermissions.js)	1.81KB	0.83KB
plugin-ai (index.js)	15.75KB	3.80KB
plugin-calendar (index.js)	46.62KB	12.83KB
plugin-charts (index.js)	64.75KB	18.37KB
plugin-chatbot (index.js)	181.21KB	43.14KB
plugin-dashboard (index.js)	128.04KB	32.75KB
plugin-designer (index.js)	212.39KB	42.83KB
plugin-detail (index.js)	241.46KB	60.56KB
plugin-editor (index.js)	2.46KB	1.10KB
plugin-form (index.js)	123.77KB	30.07KB
plugin-gantt (index.js)	164.10KB	39.87KB
plugin-grid (index.js)	198.22KB	53.27KB
plugin-kanban (index.js)	52.93KB	14.60KB
plugin-list (index.js)	111.66KB	27.13KB
plugin-map (index.js)	19.96KB	6.56KB
plugin-markdown (index.js)	13.72KB	4.69KB
plugin-report (index.js)	42.84KB	11.77KB
plugin-timeline (index.js)	26.68KB	7.66KB
plugin-tree (index.js)	8.50KB	2.88KB
plugin-view (index.js)	84.34KB	20.61KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.90KB	0.85KB
providers (UploadProvider.js)	11.66KB	3.50KB
providers (index.js)	0.44KB	0.22KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	5.62KB	2.34KB
react (LazyPluginLoader.js)	3.77KB	1.33KB
react (SchemaRenderer.js)	31.56KB	10.70KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	1.33KB	0.69KB
react (schema-input.js)	1.45KB	0.83KB
react (spec-input.js)	0.20KB	0.18KB
sdui-parser (codegen.js)	5.41KB	2.34KB
sdui-parser (index.js)	4.77KB	2.16KB
sdui-parser (input-type.js)	2.84KB	1.40KB
sdui-parser (parse.js)	10.76KB	3.17KB
sdui-parser (provenance.js)	3.66KB	1.82KB
sdui-parser (types.js)	0.29KB	0.24KB
sdui-parser (validate.js)	6.92KB	2.40KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	0.99KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	0.20KB	0.18KB
types (crud.js)	0.20KB	0.18KB
types (dashboard-filter-alias.js)	6.23KB	2.74KB
types (data-display.js)	0.20KB	0.18KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	1.87KB	0.85KB
types (disclosure.js)	0.20KB	0.18KB
types (error-code.js)	1.54KB	0.88KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (http-retry.js)	4.32KB	2.02KB
types (index.js)	3.08KB	1.53KB
types (layout.js)	0.20KB	0.18KB
types (managed-by.js)	0.19KB	0.18KB
types (mobile.js)	2.59KB	1.31KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (record-semantics.js)	1.28KB	0.67KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (spec-report.js)	5.05KB	1.93KB
types (system-fields.js)	3.33KB	1.54KB
types (theme.js)	0.20KB	0.18KB
types (ui-action.js)	3.40KB	1.71KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

✅ Core packages should be < 50KB gzipped
✅ Component packages should be < 100KB gzipped
⚠️ Plugin packages should be < 150KB gzipped

claude added 2 commits August 18, 2026 23:43

chore(fields): add empty changeset for test-only coverage fix
07d895c
Part of #4855 — test-only change to field-type-coverage.test.ts; no published behaviour changes.

github-actionsBot added the tests label Aug 18, 2026

os-support-ai marked this pull request as ready for review August 19, 2026 00:11

os-support-ai added this pull request to the merge queue Aug 19, 2026

Merged via the queue into main with commit 6f01aa3Aug 19, 2026
22 checks passed

os-support-ai deleted the claude/issue-4855-form-widget-types-user branch August 19, 2026 00:11

Navigation Menu

Uh oh!

test(fields): pin 'user' in FORM_WIDGET_TYPES to close one-way blindness - #5277

test(fields): pin 'user' in FORM_WIDGET_TYPES to close one-way blindness#5277
os-support-ai merged 2 commits into
mainfrom
claude/issue-4855-form-widget-types-user

os-support-ai commented Aug 18, 2026

Uh oh!

github-actionsBot commented Aug 19, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

os-support-ai commented Aug 18, 2026

What

Reverse verification (the point of this card)

Scope

Tests

Uh oh!

github-actionsBot commented Aug 19, 2026

✅ Console Performance Budget

📦 Bundle Size Report

Size Limits

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants