refactor(layout): remove the unread logo key from AppShellBranding

[os-support-ai]

Fixes#4818

Maintainer ruling, 2026-08-19, over the 27-card objectui decision-inbox review (comment 5339695386), verbatim: 「全部接受」 — option 1, remove. Option 2 (build a real branding context) was rejected as a permanent provider obligation with zero demand.

What was removed

AppShellBranding.logo was declared but never read.

• useAppShellBranding (packages/layout/src/AppShell.tsx) applies only primaryColor, accentColor, favicon and title; its effect dependency array does not list logo at all.
• AppShell installs no context provider, so the key's doc comment — "Logo URL — passed to sidebar/navbar via context" — named a mechanism that does not exist in the code. That comment is deleted with the key.

Six deleted lines, no additions, across four files plus a changeset.

Three feed lines, not one

The card named one feeder. There are three, and each one was handing the key a real value that was silently discarded:

Feed line	Named by
apps/console/src/hooks/useBranding.ts:27 — logo: app.branding.logo	the card
packages/layout/src/AppSchemaRenderer.tsx:582 — logo: schema.logo	the dispatch's correction
packages/app-shell/src/layout/ConsoleLayout.tsx:174 — logo: activeApp.branding.logo	nobody

The third is the only reason this diff reaches packages/app-shell, which is outside the file surface the card and the dispatch drew. It is not optional: deleting the key makes that line a hard tsc error (evidence below), so leaving it would ship a red typecheck. It is the same defect class, the same mechanical one-line deletion as its two siblings, in a file no in-flight worktree or open PR touches, and it adds no new gate. apps/console/src/hooks/useBranding.ts also loses the matching logo?: string from its local AppBranding interface — that hook has zero callers today.

The premise check the dispatch asked for — measured, and it holds

The dispatch flagged one thing to verify rather than assume: AppSchemaRenderer forwarded schema.logo, a top-level app-schema key, while AppSidebar.tsx:194 reads activeApp?.branding?.logo, a nested one — so was the forward actually dead?

Measured on origin/mainbdf8cf76e: they are not the same key and not the same place — but that turns out not to matter, because neither logo render site goes through AppShellBranding at all. Both are untouched by this PR:

• packages/layout/src/AppSchemaRenderer.tsx:385 — resolveIcon(schema.logo) — and :397-399, an img whose src is schema.logo, in the default sidebar header. This renders the top-level key directly, in the very same file that built the branding object. The forward at :582 was a second, parallel, dead route for a value the file was already rendering itself.
• packages/app-shell/src/layout/AppSidebar.tsx:194 — activeApp?.branding?.logo, read directly off the app schema.

So the ruling's premise — "the logo already renders correctly today via the real path" — is true for both halves. The roll-back clause does not trigger.

Reverse verification

Stated per leg, because a deletion PR is exactly the shape that passes vacuously. tsc has a build artifact between the edit and the result for the two cross-package legs: the root tsconfig.json has no paths entry for @object-ui/layout, so consumers resolve it through node_modules to packages/layout/dist/AppShell.d.ts. Every leg below rebuilt that artifact first and proved the marker's presence or absence in it. Vitest is the opposite: vitest.config.mts:263 aliases @object-ui/layout to packages/layout/src, so no artifact sits between the edit and the tests.

Leg 1 — baseline, logo present in the built .d.ts. After building the dependency closure, packages/layout/dist/AppShell.d.ts:14 carried logo?: string;. All three consumer packages type-checked clean, i.e. writing logo compiled:

packages/layout type-check: Done
packages/app-shell type-check: Done
apps/console type-check: Done
EXIT=0

Leg 2 — key deleted, feed lines still in place; rebuild proved the marker gone (grep -c logo packages/layout/dist/AppShell.d.ts → 0). Each of the three consumers then failed, naming exactly one site:

packages/layout src/AppSchemaRenderer.tsx(582,5): error TS2353: Object literal may only
specify known properties, and 'logo' does not exist in type 'AppShellBranding'.
packages/app-shell src/layout/ConsoleLayout.tsx(174,15): error TS2322: ... Object literal may
only specify known properties, and 'logo' does not exist in type 'AppShellBranding'.
apps/console src/hooks/useBranding.ts(27,11): error TS2345: ... Object literal may only
specify known properties, and 'logo' does not exist in type 'AppShellBranding'.

That is the answer to "show that a consumer writing logo is now a compile error" — demonstrated by three real consumers, two of them resolving through the published .d.ts exactly as an external consumer would.

Leg 3 — feed lines deleted, artifacts rebuilt, marker re-confirmed absent. All three green again (EXIT=0).

Nothing rendering-visible changed. The removed key had no reader: no branch of useAppShellBranding touched it, and AppShell exposes no context for anything downstream to read it from. The two live render sites listed above still sit at the same lines.

Tests

Run from the repo root with path filters, never pnpm --filter pkg test — 17 packages here own a standalone vitest.config.ts that does not re-export the root config, so a package-scoped run executes a different config than CI.

pnpm exec vitest run packages/layout/ apps/console/ --maxWorkers=2
Test Files 76 passed (76)
Tests 874 passed (874)
pnpm exec vitest run packages/app-shell/src/layout/ packages/app-shell/src/console/ \
packages/app-shell/src/runtime-config.test.ts packages/app-shell/src/hooks/ --maxWorkers=2
Test Files 110 passed (110)
Tests 835 passed (835)

186 files, 1709 tests, zero failures. The second command's paths cover every packages/app-shell test that mentions ConsoleLayout, AppShellBranding or branding, plus the AppSidebar suites that guard the real logo path. The remainder of that package's 456 files is left to CI, which runs the whole farm once anyway.

Gates

Union re-run after the final commit, at 49dee42ad:

check-changeset-presence 4 source file(s) of 3 released package(s) changed, 1 changeset declared
check:changeset (fixed) All workspace packages are in the changeset fixed group
check:changeset (no-major) No changeset declares a `major` bump
check:control-bytes OK (4757 tracked text files)
check:doc-types Every documented component type is registered
check:doc-snippets 87 of 87 blocks judged, 0 failed — compiled against the BUILT types
check:phantom-deps Every in-scope import is declared by the package that publishes it
check:self-import No package names itself inside its own src/
lint 0 errors (201 pre-existing warnings, unchanged from main)

check:doc-snippets is the load-bearing one for a published-type deletion: it compiles documentation snippets against the built types and found no snippet writing logo on an AppShellBranding literal.

Docs

• packages/layout/README.md:82 — re-read, unchanged. Its branding row already lists exactly the four keys really read, so it gains no stale mention.
• content/docs/guide/layout.md:82 — same row, same four keys, likewise needs nothing.
• content/docs/layout/app-shell.mdx — deliberately not touched. Its only AppShellBranding mention is a "see AppShellBranding" pointer, and its logo prose is about the navbar slot, an unrelated ReactNode. The app-shell.mdx prose is finding: app-shell.mdx 的 Features/Styling 散文完全不提 branding 与 rightRail —— 键表已补齐(#4808/PR4829),散文半截待 #4818 裁定 logo 后写 #4830's job and remains open; writing it here would be a file-surface breach.

Versioning

minor for @object-ui/layout, @object-ui/app-shell and @object-ui/console — never major. Maintainer, 2026-08-19, verbatim: 「objectui ui 的 major 是要跟着 objectstack 走的,不可以自己发 major」. The changeset body names the removed published optional key and the real replacement path.

---

Generated by Claude Code

[github-actions]

✅ Console Performance Budget

Metric	Value	Budget
Main entry (gzip)	25.3 KB	350 KB
Entry file	index-ChU24_Pk.js	—
Status	PASS	—

---

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (index.js)	9.83KB	3.70KB
app-shell (runtime-config.js)	7.42KB	2.32KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	10.06KB	3.86KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	1.17KB	0.53KB
auth (AuthProvider.js)	29.33KB	7.05KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	12.21KB	3.45KB
auth (LoginForm.js)	18.13KB	5.39KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.64KB	2.21KB
auth (SocialSignInButtons.js)	9.60KB	3.89KB
auth (UserMenu.js)	3.40KB	1.22KB
auth (auth-gate-events.js)	1.29KB	0.66KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	40.21KB	10.79KB
auth (createAuthenticatedFetch.js)	6.34KB	2.43KB
auth (index.js)	2.71KB	1.22KB
auth (invitation-status.js)	1.22KB	0.70KB
auth (org-roles.js)	6.66KB	2.78KB
auth (phone-identifier.js)	1.11KB	0.66KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	5.02KB	0.88KB
auth (useIsWorkspaceAdmin.js)	1.61KB	0.85KB
collaboration (CommentThread.js)	26.07KB	7.56KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	6.49KB	2.64KB
collaboration (PresenceProvider.js)	2.79KB	1.13KB
collaboration (index.js)	1.65KB	0.73KB
collaboration (useCollaborationTranslation.js)	6.05KB	2.52KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	505.53KB	113.13KB
core (index.js)	4.11KB	1.62KB
create-plugin (index.js)	10.08KB	3.26KB
data-objectstack (index.js)	159.80KB	44.34KB
fields (index.js)	237.07KB	59.46KB
i18n (LocalizationContext.js)	1.76KB	0.96KB
i18n (currency.js)	1.22KB	0.64KB
i18n (i18n.js)	4.28KB	1.75KB
i18n (index.js)	3.42KB	1.39KB
i18n (pickLocalized.js)	3.69KB	1.73KB
i18n (provider.js)	23.13KB	7.63KB
i18n (useDisplayLocale.js)	2.85KB	1.45KB
i18n (useObjectLabel.js)	30.51KB	7.57KB
i18n (useSafeTranslation.js)	7.77KB	3.13KB
layout (index.js)	38.95KB	10.97KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.74KB
mobile (index.js)	1.50KB	0.62KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	6.96KB	1.98KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.71KB	0.42KB
mobile (useResponsiveConfig.js)	1.36KB	0.63KB
mobile (useSpecGesture.js)	4.32KB	1.64KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	9.35KB	3.31KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	4.42KB	1.42KB
permissions (evaluator.js)	5.12KB	1.74KB
permissions (index.js)	0.91KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.52KB
permissions (usePermissions.js)	1.81KB	0.83KB
plugin-ai (index.js)	15.75KB	3.80KB
plugin-calendar (index.js)	46.62KB	12.83KB
plugin-charts (index.js)	64.75KB	18.37KB
plugin-chatbot (index.js)	181.21KB	43.14KB
plugin-dashboard (index.js)	128.07KB	32.77KB
plugin-designer (index.js)	212.39KB	42.83KB
plugin-detail (index.js)	241.46KB	60.56KB
plugin-editor (index.js)	2.46KB	1.10KB
plugin-form (index.js)	124.19KB	30.20KB
plugin-gantt (index.js)	164.10KB	39.87KB
plugin-grid (index.js)	197.30KB	53.06KB
plugin-kanban (index.js)	52.93KB	14.60KB
plugin-list (index.js)	111.66KB	27.13KB
plugin-map (index.js)	20.08KB	6.62KB
plugin-markdown (index.js)	13.72KB	4.69KB
plugin-report (index.js)	43.49KB	11.93KB
plugin-timeline (index.js)	26.68KB	7.66KB
plugin-tree (index.js)	8.50KB	2.88KB
plugin-view (index.js)	84.52KB	20.67KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.90KB	0.85KB
providers (UploadProvider.js)	11.66KB	3.50KB
providers (index.js)	0.44KB	0.22KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	5.62KB	2.34KB
react (LazyPluginLoader.js)	3.77KB	1.33KB
react (SchemaRenderer.js)	36.10KB	12.26KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	1.33KB	0.69KB
react (schema-input.js)	1.45KB	0.83KB
react (spec-input.js)	0.20KB	0.18KB
sdui-parser (codegen.js)	5.41KB	2.34KB
sdui-parser (index.js)	4.77KB	2.16KB
sdui-parser (input-type.js)	2.84KB	1.40KB
sdui-parser (parse.js)	10.76KB	3.17KB
sdui-parser (provenance.js)	3.66KB	1.82KB
sdui-parser (types.js)	0.29KB	0.24KB
sdui-parser (validate.js)	6.92KB	2.40KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	0.99KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	0.20KB	0.18KB
types (crud.js)	0.20KB	0.18KB
types (dashboard-filter-alias.js)	6.23KB	2.74KB
types (data-display.js)	0.20KB	0.18KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	1.87KB	0.85KB
types (disclosure.js)	0.20KB	0.18KB
types (error-code.js)	1.54KB	0.88KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (http-retry.js)	4.32KB	2.02KB
types (index.js)	3.08KB	1.53KB
types (layout.js)	0.20KB	0.18KB
types (managed-by.js)	0.19KB	0.18KB
types (mobile.js)	2.59KB	1.31KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (record-semantics.js)	1.28KB	0.67KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (spec-report.js)	5.05KB	1.93KB
types (system-fields.js)	3.33KB	1.54KB
types (theme.js)	0.20KB	0.18KB
types (ui-action.js)	3.40KB	1.71KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

• ✅ Core packages should be < 50KB gzipped
• ✅ Component packages should be < 100KB gzipped
• ⚠️ Plugin packages should be < 150KB gzipped