… shared evaluator
`packages/components`' published `ActionParamDialog` is the repo's second
action-param dialog, and its `select` branch rendered `param.options?.map(...)`
straight into Radix items. A per-option `visibleWhen` was not evaluated wrongly
on this surface — it was not evaluated at all, so an option gated on `record.*`
(a sibling param) or `current_user.*` was offered unconditionally, while the
app-shell dialog filtered the identical field metadata (objectui#3765 /
PR #4756).
The branch now reads `resolveVisibleOptions` from `@object-ui/core` — the same
function the governed path reaches through `useCascadingOptions` — against the
dialog's own in-progress values (the ruled Option B record) and the ambient
predicate scope. `dependsOn` gating is deliberately not reproduced: `paramToField`
copies `depends_on` only for `EXPANDABLE_FIELD_TYPES`, so a `select` param reaches
the governed widget with no `dependsOn` and `resolveCascadingOptions` reduces to
exactly this call; gating here would diverge, not converge.
A selection the predicate stops offering is cleared with the same
`isValueStillOffered` check `SelectField` uses, confined to option lists that
declare a predicate. Filtering alone would otherwise create a state the unfiltered
code could not reach: the choice disappears from the trigger while still riding in
the submitted payload.
Rebind, not removal — the component stays a published export with its props and
every other branch untouched.
Fixes#4758
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012u2pRjcqAYtoEjgr3wwhnK
Fixes#4758
What was wrong
packages/components/src/custom/action-param-dialog.tsxis the repo's second action-param dialog and a published export of thecustombarrel. Itsselectbranch renderedparam.options?.map(...)straight into RadixSelectItems, so a per-optionvisibleWhenwas not evaluated wrongly on this surface — it was not evaluated at all. An option a field's metadata gates onrecord.*(a sibling param) orcurrent_user.*was offered unconditionally here, while the app-shell dialog (#3765 / PR #4756) filtered the identical metadata.Triage ruled the governed side authoritative, with a hard scope constraint: rebind, don't delete. The component stays a published export; retiring it remains a separate maintainer decision. Fact two on the card (the producer-less
ctx.formValues/ctx.datafallback chain) is deliberately untouched here and stays pinned for its own convergence ruling —useCascadingOptions.tsandLookupField.tsxare not in this diff.The rebind
The branch now calls
resolveVisibleOptionsfrom@object-ui/core— the same function the governed path reaches, since app-shell renders params through@object-ui/fields' widgets whoseuseCascadingOptionscallsresolveCascadingOptions, which delegates the filtering half to it.values, which is the [finding] 动作对话框的继承选项谓词只认外层页面的 record:自己在途的 param 值不参与,select 的 dependsOn 门根本到不了 #3765 Option B ruling (maintainer 2026-08-11, "the dialog is a small form") that app-shell implements asdependentValues={values}.usePredicateScope(),{}with no provider — the same sourcerenderers/form/form.tsxreads.dependsOngating is deliberately NOT reproduced, and that is measured rather than assumed:paramToField()copiesdepends_ononto the field only forEXPANDABLE_FIELD_TYPES(lookup / reference / user), so aselectparam reaches the governed widget carrying nodependsOnandresolveCascadingOptionsreduces to exactly this call. Gating this branch would make the two surfaces diverge, not converge.The one thing beyond option rendering, named with its evidence
A selection the predicate stops offering is now cleared, via the shared
isValueStillOffered. This is not tidying encountered in passing — filtering alone would create a state the unfiltered code could not reach: the user picks an option, changes the sibling param that gated it, the trigger falls back to its placeholder (Radix renders no label for a value with no matching item) whilevaluesstill holds the choice andhandleSubmitstill submits it. Gone from the screen, present in the payload.The shape is the governed sibling's, not a new rule:
fields/src/widgets/SelectField.tsxclears on!isValueStillOffered(value, options), andrenderers/form/form.tsx's cascade-clear effect carries the samehasOptionPredicateguard this one uses. It is confined to option lists that actually declare a predicate, so the change is inert for every param that rendered correctly before — pinned by the last test case below.Evidence
The failing test was written and measured RED first, against the real render tree (Radix listbox opened with the pointer shim, assertions on the option labels a user can see and on the trigger's read-back text), with non-vacuity controls in the same run.
Tests 3 failed | 4 passed (7)Tests 7 passed (7)action-param-dialogtest filesTest Files 5 passed (5)/Tests 23 passed (23)The three that were red are the defect cases (
visibleWhenFALSE against the dialog values; role gating from the predicate scope; a selection the predicate stopped offering). The four green-before are controls: the dialog mounts and the listbox really opens; the predicate resolves against the dialog's own values (green pre-fix, but it fails if the record were wired to a constant{}); a broken predicate fails open; an unpredicated option list is untouched.Ablation, predicted before running: reverting the implementation to
origin/mainturns exactly those three red again. MeasuredTests 3 failed | 4 passed (7), mutation confirmed on disk by marker counts in both directions (injected0/deleted1, then1/0), restored under atrap … EXIT INT TERMand verified by hash —fe5a5ad4…before and after, byte-identical.Published surface, measured not asserted. Declaration-only emit to a scratch
outDir(composite/incremental off so nothing could skip emit), fixed tree vs. the same tree reverted toorigin/main: 208.d.tsfiles each, manifest sha20136ae3…on both legs — every emitted declaration byte-for-byte identical. Nothing is added to or removed from the public API;ActionParamDialogPropsand the component's type are untouched. (Both legs exit 2 on the same single config diagnostic,TS5011aboutrootDir, provoked by the--outDiroverride and identical on both sides; the real verdict is the packagetype-checkbelow, which exits 0.)Gates run locally, all at
98b9cdectype-check(@object-ui/components,tsc --noEmit && tsc -p tsconfig.test.json) exit 0 — and--listFilesconfirms the new test file is a program input, not silently excluded.eslint .over the whole package: 392 files, 0 errors, 904 warnings (pre-existing debt).check:control-bytesOK (4724 tracked files).check:phantom-deps,check:self-import,check:action-forward-parity,check:i18n-keys,check:i18n-drift,check:spec-symbols,lint:coverage,check-changeset-no-major— all exit 0 on their own verdict lines. CI owns the rest of the farm.Disclosed rather than hidden: the new effect adds exactly one lint warning,
react-hooks/set-state-in-effect. It is non-blocking by design —eslint.config.jssets the React Compiler rule family towarn, and.github/workflows/lint.ymldeliberately sets no--max-warnings. The in-package precedent,renderers/form/form.tsx's cascade-clear, is the same effect shape and escapes the rule only because it writes through react-hook-form'ssetValuerather than a ReactsetState.Scope
One file changed plus its test and a changeset. None of the paths fenced out this round are touched.
Generated by Claude Code