Uh oh!
There was an error while loading. Please reload this page.
docs(console): fix VITE_SERVER_URL dev defaults and dev-proxy scope in READMEs - #5803
Merged
Merged
Conversation
…n READMEs PR #5765 emptied VITE_SERVER_URL in both dev env files (same-origin by default, per the 2026-08-23 ruling on #5702). Three doc-prose items had drifted from that: 1. apps/console/README.md's Quick Start and Development Mode sections still said VITE_SERVER_URL defaults to http://localhost:3000 — it now ships empty, with the Vite dev proxy (DEV_PROXY_TARGET, defaulting to http://localhost:3000) forwarding /api/* to the backend. 2. examples/console-starter/README.md's Backend table still tabulated the old non-empty .env.development/.env.production values — both now ship empty (same-origin), documented with the same DEV_PROXY_TARGET recipe. 3. apps/console/README.md claimed the dev proxy covers /api/* and /_account/* — vite.config.ts only ever proxied /api. Per triage discretion on #5766 (zero first-party producers of /_auth/ or /_account/ action targets on origin/main, and /_account is recorded as retired into the console SPA), this fixes the doc rather than widening the proxy: states /api/* only and notes /_auth/* and /_account/* are not proxied. Fixes#5766 Filed #5802 (out of scope) for the same stale-default drift in content/docs/guide/console.md, which sits outside this card's scope. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EuPCi56cnGyykygi3z9w4m
Contributor
✅ Console Performance Budget
The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it. 📦 Bundle Size Report
Size Limits
|
os-zhuang
marked this pull request as ready for review
August 23, 2026 11:58
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#5766
What changed
PR #5765 emptied
VITE_SERVER_URLin both console dev env files (same-origin by default, per the 2026-08-23 ruling on #5702). Three doc-prose items had drifted from that outcome:apps/console/README.md(Quick Start + Development Mode) — saidVITE_SERVER_URLdefaults tohttp://localhost:3000. It now ships empty; the Vite dev proxy forwards/api/*tohttp://localhost:3000by default, or toDEV_PROXY_TARGETwhen set.examples/console-starter/README.md(Backend table) — tabulated the old non-empty.env.development/.env.productionvalues. Both files ship empty (same-origin); the table and surrounding prose now say so and give the sameDEV_PROXY_TARGETrecipe.apps/console/README.mdclaimed the dev proxy covers/api/*and/_account/*.vite.config.ts(lines 709-711) only ever proxied/api. Per triage discretion on Console and console-starter READMEs state VITE_SERVER_URL dev defaults that no longer exist, and claim a /_account/* dev proxy that never existed #5766 this fixes the doc rather than widening the proxy: zero first-party producers of/_auth///_account/action targets exist onorigin/main(verified:ActionRunner.ts:1343/1362only define the regex that would route such a target; the only other hits are CHANGELOG entries, one ActionRunner test, and doc prose), andapps/console/src/App.tsx:7records/_account/*as being retired into the Console SPA. If a real producer of/_auth///_account/action targets appears, the config half (widening the proxy) reopens as its own card — not folded into this one.Verification
apps/console/README.md:35-36and:52-54(line numbers matched what the issue quoted),examples/console-starter/README.md's Backend table (lines 89-92), andapps/console/vite.config.ts:709-711(proxy config,/apionly, unchanged)..env.developmentfiles (console and console-starter) still carry theDEV_PROXY_TARGETrecipe in their comments, as triage asked.bc21c704bis present ingit log origin/main, and9850c6e4e(the commit the issue's reachability scan cites) is an ancestor oforigin/main.node scripts/check-doc-links.mjs→Links are valid across 13 scan roots.(exit 0).node scripts/check-control-bytes.mjs→OK (scanned 4827 tracked text file(s); skipped 85 binary).node scripts/check-changeset-presence.mjs→0 of them under the src/ of a package the release covers→ no changeset owed (README-only diff, not guarded source).vite.config.tsnot edited, per the card's instruction).Out of scope
Filed #5802 (unassigned):
content/docs/guide/console.md(lines 18 and 55) has the same staleVITE_SERVER_URL→http://localhost:3000default drift, but sits outside this card's two-README scope.Generated by Claude Code