test(plugin-detail): pin record:quick_actions resultDialog reaches the shared runner

[os-zhuang]

Fixes#5711

What

Test-only pin, no product change — triage graded this Task on exactly that basis.

RecordQuickActionsRenderer (record:quick_actions) never touches resultDialog itself — it resolves actions through useActionEngine, which reuses the surrounding <ActionProvider>'s ActionRunner when one is mounted and falls back to a local, unwired one otherwise. resultDialog is honoured centrally in ActionRunner.handlePostExecution: on success it suppresses the successMessage toast and awaits the registered ResultDialogHandler; with none registered it console.warns and discards the response value while still reporting success.

Nothing pinned that a handler registered on an ambient<ActionProvider> (the one RecordDetailView mounts around a record page) is actually reachable from a record:quick_actions bar mounted as its child — the shape objectstack#10681 depends on (sys_user.generate_backup_codes, a one-shot resultDialog at record:quick_actions { location: 'record_section' }).

New file: packages/plugin-detail/src/renderers/__tests__/record-quick-actions.resultDialog.test.tsx, two legs:

1. Positive — mounted under <ActionProvider onResultDialog onToast>, running the action opens the dialog with the response value and the success toast stays suppressed.
2. Negative — mounted with no <ActionProvider> (the fallback-to-local-runner shape), the response is silently discarded and the documented console.warn fires. This is the defect class the finding is about: a refactor that accidentally drops the ambient provider keeps every affected action reporting success while showing the user nothing.

Gap verification (before writing the test)

• grep -rni resultDialog packages/plugin-detail/src → 0 hits, confirming the issue's claim.
• ActionRunner.resultDialog.test.ts pins the runner in isolation with the handler registered directly — no React tree, no useActionEngine, no <ActionProvider>.
• useActionEngine.sharedRunner.test.tsx pins runner-sharing (instance identity + ctx merge) but never touches resultDialog.
• MetadataTypeActions.test.tsx has a same-named assertion ("shows the result dialog when the action declares resultDialog") but on a different bar — MetadataTypeActions mounts its own internal <ActionProvider> (like DeclaredActionsBar), so it doesn't exercise the shared-runner path record:quick_actions relies on.

None of the four exercise the actual missing link. Gap confirmed real.

Reverse verification

Committed the test first, then mutated packages/react/src/hooks/useActionEngine.ts (const sharedRunner = null;, simulating a refactor that falls back to a local runner) and reran:

FAIL record-quick-actions.resultDialog.test.tsx > opens the result dialog … 1078ms
AssertionError: expected "vi.fn()" to be called once, but got 0 times

stderr showed the exact documented warning fired instead:

[ActionRunner] action.resultDialog set but no resultDialogHandler registered — the response value will not be shown to the user. { action: 'generate_backup_codes', data: 'BACKUP-CODE-0000' }

Restored with git checkout -- packages/react/src/hooks/useActionEngine.ts (confirmed clean via git status --porcelain), reran green: Test Files 1 passed (1), Tests 2 passed (2).

Tests

At d44e205:

• pnpm exec vitest run packages/plugin-detail/src/renderers/__tests__/record-quick-actions.resultDialog.test.tsx --maxWorkers=2 → Test Files 1 passed (1), Tests 2 passed (2).
• pnpm exec vitest run packages/plugin-detail/ --maxWorkers=2 (full package, dependency closure built first) → Test Files 95 passed (95), Tests 870 passed (870).
• pnpm --filter @object-ui/plugin-detail type-check → exit 0.
• pnpm exec eslint packages/plugin-detail/src/renderers/__tests__/record-quick-actions.resultDialog.test.tsx --no-inline-config → 0 errors, 2 no-explicit-any warnings (identical pattern to the sibling record-quick-actions.disabled-declared-gate.test.tsx, same schema-cast convention).
• node scripts/check-changeset-presence.mjs → ✅ (empty-frontmatter changeset declared).
• node scripts/check-changeset-no-major.mjs → ✅.
• node scripts/check-control-bytes.mjs → ✅ (4828 tracked text files scanned).

Out of scope

record:alert's CTA path shares the exact same wiring (useActionEngine under the same ambient <ActionProvider>) and has no resultDialog coverage either — the issue itself flagged this as worth checking. Filed as a separate unassigned finding rather than folded into this PR (different renderer, different test file, and this card's scope is record:quick_actions only).

Generated by Claude Code

---

Generated by Claude Code

[github-actions]

✅ Console Performance Budget

Metric	Value	Budget
Eager closure (gzip, 52 chunks)	3226.7 KB	3990.2 KB
Main entry chunk (gzip)	152.7 KB	350 KB
Entry file	index-BhdQ3qDN.js	—
Status	PASS	—

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.

---

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (consoleActionDispatch.js)	0.20KB	0.19KB
app-shell (index.js)	10.04KB	3.72KB
app-shell (runtime-config.js)	12.80KB	4.47KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	10.06KB	3.86KB
auth (ActiveOrganizationStorage.js)	25.05KB	9.16KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	2.07KB	1.00KB
auth (AuthProvider.js)	37.99KB	9.84KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	12.21KB	3.45KB
auth (LoginForm.js)	18.15KB	5.39KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.65KB	2.22KB
auth (SocialSignInButtons.js)	9.61KB	3.89KB
auth (UserMenu.js)	3.41KB	1.23KB
auth (auth-gate-events.js)	1.29KB	0.66KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	40.21KB	10.80KB
auth (createAuthenticatedFetch.js)	8.46KB	3.43KB
auth (index.js)	3.19KB	1.44KB
auth (invitation-status.js)	1.22KB	0.70KB
auth (org-roles.js)	6.66KB	2.78KB
auth (phone-identifier.js)	1.11KB	0.66KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	5.30KB	1.02KB
auth (useWorkspaceAdminStatus.js)	5.13KB	2.35KB
collaboration (CommentThread.js)	26.08KB	7.56KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	6.49KB	2.64KB
collaboration (PresenceProvider.js)	2.79KB	1.13KB
collaboration (index.js)	1.68KB	0.73KB
collaboration (useCollaborationTranslation.js)	6.05KB	2.52KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	503.96KB	113.94KB
core (index.js)	4.92KB	1.97KB
create-plugin (index.js)	10.08KB	3.26KB
data-objectstack (index.js)	164.55KB	45.67KB
fields (index.js)	238.40KB	59.89KB
i18n (LocalizationContext.js)	1.76KB	0.96KB
i18n (currency.js)	1.22KB	0.64KB
i18n (i18n.js)	4.28KB	1.75KB
i18n (index.js)	3.44KB	1.39KB
i18n (pickLocalized.js)	7.62KB	3.26KB
i18n (provider.js)	23.13KB	7.63KB
i18n (useDisplayLocale.js)	2.85KB	1.45KB
i18n (useObjectLabel.js)	33.40KB	8.71KB
i18n (useSafeTranslation.js)	7.77KB	3.13KB
layout (index.js)	38.95KB	10.97KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.75KB
mobile (index.js)	1.55KB	0.62KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	6.96KB	1.98KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.72KB	0.42KB
mobile (useResponsiveConfig.js)	1.37KB	0.63KB
mobile (useSpecGesture.js)	4.32KB	1.64KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	9.53KB	3.38KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	4.64KB	1.50KB
permissions (evaluator.js)	5.12KB	1.74KB
permissions (index.js)	0.93KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.53KB
permissions (usePermissions.js)	1.93KB	0.88KB
plugin-ai (index.js)	15.75KB	3.80KB
plugin-calendar (index.js)	46.62KB	12.83KB
plugin-charts (index.js)	64.66KB	18.32KB
plugin-chatbot (index.js)	186.10KB	44.03KB
plugin-dashboard (index.js)	128.41KB	32.95KB
plugin-designer (index.js)	212.30KB	42.80KB
plugin-detail (index.js)	242.34KB	60.99KB
plugin-editor (index.js)	2.46KB	1.10KB
plugin-form (index.js)	125.63KB	30.64KB
plugin-gantt (index.js)	164.10KB	39.87KB
plugin-grid (index.js)	200.79KB	54.26KB
plugin-kanban (index.js)	52.93KB	14.60KB
plugin-list (index.js)	111.80KB	27.20KB
plugin-map (index.js)	20.06KB	6.62KB
plugin-markdown (index.js)	13.72KB	4.69KB
plugin-report (index.js)	43.49KB	11.93KB
plugin-timeline (index.js)	26.49KB	7.59KB
plugin-tree (index.js)	8.50KB	2.88KB
plugin-view (index.js)	84.61KB	20.74KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.90KB	0.85KB
providers (UploadProvider.js)	11.66KB	3.50KB
providers (index.js)	0.45KB	0.23KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	5.62KB	2.34KB
react (LazyPluginLoader.js)	3.77KB	1.33KB
react (SchemaRenderer.js)	44.39KB	14.99KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	1.33KB	0.69KB
react (schema-input.js)	2.32KB	1.24KB
react (spec-input.js)	0.20KB	0.18KB
sdui-parser (codegen.js)	5.41KB	2.34KB
sdui-parser (dashboard-widget-options.js)	3.08KB	1.30KB
sdui-parser (index.js)	4.93KB	2.24KB
sdui-parser (input-type.js)	2.84KB	1.40KB
sdui-parser (parse.js)	12.13KB	3.65KB
sdui-parser (provenance.js)	3.66KB	1.82KB
sdui-parser (types.js)	0.28KB	0.23KB
sdui-parser (validate.js)	7.54KB	2.63KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	0.99KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	0.20KB	0.18KB
types (crud.js)	0.20KB	0.18KB
types (dashboard-filter-alias.js)	6.23KB	2.74KB
types (data-display.js)	0.20KB	0.18KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	1.87KB	0.85KB
types (disclosure.js)	0.20KB	0.18KB
types (error-code.js)	1.54KB	0.88KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (http-inflight.js)	8.87KB	3.73KB
types (http-retry.js)	4.32KB	2.02KB
types (index.js)	3.88KB	1.85KB
types (layout.js)	0.20KB	0.18KB
types (managed-by.js)	0.19KB	0.18KB
types (mobile.js)	2.59KB	1.31KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (record-semantics.js)	1.28KB	0.67KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (spec-report.js)	5.05KB	1.93KB
types (spec-ui-namespace.js)	0.20KB	0.19KB
types (system-fields.js)	3.33KB	1.54KB
types (theme.js)	3.40KB	1.68KB
types (ui-action.js)	3.40KB	1.71KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

• ✅ Core packages should be < 50KB gzipped
• ✅ Component packages should be < 100KB gzipped
• ⚠️ Plugin packages should be < 150KB gzipped