Uh oh!
There was an error while loading. Please reload this page.
docs(console): correct the VITE_SERVER_URL dev default to empty/same-origin - #5910
Merged
Merged
Conversation
…origin `apps/console/.env.development` ships `VITE_SERVER_URL` empty (same origin); the Vite dev server proxies `/api/*` to `DEV_PROXY_TARGET`, falling back to `http://localhost:3000`. The guide still described the old non-empty default in two places and recommended an inline absolute value in a third, which is the setting that opts dev out of same-origin auth. Matches the wording already landed in `apps/console/README.md` and `examples/console-starter/README.md`. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EuPCi56cnGyykygi3z9w4m
os-zhuang
marked this pull request as ready for review
August 23, 2026 20:19
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#5802
content/docs/guide/console.mdstill described the pre-#5765 world: a non-emptyVITE_SERVER_URLdev default. PR #5765 emptied it, and #5766 already landed thematching correction in
apps/console/README.mdandexamples/console-starter/README.md.This PR brings the guide in line with those two files rather than inventing a third
phrasing.
The measured reality (not the card's memory)
apps/console/vite.config.tsline 710, read on this branch:That is the only proxy entry —
/apiand nothing else — and the fallback targetreally is
http://localhost:3000.apps/console/.env.developmentshipsVITE_SERVER_URL=(empty), and its own header comment states why: a non-empty valuemakes every relative-target
type: 'api'action resolve cross-origin, and the actionruntime does not attach
Authorization/X-Tenant-ID/Accept-Languageto across-origin fetch — a 401 on the standard
pnpm devstack.Before / after
1. Quick Start (line 18)
2. Configuration, input 1 (lines 62-63)
3. Running with a Real Backend, step 1 (lines 81-85) — bounded in-place correction,
called out explicitly
The card named two passages. A third one in the same file, same defect class, told the
reader to run
VITE_SERVER_URL=http://localhost:3000 pnpm dev— precisely the settingthat opts dev out of same-origin and into the 401 documented above. Leaving it would have
shipped a corrected page that still steers readers into the trap #5765 removed. The
corrected form is pinned by existing evidence (the
.env.developmentheader comment andthe two READMEs #5766 brought up to date), so it is mechanical, not a judgement call:
Verification
Docs-only diff, one file. No ablation is available for a docs-only change and none was
staged — the substitute evidence is that the new claim is true, shown by reading the
config above.
Gate union re-run after the final commit, at
3bd142415:check-doc-links.mjsLinks are valid across 13 scan roots.check-doc-component-types.mjs✅ Every documented component type is registered.check-doc-snippet-types.mjsEvery covered documentation snippet compiles against the built types.check-changeset-presence.mjs✅ No source of a released package changed in this range, so no changeset is owed.check-changeset-no-major.mjs✅ No changeset declares a major bump.check-control-bytes.mjs✅ check-control-bytes: OK (scanned 4916 tracked text file(s); skipped 85 binary).Exit codes were captured into a variable before any pipe (
cmd > log 2>&1; E=$?).On the snippet gate: its first run reported "The snippet program was NOT run: the
packages it resolves against are not built" — a precondition, not a verdict. The closure
was built with the gate's own
--build-filter(plus the...dependency-closure suffix,without which
@object-ui/reactfails on an unbuilt@object-ui/i18n) and the gate wasre-run for the real judgement above. Its harness controls passed: resolution to
packages/types/dist/index.d.ts, sentinel produced TS2305, positive produced 0. This pageis not in the gate's
UNGATED_DOCSdebt list, and it holds onlybashfences — 0ts/tsx blocks — so it contributes nothing to the 101 compiled blocks either way.
Lint narrowing, declared with its three pieces of evidence:
eslint --no-inline-configon thechanged file returns
File ignored because no matching configuration was supplied.—every config block in
eslint.config.jstargets**/*.{ts,tsx}or narrower, somarkdown is outside the linted population entirely.
--format json: 1 file result, 0 errors, 1 warning, and that singlewarning is the "no matching configuration" notice rather than a rule finding.
grepforprojectService/parserOptions/project:/tsconfigRootDir/recommendedTypeCheckedineslint.config.jsreturns no matches —this repo configures no type-aware linting, so a one-file markdown diff cannot move the
verdict on any untouched file.
The changed file was also self-scanned for raw control bytes
(
grep -naP '[\x00-\x08\x0b\x0c\x0e-\x1f\x7f]'): none.Scope
content/docs/guide/console.mdonly..env.development,apps/console/vite.config.tsand the two READMEs #5766 brought up to date were read but not modified. No changeset —
the presence gate prints that none is owed for this range.
Generated by Claude Code