Uh oh!
There was an error while loading. Please reload this page.
docs(components): cover packages/components/README.md with the doc-snippet type gate - #6202
Merged
Merged
Conversation
Declares the router-layout excerpt as a fragment (`Outlet` is react-router's, supplied by the host) and deletes the document's UNGATED_DOCS ledger entry, so every ts/tsx block in this published README is compiled against the built types from now on. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019b5UBNMtTzKbVtZZGvFuxe
Contributor
✅ Console Performance Budget
The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it. 📦 Bundle Size Report
Size Limits
|
yinlianghui-tw
marked this pull request as ready for review
August 25, 2026 01:29
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Aug 25, 2026
yinlianghui-tw pushed a commit
that referenced
this pull request
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#5259
Implements the 2026-08-19 maintainer ruling (「全部接受」, Option A): declare the one remaining fragment, delete the
UNGATED_DOCSledger entry, and accept the filter growth.packages/components/README.md— a README that ships to npm — moves from unverified to permanently gated.What changed
packages/components/README.md: the router-layout excerpt at the notification-surfaces section carries the documented fragment marker.Outletis react-router's, supplied by the host application — precisely the casescripts/check-doc-snippet-types.mjsnames in its own header ("a call into the host's own router"). The marker spelling was taken verbatim fromFRAGMENT_MARKER_EXAMPLESin the gate's source, not from the card (the card's body shows an empty fence there — GitHub's sanitizer ate it).scripts/check-doc-snippet-types.mjs: thepackages/components/README.mdentry is deleted fromUNGATED_DOCS. No other ledger entry and no gate logic touched.Premise re-derivation — confirmed, with one correction to the cost figure
The card's "1 diagnostic" figure is from 2026-08-18. Re-derived on today's
main(e9e55524e), it is exactly right, same code and same line:Nothing else. No further host fragments, no real defects, nothing needing classification.
The build-filter figure, however, is stale — and the correction runs in the cheap direction. The card priced this at 11 -> 15 packages. On today's
mainthe filter is already 20 packages, and it already contains@object-ui/componentsand@object-ui/i18n, put there by documents covered in the seven days since. So the measured delta of this PR is:Both lists are byte-identical:
The reason is mechanical, not a measurement artifact: this README imports only
@object-ui/components,@object-ui/reactand@object-ui/core, and all three are already in the filter.@object-ui/react-runtimeand@object-ui/sdui-parserare absent from the emitted filter both before and after — they are transitive dependencies turbo pulls in topologically, not packages the gate emits. The ruled cost was +4; the realised cost is 0, so this lands strictly inside what the ruling priced.Coverage is real, not cosmetic — the non-vacuity control
A zero filter delta is exactly the signature the dispatch order warns about ("a silent no-op wearing a green tick"), so coverage was proven directly instead of inferred from the filter. A fabricated export was injected into a different
tsxblock of this README — theregisterDefaultRenderers-shaped fabrication the card names by name — and the gate went red on it:Mutation and restore were both proven on disk by anchored counts, never by an editor's exit code; the restore leg left
git diff HEADempty. That block was unverified before this PR and is verified after it, which is the whole value of the change.Verification at
a74f8d748check:doc-snippets255 of 255 block(s) judged, 0 failed; controls (resolution / sentinel / positive / undeclared) all greencheck:doc-fencescheck:doc-typescheck:control-bytescheck-changeset-presence.mjsvitest run scripts/__tests__/check-doc-snippet-types.test.tsLedger accounting moved as expected: covered blocks
367 — 255 to compile, 112 declared fragment(s)(was256 to compile, 111 declared fragment(s)). Build was the gate's own derived filter,turbo run build $(node scripts/check-doc-snippet-types.mjs --build-filter) --concurrency=2, exit 0.No changeset: the repo's own presence gate reports none owed, and the README edit is an HTML comment that no reader or renderer sees.
Generated by Claude Code