Skip to content

refactor(app-shell): delete the dead metadataConverters module#6265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yinlianghui merged 2 commits into from
Aug 25, 2026
Merged

refactor(app-shell): delete the dead metadataConverters module #6265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eaf4029
refactor(app-shell): delete dead metadataConverters module
claude Aug 25, 2026
4473c31
chore: add changeset for the metadataConverters deletion
claude Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .changeset/dead-metadata-converters-6224.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
---
'@object-ui/app-shell': patch
---

Delete the dead `src/utils/metadataConverters.ts` module. It had zero importers, was not
re-exported from the package barrel, and no `exports` subpath reached it — `toObjectDefinition`,
`toFieldDefinition`, `MetadataObject` and `MetadataField` were never part of the published
surface, so nothing external can break. The module was removed rather than left alone because it
carried two patterns the live code no longer uses: a name-heuristic `isSystem` (the server's real
`system` flag is the source of truth) and a three-way `referenceTo` tolerance for a target the
spec spells `reference`. A dead copy that disagrees with the live one is what a future author
copies from.
139 changes: 0 additions & 139 deletions packages/app-shell/src/utils/metadataConverters.ts
View file
Open in desktop

This file was deleted.

Loading