Skip to content

fix(app-shell): correct two PALETTE_EXCLUSIONS reasons that claimed "no renderer" - #6283

Merged
os-litant merged 2 commits into
mainfrom
claude/issue-6071-palette-exclusion-reasons
Aug 25, 2026
Merged

fix(app-shell): correct two PALETTE_EXCLUSIONS reasons that claimed "no renderer"#6283
os-litant merged 2 commits into
mainfrom
claude/issue-6071-palette-exclusion-reasons

Conversation

@os-litant

Copy link
Copy Markdown
Collaborator

Fixes#6071

What changed

PALETTE_EXCLUSIONS in the Studio page-palette ledger opened two entries with "no renderer" for element:text_input and element:record_picker. Both types do have a registered renderer under namespace: 'element' (components/renderers/basic/text-input.tsx:161, components/renderers/basic/record-picker.tsx:303), so the leading clause was simply false.

The exclusions themselves are unchanged. They are still the right decisions and still stand. Only the false leading clause moved; the substantive half — record picking is a field widget / bare inputs belong to a form — was correct all along and is kept verbatim. The new wording says why they are excluded truthfully: they render, they are just not page content.

Why a false reason string is worth a PR

This ledger was made explicit (#2943) so a palette decision is recorded where the next reader finds it, and it is read as the decision record. #5837 had to re-derive registration state from source precisely because the stated reason could not be trusted. core/src/registry/public-blocks.ts already words these same two exclusions without any renderer claim, so the ledger was also internally inconsistent.

block-config.test.ts enforced that every exclusion carries a reason (reason.length > 10). Nothing enforced that the reason is true.

The pin, and why it is shaped this way

exclusion-reason-truthfulness.test.ts pins the class, not the two strings: an exclusion whose reason claims "no renderer" must not have one. The class assertion is the cheap thing to get wrong, so it carries three explicit guards:

  1. Degenerate registry. If the renderer packages were never imported, ComponentRegistry.get(...) is undefined for everything and the negative assertion holds vacuously — a green that measures nothing. Each side-effect import therefore carries a positive probe proving that package's registrations actually ran.
  2. Vacuous loop. If every reason were reworded away from the claim, the loop would iterate over nothing and stay green while the guard silently stopped guarding. A dedicated assertion fails in that case.
  3. Bounded scope. A renderer registered in a package not imported here would read as unregistered and let a false "no renderer" pass. The import set is documented in the file header, with the instruction to widen it — and its positive probes — when a new package starts registering page blocks.

A fourth assertion pins the opposite direction: the two corrected entries do have renderers, so if a later change unregistered them their new wording would become false the other way.

Release impact

None. The changeset carries empty frontmatter — the repo's "releases nothing" declaration. The reason strings are developer-facing ledger prose read by no runtime code path, and no exclusion decision moved.

Provenance

⚠️ This PR was opened by the incomingdomain:ui seat PM (session_01Mn4BZ5AVDM81pvfij1WwM9), not by the agent that wrote the branch. The two commits were pushed by a dev under the previous seat, whose session ended before the PR was opened; the seat changed hands on a maintainer forced-handover. The dispatch ruling that authorised this shape, and the dev's report, are posted on #6071 alongside this PR — they had until now existed only inside the previous session.

🤖 Generated with Claude Code


Generated by Claude Code

…no renderer"
`element:text_input` and `element:record_picker` are registered renderers
(`namespace: 'element'`), so the leading "no renderer" clause in their exclusion
reasons was false. The exclusions themselves are decisions and are unchanged;
only the stated rationale moves to the true one, which the substantive half of
each string already carried.
Adds `exclusion-reason-truthfulness.test.ts`, which pins the class: any
exclusion whose reason claims "no renderer" must not have a registered one.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CSoz9uGhaaSgiq3hshtN7L
…releasing nothing
The reason strings are developer-facing ledger prose read by no runtime code
path, so this declares an empty frontmatter — the exemption
check-changeset-presence names explicitly, not a workaround.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CSoz9uGhaaSgiq3hshtN7L
@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

MetricValueBudget
Eager closure (gzip, 52 chunks)3222.7 KB3266.6 KB
Main entry chunk (gzip)154.1 KB350 KB
Entry fileindex-BiWtLRaE.js
StatusPASS

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

PackageSizeGzipped
app-shell (consoleActionDispatch.js)0.20KB0.19KB
app-shell (index.js)10.96KB4.16KB
app-shell (runtime-config.js)18.10KB6.51KB
app-shell (types.js)0.01KB0.04KB
app-shell (urlParams.js)10.06KB3.86KB
auth (ActiveOrganizationStorage.js)25.05KB9.16KB
auth (AuthContext.js)0.31KB0.24KB
auth (AuthGuard.js)2.07KB1.00KB
auth (AuthProvider.js)40.18KB10.59KB
auth (AuthShell.js)3.49KB1.40KB
auth (ForgotPasswordForm.js)12.21KB3.45KB
auth (LoginForm.js)18.15KB5.39KB
auth (PreviewBanner.js)0.90KB0.50KB
auth (RegisterForm.js)6.65KB2.22KB
auth (SocialSignInButtons.js)9.61KB3.89KB
auth (UserMenu.js)3.41KB1.23KB
auth (auth-gate-events.js)1.29KB0.66KB
auth (authStyles.js)5.04KB1.72KB
auth (createAuthClient.js)40.21KB10.80KB
auth (createAuthenticatedFetch.js)8.46KB3.43KB
auth (index.js)3.19KB1.44KB
auth (invitation-status.js)1.22KB0.70KB
auth (org-roles.js)6.66KB2.78KB
auth (phone-identifier.js)1.11KB0.66KB
auth (types.js)0.59KB0.35KB
auth (useAuth.js)5.30KB1.02KB
auth (useWorkspaceAdminStatus.js)5.13KB2.35KB
collaboration (CommentThread.js)26.08KB7.56KB
collaboration (LiveCursors.js)3.17KB1.27KB
collaboration (PresenceAvatars.js)6.49KB2.64KB
collaboration (PresenceProvider.js)2.79KB1.13KB
collaboration (index.js)1.68KB0.73KB
collaboration (useCollaborationTranslation.js)6.05KB2.52KB
collaboration (useCommentSearch.js)1.98KB0.88KB
collaboration (useConflictResolution.js)7.75KB1.86KB
collaboration (useMentionNotifications.js)1.81KB0.68KB
collaboration (usePresence.js)6.33KB1.84KB
collaboration (useRealtimeSubscription.js)7.91KB2.01KB
components (index.js)505.63KB114.68KB
core (index.js)5.30KB2.13KB
create-plugin (index.js)10.08KB3.26KB
data-objectstack (index.js)171.74KB47.48KB
fields (index.js)238.40KB59.89KB
i18n (LocalizationContext.js)1.76KB0.96KB
i18n (currency.js)1.22KB0.64KB
i18n (fallbackInterpolation.js)6.25KB2.77KB
i18n (i18n.js)4.28KB1.75KB
i18n (index.js)3.44KB1.39KB
i18n (pickLocalized.js)7.62KB3.26KB
i18n (provider.js)26.89KB9.04KB
i18n (useDisplayLocale.js)2.85KB1.45KB
i18n (useObjectLabel.js)33.40KB8.71KB
i18n (useSafeTranslation.js)5.60KB2.33KB
layout (index.js)38.95KB10.97KB
mobile (MobileProvider.js)0.92KB0.49KB
mobile (ResponsiveContainer.js)0.94KB0.38KB
mobile (breakpoints.js)1.51KB0.70KB
mobile (createOfflineDataSource.js)5.61KB1.75KB
mobile (index.js)1.55KB0.62KB
mobile (offlineQueue.js)3.91KB1.35KB
mobile (pwa.js)0.97KB0.49KB
mobile (serviceWorker.js)1.48KB0.62KB
mobile (serviceWorkerSource.js)3.41KB1.48KB
mobile (useBreakpoint.js)1.54KB0.65KB
mobile (useGesture.js)6.96KB1.98KB
mobile (useOfflineSync.js)1.99KB0.72KB
mobile (usePullToRefresh.js)2.53KB0.85KB
mobile (useResponsive.js)0.72KB0.42KB
mobile (useResponsiveConfig.js)1.37KB0.63KB
mobile (useSpecGesture.js)4.32KB1.64KB
mobile (useTouchTarget.js)1.01KB0.54KB
permissions (MePermissionsProvider.js)9.53KB3.38KB
permissions (PermissionContext.js)0.31KB0.25KB
permissions (PermissionGuard.js)0.89KB0.45KB
permissions (PermissionProvider.js)4.64KB1.50KB
permissions (evaluator.js)5.12KB1.74KB
permissions (index.js)0.93KB0.41KB
permissions (store.js)0.91KB0.42KB
permissions (useFieldPermissions.js)1.28KB0.53KB
permissions (usePermissions.js)1.93KB0.88KB
plugin-ai (index.js)15.75KB3.80KB
plugin-calendar (index.js)46.62KB12.83KB
plugin-charts (index.js)64.66KB18.32KB
plugin-chatbot (index.js)188.21KB44.67KB
plugin-dashboard (index.js)133.35KB34.45KB
plugin-designer (index.js)212.33KB42.81KB
plugin-detail (index.js)244.74KB62.20KB
plugin-editor (index.js)2.46KB1.10KB
plugin-form (index.js)126.42KB30.80KB
plugin-gantt (index.js)164.17KB39.89KB
plugin-grid (index.js)201.14KB54.40KB
plugin-kanban (index.js)52.83KB14.55KB
plugin-list (index.js)111.94KB27.24KB
plugin-map (index.js)20.09KB6.62KB
plugin-markdown (index.js)13.72KB4.69KB
plugin-report (index.js)43.49KB11.93KB
plugin-timeline (index.js)26.49KB7.59KB
plugin-tree (index.js)9.26KB3.13KB
plugin-view (index.js)84.55KB20.74KB
providers (DataSourceProvider.js)0.75KB0.39KB
providers (MetadataProvider.js)1.37KB0.59KB
providers (ThemeProvider.js)1.90KB0.85KB
providers (UploadProvider.js)11.66KB3.50KB
providers (index.js)0.45KB0.23KB
providers (types.js)0.01KB0.04KB
react-runtime (index.js)5.62KB2.34KB
react (LazyPluginLoader.js)4.47KB1.63KB
react (SchemaRenderer.js)54.84KB18.43KB
react (data-invalidation.js)5.05KB2.08KB
react (index.js)1.35KB0.70KB
react (schema-input.js)2.32KB1.24KB
react (spec-input.js)0.20KB0.18KB
sdui-parser (codegen.js)5.41KB2.34KB
sdui-parser (dashboard-widget-options.js)3.08KB1.30KB
sdui-parser (index.js)4.93KB2.24KB
sdui-parser (input-type.js)2.84KB1.40KB
sdui-parser (parse.js)12.13KB3.65KB
sdui-parser (provenance.js)3.66KB1.82KB
sdui-parser (types.js)0.28KB0.23KB
sdui-parser (validate.js)7.54KB2.63KB
types (ai.js)0.20KB0.17KB
types (api-types.js)0.20KB0.18KB
types (app.js)2.87KB0.99KB
types (base.js)0.20KB0.18KB
types (blocks.js)0.20KB0.18KB
types (complex.js)2.74KB1.41KB
types (crud.js)0.20KB0.18KB
types (dashboard-filter-alias.js)6.23KB2.74KB
types (data-display.js)0.20KB0.18KB
types (data-protocol.js)0.20KB0.19KB
types (data.js)0.20KB0.18KB
types (designer.js)1.87KB0.85KB
types (disclosure.js)0.20KB0.18KB
types (error-code.js)1.54KB0.88KB
types (feedback.js)0.20KB0.18KB
types (field-types.js)0.20KB0.18KB
types (form.js)0.20KB0.18KB
types (http-inflight.js)8.87KB3.73KB
types (http-retry.js)4.32KB2.02KB
types (icon-key-migration.js)4.26KB1.63KB
types (index.js)4.49KB2.14KB
types (layout.js)0.20KB0.18KB
types (managed-by.js)0.19KB0.18KB
types (mobile.js)2.59KB1.31KB
types (navigation.js)0.20KB0.18KB
types (objectql.js)0.20KB0.18KB
types (overlay.js)0.20KB0.18KB
types (permissions.js)0.20KB0.18KB
types (plugin-scope.js)0.20KB0.18KB
types (record-components.js)0.20KB0.19KB
types (record-semantics.js)1.28KB0.67KB
types (registry.js)0.20KB0.18KB
types (reports.js)0.20KB0.18KB
types (spec-report.js)5.05KB1.93KB
types (spec-ui-namespace.js)0.20KB0.19KB
types (system-fields.js)3.33KB1.54KB
types (theme.js)6.28KB2.87KB
types (ui-action.js)3.40KB1.71KB
types (views.js)0.20KB0.18KB
types (widget.js)0.20KB0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-litant
os-litant marked this pull request as ready for review August 25, 2026 09:38
@os-litant
os-litant added this pull request to the merge queueAug 25, 2026
Merged via the queue into main with commit b3a3929Aug 25, 2026
28 checks passed
@os-litant
os-litant deleted the claude/issue-6071-palette-exclusion-reasons branch August 25, 2026 09:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PALETTE_EXCLUSIONS reasons say "no renderer" for two block types that do have registered renderers

2 participants

@os-litant@claude