Skip to content

fix(console): honour each row's own hidden: true in the approvals queue and its amount sort#6364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-support-ai merged 2 commits into from
Aug 25, 2026
Merged

fix(console): honour each row's own hidden: true in the approvals queue and its amount sort #6364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5f8ee4
fix(console): honour each row's own `hidden: true` in the approvals q…
claude Aug 25, 2026
ff0457c
chore(changeset): declare the approvals queue hidden-amount fix
claude Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .changeset/approvals-queue-hidden-amount-6020.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
---
"@object-ui/console": patch
---

Approvals inbox: the queue rows and the amount sort now honour each request
object's own `hidden: true` field declaration (objectui#6020).

The `hidden: true` trim added for the drawer summary card reached only the
drawer — the desktop queue row, the mobile card and the amount comparator
still read the field, so an amount an app author declared hidden rendered
inline in the queue and ordered the list, which leaked its relative magnitude
even to a viewer who never saw the figure.

The queue spans many objects, so the trim is a per-object lookup and every row
is answered about its own object; a row left with no renderable amount now
sorts with the other amount-less rows. `hidden` stays a UI contract
(objectstack#10749) and the filter still fails open: an unanswered or failed
metadata read renders today's figure.
Loading
Loading