fix(plugin-report): register under the namespace its consumers declare by claude[bot] · Pull Request #6441 · objectstack-ai/objectui

claude · 2026-08-26T00:43:53Z

Step zero: the measurement that chose the direction

The card was filed undecided between A (move the package to plugin-report) and B (move the console and the CLI whitelist to report). The charter made A conditional on nothing in the wild authoring the report:* spellings. Measured:

$ grep -rn --exclude-dir=node_modules --exclude-dir=.git \
-E "report:(report|spec-report|report-viewer)" .
packages/cli/src/utils/known-schema-types.ts:345: 'plugin-report:report'
packages/cli/src/utils/known-schema-types.ts:346: 'plugin-report:report-viewer'
packages/cli/src/utils/known-schema-types.ts:347: 'plugin-report:spec-report'
packages/cli/src/utils/known-schema-types.ts:468: 'report:report'
packages/cli/src/utils/known-schema-types.ts:469: 'report:report-viewer'
packages/cli/src/utils/known-schema-types.ts:470: 'report:spec-report'

6 hits, all inside the generated CLI whitelist itself - 0 in authored metadata. The same grep over the sibling objectstack checkout (examples, apps, stored fixtures, docs): 0. By contrast the bare spellings (type: 'report', type: 'spec-report', type: 'report-viewer') are authored in 48 places, including plugin-dashboard's ObjectMetricWidget / DrillDownDrawer and plugin-report's own ReportRenderer. Direction A is chartered: retire the spellings nobody writes, keep the ones everybody writes.

The whitelist is generated (scripts/regenerate-known-schema-types.mjs), so lines 345-347 and 468-470 are not two hand-typed lists - they are the honest union of two disagreeing registration sites. That is the defect, stated by the generator.

What changed

packages/plugin-report/src/index.tsx registers report, spec-report and report-viewer under plugin-report instead of report. packages/cli/src/utils/known-schema-types.ts is regenerated, which drops exactly the three unsatisfiable keys:

- 'report:report',
- 'report:report-viewer',
- 'report:spec-report',

apps/console/src/register-plugins.ts needs no change - it already declared plugin-report, and that is the half this PR makes true rather than aspirational.

Why the bare keys do NOT take `skipFallback`

The card asked for the objectui#6353 skipFallback treatment on the bare report key in either direction. Applying the flag here would be wrong, and the repo's own derivation says why. A census of every registration site (via deriveRegistryKeys, the derivation that feeds the whitelist) shows the bare key has exactly two claimants:

report <- apps/console/src/register-plugins.ts:135 , packages/plugin-report/src/index.tsx:41

That is not two competing components - it is the console's lazy stub and the eager registration it loads, which is the shape of all 27 other console-stub/plugin pairs in this repo (calendar, kanban, gantt, map, markdown, ...). The objectui#6353 case was different: two distinct renderers (view:timeline and plugin-timeline:timeline) fighting over one bare key, where suppressing the loser is exactly right.

Once the namespaces agree, both claimants name the same full type, so register() clears the stub it replaces and the bare key has one owner by construction. Putting skipFallback: true on either claimant would strand bare report - the only spelling anything authors - and would drop it from the generated whitelist. So this PR gets the guarantee#6353 landed (ownership decided by declaration, not by evaluation order or load phase) from namespace unification, and pins it with the equivalent replay rather than with a flag that has no correct target here. The reasoning is written into src/index.tsx beside the registrations so the next reader does not re-litigate it.

The two pins

packages/plugin-report/src/__tests__/report-bare-key-ownership.test.ts - the #6353 equivalent. It reads this package's real declared metadata back out of the registry (no hand-copied mirror), replays it into a fresh Registry alongside a console-shaped lazy stub in both registration orders, and checks the bare key's declared namespace after every step - so a disagreement reddens mid-sequence even though each step on its own succeeds. It also pins consequence 2 directly: after the module registers, hasLazy(short, 'plugin-report') must be false rather than pending forever.

The metadata lookup deliberately does not pass the namespace under test. An earlier revision used getConfig(short, NS), which selects for the very value the per-step assertion then checks - the assertion could never have failed. Fixed in d46f6c9e2 and demonstrated below.

scripts/__tests__/report-namespace-agreement-6416.test.ts - the cross-site half, extractive from deriveRegistryKeys so nothing in it can drift: each short name must have exactly one namespaced spelling, plugin-report:{short} must be claimed by both the console site and the plugin site (before this PR the console claimed it alone - declared renderable, satisfied by nothing), and no report:* key may survive.

Ghost-assertion evidence

Both mutations restore by comparing the HEAD blob hash, not an exit code, and both restore legs are verified with git diff HEAD empty. Mutation scripts carry trap ... EXIT INT TERM. No rebuild step is involved: vitest.config.mts aliases @object-ui/* to packages/*/src, and the pin imports ../index relatively, so the tests read source directly rather than dist/.

Reproduce, on unmodified main @ 7d2a68941 - predicted red, observed red (16/16):

AssertionError: "report" must be registered as "plugin-report:report" and nothing else ...:
expected [ 'report:report' ] to deeply equal [ 'plugin-report:report' ]
AssertionError: nothing is registered as "plugin-report:report": expected undefined to be defined

Mutation A - revert the namespace to report. Predicted red on both pins; observed 23 failed | 5 passed. The load-bearing part is that the replay's per-step assertion fired 6 times (3 short names x 2 orders), not just the top-level spelling check:

MUTATION ON DISK: plugin-report spelling 3 -> 0; report spelling -> 3
AssertionError: after the "eager" step in order [eager, stub], bare "report" declares a
different namespace than the step before it - the bare key is double-claimed again (#6416):
expected 'report' to be 'plugin-report'
AssertionError: "plugin-report:report" is still a pending lazy stub after the module
registered - the registration is landing under a different full type (#6416)
RESTORE VERIFIED: git diff HEAD is empty for packages/plugin-report/src/index.tsx

Mutation C - mutate only apps/console's three stubs. Predicted: cross-site pin red, package pin green (it deliberately does not read the console - that is the seam between the two files). Observed exactly that:

MUTATION ON DISK: console plugin-report stubs 2 -> 0; report spelling -> 2
scripts/__tests__/report-namespace-agreement-6416.test.ts (12 tests | 7 failed)
Test Files 1 failed | 1 passed (2)
RESTORE VERIFIED: git diff HEAD empty for apps/console/src/register-plugins.ts

Verification, on the final commit `d46f6c9e2`

Green, quoting each gate's own verdict line:

pnpm exec vitest run packages/plugin-report/ scripts/__tests__/report-namespace-agreement-6416.test.ts scripts/__tests__/known-schema-types-derivation-5115.test.ts scripts/__tests__/check-doc-component-types.test.ts - Test Files 18 passed (18) - Tests 248 passed (248)
pnpm check:doc-types - Every documented component type is registered. (656 derived keys; this is the gate a registration change moves, and it confirms no doc snippet authored a retired key)
node scripts/regenerate-known-schema-types.mjs --check - OK ... matches the registry derivation.
pnpm --filter @object-ui/plugin-report --filter @object-ui/cli run type-check - both Done. Both new test files are confirmed in their type-check programs (tsc --listFiles | grep -c = 1 each), so the green actually covers them.
pnpm --filter @object-ui/plugin-report --filter @object-ui/cli run lint - both Done, 0 errors (pre-existing warnings only)
pnpm type-check:scripts, pnpm check:control-bytes, check:entry-guard, check:self-import, check:phantom-deps, check:esm-specifiers, check:vi-mock-specifiers, check:doc-fences, check:shell-escape-residue - all exit 0

Declared narrowing.pnpm check:readme-exports and pnpm check:doc-snippets were not measured here: both exited with PRECONDITION NOT MET, naming 13 and 23 unbuilt packages respectively - they need a full-repo build (--build-filter resolves to 21 package closures). That is "I could not run", not a verdict, and CI runs both with a full build. The narrowing is safe to state rather than merely convenient: this diff touches no .md/.mdx file and changes no package's exported surface (only a registration's namespace value), and both gates key off documentation text and declared type entries, neither of which reads ComponentMeta.namespace. The gate that does read registration namespaces, check:doc-types, ran and is green. Likewise pnpm lint / pnpm type-check are repo-wide turbo farms; the two affected packages were run individually, and eslint.config.js configures no type-aware linting (no projectService / parserOptions.project), so this diff cannot move the verdict on any file it does not touch.

Scope

Held to this card. objectui#5106 - the doc-types gate never judging the namespace half of a registration row, the gate that would have caught this whole class - is untouched and stays its own card.

Generated by Claude Code

`packages/plugin-report` registered `report`, `spec-report` and `report-viewer` under namespace `report`, while `apps/console/src/register-plugins.ts` declared the lazy stubs for the same three short names under `plugin-report` and `packages/cli/src/utils/known-schema-types.ts` shipped the `plugin-report:*` spellings as renderable. `Registry.register` clears the lazy stub for the type IT registers, and that type was `report:report` — so the three `plugin-report:*` stubs were never cleared, no component was ever stored under them, and a schema authored with a whitelisted key resolved to nothing. The bare `report` key was also claimed twice under two different namespaces, so what it DECLARED depended on whether the plugin chunk had loaded yet (the objectui#6353 shape). Direction chosen by measurement: no `report:*` spelling is authored anywhere in this repo or the sibling `objectstack` checkout (0 hits), while the bare spellings are authored in 48 places. Move the package to `plugin-report`, retire the `report:*` keys, and regenerate the whitelist. The bare keys stay claimed deliberately and must not take `skipFallback`: both claimants now name the same full type, so suppressing either would strand the only spelling anything authors. Two pins outlive the fix: a fresh-`Registry` replay of the real declared metadata plus a console-shaped lazy stub in BOTH registration orders, checking the bare key's declared namespace after every step; and a derivation-based pin that fails if the plugin, the console stubs and the generated whitelist ever disagree again. Fixes#6416 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011SfZeFWrhGLHmfq61xbz4q

…ing it The replay fetched the eager registration with `getConfig(short, NS)`, which selects for the very namespace the per-step assertion then checks — so that assertion could never fail. Look the key up by short name and report whatever namespace was declared, so a namespace regression reddens inside the replay rather than only at the top-level spelling check. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011SfZeFWrhGLHmfq61xbz4q

github-actions · 2026-08-26T00:45:47Z

✅ Console Performance Budget

Metric	Value	Budget
Eager closure (gzip, 52 chunks)	3233.6 KB	3266.6 KB
Main entry chunk (gzip)	157.4 KB	350 KB
Entry file	`index-Bwdzuh4M.js`	—
Status	PASS	—

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (consoleActionDispatch.js)	0.20KB	0.19KB
app-shell (index.js)	11.30KB	4.28KB
app-shell (runtime-config.js)	18.10KB	6.51KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	10.06KB	3.86KB
auth (ActiveOrganizationStorage.js)	25.05KB	9.16KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	2.07KB	1.00KB
auth (AuthProvider.js)	40.18KB	10.59KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	12.21KB	3.45KB
auth (LoginForm.js)	18.15KB	5.39KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.65KB	2.22KB
auth (SocialSignInButtons.js)	9.61KB	3.89KB
auth (UserMenu.js)	3.41KB	1.23KB
auth (auth-gate-events.js)	1.29KB	0.66KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	40.21KB	10.80KB
auth (createAuthenticatedFetch.js)	8.46KB	3.43KB
auth (index.js)	3.19KB	1.44KB
auth (invitation-status.js)	1.22KB	0.70KB
auth (org-roles.js)	6.66KB	2.78KB
auth (phone-identifier.js)	1.11KB	0.66KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	5.30KB	1.02KB
auth (useWorkspaceAdminStatus.js)	5.13KB	2.35KB
collaboration (CommentThread.js)	26.08KB	7.56KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	6.49KB	2.64KB
collaboration (PresenceProvider.js)	2.79KB	1.13KB
collaboration (index.js)	1.68KB	0.73KB
collaboration (useCollaborationTranslation.js)	6.05KB	2.52KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	505.86KB	114.58KB
core (index.js)	5.30KB	2.13KB
create-plugin (index.js)	10.08KB	3.26KB
data-objectstack (index.js)	173.10KB	47.96KB
fields (index.js)	238.89KB	60.02KB
i18n (LocalizationContext.js)	1.76KB	0.96KB
i18n (currency.js)	1.22KB	0.64KB
i18n (fallbackInterpolation.js)	6.25KB	2.77KB
i18n (i18n.js)	4.28KB	1.75KB
i18n (index.js)	3.44KB	1.39KB
i18n (pickLocalized.js)	7.62KB	3.26KB
i18n (provider.js)	26.89KB	9.04KB
i18n (useDisplayLocale.js)	2.85KB	1.45KB
i18n (useObjectLabel.js)	33.40KB	8.71KB
i18n (useSafeTranslation.js)	5.60KB	2.33KB
layout (index.js)	38.95KB	10.97KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.75KB
mobile (index.js)	1.55KB	0.62KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	6.96KB	1.98KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.72KB	0.42KB
mobile (useResponsiveConfig.js)	1.37KB	0.63KB
mobile (useSpecGesture.js)	4.32KB	1.64KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	9.53KB	3.38KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	4.64KB	1.50KB
permissions (evaluator.js)	5.12KB	1.74KB
permissions (index.js)	0.93KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.53KB
permissions (usePermissions.js)	1.93KB	0.88KB
plugin-ai (index.js)	15.75KB	3.80KB
plugin-calendar (index.js)	46.66KB	12.84KB
plugin-charts (index.js)	64.66KB	18.32KB
plugin-chatbot (index.js)	188.60KB	44.82KB
plugin-dashboard (index.js)	133.48KB	34.49KB
plugin-designer (index.js)	211.90KB	42.74KB
plugin-detail (index.js)	245.10KB	62.31KB
plugin-editor (index.js)	2.46KB	1.10KB
plugin-form (index.js)	131.78KB	32.19KB
plugin-gantt (index.js)	164.14KB	39.87KB
plugin-grid (index.js)	201.79KB	54.60KB
plugin-kanban (index.js)	53.16KB	14.65KB
plugin-list (index.js)	112.63KB	27.45KB
plugin-map (index.js)	20.09KB	6.62KB
plugin-markdown (index.js)	13.72KB	4.69KB
plugin-report (index.js)	43.51KB	11.94KB
plugin-timeline (index.js)	26.72KB	7.71KB
plugin-tree (index.js)	9.26KB	3.13KB
plugin-view (index.js)	84.55KB	20.74KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.90KB	0.85KB
providers (UploadProvider.js)	11.66KB	3.50KB
providers (index.js)	0.45KB	0.23KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	5.62KB	2.34KB
react (LazyPluginLoader.js)	4.47KB	1.63KB
react (SchemaRenderer.js)	54.84KB	18.43KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	1.35KB	0.70KB
react (schema-input.js)	2.32KB	1.24KB
react (spec-input.js)	0.20KB	0.18KB
sdui-parser (codegen.js)	5.41KB	2.34KB
sdui-parser (dashboard-widget-options.js)	3.08KB	1.30KB
sdui-parser (index.js)	4.93KB	2.24KB
sdui-parser (input-type.js)	2.84KB	1.40KB
sdui-parser (parse.js)	12.13KB	3.65KB
sdui-parser (provenance.js)	3.66KB	1.82KB
sdui-parser (types.js)	0.28KB	0.23KB
sdui-parser (validate.js)	7.54KB	2.63KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	0.99KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	2.74KB	1.41KB
types (crud.js)	0.20KB	0.18KB
types (dashboard-filter-alias.js)	6.23KB	2.74KB
types (data-display.js)	3.75KB	1.85KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	1.85KB	0.85KB
types (disclosure.js)	0.20KB	0.18KB
types (error-code.js)	1.54KB	0.88KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (http-inflight.js)	8.87KB	3.73KB
types (http-retry.js)	4.32KB	2.02KB
types (icon-key-migration.js)	4.26KB	1.63KB
types (index.js)	4.72KB	2.24KB
types (layout.js)	0.20KB	0.18KB
types (managed-by.js)	0.19KB	0.18KB
types (mobile.js)	2.59KB	1.31KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (record-semantics.js)	1.28KB	0.67KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (spec-report.js)	5.05KB	1.93KB
types (spec-ui-namespace.js)	0.20KB	0.19KB
types (system-fields.js)	3.33KB	1.54KB
types (theme.js)	6.28KB	2.87KB
types (ui-action.js)	3.40KB	1.71KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

✅ Core packages should be < 50KB gzipped
✅ Component packages should be < 100KB gzipped
⚠️ Plugin packages should be < 150KB gzipped

claude added 2 commits August 26, 2026 00:29

github-actionsBot added plugin tests labels Aug 26, 2026

claudeBot mentioned this pull request Aug 26, 2026
plugin-report registers under namespace report while the console and the CLI whitelist declare plugin-report — bare report is double-claimed and three plugin-report:* keys are unrenderable #6416
Closed

os-support-ai marked this pull request as ready for review August 26, 2026 00:55

os-support-ai added this pull request to the merge queue Aug 26, 2026

Merged via the queue into main with commit 854222cAug 26, 2026
29 checks passed

os-support-ai deleted the claude/issue-6416-plugin-report-namespace branch August 26, 2026 01:07

Navigation Menu

Uh oh!

fix(plugin-report): register under the namespace its consumers declare - #6441

fix(plugin-report): register under the namespace its consumers declare#6441
os-support-ai merged 2 commits into
mainfrom
claude/issue-6416-plugin-report-namespace

claudeBot commented Aug 26, 2026

Uh oh!

github-actionsBot commented Aug 26, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

claudeBot commented Aug 26, 2026

Step zero: the measurement that chose the direction

What changed

Why the bare keys do NOT take skipFallback

The two pins

Ghost-assertion evidence

Verification, on the final commit d46f6c9e2

Scope

Uh oh!

github-actionsBot commented Aug 26, 2026

✅ Console Performance Budget

📦 Bundle Size Report

Size Limits

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Why the bare keys do NOT take `skipFallback`

Verification, on the final commit `d46f6c9e2`