Skip to content

test(core): name the closed-surface pin after the project that compiles it#6555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-support-ai merged 1 commit into from
Aug 26, 2026
Merged

test(core): name the closed-surface pin after the project that compiles it #6555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .changeset/6548-stale-test-name.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
---
---

Test-only change in `@object-ui/core`: renamed one `it()` in
`actionDef-closed-surface.test.ts` so its reported name cites `tsconfig.test.json`,
the project that actually compiles the file, instead of the retired
`tsconfig.typetests.json` (objectui#4040). No assertion, source file or published
behaviour changes — only the string the runner prints.
2 changes: 1 addition & 1 deletion packages/core/src/actions/__tests__/actionDef-closed-surface.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -121,7 +121,7 @@ const _navigationAlias: ActionDef = {
const _navNewTabString: ActionDef = { type: 'navigation', to: '/x', newTab: 'new-tab' };

describe('ActionDef is a closed surface (objectstack#4075 step 3)', () => {
it('states its contract as types, compiled by tsconfig.typetests.json', () => {
it('states its contract as types, compiled by tsconfig.test.json', () => {
// The assertions above are the test. This body exists so the file is a
// legitimate vitest suite as well as a tsc input, and so a reader running
// the suite sees the pin acknowledged rather than an empty file.
Expand Down
Loading