Skip to content

fix(console): delete dead pre-ADR-0079 getRecordDisplayName/formatRecordTitle copy#6571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-support-ai merged 1 commit into from
Aug 26, 2026
+15 −44
Merged

fix(console): delete dead pre-ADR-0079 getRecordDisplayName/formatRecordTitle copy #6571

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/6558-remove-dead-console-record-title-copy.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
---
---

Removed a dead pre-ADR-0079 `getRecordDisplayName` / `formatRecordTitle` copy from
`apps/console/src/utils.ts`. Both were unexported-from-behaviour dead code with zero
console importers (superseded by the unified `@object-ui/core#getRecordDisplayName`);
no published behaviour changes.
52 changes: 8 additions & 44 deletions apps/console/src/utils.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -34,47 +34,11 @@ export function capitalizeFirst(str: string): string {
return str.charAt(0).toUpperCase() + str.slice(1);
}

/**
* Format a record title using the titleFormat pattern
* @param titleFormat Pattern like "{name} - {email}", or an Expression
* envelope `{ dialect: 'template', source: '...' }` produced by the
* framework's compile step.
* @param record The record data object
* @returns Formatted title string
*/
export function formatRecordTitle(titleFormat: string | { source?: string } | undefined, record: any): string {
const template: string | undefined =
typeof titleFormat === 'string'
? titleFormat
: (titleFormat && typeof titleFormat === 'object' && typeof titleFormat.source === 'string')
? titleFormat.source
: undefined;

if (!template || !record) {
return record?.id || record?._id || 'Record';
}

// Replace {fieldName} patterns with actual values
return template.replace(/\{(\w+)\}/g, (_match, fieldName) => {
const value = record[fieldName];
if (value === null || value === undefined) {
return '';
}
return String(value);
});
}

/**
* Get display name for a record using titleFormat or fallback
* @param objectDef Object definition with optional titleFormat
* @param record The record data
* @returns Display name for the record
*/
export function getRecordDisplayName(objectDef: any, record: any): string {
if (objectDef?.titleFormat) {
return formatRecordTitle(objectDef.titleFormat, record);
}

// Fallback: Try common name fields
return record?.name || record?.title || record?.label || record?.id || record?._id || 'Untitled';
}
// `formatRecordTitle` / `getRecordDisplayName` (a pre-ADR-0079 divergent
// resolver pair, ~6 of which existed across surfaces) were removed here as
// dead code (objectui#6558) — zero console importers, and their presence
// re-armed the exact trap ADR-0079 closed: a same-named, same-signature
// resolver one import away that ignores `nameField`/`displayNameField` and
// ranks the legacy `titleFormat` template first. Console surfaces that need
// a record title use the unified `@object-ui/core#getRecordDisplayName`
// (and `formatTitleTemplate`), which the console already depends on.
Loading