Skip to content

docs(app-shell): grid-columns pin measures identity churn, not a column change#6835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-sam merged 1 commit into from
Aug 30, 2026
Merged

docs(app-shell): grid-columns pin measures identity churn, not a column change #6835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .changeset/olive-donkeys-smoke.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
---
---

Docs-only: correct the stale docstring on the Studio Data-pillar grid-columns pin
(`StudioDesignSurface.gridColumns.test.tsx`). Since cloud#1652 added the
`publishedFieldNames` filter to `gridColumns`, the second case exercises
identity-churn liveness rather than a real column change, and its prose said the
opposite. Comment and test title only — no assertion, no source, no published
behaviour changes. objectui#6729.
38 changes: 30 additions & 8 deletions packages/app-shell/src/views/studio-design/StudioDesignSurface.gridColumns.test.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -152,15 +152,37 @@ describe('Studio Data pillar grid — the columns array keeps a stable identity
});

/**
* The dependency must stay LIVE, not be defeated. This pin is green before and
* after the fix on purpose — it is a must-not-change, not a red-first case.
* Its force comes from the path it uses: "+ Add field" mutates `objDraft.fields`
* WITHOUT remounting the grid (its key is `${current.name}:${gridVer}` and
* `gridVer` is unchanged), so the refetch it produces can only have arrived
* through the column-identity dependency chain. A memo that froze the columns
* (or returned a constant) would turn this red.
* Identity-churn liveness: the columns dependency must stay LIVE against a
* FRESH ARRAY — not be defeated by a producer-side memo that freezes the
* columns or constant-folds them. This pin is green before and after the
* #4567 fix on purpose; it is a must-not-change, not a red-first case.
*
* ⚠️ What this case drives is NOT a content change, and this docstring used
* to say that it was ("a REAL column change still refetches"). cloud#1652 is
* what moved it out from under that sentence: `gridColumns` gained a trailing
* `.filter((n) => publishedFieldNames.has(n))`, and `publishedFieldNames` is
* read from the SERVER baseline alone (the `layered()` response), never from
* the draft. "+ Add field" appends an UNPUBLISHED `field_<N>` to
* `objDraft.fields`, so the memo recomputes — new `fields`, hence a new array
* — and that same filter then removes `field_<N>` again. What reaches the grid
* is therefore an array of EQUAL CONTENT carrying a FRESH IDENTITY.
*
* Measured on origin/main while correcting this docstring (objectui#6729):
* across the click `find()` goes 1 -> 2 while `$select` is
* `["id","name","status"]` both before and after, and no `field_` ever reaches
* the projection. So the refetch asserted below can only have arrived through
* the column-IDENTITY dependency chain — and there is no remount to explain it
* either: the grid's key is `${current.name}:${gridVer}`, and `gridVer` does
* not move.
*
* ⛔ Do not read this as covering "columns whose CONTENT changed must still
* refetch". That case is real, and it is pinned elsewhere — plugin-list's
* `ListView.discardedExpandFieldsMemo.test.tsx` (objectui#6697), which moves
* `$select` while holding `$expand` byte-identical. Taking the old sentence at
* face value already cost one round: #6697's implementer concluded the content
* case was covered here, and had to add it there.
*/
it('a REAL column change still refetches — the dependency stays live', async () => {
it('a fresh columns array of EQUAL content still refetches — identity-churn liveness', async () => {
const before = await mountSettledGrid();

fireEvent.click(screen.getAllByRole('button', { name: /Add field/i })[0]);
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
docs(app-shell): grid-columns pin measures identity churn, not a column change by os-sales · Pull Request #6835 · objectstack-ai/objectui · GitHub
Skip to content
docs(app-shell): grid-columns pin measures identity churn, not a column change#6835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-sam
merged 1 commit into

from

Aug 30, 2026
 Merged


docs(app-shell): grid-columns pin measures identity churn, not a column change
#6835
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


9 changes: 9 additions & 0 deletions
.changeset/olive-donkeys-smoke.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
---
---

Docs-only: correct the stale docstring on the Studio Data-pillar grid-columns pin
(`StudioDesignSurface.gridColumns.test.tsx`). Since cloud#1652 added the
`publishedFieldNames` filter to `gridColumns`, the second case exercises
identity-churn liveness rather than a real column change, and its prose said the
opposite. Comment and test title only — no assertion, no source, no published
behaviour changes. objectui#6729.

38 changes: 30 additions & 8 deletions
packages/app-shell/src/views/studio-design/StudioDesignSurface.gridColumns.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -152,15 +152,37 @@ describe('Studio Data pillar grid — the columns array keeps a stable identity
 });

 /**
 * The dependency must stay LIVE, not be defeated. This pin is green before and
 * after the fix on purpose — it is a must-not-change, not a red-first case.
 * Its force comes from the path it uses: "+ Add field" mutates `objDraft.fields`
 * WITHOUT remounting the grid (its key is `${current.name}:${gridVer}` and
 * `gridVer` is unchanged), so the refetch it produces can only have arrived
 * through the column-identity dependency chain. A memo that froze the columns
 * (or returned a constant) would turn this red.
 * Identity-churn liveness: the columns dependency must stay LIVE against a
 * FRESH ARRAY — not be defeated by a producer-side memo that freezes the
 * columns or constant-folds them. This pin is green before and after the
 * #4567 fix on purpose; it is a must-not-change, not a red-first case.
 *
 * ⚠️ What this case drives is NOT a content change, and this docstring used
 * to say that it was ("a REAL column change still refetches"). cloud#1652 is
 * what moved it out from under that sentence: `gridColumns` gained a trailing
 * `.filter((n) => publishedFieldNames.has(n))`, and `publishedFieldNames` is
 * read from the SERVER baseline alone (the `layered()` response), never from
 * the draft. "+ Add field" appends an UNPUBLISHED `field_<N>` to
 * `objDraft.fields`, so the memo recomputes — new `fields`, hence a new array
 * — and that same filter then removes `field_<N>` again. What reaches the grid
 * is therefore an array of EQUAL CONTENT carrying a FRESH IDENTITY.
 *
 * Measured on origin/main while correcting this docstring (objectui#6729):
 * across the click `find()` goes 1 -> 2 while `$select` is
 * `["id","name","status"]` both before and after, and no `field_` ever reaches
 * the projection. So the refetch asserted below can only have arrived through
 * the column-IDENTITY dependency chain — and there is no remount to explain it
 * either: the grid's key is `${current.name}:${gridVer}`, and `gridVer` does
 * not move.
 *
 * ⛔ Do not read this as covering "columns whose CONTENT changed must still
 * refetch". That case is real, and it is pinned elsewhere — plugin-list's
 * `ListView.discardedExpandFieldsMemo.test.tsx` (objectui#6697), which moves
 * `$select` while holding `$expand` byte-identical. Taking the old sentence at
 * face value already cost one round: #6697's implementer concluded the content
 * case was covered here, and had to add it there.
 */
 it('a REAL column change still refetches — the dependency stays live', async () => {
 it('a fresh columns array of EQUAL content still refetches — identity-churn liveness', async () => {
 const before = await mountSettledGrid();

 fireEvent.click(screen.getAllByRole('button', { name: /Add field/i })[0]);
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
docs(app-shell): grid-columns pin measures identity churn, not a column change by os-sales · Pull Request #6835 · objectstack-ai/objectui · GitHub
Skip to content
docs(app-shell): grid-columns pin measures identity churn, not a column change#6835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-sam
merged 1 commit into

from

Aug 30, 2026
 Merged


docs(app-shell): grid-columns pin measures identity churn, not a column change
#6835
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


9 changes: 9 additions & 0 deletions
.changeset/olive-donkeys-smoke.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
---
---

Docs-only: correct the stale docstring on the Studio Data-pillar grid-columns pin
(`StudioDesignSurface.gridColumns.test.tsx`). Since cloud#1652 added the
`publishedFieldNames` filter to `gridColumns`, the second case exercises
identity-churn liveness rather than a real column change, and its prose said the
opposite. Comment and test title only — no assertion, no source, no published
behaviour changes. objectui#6729.

38 changes: 30 additions & 8 deletions
packages/app-shell/src/views/studio-design/StudioDesignSurface.gridColumns.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -152,15 +152,37 @@ describe('Studio Data pillar grid — the columns array keeps a stable identity
 });

 /**
 * The dependency must stay LIVE, not be defeated. This pin is green before and
 * after the fix on purpose — it is a must-not-change, not a red-first case.
 * Its force comes from the path it uses: "+ Add field" mutates `objDraft.fields`
 * WITHOUT remounting the grid (its key is `${current.name}:${gridVer}` and
 * `gridVer` is unchanged), so the refetch it produces can only have arrived
 * through the column-identity dependency chain. A memo that froze the columns
 * (or returned a constant) would turn this red.
 * Identity-churn liveness: the columns dependency must stay LIVE against a
 * FRESH ARRAY — not be defeated by a producer-side memo that freezes the
 * columns or constant-folds them. This pin is green before and after the
 * #4567 fix on purpose; it is a must-not-change, not a red-first case.
 *
 * ⚠️ What this case drives is NOT a content change, and this docstring used
 * to say that it was ("a REAL column change still refetches"). cloud#1652 is
 * what moved it out from under that sentence: `gridColumns` gained a trailing
 * `.filter((n) => publishedFieldNames.has(n))`, and `publishedFieldNames` is
 * read from the SERVER baseline alone (the `layered()` response), never from
 * the draft. "+ Add field" appends an UNPUBLISHED `field_<N>` to
 * `objDraft.fields`, so the memo recomputes — new `fields`, hence a new array
 * — and that same filter then removes `field_<N>` again. What reaches the grid
 * is therefore an array of EQUAL CONTENT carrying a FRESH IDENTITY.
 *
 * Measured on origin/main while correcting this docstring (objectui#6729):
 * across the click `find()` goes 1 -> 2 while `$select` is
 * `["id","name","status"]` both before and after, and no `field_` ever reaches
 * the projection. So the refetch asserted below can only have arrived through
 * the column-IDENTITY dependency chain — and there is no remount to explain it
 * either: the grid's key is `${current.name}:${gridVer}`, and `gridVer` does
 * not move.
 *
 * ⛔ Do not read this as covering "columns whose CONTENT changed must still
 * refetch". That case is real, and it is pinned elsewhere — plugin-list's
 * `ListView.discardedExpandFieldsMemo.test.tsx` (objectui#6697), which moves
 * `$select` while holding `$expand` byte-identical. Taking the old sentence at
 * face value already cost one round: #6697's implementer concluded the content
 * case was covered here, and had to add it there.
 */
 it('a REAL column change still refetches — the dependency stays live', async () => {
 it('a fresh columns array of EQUAL content still refetches — identity-churn liveness', async () => {
 const before = await mountSettledGrid();

 fireEvent.click(screen.getAllByRole('button', { name: /Add field/i })[0]);
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
docs(app-shell): grid-columns pin measures identity churn, not a column change by os-sales · Pull Request #6835 · objectstack-ai/objectui · GitHub
Skip to content
docs(app-shell): grid-columns pin measures identity churn, not a column change#6835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-sam
merged 1 commit into

from

Aug 30, 2026
 Merged


docs(app-shell): grid-columns pin measures identity churn, not a column change
#6835
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


9 changes: 9 additions & 0 deletions
.changeset/olive-donkeys-smoke.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
---
---

Docs-only: correct the stale docstring on the Studio Data-pillar grid-columns pin
(`StudioDesignSurface.gridColumns.test.tsx`). Since cloud#1652 added the
`publishedFieldNames` filter to `gridColumns`, the second case exercises
identity-churn liveness rather than a real column change, and its prose said the
opposite. Comment and test title only — no assertion, no source, no published
behaviour changes. objectui#6729.

38 changes: 30 additions & 8 deletions
packages/app-shell/src/views/studio-design/StudioDesignSurface.gridColumns.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -152,15 +152,37 @@ describe('Studio Data pillar grid — the columns array keeps a stable identity
 });

 /**
 * The dependency must stay LIVE, not be defeated. This pin is green before and
 * after the fix on purpose — it is a must-not-change, not a red-first case.
 * Its force comes from the path it uses: "+ Add field" mutates `objDraft.fields`
 * WITHOUT remounting the grid (its key is `${current.name}:${gridVer}` and
 * `gridVer` is unchanged), so the refetch it produces can only have arrived
 * through the column-identity dependency chain. A memo that froze the columns
 * (or returned a constant) would turn this red.
 * Identity-churn liveness: the columns dependency must stay LIVE against a
 * FRESH ARRAY — not be defeated by a producer-side memo that freezes the
 * columns or constant-folds them. This pin is green before and after the
 * #4567 fix on purpose; it is a must-not-change, not a red-first case.
 *
 * ⚠️ What this case drives is NOT a content change, and this docstring used
 * to say that it was ("a REAL column change still refetches"). cloud#1652 is
 * what moved it out from under that sentence: `gridColumns` gained a trailing
 * `.filter((n) => publishedFieldNames.has(n))`, and `publishedFieldNames` is
 * read from the SERVER baseline alone (the `layered()` response), never from
 * the draft. "+ Add field" appends an UNPUBLISHED `field_<N>` to
 * `objDraft.fields`, so the memo recomputes — new `fields`, hence a new array
 * — and that same filter then removes `field_<N>` again. What reaches the grid
 * is therefore an array of EQUAL CONTENT carrying a FRESH IDENTITY.
 *
 * Measured on origin/main while correcting this docstring (objectui#6729):
 * across the click `find()` goes 1 -> 2 while `$select` is
 * `["id","name","status"]` both before and after, and no `field_` ever reaches
 * the projection. So the refetch asserted below can only have arrived through
 * the column-IDENTITY dependency chain — and there is no remount to explain it
 * either: the grid's key is `${current.name}:${gridVer}`, and `gridVer` does
 * not move.
 *
 * ⛔ Do not read this as covering "columns whose CONTENT changed must still
 * refetch". That case is real, and it is pinned elsewhere — plugin-list's
 * `ListView.discardedExpandFieldsMemo.test.tsx` (objectui#6697), which moves
 * `$select` while holding `$expand` byte-identical. Taking the old sentence at
 * face value already cost one round: #6697's implementer concluded the content
 * case was covered here, and had to add it there.
 */
 it('a REAL column change still refetches — the dependency stays live', async () => {
 it('a fresh columns array of EQUAL content still refetches — identity-churn liveness', async () => {
 const before = await mountSettledGrid();

 fireEvent.click(screen.getAllByRole('button', { name: /Add field/i })[0]);
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
docs(app-shell): grid-columns pin measures identity churn, not a column change by os-sales · Pull Request #6835 · objectstack-ai/objectui · GitHub
Skip to content
docs(app-shell): grid-columns pin measures identity churn, not a column change#6835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-sam
merged 1 commit into

from

Aug 30, 2026
 Merged


docs(app-shell): grid-columns pin measures identity churn, not a column change
#6835
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


9 changes: 9 additions & 0 deletions
.changeset/olive-donkeys-smoke.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
---
---

Docs-only: correct the stale docstring on the Studio Data-pillar grid-columns pin
(`StudioDesignSurface.gridColumns.test.tsx`). Since cloud#1652 added the
`publishedFieldNames` filter to `gridColumns`, the second case exercises
identity-churn liveness rather than a real column change, and its prose said the
opposite. Comment and test title only — no assertion, no source, no published
behaviour changes. objectui#6729.

38 changes: 30 additions & 8 deletions
packages/app-shell/src/views/studio-design/StudioDesignSurface.gridColumns.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -152,15 +152,37 @@ describe('Studio Data pillar grid — the columns array keeps a stable identity
 });

 /**
 * The dependency must stay LIVE, not be defeated. This pin is green before and
 * after the fix on purpose — it is a must-not-change, not a red-first case.
 * Its force comes from the path it uses: "+ Add field" mutates `objDraft.fields`
 * WITHOUT remounting the grid (its key is `${current.name}:${gridVer}` and
 * `gridVer` is unchanged), so the refetch it produces can only have arrived
 * through the column-identity dependency chain. A memo that froze the columns
 * (or returned a constant) would turn this red.
 * Identity-churn liveness: the columns dependency must stay LIVE against a
 * FRESH ARRAY — not be defeated by a producer-side memo that freezes the
 * columns or constant-folds them. This pin is green before and after the
 * #4567 fix on purpose; it is a must-not-change, not a red-first case.
 *
 * ⚠️ What this case drives is NOT a content change, and this docstring used
 * to say that it was ("a REAL column change still refetches"). cloud#1652 is
 * what moved it out from under that sentence: `gridColumns` gained a trailing
 * `.filter((n) => publishedFieldNames.has(n))`, and `publishedFieldNames` is
 * read from the SERVER baseline alone (the `layered()` response), never from
 * the draft. "+ Add field" appends an UNPUBLISHED `field_<N>` to
 * `objDraft.fields`, so the memo recomputes — new `fields`, hence a new array
 * — and that same filter then removes `field_<N>` again. What reaches the grid
 * is therefore an array of EQUAL CONTENT carrying a FRESH IDENTITY.
 *
 * Measured on origin/main while correcting this docstring (objectui#6729):
 * across the click `find()` goes 1 -> 2 while `$select` is
 * `["id","name","status"]` both before and after, and no `field_` ever reaches
 * the projection. So the refetch asserted below can only have arrived through
 * the column-IDENTITY dependency chain — and there is no remount to explain it
 * either: the grid's key is `${current.name}:${gridVer}`, and `gridVer` does
 * not move.
 *
 * ⛔ Do not read this as covering "columns whose CONTENT changed must still
 * refetch". That case is real, and it is pinned elsewhere — plugin-list's
 * `ListView.discardedExpandFieldsMemo.test.tsx` (objectui#6697), which moves
 * `$select` while holding `$expand` byte-identical. Taking the old sentence at
 * face value already cost one round: #6697's implementer concluded the content
 * case was covered here, and had to add it there.
 */
 it('a REAL column change still refetches — the dependency stays live', async () => {
 it('a fresh columns array of EQUAL content still refetches — identity-churn liveness', async () => {
 const before = await mountSettledGrid();

 fireEvent.click(screen.getAllByRole('button', { name: /Add field/i })[0]);
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
docs(app-shell): grid-columns pin measures identity churn, not a column change by os-sales · Pull Request #6835 · objectstack-ai/objectui · GitHub
Skip to content
docs(app-shell): grid-columns pin measures identity churn, not a column change#6835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-sam
merged 1 commit into

from

Aug 30, 2026
 Merged


docs(app-shell): grid-columns pin measures identity churn, not a column change
#6835
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


9 changes: 9 additions & 0 deletions
.changeset/olive-donkeys-smoke.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
---
---

Docs-only: correct the stale docstring on the Studio Data-pillar grid-columns pin
(`StudioDesignSurface.gridColumns.test.tsx`). Since cloud#1652 added the
`publishedFieldNames` filter to `gridColumns`, the second case exercises
identity-churn liveness rather than a real column change, and its prose said the
opposite. Comment and test title only — no assertion, no source, no published
behaviour changes. objectui#6729.

38 changes: 30 additions & 8 deletions
packages/app-shell/src/views/studio-design/StudioDesignSurface.gridColumns.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -152,15 +152,37 @@ describe('Studio Data pillar grid — the columns array keeps a stable identity
 });

 /**
 * The dependency must stay LIVE, not be defeated. This pin is green before and
 * after the fix on purpose — it is a must-not-change, not a red-first case.
 * Its force comes from the path it uses: "+ Add field" mutates `objDraft.fields`
 * WITHOUT remounting the grid (its key is `${current.name}:${gridVer}` and
 * `gridVer` is unchanged), so the refetch it produces can only have arrived
 * through the column-identity dependency chain. A memo that froze the columns
 * (or returned a constant) would turn this red.
 * Identity-churn liveness: the columns dependency must stay LIVE against a
 * FRESH ARRAY — not be defeated by a producer-side memo that freezes the
 * columns or constant-folds them. This pin is green before and after the
 * #4567 fix on purpose; it is a must-not-change, not a red-first case.
 *
 * ⚠️ What this case drives is NOT a content change, and this docstring used
 * to say that it was ("a REAL column change still refetches"). cloud#1652 is
 * what moved it out from under that sentence: `gridColumns` gained a trailing
 * `.filter((n) => publishedFieldNames.has(n))`, and `publishedFieldNames` is
 * read from the SERVER baseline alone (the `layered()` response), never from
 * the draft. "+ Add field" appends an UNPUBLISHED `field_<N>` to
 * `objDraft.fields`, so the memo recomputes — new `fields`, hence a new array
 * — and that same filter then removes `field_<N>` again. What reaches the grid
 * is therefore an array of EQUAL CONTENT carrying a FRESH IDENTITY.
 *
 * Measured on origin/main while correcting this docstring (objectui#6729):
 * across the click `find()` goes 1 -> 2 while `$select` is
 * `["id","name","status"]` both before and after, and no `field_` ever reaches
 * the projection. So the refetch asserted below can only have arrived through
 * the column-IDENTITY dependency chain — and there is no remount to explain it
 * either: the grid's key is `${current.name}:${gridVer}`, and `gridVer` does
 * not move.
 *
 * ⛔ Do not read this as covering "columns whose CONTENT changed must still
 * refetch". That case is real, and it is pinned elsewhere — plugin-list's
 * `ListView.discardedExpandFieldsMemo.test.tsx` (objectui#6697), which moves
 * `$select` while holding `$expand` byte-identical. Taking the old sentence at
 * face value already cost one round: #6697's implementer concluded the content
 * case was covered here, and had to add it there.
 */
 it('a REAL column change still refetches — the dependency stays live', async () => {
 it('a fresh columns array of EQUAL content still refetches — identity-churn liveness', async () => {
 const before = await mountSettledGrid();

 fireEvent.click(screen.getAllByRole('button', { name: /Add field/i })[0]);
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
docs(app-shell): grid-columns pin measures identity churn, not a column change by os-sales · Pull Request #6835 · objectstack-ai/objectui · GitHub
Skip to content
docs(app-shell): grid-columns pin measures identity churn, not a column change#6835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-sam
merged 1 commit into

from

Aug 30, 2026
 Merged


docs(app-shell): grid-columns pin measures identity churn, not a column change
#6835
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


9 changes: 9 additions & 0 deletions
.changeset/olive-donkeys-smoke.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
---
---

Docs-only: correct the stale docstring on the Studio Data-pillar grid-columns pin
(`StudioDesignSurface.gridColumns.test.tsx`). Since cloud#1652 added the
`publishedFieldNames` filter to `gridColumns`, the second case exercises
identity-churn liveness rather than a real column change, and its prose said the
opposite. Comment and test title only — no assertion, no source, no published
behaviour changes. objectui#6729.

38 changes: 30 additions & 8 deletions
packages/app-shell/src/views/studio-design/StudioDesignSurface.gridColumns.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -152,15 +152,37 @@ describe('Studio Data pillar grid — the columns array keeps a stable identity
 });

 /**
 * The dependency must stay LIVE, not be defeated. This pin is green before and
 * after the fix on purpose — it is a must-not-change, not a red-first case.
 * Its force comes from the path it uses: "+ Add field" mutates `objDraft.fields`
 * WITHOUT remounting the grid (its key is `${current.name}:${gridVer}` and
 * `gridVer` is unchanged), so the refetch it produces can only have arrived
 * through the column-identity dependency chain. A memo that froze the columns
 * (or returned a constant) would turn this red.
 * Identity-churn liveness: the columns dependency must stay LIVE against a
 * FRESH ARRAY — not be defeated by a producer-side memo that freezes the
 * columns or constant-folds them. This pin is green before and after the
 * #4567 fix on purpose; it is a must-not-change, not a red-first case.
 *
 * ⚠️ What this case drives is NOT a content change, and this docstring used
 * to say that it was ("a REAL column change still refetches"). cloud#1652 is
 * what moved it out from under that sentence: `gridColumns` gained a trailing
 * `.filter((n) => publishedFieldNames.has(n))`, and `publishedFieldNames` is
 * read from the SERVER baseline alone (the `layered()` response), never from
 * the draft. "+ Add field" appends an UNPUBLISHED `field_<N>` to
 * `objDraft.fields`, so the memo recomputes — new `fields`, hence a new array
 * — and that same filter then removes `field_<N>` again. What reaches the grid
 * is therefore an array of EQUAL CONTENT carrying a FRESH IDENTITY.
 *
 * Measured on origin/main while correcting this docstring (objectui#6729):
 * across the click `find()` goes 1 -> 2 while `$select` is
 * `["id","name","status"]` both before and after, and no `field_` ever reaches
 * the projection. So the refetch asserted below can only have arrived through
 * the column-IDENTITY dependency chain — and there is no remount to explain it
 * either: the grid's key is `${current.name}:${gridVer}`, and `gridVer` does
 * not move.
 *
 * ⛔ Do not read this as covering "columns whose CONTENT changed must still
 * refetch". That case is real, and it is pinned elsewhere — plugin-list's
 * `ListView.discardedExpandFieldsMemo.test.tsx` (objectui#6697), which moves
 * `$select` while holding `$expand` byte-identical. Taking the old sentence at
 * face value already cost one round: #6697's implementer concluded the content
 * case was covered here, and had to add it there.
 */
 it('a REAL column change still refetches — the dependency stays live', async () => {
 it('a fresh columns array of EQUAL content still refetches — identity-churn liveness', async () => {
 const before = await mountSettledGrid();

 fireEvent.click(screen.getAllByRole('button', { name: /Add field/i })[0]);
Expand Down
Loading