Skip to content

test(tooling): ratchet the vi.mock factories that must inherit the real export surface#6894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-sam merged 3 commits into from
Aug 30, 2026
Merged

test(tooling): ratchet the vi.mock factories that must inherit the real export surface #6894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a6f502f
test(tooling): ratchet the vi.mock factories that must inherit the re…
claude Aug 30, 2026
7c104d1
chore(tooling): declare the changeset and fix the suite's inferred re…
claude Aug 30, 2026
c935289
docs(tooling): point the guard's cross-references at the filed findings
claude Aug 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .changeset/vi-mock-inherit-guard-6849.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
---
---

Test/tooling only; nothing published changes.

Adds `scripts/check-vi-mock-inherit.mjs`, a ratchet that rejects a `vi.mock` factory
which hand-lists the exports of a covered workspace specifier instead of inheriting the
real module's export surface. The only `src/` file it touches is a plugin-view test
file, converted to the inheriting form — no runtime behaviour, no public API, no
published output changes.
35 changes: 35 additions & 0 deletions .github/workflows/vi-mock-specifiers.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,20 @@
name: Inert vi.mock Specifiers

# Two gates over ONE population, in one home. Both read the `vi.mock` call sites
# of this tree and both catch a mock that is silently not doing what it looks
# like it is doing: `check-vi-mock-specifiers.mjs` catches a specifier that
# resolves to no file (an inert stand-in), and `check-vi-mock-inherit.mjs`
# catches a factory that hand-lists its exports (a frozen export surface,
# objectui#6849). They share the call-site pattern deliberately -- a population
# that drifted between them would be a hole neither one reports -- so they share
# a workflow rather than each registering a required context of its own.
#
# The workflow `name:` and the job `name:` are therefore BROADER than the older
# of the two gates. They are left unchanged on purpose: those two strings are
# the check-run context that branch protection and
# `scripts/dependabot-merge-gate.mjs` name, and renaming a required context
# silently un-requires it.
#
# Why this is its own workflow rather than a step in `ci.yml` or `lint.yml`: a
# module mock can be written into any package, in any shape of pull request, and
# both of those workflows decide inside the job whether the change "needs a full
Expand DownExpand Up@@ -79,3 +94,23 @@ jobs:
# gate's own defect one level up.
- name: Check every relative vi.mock specifier resolves
run: node scripts/check-vi-mock-specifiers.mjs

# The sibling property of the same call sites: a factory that HAND-LISTS
# the exports it returns freezes the mock's export surface. The next
# export any module in the file's import graph reads AT MODULE SCOPE then
# kills the file during COLLECTION -- `Test Files 3 failed | 546 passed`
# with `Tests 6694 passed`, ZERO failed assertions, because the tests in
# those files never ran (objectui#6768). It reads as flake to whoever
# sees it next, and the bill lands on whoever added the export.
#
# The recogniser is SEMANTIC, never a grep for `importOriginal`: that
# spelling mis-counted eleven correct files as broken AND missed one
# broken file entirely (objectui#6849). It asks whether the factory
# OBTAINS the real module -- a callback parameter under any name, or
# `vi.importActual` of the same specifier -- and SPREADS it.
#
# Narrow by ruling: only the covered workspace specifiers in
# `COVERED_SPECIFIERS` are judged. Whole-module replacement of a local
# module is legitimate and out of scope by construction, not by exemption.
- name: Check every covered vi.mock factory inherits the real export surface
run: node scripts/check-vi-mock-inherit.mjs
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -66,6 +66,7 @@
"governed": "node scripts/check-governed-queue-guard.mjs --test",
"check:pre-install-import-graph": "node scripts/check-pre-install-import-graph.mjs",
"check:vi-mock-specifiers": "node scripts/check-vi-mock-specifiers.mjs",
"check:vi-mock-inherit": "node scripts/check-vi-mock-inherit.mjs",
"check:shell-escape-residue": "node scripts/check-shell-escape-residue.mjs",
"check:readme-exports": "node scripts/check-readme-exports.mjs",
"cli": "node packages/cli/dist/cli.js",
Expand Down
8 changes: 7 additions & 1 deletion packages/plugin-view/src/__tests__/ObjectView.contractEnvelope-6726.test.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -42,9 +42,15 @@ import type { ObjectViewSchema } from '@object-ui/types';
/** Every `data` prop the view handed to SchemaRenderer, in order. */
const delivered: unknown[][] = [];

vi.mock('@object-ui/react', async () => {
vi.mock('@object-ui/react', async (importOriginal) => {
const React = await import('react');
return {
// Inherit the real export surface, then override only what this pin reads.
// A hand-listed factory freezes the mock at whatever was typed that day, and
// the next export any module in this file's import graph reads at module
// scope kills the file during COLLECTION -- zero failed assertions, tests
// that never ran (objectui#6768 / #6849).
...(await importOriginal<Record<string, unknown>>()),
SchemaRenderer: ({ data }: any) => {
if (Array.isArray(data)) delivered.push(data);
return <div data-testid="schema-renderer" />;
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
test(tooling): ratchet the vi.mock factories that must inherit the real export surface by os-sam · Pull Request #6894 · objectstack-ai/objectui · GitHub
Skip to content
test(tooling): ratchet the vi.mock factories that must inherit the real export surface#6894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-sam
merged 3 commits into

from

Aug 30, 2026
 Merged


test(tooling): ratchet the vi.mock factories that must inherit the real export surface
#6894
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
a6f502f

test(tooling): ratchet the vi.mock factories that must inherit the re…


claude Aug 30, 2026
7c104d1

chore(tooling): declare the changeset and fix the suite's inferred re…


claude Aug 30, 2026
c935289

docs(tooling): point the guard's cross-references at the filed findings


claude Aug 30, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


10 changes: 10 additions & 0 deletions
.changeset/vi-mock-inherit-guard-6849.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
---
---

Test/tooling only; nothing published changes.

Adds `scripts/check-vi-mock-inherit.mjs`, a ratchet that rejects a `vi.mock` factory
which hand-lists the exports of a covered workspace specifier instead of inheriting the
real module's export surface. The only `src/` file it touches is a plugin-view test
file, converted to the inheriting form — no runtime behaviour, no public API, no
published output changes.

35 changes: 35 additions & 0 deletions
.github/workflows/vi-mock-specifiers.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,20 @@
name: Inert vi.mock Specifiers

# Two gates over ONE population, in one home. Both read the `vi.mock` call sites
# of this tree and both catch a mock that is silently not doing what it looks
# like it is doing: `check-vi-mock-specifiers.mjs` catches a specifier that
# resolves to no file (an inert stand-in), and `check-vi-mock-inherit.mjs`
# catches a factory that hand-lists its exports (a frozen export surface,
# objectui#6849). They share the call-site pattern deliberately -- a population
# that drifted between them would be a hole neither one reports -- so they share
# a workflow rather than each registering a required context of its own.
#
# The workflow `name:` and the job `name:` are therefore BROADER than the older
# of the two gates. They are left unchanged on purpose: those two strings are
# the check-run context that branch protection and
# `scripts/dependabot-merge-gate.mjs` name, and renaming a required context
# silently un-requires it.
#
# Why this is its own workflow rather than a step in `ci.yml` or `lint.yml`: a
# module mock can be written into any package, in any shape of pull request, and
# both of those workflows decide inside the job whether the change "needs a full
Expand DownExpand Up@@ -79,3 +94,23 @@ jobs:
 # gate's own defect one level up.
 - name: Check every relative vi.mock specifier resolves
 run: node scripts/check-vi-mock-specifiers.mjs

 # The sibling property of the same call sites: a factory that HAND-LISTS
 # the exports it returns freezes the mock's export surface. The next
 # export any module in the file's import graph reads AT MODULE SCOPE then
 # kills the file during COLLECTION -- `Test Files 3 failed | 546 passed`
 # with `Tests 6694 passed`, ZERO failed assertions, because the tests in
 # those files never ran (objectui#6768). It reads as flake to whoever
 # sees it next, and the bill lands on whoever added the export.
 #
 # The recogniser is SEMANTIC, never a grep for `importOriginal`: that
 # spelling mis-counted eleven correct files as broken AND missed one
 # broken file entirely (objectui#6849). It asks whether the factory
 # OBTAINS the real module -- a callback parameter under any name, or
 # `vi.importActual` of the same specifier -- and SPREADS it.
 #
 # Narrow by ruling: only the covered workspace specifiers in
 # `COVERED_SPECIFIERS` are judged. Whole-module replacement of a local
 # module is legitimate and out of scope by construction, not by exemption.
 - name: Check every covered vi.mock factory inherits the real export surface
 run: node scripts/check-vi-mock-inherit.mjs

1 change: 1 addition & 0 deletions
package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -66,6 +66,7 @@
 "governed": "node scripts/check-governed-queue-guard.mjs --test",
 "check:pre-install-import-graph": "node scripts/check-pre-install-import-graph.mjs",
 "check:vi-mock-specifiers": "node scripts/check-vi-mock-specifiers.mjs",
 "check:vi-mock-inherit": "node scripts/check-vi-mock-inherit.mjs",
 "check:shell-escape-residue": "node scripts/check-shell-escape-residue.mjs",
 "check:readme-exports": "node scripts/check-readme-exports.mjs",
 "cli": "node packages/cli/dist/cli.js",
Expand Down

8 changes: 7 additions & 1 deletion
packages/plugin-view/src/__tests__/ObjectView.contractEnvelope-6726.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -42,9 +42,15 @@ import type { ObjectViewSchema } from '@object-ui/types';
/** Every `data` prop the view handed to SchemaRenderer, in order. */
const delivered: unknown[][] = [];

vi.mock('@object-ui/react', async () => {
vi.mock('@object-ui/react', async (importOriginal) => {
 const React = await import('react');
 return {
 // Inherit the real export surface, then override only what this pin reads.
 // A hand-listed factory freezes the mock at whatever was typed that day, and
 // the next export any module in this file's import graph reads at module
 // scope kills the file during COLLECTION -- zero failed assertions, tests
 // that never ran (objectui#6768 / #6849).
 ...(await importOriginal<Record<string, unknown>>()),
 SchemaRenderer: ({ data }: any) => {
 if (Array.isArray(data)) delivered.push(data);
 return <div data-testid="schema-renderer" />;
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
test(tooling): ratchet the vi.mock factories that must inherit the real export surface by os-sam · Pull Request #6894 · objectstack-ai/objectui · GitHub
Skip to content
test(tooling): ratchet the vi.mock factories that must inherit the real export surface#6894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-sam
merged 3 commits into

from

Aug 30, 2026
 Merged


test(tooling): ratchet the vi.mock factories that must inherit the real export surface
#6894
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
a6f502f

test(tooling): ratchet the vi.mock factories that must inherit the re…


claude Aug 30, 2026
7c104d1

chore(tooling): declare the changeset and fix the suite's inferred re…


claude Aug 30, 2026
c935289

docs(tooling): point the guard's cross-references at the filed findings


claude Aug 30, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


10 changes: 10 additions & 0 deletions
.changeset/vi-mock-inherit-guard-6849.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
---
---

Test/tooling only; nothing published changes.

Adds `scripts/check-vi-mock-inherit.mjs`, a ratchet that rejects a `vi.mock` factory
which hand-lists the exports of a covered workspace specifier instead of inheriting the
real module's export surface. The only `src/` file it touches is a plugin-view test
file, converted to the inheriting form — no runtime behaviour, no public API, no
published output changes.

35 changes: 35 additions & 0 deletions
.github/workflows/vi-mock-specifiers.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,20 @@
name: Inert vi.mock Specifiers

# Two gates over ONE population, in one home. Both read the `vi.mock` call sites
# of this tree and both catch a mock that is silently not doing what it looks
# like it is doing: `check-vi-mock-specifiers.mjs` catches a specifier that
# resolves to no file (an inert stand-in), and `check-vi-mock-inherit.mjs`
# catches a factory that hand-lists its exports (a frozen export surface,
# objectui#6849). They share the call-site pattern deliberately -- a population
# that drifted between them would be a hole neither one reports -- so they share
# a workflow rather than each registering a required context of its own.
#
# The workflow `name:` and the job `name:` are therefore BROADER than the older
# of the two gates. They are left unchanged on purpose: those two strings are
# the check-run context that branch protection and
# `scripts/dependabot-merge-gate.mjs` name, and renaming a required context
# silently un-requires it.
#
# Why this is its own workflow rather than a step in `ci.yml` or `lint.yml`: a
# module mock can be written into any package, in any shape of pull request, and
# both of those workflows decide inside the job whether the change "needs a full
Expand DownExpand Up@@ -79,3 +94,23 @@ jobs:
 # gate's own defect one level up.
 - name: Check every relative vi.mock specifier resolves
 run: node scripts/check-vi-mock-specifiers.mjs

 # The sibling property of the same call sites: a factory that HAND-LISTS
 # the exports it returns freezes the mock's export surface. The next
 # export any module in the file's import graph reads AT MODULE SCOPE then
 # kills the file during COLLECTION -- `Test Files 3 failed | 546 passed`
 # with `Tests 6694 passed`, ZERO failed assertions, because the tests in
 # those files never ran (objectui#6768). It reads as flake to whoever
 # sees it next, and the bill lands on whoever added the export.
 #
 # The recogniser is SEMANTIC, never a grep for `importOriginal`: that
 # spelling mis-counted eleven correct files as broken AND missed one
 # broken file entirely (objectui#6849). It asks whether the factory
 # OBTAINS the real module -- a callback parameter under any name, or
 # `vi.importActual` of the same specifier -- and SPREADS it.
 #
 # Narrow by ruling: only the covered workspace specifiers in
 # `COVERED_SPECIFIERS` are judged. Whole-module replacement of a local
 # module is legitimate and out of scope by construction, not by exemption.
 - name: Check every covered vi.mock factory inherits the real export surface
 run: node scripts/check-vi-mock-inherit.mjs

1 change: 1 addition & 0 deletions
package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -66,6 +66,7 @@
 "governed": "node scripts/check-governed-queue-guard.mjs --test",
 "check:pre-install-import-graph": "node scripts/check-pre-install-import-graph.mjs",
 "check:vi-mock-specifiers": "node scripts/check-vi-mock-specifiers.mjs",
 "check:vi-mock-inherit": "node scripts/check-vi-mock-inherit.mjs",
 "check:shell-escape-residue": "node scripts/check-shell-escape-residue.mjs",
 "check:readme-exports": "node scripts/check-readme-exports.mjs",
 "cli": "node packages/cli/dist/cli.js",
Expand Down

8 changes: 7 additions & 1 deletion
packages/plugin-view/src/__tests__/ObjectView.contractEnvelope-6726.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -42,9 +42,15 @@ import type { ObjectViewSchema } from '@object-ui/types';
/** Every `data` prop the view handed to SchemaRenderer, in order. */
const delivered: unknown[][] = [];

vi.mock('@object-ui/react', async () => {
vi.mock('@object-ui/react', async (importOriginal) => {
 const React = await import('react');
 return {
 // Inherit the real export surface, then override only what this pin reads.
 // A hand-listed factory freezes the mock at whatever was typed that day, and
 // the next export any module in this file's import graph reads at module
 // scope kills the file during COLLECTION -- zero failed assertions, tests
 // that never ran (objectui#6768 / #6849).
 ...(await importOriginal<Record<string, unknown>>()),
 SchemaRenderer: ({ data }: any) => {
 if (Array.isArray(data)) delivered.push(data);
 return <div data-testid="schema-renderer" />;
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
test(tooling): ratchet the vi.mock factories that must inherit the real export surface by os-sam · Pull Request #6894 · objectstack-ai/objectui · GitHub
Skip to content
test(tooling): ratchet the vi.mock factories that must inherit the real export surface#6894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-sam
merged 3 commits into

from

Aug 30, 2026
 Merged


test(tooling): ratchet the vi.mock factories that must inherit the real export surface
#6894
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
a6f502f

test(tooling): ratchet the vi.mock factories that must inherit the re…


claude Aug 30, 2026
7c104d1

chore(tooling): declare the changeset and fix the suite's inferred re…


claude Aug 30, 2026
c935289

docs(tooling): point the guard's cross-references at the filed findings


claude Aug 30, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


10 changes: 10 additions & 0 deletions
.changeset/vi-mock-inherit-guard-6849.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
---
---

Test/tooling only; nothing published changes.

Adds `scripts/check-vi-mock-inherit.mjs`, a ratchet that rejects a `vi.mock` factory
which hand-lists the exports of a covered workspace specifier instead of inheriting the
real module's export surface. The only `src/` file it touches is a plugin-view test
file, converted to the inheriting form — no runtime behaviour, no public API, no
published output changes.

35 changes: 35 additions & 0 deletions
.github/workflows/vi-mock-specifiers.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,20 @@
name: Inert vi.mock Specifiers

# Two gates over ONE population, in one home. Both read the `vi.mock` call sites
# of this tree and both catch a mock that is silently not doing what it looks
# like it is doing: `check-vi-mock-specifiers.mjs` catches a specifier that
# resolves to no file (an inert stand-in), and `check-vi-mock-inherit.mjs`
# catches a factory that hand-lists its exports (a frozen export surface,
# objectui#6849). They share the call-site pattern deliberately -- a population
# that drifted between them would be a hole neither one reports -- so they share
# a workflow rather than each registering a required context of its own.
#
# The workflow `name:` and the job `name:` are therefore BROADER than the older
# of the two gates. They are left unchanged on purpose: those two strings are
# the check-run context that branch protection and
# `scripts/dependabot-merge-gate.mjs` name, and renaming a required context
# silently un-requires it.
#
# Why this is its own workflow rather than a step in `ci.yml` or `lint.yml`: a
# module mock can be written into any package, in any shape of pull request, and
# both of those workflows decide inside the job whether the change "needs a full
Expand DownExpand Up@@ -79,3 +94,23 @@ jobs:
 # gate's own defect one level up.
 - name: Check every relative vi.mock specifier resolves
 run: node scripts/check-vi-mock-specifiers.mjs

 # The sibling property of the same call sites: a factory that HAND-LISTS
 # the exports it returns freezes the mock's export surface. The next
 # export any module in the file's import graph reads AT MODULE SCOPE then
 # kills the file during COLLECTION -- `Test Files 3 failed | 546 passed`
 # with `Tests 6694 passed`, ZERO failed assertions, because the tests in
 # those files never ran (objectui#6768). It reads as flake to whoever
 # sees it next, and the bill lands on whoever added the export.
 #
 # The recogniser is SEMANTIC, never a grep for `importOriginal`: that
 # spelling mis-counted eleven correct files as broken AND missed one
 # broken file entirely (objectui#6849). It asks whether the factory
 # OBTAINS the real module -- a callback parameter under any name, or
 # `vi.importActual` of the same specifier -- and SPREADS it.
 #
 # Narrow by ruling: only the covered workspace specifiers in
 # `COVERED_SPECIFIERS` are judged. Whole-module replacement of a local
 # module is legitimate and out of scope by construction, not by exemption.
 - name: Check every covered vi.mock factory inherits the real export surface
 run: node scripts/check-vi-mock-inherit.mjs

1 change: 1 addition & 0 deletions
package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -66,6 +66,7 @@
 "governed": "node scripts/check-governed-queue-guard.mjs --test",
 "check:pre-install-import-graph": "node scripts/check-pre-install-import-graph.mjs",
 "check:vi-mock-specifiers": "node scripts/check-vi-mock-specifiers.mjs",
 "check:vi-mock-inherit": "node scripts/check-vi-mock-inherit.mjs",
 "check:shell-escape-residue": "node scripts/check-shell-escape-residue.mjs",
 "check:readme-exports": "node scripts/check-readme-exports.mjs",
 "cli": "node packages/cli/dist/cli.js",
Expand Down

8 changes: 7 additions & 1 deletion
packages/plugin-view/src/__tests__/ObjectView.contractEnvelope-6726.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -42,9 +42,15 @@ import type { ObjectViewSchema } from '@object-ui/types';
/** Every `data` prop the view handed to SchemaRenderer, in order. */
const delivered: unknown[][] = [];

vi.mock('@object-ui/react', async () => {
vi.mock('@object-ui/react', async (importOriginal) => {
 const React = await import('react');
 return {
 // Inherit the real export surface, then override only what this pin reads.
 // A hand-listed factory freezes the mock at whatever was typed that day, and
 // the next export any module in this file's import graph reads at module
 // scope kills the file during COLLECTION -- zero failed assertions, tests
 // that never ran (objectui#6768 / #6849).
 ...(await importOriginal<Record<string, unknown>>()),
 SchemaRenderer: ({ data }: any) => {
 if (Array.isArray(data)) delivered.push(data);
 return <div data-testid="schema-renderer" />;
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
test(tooling): ratchet the vi.mock factories that must inherit the real export surface by os-sam · Pull Request #6894 · objectstack-ai/objectui · GitHub
Skip to content
test(tooling): ratchet the vi.mock factories that must inherit the real export surface#6894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-sam
merged 3 commits into

from

Aug 30, 2026
 Merged


test(tooling): ratchet the vi.mock factories that must inherit the real export surface
#6894
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
a6f502f

test(tooling): ratchet the vi.mock factories that must inherit the re…


claude Aug 30, 2026
7c104d1

chore(tooling): declare the changeset and fix the suite's inferred re…


claude Aug 30, 2026
c935289

docs(tooling): point the guard's cross-references at the filed findings


claude Aug 30, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


10 changes: 10 additions & 0 deletions
.changeset/vi-mock-inherit-guard-6849.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
---
---

Test/tooling only; nothing published changes.

Adds `scripts/check-vi-mock-inherit.mjs`, a ratchet that rejects a `vi.mock` factory
which hand-lists the exports of a covered workspace specifier instead of inheriting the
real module's export surface. The only `src/` file it touches is a plugin-view test
file, converted to the inheriting form — no runtime behaviour, no public API, no
published output changes.

35 changes: 35 additions & 0 deletions
.github/workflows/vi-mock-specifiers.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,20 @@
name: Inert vi.mock Specifiers

# Two gates over ONE population, in one home. Both read the `vi.mock` call sites
# of this tree and both catch a mock that is silently not doing what it looks
# like it is doing: `check-vi-mock-specifiers.mjs` catches a specifier that
# resolves to no file (an inert stand-in), and `check-vi-mock-inherit.mjs`
# catches a factory that hand-lists its exports (a frozen export surface,
# objectui#6849). They share the call-site pattern deliberately -- a population
# that drifted between them would be a hole neither one reports -- so they share
# a workflow rather than each registering a required context of its own.
#
# The workflow `name:` and the job `name:` are therefore BROADER than the older
# of the two gates. They are left unchanged on purpose: those two strings are
# the check-run context that branch protection and
# `scripts/dependabot-merge-gate.mjs` name, and renaming a required context
# silently un-requires it.
#
# Why this is its own workflow rather than a step in `ci.yml` or `lint.yml`: a
# module mock can be written into any package, in any shape of pull request, and
# both of those workflows decide inside the job whether the change "needs a full
Expand DownExpand Up@@ -79,3 +94,23 @@ jobs:
 # gate's own defect one level up.
 - name: Check every relative vi.mock specifier resolves
 run: node scripts/check-vi-mock-specifiers.mjs

 # The sibling property of the same call sites: a factory that HAND-LISTS
 # the exports it returns freezes the mock's export surface. The next
 # export any module in the file's import graph reads AT MODULE SCOPE then
 # kills the file during COLLECTION -- `Test Files 3 failed | 546 passed`
 # with `Tests 6694 passed`, ZERO failed assertions, because the tests in
 # those files never ran (objectui#6768). It reads as flake to whoever
 # sees it next, and the bill lands on whoever added the export.
 #
 # The recogniser is SEMANTIC, never a grep for `importOriginal`: that
 # spelling mis-counted eleven correct files as broken AND missed one
 # broken file entirely (objectui#6849). It asks whether the factory
 # OBTAINS the real module -- a callback parameter under any name, or
 # `vi.importActual` of the same specifier -- and SPREADS it.
 #
 # Narrow by ruling: only the covered workspace specifiers in
 # `COVERED_SPECIFIERS` are judged. Whole-module replacement of a local
 # module is legitimate and out of scope by construction, not by exemption.
 - name: Check every covered vi.mock factory inherits the real export surface
 run: node scripts/check-vi-mock-inherit.mjs

1 change: 1 addition & 0 deletions
package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -66,6 +66,7 @@
 "governed": "node scripts/check-governed-queue-guard.mjs --test",
 "check:pre-install-import-graph": "node scripts/check-pre-install-import-graph.mjs",
 "check:vi-mock-specifiers": "node scripts/check-vi-mock-specifiers.mjs",
 "check:vi-mock-inherit": "node scripts/check-vi-mock-inherit.mjs",
 "check:shell-escape-residue": "node scripts/check-shell-escape-residue.mjs",
 "check:readme-exports": "node scripts/check-readme-exports.mjs",
 "cli": "node packages/cli/dist/cli.js",
Expand Down

8 changes: 7 additions & 1 deletion
packages/plugin-view/src/__tests__/ObjectView.contractEnvelope-6726.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -42,9 +42,15 @@ import type { ObjectViewSchema } from '@object-ui/types';
/** Every `data` prop the view handed to SchemaRenderer, in order. */
const delivered: unknown[][] = [];

vi.mock('@object-ui/react', async () => {
vi.mock('@object-ui/react', async (importOriginal) => {
 const React = await import('react');
 return {
 // Inherit the real export surface, then override only what this pin reads.
 // A hand-listed factory freezes the mock at whatever was typed that day, and
 // the next export any module in this file's import graph reads at module
 // scope kills the file during COLLECTION -- zero failed assertions, tests
 // that never ran (objectui#6768 / #6849).
 ...(await importOriginal<Record<string, unknown>>()),
 SchemaRenderer: ({ data }: any) => {
 if (Array.isArray(data)) delivered.push(data);
 return <div data-testid="schema-renderer" />;
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
test(tooling): ratchet the vi.mock factories that must inherit the real export surface by os-sam · Pull Request #6894 · objectstack-ai/objectui · GitHub
Skip to content
test(tooling): ratchet the vi.mock factories that must inherit the real export surface#6894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-sam
merged 3 commits into

from

Aug 30, 2026
 Merged


test(tooling): ratchet the vi.mock factories that must inherit the real export surface
#6894
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
a6f502f

test(tooling): ratchet the vi.mock factories that must inherit the re…


claude Aug 30, 2026
7c104d1

chore(tooling): declare the changeset and fix the suite's inferred re…


claude Aug 30, 2026
c935289

docs(tooling): point the guard's cross-references at the filed findings


claude Aug 30, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


10 changes: 10 additions & 0 deletions
.changeset/vi-mock-inherit-guard-6849.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
---
---

Test/tooling only; nothing published changes.

Adds `scripts/check-vi-mock-inherit.mjs`, a ratchet that rejects a `vi.mock` factory
which hand-lists the exports of a covered workspace specifier instead of inheriting the
real module's export surface. The only `src/` file it touches is a plugin-view test
file, converted to the inheriting form — no runtime behaviour, no public API, no
published output changes.

35 changes: 35 additions & 0 deletions
.github/workflows/vi-mock-specifiers.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,20 @@
name: Inert vi.mock Specifiers

# Two gates over ONE population, in one home. Both read the `vi.mock` call sites
# of this tree and both catch a mock that is silently not doing what it looks
# like it is doing: `check-vi-mock-specifiers.mjs` catches a specifier that
# resolves to no file (an inert stand-in), and `check-vi-mock-inherit.mjs`
# catches a factory that hand-lists its exports (a frozen export surface,
# objectui#6849). They share the call-site pattern deliberately -- a population
# that drifted between them would be a hole neither one reports -- so they share
# a workflow rather than each registering a required context of its own.
#
# The workflow `name:` and the job `name:` are therefore BROADER than the older
# of the two gates. They are left unchanged on purpose: those two strings are
# the check-run context that branch protection and
# `scripts/dependabot-merge-gate.mjs` name, and renaming a required context
# silently un-requires it.
#
# Why this is its own workflow rather than a step in `ci.yml` or `lint.yml`: a
# module mock can be written into any package, in any shape of pull request, and
# both of those workflows decide inside the job whether the change "needs a full
Expand DownExpand Up@@ -79,3 +94,23 @@ jobs:
 # gate's own defect one level up.
 - name: Check every relative vi.mock specifier resolves
 run: node scripts/check-vi-mock-specifiers.mjs

 # The sibling property of the same call sites: a factory that HAND-LISTS
 # the exports it returns freezes the mock's export surface. The next
 # export any module in the file's import graph reads AT MODULE SCOPE then
 # kills the file during COLLECTION -- `Test Files 3 failed | 546 passed`
 # with `Tests 6694 passed`, ZERO failed assertions, because the tests in
 # those files never ran (objectui#6768). It reads as flake to whoever
 # sees it next, and the bill lands on whoever added the export.
 #
 # The recogniser is SEMANTIC, never a grep for `importOriginal`: that
 # spelling mis-counted eleven correct files as broken AND missed one
 # broken file entirely (objectui#6849). It asks whether the factory
 # OBTAINS the real module -- a callback parameter under any name, or
 # `vi.importActual` of the same specifier -- and SPREADS it.
 #
 # Narrow by ruling: only the covered workspace specifiers in
 # `COVERED_SPECIFIERS` are judged. Whole-module replacement of a local
 # module is legitimate and out of scope by construction, not by exemption.
 - name: Check every covered vi.mock factory inherits the real export surface
 run: node scripts/check-vi-mock-inherit.mjs

1 change: 1 addition & 0 deletions
package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -66,6 +66,7 @@
 "governed": "node scripts/check-governed-queue-guard.mjs --test",
 "check:pre-install-import-graph": "node scripts/check-pre-install-import-graph.mjs",
 "check:vi-mock-specifiers": "node scripts/check-vi-mock-specifiers.mjs",
 "check:vi-mock-inherit": "node scripts/check-vi-mock-inherit.mjs",
 "check:shell-escape-residue": "node scripts/check-shell-escape-residue.mjs",
 "check:readme-exports": "node scripts/check-readme-exports.mjs",
 "cli": "node packages/cli/dist/cli.js",
Expand Down

8 changes: 7 additions & 1 deletion
packages/plugin-view/src/__tests__/ObjectView.contractEnvelope-6726.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -42,9 +42,15 @@ import type { ObjectViewSchema } from '@object-ui/types';
/** Every `data` prop the view handed to SchemaRenderer, in order. */
const delivered: unknown[][] = [];

vi.mock('@object-ui/react', async () => {
vi.mock('@object-ui/react', async (importOriginal) => {
 const React = await import('react');
 return {
 // Inherit the real export surface, then override only what this pin reads.
 // A hand-listed factory freezes the mock at whatever was typed that day, and
 // the next export any module in this file's import graph reads at module
 // scope kills the file during COLLECTION -- zero failed assertions, tests
 // that never ran (objectui#6768 / #6849).
 ...(await importOriginal<Record<string, unknown>>()),
 SchemaRenderer: ({ data }: any) => {
 if (Array.isArray(data)) delivered.push(data);
 return <div data-testid="schema-renderer" />;
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
test(tooling): ratchet the vi.mock factories that must inherit the real export surface by os-sam · Pull Request #6894 · objectstack-ai/objectui · GitHub
Skip to content
test(tooling): ratchet the vi.mock factories that must inherit the real export surface#6894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-sam
merged 3 commits into

from

Aug 30, 2026
 Merged


test(tooling): ratchet the vi.mock factories that must inherit the real export surface
#6894
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
a6f502f

test(tooling): ratchet the vi.mock factories that must inherit the re…


claude Aug 30, 2026
7c104d1

chore(tooling): declare the changeset and fix the suite's inferred re…


claude Aug 30, 2026
c935289

docs(tooling): point the guard's cross-references at the filed findings


claude Aug 30, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


10 changes: 10 additions & 0 deletions
.changeset/vi-mock-inherit-guard-6849.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
---
---

Test/tooling only; nothing published changes.

Adds `scripts/check-vi-mock-inherit.mjs`, a ratchet that rejects a `vi.mock` factory
which hand-lists the exports of a covered workspace specifier instead of inheriting the
real module's export surface. The only `src/` file it touches is a plugin-view test
file, converted to the inheriting form — no runtime behaviour, no public API, no
published output changes.

35 changes: 35 additions & 0 deletions
.github/workflows/vi-mock-specifiers.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,20 @@
name: Inert vi.mock Specifiers

# Two gates over ONE population, in one home. Both read the `vi.mock` call sites
# of this tree and both catch a mock that is silently not doing what it looks
# like it is doing: `check-vi-mock-specifiers.mjs` catches a specifier that
# resolves to no file (an inert stand-in), and `check-vi-mock-inherit.mjs`
# catches a factory that hand-lists its exports (a frozen export surface,
# objectui#6849). They share the call-site pattern deliberately -- a population
# that drifted between them would be a hole neither one reports -- so they share
# a workflow rather than each registering a required context of its own.
#
# The workflow `name:` and the job `name:` are therefore BROADER than the older
# of the two gates. They are left unchanged on purpose: those two strings are
# the check-run context that branch protection and
# `scripts/dependabot-merge-gate.mjs` name, and renaming a required context
# silently un-requires it.
#
# Why this is its own workflow rather than a step in `ci.yml` or `lint.yml`: a
# module mock can be written into any package, in any shape of pull request, and
# both of those workflows decide inside the job whether the change "needs a full
Expand DownExpand Up@@ -79,3 +94,23 @@ jobs:
 # gate's own defect one level up.
 - name: Check every relative vi.mock specifier resolves
 run: node scripts/check-vi-mock-specifiers.mjs

 # The sibling property of the same call sites: a factory that HAND-LISTS
 # the exports it returns freezes the mock's export surface. The next
 # export any module in the file's import graph reads AT MODULE SCOPE then
 # kills the file during COLLECTION -- `Test Files 3 failed | 546 passed`
 # with `Tests 6694 passed`, ZERO failed assertions, because the tests in
 # those files never ran (objectui#6768). It reads as flake to whoever
 # sees it next, and the bill lands on whoever added the export.
 #
 # The recogniser is SEMANTIC, never a grep for `importOriginal`: that
 # spelling mis-counted eleven correct files as broken AND missed one
 # broken file entirely (objectui#6849). It asks whether the factory
 # OBTAINS the real module -- a callback parameter under any name, or
 # `vi.importActual` of the same specifier -- and SPREADS it.
 #
 # Narrow by ruling: only the covered workspace specifiers in
 # `COVERED_SPECIFIERS` are judged. Whole-module replacement of a local
 # module is legitimate and out of scope by construction, not by exemption.
 - name: Check every covered vi.mock factory inherits the real export surface
 run: node scripts/check-vi-mock-inherit.mjs

1 change: 1 addition & 0 deletions
package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -66,6 +66,7 @@
 "governed": "node scripts/check-governed-queue-guard.mjs --test",
 "check:pre-install-import-graph": "node scripts/check-pre-install-import-graph.mjs",
 "check:vi-mock-specifiers": "node scripts/check-vi-mock-specifiers.mjs",
 "check:vi-mock-inherit": "node scripts/check-vi-mock-inherit.mjs",
 "check:shell-escape-residue": "node scripts/check-shell-escape-residue.mjs",
 "check:readme-exports": "node scripts/check-readme-exports.mjs",
 "cli": "node packages/cli/dist/cli.js",
Expand Down

8 changes: 7 additions & 1 deletion
packages/plugin-view/src/__tests__/ObjectView.contractEnvelope-6726.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -42,9 +42,15 @@ import type { ObjectViewSchema } from '@object-ui/types';
/** Every `data` prop the view handed to SchemaRenderer, in order. */
const delivered: unknown[][] = [];

vi.mock('@object-ui/react', async () => {
vi.mock('@object-ui/react', async (importOriginal) => {
 const React = await import('react');
 return {
 // Inherit the real export surface, then override only what this pin reads.
 // A hand-listed factory freezes the mock at whatever was typed that day, and
 // the next export any module in this file's import graph reads at module
 // scope kills the file during COLLECTION -- zero failed assertions, tests
 // that never ran (objectui#6768 / #6849).
 ...(await importOriginal<Record<string, unknown>>()),
 SchemaRenderer: ({ data }: any) => {
 if (Array.isArray(data)) delivered.push(data);
 return <div data-testid="schema-renderer" />;
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
test(tooling): ratchet the vi.mock factories that must inherit the real export surface by os-sam · Pull Request #6894 · objectstack-ai/objectui · GitHub
Skip to content
test(tooling): ratchet the vi.mock factories that must inherit the real export surface#6894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-sam
merged 3 commits into

from

Aug 30, 2026
 Merged


test(tooling): ratchet the vi.mock factories that must inherit the real export surface
#6894
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
a6f502f

test(tooling): ratchet the vi.mock factories that must inherit the re…


claude Aug 30, 2026
7c104d1

chore(tooling): declare the changeset and fix the suite's inferred re…


claude Aug 30, 2026
c935289

docs(tooling): point the guard's cross-references at the filed findings


claude Aug 30, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


10 changes: 10 additions & 0 deletions
.changeset/vi-mock-inherit-guard-6849.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
---
---

Test/tooling only; nothing published changes.

Adds `scripts/check-vi-mock-inherit.mjs`, a ratchet that rejects a `vi.mock` factory
which hand-lists the exports of a covered workspace specifier instead of inheriting the
real module's export surface. The only `src/` file it touches is a plugin-view test
file, converted to the inheriting form — no runtime behaviour, no public API, no
published output changes.

35 changes: 35 additions & 0 deletions
.github/workflows/vi-mock-specifiers.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,20 @@
name: Inert vi.mock Specifiers

# Two gates over ONE population, in one home. Both read the `vi.mock` call sites
# of this tree and both catch a mock that is silently not doing what it looks
# like it is doing: `check-vi-mock-specifiers.mjs` catches a specifier that
# resolves to no file (an inert stand-in), and `check-vi-mock-inherit.mjs`
# catches a factory that hand-lists its exports (a frozen export surface,
# objectui#6849). They share the call-site pattern deliberately -- a population
# that drifted between them would be a hole neither one reports -- so they share
# a workflow rather than each registering a required context of its own.
#
# The workflow `name:` and the job `name:` are therefore BROADER than the older
# of the two gates. They are left unchanged on purpose: those two strings are
# the check-run context that branch protection and
# `scripts/dependabot-merge-gate.mjs` name, and renaming a required context
# silently un-requires it.
#
# Why this is its own workflow rather than a step in `ci.yml` or `lint.yml`: a
# module mock can be written into any package, in any shape of pull request, and
# both of those workflows decide inside the job whether the change "needs a full
Expand DownExpand Up@@ -79,3 +94,23 @@ jobs:
 # gate's own defect one level up.
 - name: Check every relative vi.mock specifier resolves
 run: node scripts/check-vi-mock-specifiers.mjs

 # The sibling property of the same call sites: a factory that HAND-LISTS
 # the exports it returns freezes the mock's export surface. The next
 # export any module in the file's import graph reads AT MODULE SCOPE then
 # kills the file during COLLECTION -- `Test Files 3 failed | 546 passed`
 # with `Tests 6694 passed`, ZERO failed assertions, because the tests in
 # those files never ran (objectui#6768). It reads as flake to whoever
 # sees it next, and the bill lands on whoever added the export.
 #
 # The recogniser is SEMANTIC, never a grep for `importOriginal`: that
 # spelling mis-counted eleven correct files as broken AND missed one
 # broken file entirely (objectui#6849). It asks whether the factory
 # OBTAINS the real module -- a callback parameter under any name, or
 # `vi.importActual` of the same specifier -- and SPREADS it.
 #
 # Narrow by ruling: only the covered workspace specifiers in
 # `COVERED_SPECIFIERS` are judged. Whole-module replacement of a local
 # module is legitimate and out of scope by construction, not by exemption.
 - name: Check every covered vi.mock factory inherits the real export surface
 run: node scripts/check-vi-mock-inherit.mjs

1 change: 1 addition & 0 deletions
package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -66,6 +66,7 @@
 "governed": "node scripts/check-governed-queue-guard.mjs --test",
 "check:pre-install-import-graph": "node scripts/check-pre-install-import-graph.mjs",
 "check:vi-mock-specifiers": "node scripts/check-vi-mock-specifiers.mjs",
 "check:vi-mock-inherit": "node scripts/check-vi-mock-inherit.mjs",
 "check:shell-escape-residue": "node scripts/check-shell-escape-residue.mjs",
 "check:readme-exports": "node scripts/check-readme-exports.mjs",
 "cli": "node packages/cli/dist/cli.js",
Expand Down

8 changes: 7 additions & 1 deletion
packages/plugin-view/src/__tests__/ObjectView.contractEnvelope-6726.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -42,9 +42,15 @@ import type { ObjectViewSchema } from '@object-ui/types';
/** Every `data` prop the view handed to SchemaRenderer, in order. */
const delivered: unknown[][] = [];

vi.mock('@object-ui/react', async () => {
vi.mock('@object-ui/react', async (importOriginal) => {
 const React = await import('react');
 return {
 // Inherit the real export surface, then override only what this pin reads.
 // A hand-listed factory freezes the mock at whatever was typed that day, and
 // the next export any module in this file's import graph reads at module
 // scope kills the file during COLLECTION -- zero failed assertions, tests
 // that never ran (objectui#6768 / #6849).
 ...(await importOriginal<Record<string, unknown>>()),
 SchemaRenderer: ({ data }: any) => {
 if (Array.isArray(data)) delivered.push(data);
 return <div data-testid="schema-renderer" />;
Expand Down
Loading
Loading