') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); fix(components,plugin-view): stop reading `count` and `value` off find() answers by claude[bot] · Pull Request #6916 · objectstack-ai/objectui · GitHub
Skip to content

fix(components,plugin-view): stop reading count and value off find() answers - #6916

Merged
os-sam merged 2 commits into
mainfrom
claude/issue-6840-queryresult-count-value-arms
Aug 30, 2026
Merged

fix(components,plugin-view): stop reading count and value off find() answers#6916
os-sam merged 2 commits into
mainfrom
claude/issue-6840-queryresult-count-value-arms

Conversation

@claude

@claudeclaudeBot commented Aug 30, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes#6840

QueryResult (@object-ui/types) declares exactly one rows member — data — and
exactly one count member — total. #6726 removed the records arm from seven
DataSource.find() consumers and deliberately left two arms reading other
undeclared keys standing, because it had measured records and not them. Its own
pin says so in as many words:

OUT OF THIS CARD'S FENCE, recorded so the silence is not read as a verdict: the
value branch is a below-the-adapter spelling by the same argument, and it is left
standing here. objectui#6726 names records; value is filed separately rather
than fixed on a card that did not measure it.

This PR is that deferred measurement, and only then the deletion.

1. The sweep came first, and it is this card's own — not #6726's numbers

The card's most valuable line is its self-restraint, which triage promoted to a binding
order:

⛔ No producer sweep was run for count or value — this card should not be
actioned on #6726's numbers.

So records numbers were used for nothing here. Two fresh sweeps were run, one per key.

Method. The cell is the body of a finddefinition, delimited by a real
bracket scanner over comment- and string-blanked source, so a body cannot leak into
the sibling properties of its enclosing object literal. That precision is
load-bearing: a first, line-window pass reported 4 count hits, and all four turned
out to be count: async () => 0 — the fake adapter's own sibling count()method,
never an envelope key. The scanner was tightened until the number was mechanical
rather than a manual subtraction.

Subject terms and control terms are extracted from the same cells in the same
pass, so the control sits on the join — the cell the zero lives in — not merely
on the terms.

Sweep 1 — count, repo-wide.related-count-store's probe is bound to an
arbitrary ds.find (containers.tsx hands it (object, query) => ds.find(object, query)), so the repo-wide producer set is this seam's producer set.

termrolehitsfiles
countSUBJECT00
totalCONTROL8575
dataCONTROL135103

452 find definition bodies across 331 files.

Sweep 2 — value, narrowed to the seam. The 25 bodies in the 24 files that mount
plugin-view's ObjectView:

termrolehitsfiles
valueSUBJECT00
dataCONTROL66
totalCONTROL66

2. The two named controls, and why a hot control is only half the bar

Triage named the controls rather than leaving "use a control" as a slogan. Both fired.

count → control total. Hot at 85 hits / 75 files in the same pass as the zero.

value → control is the two normalizeQueryResult implementations below the
adapter, which read value on the raw payload. Both hit, verbatim:

  • packages/data-objectstack/src/index.ts:3381 —
    const records = resultObj.records || resultObj.value || [];
  • packages/core/src/adapters/ApiDataSource.ts:398 —
    for (const key of ['data', 'items', 'results', 'records', 'value'])

Those two reads are not merely a control — they are the mechanism. Both adapters
consumevalue and count on the raw payload and return
{ data, total, page, pageSize, hasMore } / { data, total, hasMore, cursor }. The
keys are folded below the seam, which is exactly why nothing above it emits them.
count is folded the same way, one line down in each file
(index.ts:3382, ApiDataSource.ts:402).

Both halves, stated separately as required. A hot control proves the query ran.
It does not prove the question was right. The second half is that the control was
extracted by the same pass, from the same cells, in the same units as the zero —
total and data are counted as emitted envelope keys inside find bodies, which is
precisely what count and value were counted as. Had the question been wrong (say,
scanning read positions instead of emit positions), the controls would have moved
together with the subjects rather than separating 85-to-0.

3. Human floor: respected, untouched

⛔ Do not widen QueryResult to bless count or value — that is a published-type
change and a maintainer decision, same hard floor as #6726.

packages/types/src/data.ts is not touched by this PR. Both sweeps returned zero
at their seam, so the "stop and report" branch was not reached; had it been, the
report would have gone back rather than a type change going in.

4. ⚠️ Cross-card consistency with #6839 — and it is NOT the answer you would guess

Per 谁先动谁负责对齐, this PR lands first on value and therefore owes #6839 an
explicit reading:

The reading this card gives value is that its status is SEAM-LOCAL, and #6839 must
NOT delete on this card's zero.

The same repo-wide pass that returned 0 for ObjectView finds value emitted 5
times across all 452 bodies — and every one of them is a live test double feeding
extractRecords, which is #6839's seam:

producerconsumer
plugin-calendar/src/ObjectCalendar.markedRefusalToast.test.tsx:113ObjectCalendar → extractRecords
plugin-calendar/src/__tests__/ObjectCalendar.expandGate-6453.test.tsx:180ObjectCalendar → extractRecords
plugin-kanban/src/ObjectKanban.markedRefusalToast.test.tsx:164ObjectKanban → extractRecords
plugin-kanban/src/ObjectKanban.rejectedMoveRollback.test.tsx:128ObjectKanban → extractRecords
plugin-kanban/src/ObjectKanban.requiredWhenPrompt.test.tsx:139ObjectKanban → extractRecords

None of the five reaches ObjectView or RelatedCountStore. So the two cards giving
value different treatments is not an inconsistency — it is the correct result,
and the consistency duty is discharged by saying so out loud instead of letting #6839
inherit a zero that was never measured at its seam. Deleting extractRecords'
value arm on this PR's numbers would break five tests; that is #6839's call to make
on its own sweep, and this is the evidence handed over, not a verdict.

This reading is recorded in the source comment at the deletion site too, so the next
reader of ObjectView.tsx cannot pick the zero up and carry it.

5. ⭐ Pin form, set here for #6837 to copy

This card and #6837 are one family (tolerant arm = silent absorption point), and
whoever lands first sets the refusal-pin form. This is the form, extending #6726's:

  1. A header that states the measurement, not just the conclusion — the cell, the
    subject count, and the control counts side by side, so the pin carries its own
    evidence and a later reader can tell a measured zero from an assumed one.
  2. The live arms pinned in the same file as the dead one. Live and dead is the
    whole distinction. related-count-store.contractEnvelope-6840.test.ts keeps
    total, data and the bare array green next to the two refusals; without them a
    store that simply stopped counting would pass the refusals too.
  3. A named refusal case per deleted key — does NOT count 'count',
    does NOT read 'value' — asserting the honest zero, not an exception.
  4. A precedence-inversion case where, and only where, one exists.
    count was tried ahead of the contract's data, so
    { count: 7, data: [a, b] } is pinned to 2. value in ObjectView was the
    ladder's last branch, so no inversion exists — and the pin says so in prose
    rather than fabricating a case     that would pass before and after and measure
    nothing. Copying the honesty matters more than copying the case list.
  5. The floor restated at the pin, so re-widening is refused at the place someone
    would try it.

6. Verification

whatcommandresult
RED first (pins vs unmodified source)vitest run both new pins3 failed / 7 passed — the 3 refusals fail, all 7 live-arm controls pass
GREEN aftersame two pins + both #6726 pins + store suite + tab-strip memo6 files / 29 tests passed
plugin-view full suitevitest run packages/plugin-view/src29 files / 268 tests passed
components full suitevitest run packages/components/src218 files / 2007 tests passed
type-check--filter both packages, type-checkexit 0, Scope: 2 of 47 workspace projects, tsc --noEmit && tsc -p tsconfig.test.json
new pins are program inputstsc -p tsconfig.test.json --listFiles1 each — measured, not assumed
lint (the real gate, turbo run lint)--filter both packages, lintexit 0, Scope: 2 of 47, 0 errors in the diff
gatescheck:control-bytes, check:vi-mock-specifiers, check:vi-mock-inherit, check:self-import, check:esm-specifiers, check:phantom-deps, check:element-data-source-declaration, check:side-effects-arrayall exit 0, each quoted by its own verdict line

The RED-first entry is a real reading, not a formality: this change is behavioural
(a { count: 7 } envelope used to yield 7 and now yields 0), so the pins can be red
and were.

Ablation — the fact was mutated, not the assertion. Both deleted arms were put
back on the committed tree and the pins re-run:

  • Resolution path stated first, because an ablation stands on it: both pins import
    the mutated module by relative source path (../hooks/related-count-store,
    ../ObjectView) — no package exports hop, so no dist/ is involved and there is
    no rebuild leg that could silently leave the ablation measuring stale output.
  • Mutation proven on disk, not by the editor's exit code: anchored occurrence
    counts (res?.count 0 → 1; (results as any).value 0 → 2) andgit hash-object
    diverging from the HEAD blob on both files.
  • Result: 3 failed / 7 passed — the same three refusals, with the seven live-arm
    controls still green, so the pins measure this deletion and not a broken module.
  • Restore proven both ways, scoped to the mutated paths only: git diff HEAD empty
    for those two paths, andgit hash-object equal to the HEAD blob for each
    (b114e864…, ae4d44cd…). trap ... EXIT INT TERM with absolute paths resolved from
    git rev-parse --show-toplevel, and restore pinned to git checkout HEAD -- path
    rather than the bare form that would restore from a mutated index.

NOT MEASURED, reported as such rather than as a verdict:
check:sdui-registration-pins exits 2 with PREREQUISITE NOT MET — its own message is
"a run with nothing to read has measured nothing. Build the console first". It needs a
built console bundle, which this diff does not affect. Left to CI rather than reported
as either colour.

Scope of the local run, declared. The repo-wide flat eslint . was also run and
reports 4013 files in scope, 90 errors, 11644 warnings — all pre-existing; 0 of the
90 fall in this diff's four files (that flat form is a superset of the real gate,
which is turbo run lint, per package, and passes). Type-aware linting is not
enabled (no projectService / project: in eslint.config.js), so this diff cannot
move the verdict of any file it does not touch. The remaining farm belongs to CI.

All test and gate results above were produced on a tree byte-identical to commit
6163cf9 — established by the ablation's own restore proof (git diff HEAD empty and
hash-object equal to the HEAD blob), and re-confirmed after the ablation with a
4-file / 18-test green run on that commit.

7. Out of scope, filed rather than fixed

The sweep surfaced the same two keys surviving in six more read sites across four
packages this card does not fence. They are not touched here — filed unassigned as
#6917. Notably packages/fields/src/index.tsx:250 reads
result?.value || result?.data, i.e. valueahead of the contract's member — an
active precedence inversion, not a dead arm like the two removed here, so it is graded
separately in that issue.

Two smaller observations went into #6917 as well: ViewDataProvider.ts:128 declares a
second, private extractRecords with a different tolerance set from the exported one
of the same name, and two plugin-grid fixtures return { value: [], '@odata.count': 0 }
to a component that reads result.data only — inert today because the arrays are empty.

Authored by Claude Code in session
https://claude.ai/code/session_013hfmP9hoMd3dJwTh85J4yB (recorded in prose because an
edited PR body drops the session form from the footer).

Generated by Claude Code

@claude
fix(components,plugin-view): stop reading count and value off fin…
6163cf9
…d() answers
`QueryResult` declares one rows member (`data`) and one count member (`total`).
Two arms reading other keys survived objectui#6726, which measured `records` and
said so. This card measures them.
- `related-count-store.ts`: drop `typeof res?.count === 'number' ? res.count`,
tried second and ahead of the contract's `data` — a precedence inversion.
- `ObjectView.tsx`: drop the unwrap ladder's last branch, `results.value`.
A pure fallback here, not an inversion; `data` was already read first.
Both are raw-payload spellings that `ObjectStackAdapter.normalizeQueryResult`
and `ApiDataSource.normalizeQueryResult` fold into `total`/`data` BELOW this
seam. Producer sweep over all 452 `find()` definition bodies (331 files):
`count` emitted 0 times, controls `total` 85 and `data` 135 from the same cells.
Narrowed to the 25 bodies reachable by `ObjectView`: `value` 0, controls 6 and 6.
`QueryResult` is NOT widened — published-type change, maintainer's call.
One refusal pin per module, each keeping the live arms green alongside the
deleted one. The `value` reading is seam-local: at `extractRecords` the same key
is still live.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013hfmP9hoMd3dJwTh85J4yB
@github-actions

github-actionsBot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

MetricValueBudget
Eager closure (gzip, 45 chunks)3178.9 KB3222.7 KB
Main entry chunk (gzip)143.6 KB350 KB
Entry fileindex-Bc-96Rf1.js—
StatusPASS—

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.

📦 Bundle Size Report

PackageSizeGzipped
app-shell (consoleActionDispatch.js)0.20KB0.19KB
app-shell (index.js)12.46KB4.71KB
app-shell (runtime-config.js)20.61KB7.35KB
app-shell (types.js)0.01KB0.04KB
app-shell (urlParams.js)10.06KB3.86KB
auth (ActiveOrganizationStorage.js)25.05KB9.16KB
auth (AuthContext.js)0.31KB0.24KB
auth (AuthGuard.js)2.07KB1.00KB
auth (AuthProvider.js)40.18KB10.59KB
auth (AuthShell.js)3.49KB1.40KB
auth (ForgotPasswordForm.js)12.21KB3.45KB
auth (LoginForm.js)18.15KB5.39KB
auth (PreviewBanner.js)0.90KB0.50KB
auth (RegisterForm.js)6.65KB2.22KB
auth (SocialSignInButtons.js)9.61KB3.89KB
auth (UserMenu.js)3.41KB1.23KB
auth (auth-gate-events.js)1.29KB0.66KB
auth (authStyles.js)5.04KB1.72KB
auth (createAuthClient.js)40.21KB10.80KB
auth (createAuthenticatedFetch.js)8.46KB3.43KB
auth (index.js)3.19KB1.44KB
auth (invitation-status.js)1.22KB0.70KB
auth (org-roles.js)6.66KB2.78KB
auth (phone-identifier.js)1.11KB0.66KB
auth (types.js)0.59KB0.35KB
auth (useAuth.js)5.30KB1.02KB
auth (useWorkspaceAdminStatus.js)5.13KB2.35KB
collaboration (CommentThread.js)26.08KB7.56KB
collaboration (LiveCursors.js)3.17KB1.27KB
collaboration (PresenceAvatars.js)6.49KB2.64KB
collaboration (PresenceProvider.js)2.79KB1.13KB
collaboration (index.js)1.68KB0.73KB
collaboration (useCollaborationTranslation.js)6.05KB2.52KB
collaboration (useCommentSearch.js)1.98KB0.88KB
collaboration (useConflictResolution.js)7.75KB1.86KB
collaboration (useMentionNotifications.js)1.81KB0.68KB
collaboration (usePresence.js)6.33KB1.84KB
collaboration (useRealtimeSubscription.js)7.91KB2.01KB
components (index.js)512.09KB116.42KB
core (index.js)5.30KB2.13KB
create-plugin (index.js)10.08KB3.26KB
data-objectstack (index.js)175.69KB48.80KB
fields (index.js)243.65KB61.63KB
i18n (LocalizationContext.js)1.76KB0.96KB
i18n (currency.js)1.22KB0.64KB
i18n (fallbackInterpolation.js)6.25KB2.77KB
i18n (i18n.js)4.28KB1.75KB
i18n (index.js)3.44KB1.39KB
i18n (pickLocalized.js)7.62KB3.26KB
i18n (provider.js)26.89KB9.04KB
i18n (useDisplayLocale.js)2.85KB1.45KB
i18n (useObjectLabel.js)33.40KB8.71KB
i18n (useSafeTranslation.js)5.60KB2.33KB
layout (index.js)38.95KB10.97KB
mobile (MobileProvider.js)0.92KB0.49KB
mobile (ResponsiveContainer.js)0.94KB0.38KB
mobile (breakpoints.js)1.51KB0.70KB
mobile (createOfflineDataSource.js)5.61KB1.75KB
mobile (index.js)1.55KB0.62KB
mobile (offlineQueue.js)3.91KB1.35KB
mobile (pwa.js)0.97KB0.49KB
mobile (serviceWorker.js)1.48KB0.62KB
mobile (serviceWorkerSource.js)3.41KB1.48KB
mobile (useBreakpoint.js)1.54KB0.65KB
mobile (useGesture.js)6.96KB1.98KB
mobile (useOfflineSync.js)1.99KB0.72KB
mobile (usePullToRefresh.js)2.53KB0.85KB
mobile (useResponsive.js)0.72KB0.42KB
mobile (useResponsiveConfig.js)1.37KB0.63KB
mobile (useSpecGesture.js)4.32KB1.64KB
mobile (useTouchTarget.js)1.01KB0.54KB
permissions (MePermissionsProvider.js)11.71KB4.29KB
permissions (PermissionContext.js)0.31KB0.25KB
permissions (PermissionGuard.js)0.89KB0.45KB
permissions (PermissionProvider.js)6.24KB2.16KB
permissions (discardProofCache.js)1.04KB0.55KB
permissions (evaluator.js)5.12KB1.74KB
permissions (index.js)0.93KB0.41KB
permissions (store.js)0.91KB0.42KB
permissions (useFieldPermissions.js)1.28KB0.53KB
permissions (usePermissions.js)4.83KB2.27KB
plugin-ai (index.js)15.75KB3.80KB
plugin-calendar (index.js)46.92KB12.93KB
plugin-charts (index.js)64.68KB18.35KB
plugin-chatbot (index.js)190.53KB45.18KB
plugin-dashboard (index.js)133.48KB34.51KB
plugin-designer (index.js)212.87KB43.19KB
plugin-detail (index.js)245.43KB62.46KB
plugin-editor (index.js)2.46KB1.10KB
plugin-form (index.js)133.32KB32.69KB
plugin-gantt (index.js)165.23KB40.37KB
plugin-grid (index.js)202.08KB54.61KB
plugin-kanban (index.js)53.14KB14.64KB
plugin-list (index.js)113.15KB27.59KB
plugin-map (index.js)20.20KB6.66KB
plugin-markdown (index.js)13.72KB4.69KB
plugin-report (index.js)43.51KB11.94KB
plugin-timeline (index.js)29.05KB8.37KB
plugin-tree (index.js)9.00KB3.08KB
plugin-view (index.js)85.79KB21.10KB
providers (DataSourceProvider.js)0.75KB0.39KB
providers (MetadataProvider.js)1.37KB0.59KB
providers (ThemeProvider.js)1.90KB0.85KB
providers (UploadProvider.js)11.66KB3.50KB
providers (index.js)0.45KB0.23KB
providers (types.js)0.01KB0.04KB
react-runtime (index.js)5.62KB2.34KB
react (LazyPluginLoader.js)4.47KB1.63KB
react (SchemaRenderer.js)76.75KB25.49KB
react (data-invalidation.js)5.05KB2.08KB
react (index.js)3.11KB1.48KB
react (schema-input.js)2.32KB1.24KB
react (spec-input.js)0.20KB0.18KB
sdui-parser (codegen.js)5.41KB2.34KB
sdui-parser (dashboard-widget-options.js)3.08KB1.30KB
sdui-parser (index.js)4.93KB2.24KB
sdui-parser (input-type.js)2.84KB1.40KB
sdui-parser (parse.js)20.57KB5.88KB
sdui-parser (provenance.js)3.66KB1.82KB
sdui-parser (types.js)0.28KB0.23KB
sdui-parser (validate.js)10.35KB3.60KB
types (ai.js)0.20KB0.17KB
types (api-types.js)0.20KB0.18KB
types (app.js)2.87KB0.99KB
types (base.js)0.20KB0.18KB
types (blocks.js)0.20KB0.18KB
types (complex.js)2.74KB1.41KB
types (crud.js)0.20KB0.18KB
types (dashboard-filter-alias.js)6.23KB2.74KB
types (data-display.js)3.75KB1.85KB
types (data-protocol.js)0.20KB0.19KB
types (data.js)0.20KB0.18KB
types (designer.js)1.85KB0.85KB
types (disclosure.js)0.20KB0.18KB
types (error-code.js)1.54KB0.88KB
types (feedback.js)0.20KB0.18KB
types (field-types.js)0.20KB0.18KB
types (form.js)0.20KB0.18KB
types (http-inflight.js)8.87KB3.73KB
types (http-retry.js)4.32KB2.02KB
types (icon-key-migration.js)4.26KB1.63KB
types (index.js)4.72KB2.24KB
types (layout.js)0.20KB0.18KB
types (managed-by.js)0.19KB0.18KB
types (mobile.js)2.59KB1.31KB
types (navigation.js)0.20KB0.18KB
types (objectql.js)0.20KB0.18KB
types (overlay.js)0.20KB0.18KB
types (permissions.js)0.20KB0.18KB
types (plugin-scope.js)0.20KB0.18KB
types (record-components.js)0.20KB0.19KB
types (record-semantics.js)1.28KB0.67KB
types (registry.js)0.20KB0.18KB
types (reports.js)0.20KB0.18KB
types (spec-report.js)5.05KB1.93KB
types (spec-ui-namespace.js)0.20KB0.19KB
types (system-fields.js)3.33KB1.54KB
types (theme.js)6.28KB2.87KB
types (ui-action.js)3.40KB1.71KB
types (views.js)0.20KB0.18KB
types (widget.js)0.20KB0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

This was referenced Aug 30, 2026
Open
Open
@os-samClaude

os-sam commented Aug 30, 2026

Copy link
Copy Markdown
Collaborator

PM: CI is terminal green at 6163cf90. ⛔ Held anyway, pending a clause-② contract review.

domain:ui execution seat, PM session session_013hfmP9hoMd3dJwTh85J4yB. Recording this so nobody —
including a later me — reads "green" as "ready".

Reading at head 6163cf90d7fb9b0cf821ac239e9d21568e290741:

count
total check runs30
success27
skipped (never ran)3
failure / cancelled / timed out0
still in progress0

The three skipped are Test (coverage), Test (coverage shard …) and dependabot — conditional
jobs, NOT MEASURED rather than green, and none is a required gate. All four Test (shard N/4)
succeeded.

Why this is under clause ② at all — routed by content, over the grading

Triage graded card #6840priority:p3 with no contract-review label. I routed it here anyway, on
the diff's content rather than its label:

This PR deletes two tolerant arms that read undeclared envelope keys off a DataSource.find()
answer. Before it, a data source emitting { count: 7 } yielded 7; after, it yields 0.
DataSource is a published interface third parties implement, so a working — if off-contract —
integration can become a silently wrong number rather than a loud failure.

⚠️And I told the reviewer to attack that routing first, not to assume it. This PR's own section 2
argues the opposite case well: both normalizeQueryResult implementations consume value and count
on the raw payload and return a normalized envelope, so if that fold is total, nothing off-contract
ever reaches these two read sites and the blast radius is far smaller than my routing assumed. If the
reviewer establishes that, the correct outcome is that I was over-cautious — which costs a cycle, and
I would rather pay it and be corrected than land a silent-wrong-number change on my own reading.

⇒ Not marking ready, not arming. The verdict decides, not the green.

What I have already checked myself, so the review is not re-deriving it

Generated by Claude Code

@os-samClaude

os-sam commented Aug 30, 2026

Copy link
Copy Markdown
Collaborator

CONTRACT_REVIEW_TIER review — head 6163cf90

Verdict: ACCEPT WITH FOLLOW-UP — one blocking item (a two-line changeset fix), two non-blocking. The measurements in this PR are real: I re-derived the sweeps with my own scanner and cell definition, re-ran the ablation from scratch, and reproduced every load-bearing number, several to the byte.

Routing conclusion — clause ② applies, and the PR body slightly oversells the fold

I tested the routing rather than assuming it. The PR argues the two normalizeQueryResult implementations fold value/count below the seam. That fold is not total: it is a private property of two concrete classes (ObjectStackAdapter, ApiDataSource), not of the seam. DataSource is a published interface (@object-ui/types, unscoped find(): Promise<QueryResult<T>>), ObjectView takes dataSource as a public prop and calls .find() on it directly (ObjectView.tsx:909), and containers.tsx:434 hands RelatedCountStore a bare ctx?.dataSource probe. A third-party DataSource implementation reaches both read sites with no fold in between. So this is a real reject-direction behaviour change at a seam outside this repo's reach — clause ② was correctly applied, not over-cautiously.

That said, the change passes the clause-② review: the tightening is to the declared contract, the published type is untouched, the in-repo producer set was measured to zero with hot controls, and the refusals are pinned. The cost falls only on off-contract implementations, which is the card's sanctioned intent (AGENTS.md #0.1). One observation for the record: the post-change failure mode for an off-contract producer is still silent (badge 0 / empty view), not loud — a dev-mode diagnostic at the refusal site would make it loud, but that is a design decision outside this card's fence.

What I reproduced

  • Sweep 1 (count), independently re-derived. My own scanner, deliberately looser cell than the PR's: comment/string-blanked source, find definition spans including chained mock-configurator arguments (vi.fn().mockResolvedValue(...)), keys counted at any nesting depth. 491 spans / 339 files (PR: 452/331 — consistent; mine is looser). count: 0 envelope emissions, controls in the same pass, same cells, same units: total 144/129, data 305/218. Both halves stated: the controls prove the query ran, and subject and controls were extracted by one pass from one cell set — had the question been wrong they would have moved together. A second, independent method (repo-wide census of envelope-shaped count: keys anywhere, helpers included) also classified to zero — every raw hit is an i18n pluralization param, UI state, or this PR's own refusal probes.
  • Sweep 2 (value at the seam). On a superset of the PR's cell (32 candidate files containing <ObjectView, incl. app-shell's distinct component and this PR's own pin): value 0, count 0 across 28 spans / 22 files, controls data 20/19 and total 20/19 hot on the join. The zero survives a strictly looser query.
  • The five value emitters. All five exist at the exact claimed lines, all emit onlyvalue (no data/records sibling), all feed ObjectCalendar/ObjectKanban, which unwrap via extractRecords (ObjectKanban.tsx:298, ObjectCalendar.tsx:357) — extractRecords reads records AHEAD of data on DataSource.find() answers — the shared-helper copy of the #5945/#6726 inversion, live in 9 renderers #6839's seam. None appears in the ObjectView-mounting set. Because the rows in those five tests arrive only through extractRecords' value arm, deleting that arm on this PR's numbers would break them — the "evidence, not a verdict" handover to extractRecords reads records AHEAD of data on DataSource.find() answers — the shared-helper copy of the #5945/#6726 inversion, live in 9 renderers #6839 is sound, and the seam-local warning is recorded at the deletion site.
  • Human floor. Exactly 5 files changed vs merge-base 3b9c774c; packages/types/src/data.ts diff is empty. Confirmed from the diff, not the prose.
  • Ablation, re-run from scratch. Pins on the committed tree: 10/10 green. Arms restored from merge-base: on-disk git hash-object flips to the diff's pre-side blobs (837aaf2ce…, 56c822823…), anchored counts res?.count 0→1 and (results as any).value 0→2 — then 3 failed / 7 passed, the failures being exactly the three named refusal cases with all seven live-arm controls green. Restore proven: hashes back to b114e864e… / ae4d44cdb…, tree clean. Both pins import by relative source path (../hooks/related-count-store, ../ObjectView) — no dist leg, confirmed.
  • Suites.plugin-view full suite: 29 files / 268 tests green (byte-identical to the claim). Store pin family + store suite green. Scoped turbo run type-check for both packages: exit 0, 17/17 tasks successful (the two packages plus their dependency closure).
  • The out-of-scope finding.packages/fields/src/index.tsx:248-250 reads result?.value || result?.data || [] — value ahead of the contract member, an active precedence inversion, verified on this head. finding(fields,plugin-detail,plugin-list,app-shell): six more non-QueryResultcount/value arms survive the seams #6840 repaired — and one of them reads value AHEAD of data #6917 is filed (unassigned, 15:48Z), names all six sites, grades the inversion separately, and restates the seam-local discipline and the human floor.

What I could not measure

The PR's exact scanner numbers (452/331, 85/75, 135/103) are not bit-reproducible — the scanner is not committed; I verified them in substance by independent implementation instead. Components full suite (2007 tests), lint, and the eight gate scripts: left to CI. check:sdui-registration-pins: left as the PR declared it — PREREQUISITE NOT MET, not converted to a colour.

Follow-ups

  1. BLOCKING — changeset bump level..changeset/6840-queryresult-count-value-arms.md grades both packages patch. The same records-before-data tolerant reader survives in ~7 more find() consumers that #5945 did not name #6726 — the identical change class, which this changeset's own text says it follows — shipped as minor for every touched package (.changeset/6726-find-envelope-records-arms.md on main). A reject-direction behaviour change at a published seam is exactly where the version signal matters; ship this as minor for @object-ui/components and @object-ui/plugin-view, matching family precedent. Two-line fix.
  2. Non-blocking, for extractRecords reads records AHEAD of data on DataSource.find() answers — the shared-helper copy of the #5945/#6726 inversion, live in 9 renderers #6839's implementer: the repo-wide "value emitted 5 times" is a cell-relative number, not an absolute one. A definition-body scanner cannot see envelopes in vi.fn().mockResolvedValue({...}) arguments — two such emitters exist (plugin-gridcolumnIdentity/recordIdFieldProjection fixtures, { value: [], '@odata.count': 0 }), which this PR disclosed in §7/finding(fields,plugin-detail,plugin-list,app-shell): six more non-QueryResultcount/value arms survive the seams #6840 repaired — and one of them reads value AHEAD of data #6917 but did not count — nor helper-built envelopes (this PR's own asValue pin helper is the existence proof; my census found no others). Neither class touches this PR's seams — I verified both zeros on looser cells — but extractRecords reads records AHEAD of data on DataSource.find() answers — the shared-helper copy of the #5945/#6726 inversion, live in 9 renderers #6839 should not read "5" as the full producer universe for its own sweep.
  3. Non-blocking, for the PM:finding(fields,plugin-detail,plugin-list,app-shell): six more non-QueryResultcount/value arms survive the seams #6840 repaired — and one of them reads value AHEAD of data #6917 contains a live-defect-class item (the fields inversion) and is unassigned and ungraded; it should be triaged rather than left as a recording. Also: this PR is a draft and its branch is behind main — updating and readying it is the author seat's move, not mine.

Generated by Claude Code

@os-samos-sam mentioned this pull request Aug 30, 2026
Open
@os-samClaude

os-sam commented Aug 30, 2026

Copy link
Copy Markdown
Collaborator

PM: clause-② verdict received — ACCEPT WITH FOLLOW-UP. One blocking item, dispatched.

domain:ui execution seat, PM session session_013hfmP9hoMd3dJwTh85J4yB.

⭐ I asked the reviewer to attack my own routing. It held — and now for a measured reason.

I routed this to clause ② over triage's p3 / no-label grading, then told the reviewer that this PR's
section 2 argues the opposite case well and that being corrected was the preferred outcome if the
adapter fold turned out to be total.

It is not total, and the reviewer showed why rather than asserting it:

normalizeQueryResult is private to ObjectStackAdapter / ApiDataSource, while DataSource
is a published interface (@object-ui/types, find(): Promise<QueryResult<T>>) reaching both
read sites raw — ObjectView.tsx:909 calls .find() on a public prop, and containers.tsx:434
hands RelatedCountStore a bare ctx?.dataSource probe. A third-party implementation bypasses the
fold entirely.

⇒ The two normalizeQueryResult reads are the mechanism behind the in-repo zero, which is exactly
what this PR claims and proves. They are not a wall around the seam. The cost of this change therefore
lands on off-contract third-party implementations — which is the card's sanctioned intent, not a
surprise — and clause ② was the right gate to make that visible before landing rather than after.

⛔ Routing stands. Not withdrawn.

Blocking follow-up — dispatched, not waived

The changeset grades both packages patch; predecessor #6726 shipped the identical change
class as minor (.changeset/6726-find-envelope-records-arms.md on main).

Two lines. A dev seat is applying it now, and I have told it to verify the precedent itself and stop
if the file does not say what the review says it says — a bump grade justified by a misquoted
precedent is worse than the original patch.

What the review reproduced to the byte, so it is not taken on report

  • Ablation re-run: pins 10/10 green on the committed tree; arms restored → 3 failed / 7 passed,
    exactly the three named refusals. Mutation and restore proven by git hash-object (pre-blobs
    837aaf2ce / 56c822823; HEAD blobs b114e864e / ae4d44cdb) plus anchored counts 0→1 / 0→2. Pins
    import by relative source path — no dist leg.
  • Sweeps re-derived with the reviewer's own scanner on looser cells: count0 against controls
    total 144/129 and data 305/218 in the same pass; value0 at the seam across a 32-file
    superset     with controls 20/19 and 20/19. ⭐ Looser cells reaching the same zero is the stronger
    result — it rules out the worry that the tightened bracket scanner had under-counted.
  • Human floor: packages/types/src/data.ts untouched; exactly 5 files against merge-base 3b9c774c.
  • plugin-view 29 files / 268 tests green, identical to the claim; type-check 17/17, exit 0.
  • The fields/src/index.tsx:248-250 precedence inversion is real on head, and finding(fields,plugin-detail,plugin-list,app-shell): six more non-QueryResultcount/value arms survive the seams #6840 repaired — and one of them reads value AHEAD of data #6917 is filed.

NOT MEASURED, declared: the PR's exact scanner numbers bit-for-bit (the scanner is not committed —
verified in substance instead); the components full suite, lint and gate scripts (CI's);
check:sdui-registration-pins left as PREREQUISITE NOT MET.

One finding handed onward rather than acted on here

⚠️ The repo-wide "value emitted 5×" is cell-relative: mockResolvedValue-argument envelopes (2 in
plugin-grid, disclosed but uncounted) and helper-built envelopes are invisible to any body-scanner.
That does not weaken this PR — its seam zero survived a 32-file superset — but it means 5 is a floor,
not the producer universe. Recorded on #6839 so its own sweep cannot inherit the blind spot.

Landing once the changeset commit lands and CI is terminal on the new head.

Generated by Claude Code

@claude
chore(changeset): grade the count/value arm removal minor, not patch
7a3f9da
Both package grades in `.changeset/6840-queryresult-count-value-arms.md` go
from `patch` to `minor`. No prose change: the body asserts nothing about
patch semantics, and the two frontmatter lines are the whole delta.
The predecessor `.changeset/6726-find-envelope-records-arms.md` (on `main`)
ships the identical change class — a tolerant arm reading an undeclared
envelope key deleted from `DataSource.find()` consumers, in two of the very
same modules — and grades its three packages `minor`. Same class, same
grade.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013hfmP9hoMd3dJwTh85J4yB
@claude

claudeBot commented Aug 30, 2026

Copy link
Copy Markdown
ContributorAuthor

Changeset grade: patch → minor (7a3f9da)

One commit on top of 6163cf90d, touching one file and nothing else:
.changeset/6840-queryresult-count-value-arms.md.

 ---
-'@object-ui/components': patch-'@object-ui/plugin-view': patch+'@object-ui/components': minor+'@object-ui/plugin-view': minor
---

That is the whole delta — two frontmatter lines. The body is untouched: it
asserts nothing about patch semantics anywhere (the only occurrences of the
word "patch" in the file were the two grade lines themselves), so there was
no prose to correct. No source file, no test, no other changeset.

Precedent verified before the edit

The predecessor card #6726 shipped the identical change class and graded it
minor. Read straight off origin/main
(git show origin/main:.changeset/6726-find-envelope-records-arms.md):

---
'@object-ui/components': minor
'@object-ui/plugin-detail': minor
'@object-ui/plugin-view': minor
---
Seven more `find()` readers now read exactly what `QueryResult` declares — the
`records` arm is removed from each (objectui#6726, following objectui#5945).

Both checks hold:

  1. It grades minor — three packages, all minor.
  2. Same change class — a tolerant arm reading an undeclared envelope key,
    deleted from DataSource.find() consumers. The same records-before-data tolerant reader survives in ~7 more find() consumers that #5945 did not name #6726 removed the records
    arm; this PR removes the count and value arms that The same records-before-data tolerant reader survives in ~7 more find() consumers that #5945 did not name #6726 explicitly
    left standing in the very same expressions. Two of The same records-before-data tolerant reader survives in ~7 more find() consumers that #5945 did not name #6726's seven modules
    are exactly the two this PR edits: components/src/hooks/related-count-store.ts
    and plugin-view/src/ObjectView.tsx. Not merely a similar class — the
    deferred remainder of the same sweep, as this changeset's own body says
    ("This is the measurement it deferred").

A grade of patch for the same removal shape that shipped as minor a card
ago would have made the release line read as though the two were different
kinds of change. They are not.

Verification

A changeset grade change has no failing state to start from — there is no
red-first demonstration to give here, and I am not claiming one. What is
measurable is that the changeset gates were green before the edit and are
green after it, and that the bump-policy gate — the one gate with an opinion
about grades — accepts minor.

Each gate, run standalone post-edit on the committed tree, with its exit code
captured before any pipe:

$ node scripts/check-changeset-presence.mjs # exit 0
Compared the working tree with 3b9c774c5 (merge-base with origin/main): 5 file(s) changed,
4 of them published source of a package the release covers, 0 under a package changesets
ignores, 1 changeset(s) added.
OK 4 source file(s) of 2 released package(s) changed, and this change declares
1 changeset(s): .changeset/6840-queryresult-count-value-arms.md.
$ pnpm changeset:check # exit 0
OK All workspace packages are in the changeset fixed group.
OK privatePackages declared: version=true, tag=false.
OK No changeset declares a `major` bump.
$ node scripts/check-changeset-no-major.mjs # exit 0
(this is the "Changeset Bump Policy" job's own command)
OK No changeset declares a `major` bump.
$ node scripts/check-changeset-overwrite.mjs # exit 0
(this is the "Changeset Overwrite Report" job's own command)
Compared the working tree with 3b9c774c5 (merge-base with origin/main):
1 changeset(s) added, 0 modified, 0 deleted.
OK No pre-existing changeset was modified or deleted.

(Each OK above stands where the gate printed its own green check mark.)

All four ran standalone, post-edit, on the committed tree
(git rev-parse --short HEAD = 7a3f9da63); the first three also ran pre-edit
and were already green. Nothing was NOT MEASURED: no timeout, no shared-lock
wait (these gates are dependency-free node:fs scans that finish in about a
second, so no build or test lock was taken), no PREREQUISITE NOT MET, and no
unbuilt-dependency TS2307 — none of these gates compile anything.

minor is also the correct ceiling here on its own terms, independent of the
precedent: AGENTS.md forbids major in this repo's fixed group, and
check-changeset-no-major.mjs enforces it.

The PR remains a draft and auto-merge is not armed; landing it stays
with the PM seat.

Generated by Claude Code

Generated by Claude Code

@github-actions

github-actionsBot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

MetricValueBudget
Eager closure (gzip, 45 chunks)3178.9 KB3222.7 KB
Main entry chunk (gzip)143.6 KB350 KB
Entry fileindex-Bc-96Rf1.js—
StatusPASS—

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.

📦 Bundle Size Report

PackageSizeGzipped
app-shell (consoleActionDispatch.js)0.20KB0.19KB
app-shell (index.js)12.46KB4.71KB
app-shell (runtime-config.js)20.61KB7.35KB
app-shell (types.js)0.01KB0.04KB
app-shell (urlParams.js)10.06KB3.86KB
auth (ActiveOrganizationStorage.js)25.05KB9.16KB
auth (AuthContext.js)0.31KB0.24KB
auth (AuthGuard.js)2.07KB1.00KB
auth (AuthProvider.js)40.18KB10.59KB
auth (AuthShell.js)3.49KB1.40KB
auth (ForgotPasswordForm.js)12.21KB3.45KB
auth (LoginForm.js)18.15KB5.39KB
auth (PreviewBanner.js)0.90KB0.50KB
auth (RegisterForm.js)6.65KB2.22KB
auth (SocialSignInButtons.js)9.61KB3.89KB
auth (UserMenu.js)3.41KB1.23KB
auth (auth-gate-events.js)1.29KB0.66KB
auth (authStyles.js)5.04KB1.72KB
auth (createAuthClient.js)40.21KB10.80KB
auth (createAuthenticatedFetch.js)8.46KB3.43KB
auth (index.js)3.19KB1.44KB
auth (invitation-status.js)1.22KB0.70KB
auth (org-roles.js)6.66KB2.78KB
auth (phone-identifier.js)1.11KB0.66KB
auth (types.js)0.59KB0.35KB
auth (useAuth.js)5.30KB1.02KB
auth (useWorkspaceAdminStatus.js)5.13KB2.35KB
collaboration (CommentThread.js)26.08KB7.56KB
collaboration (LiveCursors.js)3.17KB1.27KB
collaboration (PresenceAvatars.js)6.49KB2.64KB
collaboration (PresenceProvider.js)2.79KB1.13KB
collaboration (index.js)1.68KB0.73KB
collaboration (useCollaborationTranslation.js)6.05KB2.52KB
collaboration (useCommentSearch.js)1.98KB0.88KB
collaboration (useConflictResolution.js)7.75KB1.86KB
collaboration (useMentionNotifications.js)1.81KB0.68KB
collaboration (usePresence.js)6.33KB1.84KB
collaboration (useRealtimeSubscription.js)7.91KB2.01KB
components (index.js)512.09KB116.42KB
core (index.js)5.30KB2.13KB
create-plugin (index.js)10.08KB3.26KB
data-objectstack (index.js)175.69KB48.80KB
fields (index.js)243.65KB61.63KB
i18n (LocalizationContext.js)1.76KB0.96KB
i18n (currency.js)1.22KB0.64KB
i18n (fallbackInterpolation.js)6.25KB2.77KB
i18n (i18n.js)4.28KB1.75KB
i18n (index.js)3.44KB1.39KB
i18n (pickLocalized.js)7.62KB3.26KB
i18n (provider.js)26.89KB9.04KB
i18n (useDisplayLocale.js)2.85KB1.45KB
i18n (useObjectLabel.js)33.40KB8.71KB
i18n (useSafeTranslation.js)5.60KB2.33KB
layout (index.js)38.95KB10.97KB
mobile (MobileProvider.js)0.92KB0.49KB
mobile (ResponsiveContainer.js)0.94KB0.38KB
mobile (breakpoints.js)1.51KB0.70KB
mobile (createOfflineDataSource.js)5.61KB1.75KB
mobile (index.js)1.55KB0.62KB
mobile (offlineQueue.js)3.91KB1.35KB
mobile (pwa.js)0.97KB0.49KB
mobile (serviceWorker.js)1.48KB0.62KB
mobile (serviceWorkerSource.js)3.41KB1.48KB
mobile (useBreakpoint.js)1.54KB0.65KB
mobile (useGesture.js)6.96KB1.98KB
mobile (useOfflineSync.js)1.99KB0.72KB
mobile (usePullToRefresh.js)2.53KB0.85KB
mobile (useResponsive.js)0.72KB0.42KB
mobile (useResponsiveConfig.js)1.37KB0.63KB
mobile (useSpecGesture.js)4.32KB1.64KB
mobile (useTouchTarget.js)1.01KB0.54KB
permissions (MePermissionsProvider.js)11.71KB4.29KB
permissions (PermissionContext.js)0.31KB0.25KB
permissions (PermissionGuard.js)0.89KB0.45KB
permissions (PermissionProvider.js)6.24KB2.16KB
permissions (discardProofCache.js)1.04KB0.55KB
permissions (evaluator.js)5.12KB1.74KB
permissions (index.js)0.93KB0.41KB
permissions (store.js)0.91KB0.42KB
permissions (useFieldPermissions.js)1.28KB0.53KB
permissions (usePermissions.js)4.83KB2.27KB
plugin-ai (index.js)15.75KB3.80KB
plugin-calendar (index.js)46.92KB12.93KB
plugin-charts (index.js)64.68KB18.35KB
plugin-chatbot (index.js)190.53KB45.18KB
plugin-dashboard (index.js)133.48KB34.51KB
plugin-designer (index.js)212.87KB43.19KB
plugin-detail (index.js)245.43KB62.46KB
plugin-editor (index.js)2.46KB1.10KB
plugin-form (index.js)133.32KB32.69KB
plugin-gantt (index.js)165.23KB40.37KB
plugin-grid (index.js)202.08KB54.61KB
plugin-kanban (index.js)53.14KB14.64KB
plugin-list (index.js)113.15KB27.59KB
plugin-map (index.js)20.20KB6.66KB
plugin-markdown (index.js)13.72KB4.69KB
plugin-report (index.js)43.51KB11.94KB
plugin-timeline (index.js)29.05KB8.37KB
plugin-tree (index.js)9.00KB3.08KB
plugin-view (index.js)85.79KB21.10KB
providers (DataSourceProvider.js)0.75KB0.39KB
providers (MetadataProvider.js)1.37KB0.59KB
providers (ThemeProvider.js)1.90KB0.85KB
providers (UploadProvider.js)11.66KB3.50KB
providers (index.js)0.45KB0.23KB
providers (types.js)0.01KB0.04KB
react-runtime (index.js)5.62KB2.34KB
react (LazyPluginLoader.js)4.47KB1.63KB
react (SchemaRenderer.js)76.75KB25.49KB
react (data-invalidation.js)5.05KB2.08KB
react (index.js)3.11KB1.48KB
react (schema-input.js)2.32KB1.24KB
react (spec-input.js)0.20KB0.18KB
sdui-parser (codegen.js)5.41KB2.34KB
sdui-parser (dashboard-widget-options.js)3.08KB1.30KB
sdui-parser (index.js)4.93KB2.24KB
sdui-parser (input-type.js)2.84KB1.40KB
sdui-parser (parse.js)20.57KB5.88KB
sdui-parser (provenance.js)3.66KB1.82KB
sdui-parser (types.js)0.28KB0.23KB
sdui-parser (validate.js)10.35KB3.60KB
types (ai.js)0.20KB0.17KB
types (api-types.js)0.20KB0.18KB
types (app.js)2.87KB0.99KB
types (base.js)0.20KB0.18KB
types (blocks.js)0.20KB0.18KB
types (complex.js)2.74KB1.41KB
types (crud.js)0.20KB0.18KB
types (dashboard-filter-alias.js)6.23KB2.74KB
types (data-display.js)3.75KB1.85KB
types (data-protocol.js)0.20KB0.19KB
types (data.js)0.20KB0.18KB
types (designer.js)1.85KB0.85KB
types (disclosure.js)0.20KB0.18KB
types (error-code.js)1.54KB0.88KB
types (feedback.js)0.20KB0.18KB
types (field-types.js)0.20KB0.18KB
types (form.js)0.20KB0.18KB
types (http-inflight.js)8.87KB3.73KB
types (http-retry.js)4.32KB2.02KB
types (icon-key-migration.js)4.26KB1.63KB
types (index.js)4.72KB2.24KB
types (layout.js)0.20KB0.18KB
types (managed-by.js)0.19KB0.18KB
types (mobile.js)2.59KB1.31KB
types (navigation.js)0.20KB0.18KB
types (objectql.js)0.20KB0.18KB
types (overlay.js)0.20KB0.18KB
types (permissions.js)0.20KB0.18KB
types (plugin-scope.js)0.20KB0.18KB
types (record-components.js)0.20KB0.19KB
types (record-semantics.js)1.28KB0.67KB
types (registry.js)0.20KB0.18KB
types (reports.js)0.20KB0.18KB
types (spec-report.js)5.05KB1.93KB
types (spec-ui-namespace.js)0.20KB0.19KB
types (system-fields.js)3.33KB1.54KB
types (theme.js)6.28KB2.87KB
types (ui-action.js)3.40KB1.71KB
types (views.js)0.20KB0.18KB
types (widget.js)0.20KB0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-sam
os-sam marked this pull request as ready for review August 30, 2026 16:21
@os-sam
os-sam added this pull request to the merge queueAug 30, 2026
@os-samos-sam mentioned this pull request Aug 30, 2026
Merged
Merged via the queue into main with commit c18d099Aug 30, 2026
32 checks passed
@os-sam
os-sam deleted the claude/issue-6840-queryresult-count-value-arms branch August 30, 2026 16:34
This was referenced Aug 30, 2026
Closed
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

package: componentsplugintests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

finding(components,plugin-view): two more non-QueryResult arms survive on the seams #6726 repaired — res?.count and results.value

2 participants

@os-sam@claude