Skip to content

refactor(components): derive metadata-viewer's option shape from the spec's SelectOption#7013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-sam merged 1 commit into from
Aug 31, 2026
+65 −7
Merged

refactor(components): derive metadata-viewer's option shape from the spec's SelectOption #7013

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions .changeset/6887-metadata-viewer-derive-select-option.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
---
---

Declaration-only: `metadata-viewer`'s state-machine view no longer hand-writes
the select-option shape.

`packages/components/src/renderers/basic/metadata-viewer.tsx` declared its own
module-local `interface SelectOption` — four of the five keys
`@objectstack/spec/data`'s `SelectOption` declares, with `visibleWhen` dropped
by silence: no `Omit` naming the narrowing and no comment saying the drop was
deliberate. It is now derived, `type StateOption = Omit<SpecSelectOption,
'visibleWhen'>`, the same `Omit`-with-named-narrowings form
`metadata-admin/form-spec.ts` uses for `FormFieldSpec.options`, with the drop
and the retained `default` each written out next to its reason.

No behaviour change and no released surface moves: the type is module-local,
the value it annotates arrives from `useMetadataItem` as `any`, and
`StateMachineView`'s `labelOf` / `colorOf` / `initial` logic is untouched — the
object-field `default` it reads stays the ruled-`enforce` key it always was.
53 changes: 46 additions & 7 deletions packages/components/src/renderers/basic/metadata-viewer.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -32,6 +32,7 @@ import {
Minus,
AlertTriangle,
} from 'lucide-react';
import type { SelectOption as SpecSelectOption } from '@objectstack/spec/data';
import { cn } from '../../lib/utils';
import { readProps } from './readProps';

Expand DownExpand Up@@ -106,12 +107,50 @@ function Placeholder({ tone = 'muted', children }: { tone?: 'muted' | 'warn'; ch
// state_machine — live transition graph from a `state_machine` validation rule
// ---------------------------------------------------------------------------

interface SelectOption {
label?: string;
value: string;
color?: string;
default?: boolean;
}
/**
* One declared option of the object field a state machine runs on — DERIVED
* from the spec's own `SelectOption` (`@objectstack/spec/data`), with the one
* narrowing this projection needs named in the `Omit` below (objectui#6887).
*
* It was a hand-written `{ label?; value; color?; default? }` quadruple: four of
* the spec's five keys, with the fifth dropped by SILENCE — no `Omit` naming it,
* no comment saying the drop was deliberate. Nothing type-checks author-written
* metadata against this declaration (the value arrives from `useMetadataItem`
* as `any`), so unlike the authoring-side copies this one could not mis-accept
* anything; what it could do is go on compiling while the spec's option shape
* moved, and silently answer an older question. Deriving is what stops that,
* and it is the same form `form-spec.ts` uses one package over for
* `FormFieldSpec.options` (objectui#6247 / PR #6618).
*
* - `visibleWhen` is DROPPED, and now says so. This view draws the DECLARED
* state set — every option the field declares becomes a chip, and the
* transition graph is read from the `state_machine` rule, not from who is
* looking. Per-option `visibleWhen` withdraws an option from a PICKER for
* one record and one `current_user` (ADR-0068); a diagram of the machine
* has no such subject, so there is nothing here to evaluate it against.
* Carrying the key would advertise a gate this projection does not apply.
*
* - `default` is KEPT, and is read at `initial` below. That is deliberate and
* is the whole reason this is a spec derivation rather than a narrower
* local shape: `default` on the OBJECT-field face is ruled `enforce`
* (objectstack#7246, implemented by PR #7388) — the engine seeds the insert
* path from the option marked `default: true` — so the state this view
* calls "initial" is the same one the platform actually writes.
*
* `SelectOption` (`z.input`) rather than `SelectOptionParsed` (`z.infer`) even
* though this is a read model: on the four retained keys the two are the SAME
* type — none of `label` / `value` / `color` / `default` carries a `.default()`
* or a transform — and the entire input/output difference lives on
* `visibleWhen`, the key omitted above.
*
* ⚠️ Structurally this admits one shape LESS than the quadruple it replaces:
* the spec makes `label` REQUIRED and the hand copy had relaxed it to optional,
* by silence, the same way it dropped `visibleWhen`. Nothing turned on the
* relaxation — `labelOf` falls back to the raw value for any state the option
* list does not describe at all, which is the case that fallback exists for
* (transition sources and targets are not required to be declared options).
*/
type StateOption = Omit<SpecSelectOption, 'visibleWhen'>;

function StateMachineView({ object, name }: ViewerProps) {
const { item: obj, loading, error } = useMetadataItem('object', object ?? null);
Expand DownExpand Up@@ -141,7 +180,7 @@ function StateMachineView({ object, name }: ViewerProps) {
? rule.transitions
: {};
const field = getField(obj, rule.field);
const options: SelectOption[] = Array.isArray(field?.options) ? field.options : [];
const options: StateOption[] = Array.isArray(field?.options) ? field.options : [];
const optByValue = new Map(options.map((o) => [o.value, o]));
const labelOf = (v: string) => optByValue.get(v)?.label ?? v;
const colorOf = (v: string) => optByValue.get(v)?.color;
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
refactor(components): derive metadata-viewer's option shape from the spec's SelectOption by claude[bot] · Pull Request #7013 · objectstack-ai/objectui · GitHub
Skip to content
refactor(components): derive metadata-viewer's option shape from the spec's SelectOption#7013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-sam
merged 1 commit into

from

Aug 31, 2026

+65

−7

 Merged


refactor(components): derive metadata-viewer's option shape from the spec's SelectOption
#7013
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


19 changes: 19 additions & 0 deletions
.changeset/6887-metadata-viewer-derive-select-option.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
---
---

Declaration-only: `metadata-viewer`'s state-machine view no longer hand-writes
the select-option shape.

`packages/components/src/renderers/basic/metadata-viewer.tsx` declared its own
module-local `interface SelectOption` — four of the five keys
`@objectstack/spec/data`'s `SelectOption` declares, with `visibleWhen` dropped
by silence: no `Omit` naming the narrowing and no comment saying the drop was
deliberate. It is now derived, `type StateOption = Omit<SpecSelectOption,
'visibleWhen'>`, the same `Omit`-with-named-narrowings form
`metadata-admin/form-spec.ts` uses for `FormFieldSpec.options`, with the drop
and the retained `default` each written out next to its reason.

No behaviour change and no released surface moves: the type is module-local,
the value it annotates arrives from `useMetadataItem` as `any`, and
`StateMachineView`'s `labelOf` / `colorOf` / `initial` logic is untouched — the
object-field `default` it reads stays the ruled-`enforce` key it always was.

53 changes: 46 additions & 7 deletions
packages/components/src/renderers/basic/metadata-viewer.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -32,6 +32,7 @@ import {
 Minus,
 AlertTriangle,
} from 'lucide-react';
import type { SelectOption as SpecSelectOption } from '@objectstack/spec/data';
import { cn } from '../../lib/utils';
import { readProps } from './readProps';

Expand DownExpand Up@@ -106,12 +107,50 @@ function Placeholder({ tone = 'muted', children }: { tone?: 'muted' | 'warn'; ch
// state_machine — live transition graph from a `state_machine` validation rule
// ---------------------------------------------------------------------------

interface SelectOption {
 label?: string;
 value: string;
 color?: string;
 default?: boolean;
}
/**
 * One declared option of the object field a state machine runs on — DERIVED
 * from the spec's own `SelectOption` (`@objectstack/spec/data`), with the one
 * narrowing this projection needs named in the `Omit` below (objectui#6887).
 *
 * It was a hand-written `{ label?; value; color?; default? }` quadruple: four of
 * the spec's five keys, with the fifth dropped by SILENCE — no `Omit` naming it,
 * no comment saying the drop was deliberate. Nothing type-checks author-written
 * metadata against this declaration (the value arrives from `useMetadataItem`
 * as `any`), so unlike the authoring-side copies this one could not mis-accept
 * anything; what it could do is go on compiling while the spec's option shape
 * moved, and silently answer an older question. Deriving is what stops that,
 * and it is the same form `form-spec.ts` uses one package over for
 * `FormFieldSpec.options` (objectui#6247 / PR #6618).
 *
 * - `visibleWhen` is DROPPED, and now says so. This view draws the DECLARED
 * state set — every option the field declares becomes a chip, and the
 * transition graph is read from the `state_machine` rule, not from who is
 * looking. Per-option `visibleWhen` withdraws an option from a PICKER for
 * one record and one `current_user` (ADR-0068); a diagram of the machine
 * has no such subject, so there is nothing here to evaluate it against.
 * Carrying the key would advertise a gate this projection does not apply.
 *
 * - `default` is KEPT, and is read at `initial` below. That is deliberate and
 * is the whole reason this is a spec derivation rather than a narrower
 * local shape: `default` on the OBJECT-field face is ruled `enforce`
 * (objectstack#7246, implemented by PR #7388) — the engine seeds the insert
 * path from the option marked `default: true` — so the state this view
 * calls "initial" is the same one the platform actually writes.
 *
 * `SelectOption` (`z.input`) rather than `SelectOptionParsed` (`z.infer`) even
 * though this is a read model: on the four retained keys the two are the SAME
 * type — none of `label` / `value` / `color` / `default` carries a `.default()`
 * or a transform — and the entire input/output difference lives on
 * `visibleWhen`, the key omitted above.
 *
 * ⚠️ Structurally this admits one shape LESS than the quadruple it replaces:
 * the spec makes `label` REQUIRED and the hand copy had relaxed it to optional,
 * by silence, the same way it dropped `visibleWhen`. Nothing turned on the
 * relaxation — `labelOf` falls back to the raw value for any state the option
 * list does not describe at all, which is the case that fallback exists for
 * (transition sources and targets are not required to be declared options).
 */
type StateOption = Omit<SpecSelectOption, 'visibleWhen'>;

function StateMachineView({ object, name }: ViewerProps) {
 const { item: obj, loading, error } = useMetadataItem('object', object ?? null);
Expand DownExpand Up@@ -141,7 +180,7 @@ function StateMachineView({ object, name }: ViewerProps) {
 ? rule.transitions
 : {};
 const field = getField(obj, rule.field);
 const options: SelectOption[] = Array.isArray(field?.options) ? field.options : [];
 const options: StateOption[] = Array.isArray(field?.options) ? field.options : [];
 const optByValue = new Map(options.map((o) => [o.value, o]));
 const labelOf = (v: string) => optByValue.get(v)?.label ?? v;
 const colorOf = (v: string) => optByValue.get(v)?.color;
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
refactor(components): derive metadata-viewer's option shape from the spec's SelectOption by claude[bot] · Pull Request #7013 · objectstack-ai/objectui · GitHub
Skip to content
refactor(components): derive metadata-viewer's option shape from the spec's SelectOption#7013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-sam
merged 1 commit into

from

Aug 31, 2026

+65

−7

 Merged


refactor(components): derive metadata-viewer's option shape from the spec's SelectOption
#7013
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


19 changes: 19 additions & 0 deletions
.changeset/6887-metadata-viewer-derive-select-option.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
---
---

Declaration-only: `metadata-viewer`'s state-machine view no longer hand-writes
the select-option shape.

`packages/components/src/renderers/basic/metadata-viewer.tsx` declared its own
module-local `interface SelectOption` — four of the five keys
`@objectstack/spec/data`'s `SelectOption` declares, with `visibleWhen` dropped
by silence: no `Omit` naming the narrowing and no comment saying the drop was
deliberate. It is now derived, `type StateOption = Omit<SpecSelectOption,
'visibleWhen'>`, the same `Omit`-with-named-narrowings form
`metadata-admin/form-spec.ts` uses for `FormFieldSpec.options`, with the drop
and the retained `default` each written out next to its reason.

No behaviour change and no released surface moves: the type is module-local,
the value it annotates arrives from `useMetadataItem` as `any`, and
`StateMachineView`'s `labelOf` / `colorOf` / `initial` logic is untouched — the
object-field `default` it reads stays the ruled-`enforce` key it always was.

53 changes: 46 additions & 7 deletions
packages/components/src/renderers/basic/metadata-viewer.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -32,6 +32,7 @@ import {
 Minus,
 AlertTriangle,
} from 'lucide-react';
import type { SelectOption as SpecSelectOption } from '@objectstack/spec/data';
import { cn } from '../../lib/utils';
import { readProps } from './readProps';

Expand DownExpand Up@@ -106,12 +107,50 @@ function Placeholder({ tone = 'muted', children }: { tone?: 'muted' | 'warn'; ch
// state_machine — live transition graph from a `state_machine` validation rule
// ---------------------------------------------------------------------------

interface SelectOption {
 label?: string;
 value: string;
 color?: string;
 default?: boolean;
}
/**
 * One declared option of the object field a state machine runs on — DERIVED
 * from the spec's own `SelectOption` (`@objectstack/spec/data`), with the one
 * narrowing this projection needs named in the `Omit` below (objectui#6887).
 *
 * It was a hand-written `{ label?; value; color?; default? }` quadruple: four of
 * the spec's five keys, with the fifth dropped by SILENCE — no `Omit` naming it,
 * no comment saying the drop was deliberate. Nothing type-checks author-written
 * metadata against this declaration (the value arrives from `useMetadataItem`
 * as `any`), so unlike the authoring-side copies this one could not mis-accept
 * anything; what it could do is go on compiling while the spec's option shape
 * moved, and silently answer an older question. Deriving is what stops that,
 * and it is the same form `form-spec.ts` uses one package over for
 * `FormFieldSpec.options` (objectui#6247 / PR #6618).
 *
 * - `visibleWhen` is DROPPED, and now says so. This view draws the DECLARED
 * state set — every option the field declares becomes a chip, and the
 * transition graph is read from the `state_machine` rule, not from who is
 * looking. Per-option `visibleWhen` withdraws an option from a PICKER for
 * one record and one `current_user` (ADR-0068); a diagram of the machine
 * has no such subject, so there is nothing here to evaluate it against.
 * Carrying the key would advertise a gate this projection does not apply.
 *
 * - `default` is KEPT, and is read at `initial` below. That is deliberate and
 * is the whole reason this is a spec derivation rather than a narrower
 * local shape: `default` on the OBJECT-field face is ruled `enforce`
 * (objectstack#7246, implemented by PR #7388) — the engine seeds the insert
 * path from the option marked `default: true` — so the state this view
 * calls "initial" is the same one the platform actually writes.
 *
 * `SelectOption` (`z.input`) rather than `SelectOptionParsed` (`z.infer`) even
 * though this is a read model: on the four retained keys the two are the SAME
 * type — none of `label` / `value` / `color` / `default` carries a `.default()`
 * or a transform — and the entire input/output difference lives on
 * `visibleWhen`, the key omitted above.
 *
 * ⚠️ Structurally this admits one shape LESS than the quadruple it replaces:
 * the spec makes `label` REQUIRED and the hand copy had relaxed it to optional,
 * by silence, the same way it dropped `visibleWhen`. Nothing turned on the
 * relaxation — `labelOf` falls back to the raw value for any state the option
 * list does not describe at all, which is the case that fallback exists for
 * (transition sources and targets are not required to be declared options).
 */
type StateOption = Omit<SpecSelectOption, 'visibleWhen'>;

function StateMachineView({ object, name }: ViewerProps) {
 const { item: obj, loading, error } = useMetadataItem('object', object ?? null);
Expand DownExpand Up@@ -141,7 +180,7 @@ function StateMachineView({ object, name }: ViewerProps) {
 ? rule.transitions
 : {};
 const field = getField(obj, rule.field);
 const options: SelectOption[] = Array.isArray(field?.options) ? field.options : [];
 const options: StateOption[] = Array.isArray(field?.options) ? field.options : [];
 const optByValue = new Map(options.map((o) => [o.value, o]));
 const labelOf = (v: string) => optByValue.get(v)?.label ?? v;
 const colorOf = (v: string) => optByValue.get(v)?.color;
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
refactor(components): derive metadata-viewer's option shape from the spec's SelectOption by claude[bot] · Pull Request #7013 · objectstack-ai/objectui · GitHub
Skip to content
refactor(components): derive metadata-viewer's option shape from the spec's SelectOption#7013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-sam
merged 1 commit into

from

Aug 31, 2026

+65

−7

 Merged


refactor(components): derive metadata-viewer's option shape from the spec's SelectOption
#7013
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


19 changes: 19 additions & 0 deletions
.changeset/6887-metadata-viewer-derive-select-option.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
---
---

Declaration-only: `metadata-viewer`'s state-machine view no longer hand-writes
the select-option shape.

`packages/components/src/renderers/basic/metadata-viewer.tsx` declared its own
module-local `interface SelectOption` — four of the five keys
`@objectstack/spec/data`'s `SelectOption` declares, with `visibleWhen` dropped
by silence: no `Omit` naming the narrowing and no comment saying the drop was
deliberate. It is now derived, `type StateOption = Omit<SpecSelectOption,
'visibleWhen'>`, the same `Omit`-with-named-narrowings form
`metadata-admin/form-spec.ts` uses for `FormFieldSpec.options`, with the drop
and the retained `default` each written out next to its reason.

No behaviour change and no released surface moves: the type is module-local,
the value it annotates arrives from `useMetadataItem` as `any`, and
`StateMachineView`'s `labelOf` / `colorOf` / `initial` logic is untouched — the
object-field `default` it reads stays the ruled-`enforce` key it always was.

53 changes: 46 additions & 7 deletions
packages/components/src/renderers/basic/metadata-viewer.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -32,6 +32,7 @@ import {
 Minus,
 AlertTriangle,
} from 'lucide-react';
import type { SelectOption as SpecSelectOption } from '@objectstack/spec/data';
import { cn } from '../../lib/utils';
import { readProps } from './readProps';

Expand DownExpand Up@@ -106,12 +107,50 @@ function Placeholder({ tone = 'muted', children }: { tone?: 'muted' | 'warn'; ch
// state_machine — live transition graph from a `state_machine` validation rule
// ---------------------------------------------------------------------------

interface SelectOption {
 label?: string;
 value: string;
 color?: string;
 default?: boolean;
}
/**
 * One declared option of the object field a state machine runs on — DERIVED
 * from the spec's own `SelectOption` (`@objectstack/spec/data`), with the one
 * narrowing this projection needs named in the `Omit` below (objectui#6887).
 *
 * It was a hand-written `{ label?; value; color?; default? }` quadruple: four of
 * the spec's five keys, with the fifth dropped by SILENCE — no `Omit` naming it,
 * no comment saying the drop was deliberate. Nothing type-checks author-written
 * metadata against this declaration (the value arrives from `useMetadataItem`
 * as `any`), so unlike the authoring-side copies this one could not mis-accept
 * anything; what it could do is go on compiling while the spec's option shape
 * moved, and silently answer an older question. Deriving is what stops that,
 * and it is the same form `form-spec.ts` uses one package over for
 * `FormFieldSpec.options` (objectui#6247 / PR #6618).
 *
 * - `visibleWhen` is DROPPED, and now says so. This view draws the DECLARED
 * state set — every option the field declares becomes a chip, and the
 * transition graph is read from the `state_machine` rule, not from who is
 * looking. Per-option `visibleWhen` withdraws an option from a PICKER for
 * one record and one `current_user` (ADR-0068); a diagram of the machine
 * has no such subject, so there is nothing here to evaluate it against.
 * Carrying the key would advertise a gate this projection does not apply.
 *
 * - `default` is KEPT, and is read at `initial` below. That is deliberate and
 * is the whole reason this is a spec derivation rather than a narrower
 * local shape: `default` on the OBJECT-field face is ruled `enforce`
 * (objectstack#7246, implemented by PR #7388) — the engine seeds the insert
 * path from the option marked `default: true` — so the state this view
 * calls "initial" is the same one the platform actually writes.
 *
 * `SelectOption` (`z.input`) rather than `SelectOptionParsed` (`z.infer`) even
 * though this is a read model: on the four retained keys the two are the SAME
 * type — none of `label` / `value` / `color` / `default` carries a `.default()`
 * or a transform — and the entire input/output difference lives on
 * `visibleWhen`, the key omitted above.
 *
 * ⚠️ Structurally this admits one shape LESS than the quadruple it replaces:
 * the spec makes `label` REQUIRED and the hand copy had relaxed it to optional,
 * by silence, the same way it dropped `visibleWhen`. Nothing turned on the
 * relaxation — `labelOf` falls back to the raw value for any state the option
 * list does not describe at all, which is the case that fallback exists for
 * (transition sources and targets are not required to be declared options).
 */
type StateOption = Omit<SpecSelectOption, 'visibleWhen'>;

function StateMachineView({ object, name }: ViewerProps) {
 const { item: obj, loading, error } = useMetadataItem('object', object ?? null);
Expand DownExpand Up@@ -141,7 +180,7 @@ function StateMachineView({ object, name }: ViewerProps) {
 ? rule.transitions
 : {};
 const field = getField(obj, rule.field);
 const options: SelectOption[] = Array.isArray(field?.options) ? field.options : [];
 const options: StateOption[] = Array.isArray(field?.options) ? field.options : [];
 const optByValue = new Map(options.map((o) => [o.value, o]));
 const labelOf = (v: string) => optByValue.get(v)?.label ?? v;
 const colorOf = (v: string) => optByValue.get(v)?.color;
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
refactor(components): derive metadata-viewer's option shape from the spec's SelectOption by claude[bot] · Pull Request #7013 · objectstack-ai/objectui · GitHub
Skip to content
refactor(components): derive metadata-viewer's option shape from the spec's SelectOption#7013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-sam
merged 1 commit into

from

Aug 31, 2026

+65

−7

 Merged


refactor(components): derive metadata-viewer's option shape from the spec's SelectOption
#7013
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


19 changes: 19 additions & 0 deletions
.changeset/6887-metadata-viewer-derive-select-option.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
---
---

Declaration-only: `metadata-viewer`'s state-machine view no longer hand-writes
the select-option shape.

`packages/components/src/renderers/basic/metadata-viewer.tsx` declared its own
module-local `interface SelectOption` — four of the five keys
`@objectstack/spec/data`'s `SelectOption` declares, with `visibleWhen` dropped
by silence: no `Omit` naming the narrowing and no comment saying the drop was
deliberate. It is now derived, `type StateOption = Omit<SpecSelectOption,
'visibleWhen'>`, the same `Omit`-with-named-narrowings form
`metadata-admin/form-spec.ts` uses for `FormFieldSpec.options`, with the drop
and the retained `default` each written out next to its reason.

No behaviour change and no released surface moves: the type is module-local,
the value it annotates arrives from `useMetadataItem` as `any`, and
`StateMachineView`'s `labelOf` / `colorOf` / `initial` logic is untouched — the
object-field `default` it reads stays the ruled-`enforce` key it always was.

53 changes: 46 additions & 7 deletions
packages/components/src/renderers/basic/metadata-viewer.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -32,6 +32,7 @@ import {
 Minus,
 AlertTriangle,
} from 'lucide-react';
import type { SelectOption as SpecSelectOption } from '@objectstack/spec/data';
import { cn } from '../../lib/utils';
import { readProps } from './readProps';

Expand DownExpand Up@@ -106,12 +107,50 @@ function Placeholder({ tone = 'muted', children }: { tone?: 'muted' | 'warn'; ch
// state_machine — live transition graph from a `state_machine` validation rule
// ---------------------------------------------------------------------------

interface SelectOption {
 label?: string;
 value: string;
 color?: string;
 default?: boolean;
}
/**
 * One declared option of the object field a state machine runs on — DERIVED
 * from the spec's own `SelectOption` (`@objectstack/spec/data`), with the one
 * narrowing this projection needs named in the `Omit` below (objectui#6887).
 *
 * It was a hand-written `{ label?; value; color?; default? }` quadruple: four of
 * the spec's five keys, with the fifth dropped by SILENCE — no `Omit` naming it,
 * no comment saying the drop was deliberate. Nothing type-checks author-written
 * metadata against this declaration (the value arrives from `useMetadataItem`
 * as `any`), so unlike the authoring-side copies this one could not mis-accept
 * anything; what it could do is go on compiling while the spec's option shape
 * moved, and silently answer an older question. Deriving is what stops that,
 * and it is the same form `form-spec.ts` uses one package over for
 * `FormFieldSpec.options` (objectui#6247 / PR #6618).
 *
 * - `visibleWhen` is DROPPED, and now says so. This view draws the DECLARED
 * state set — every option the field declares becomes a chip, and the
 * transition graph is read from the `state_machine` rule, not from who is
 * looking. Per-option `visibleWhen` withdraws an option from a PICKER for
 * one record and one `current_user` (ADR-0068); a diagram of the machine
 * has no such subject, so there is nothing here to evaluate it against.
 * Carrying the key would advertise a gate this projection does not apply.
 *
 * - `default` is KEPT, and is read at `initial` below. That is deliberate and
 * is the whole reason this is a spec derivation rather than a narrower
 * local shape: `default` on the OBJECT-field face is ruled `enforce`
 * (objectstack#7246, implemented by PR #7388) — the engine seeds the insert
 * path from the option marked `default: true` — so the state this view
 * calls "initial" is the same one the platform actually writes.
 *
 * `SelectOption` (`z.input`) rather than `SelectOptionParsed` (`z.infer`) even
 * though this is a read model: on the four retained keys the two are the SAME
 * type — none of `label` / `value` / `color` / `default` carries a `.default()`
 * or a transform — and the entire input/output difference lives on
 * `visibleWhen`, the key omitted above.
 *
 * ⚠️ Structurally this admits one shape LESS than the quadruple it replaces:
 * the spec makes `label` REQUIRED and the hand copy had relaxed it to optional,
 * by silence, the same way it dropped `visibleWhen`. Nothing turned on the
 * relaxation — `labelOf` falls back to the raw value for any state the option
 * list does not describe at all, which is the case that fallback exists for
 * (transition sources and targets are not required to be declared options).
 */
type StateOption = Omit<SpecSelectOption, 'visibleWhen'>;

function StateMachineView({ object, name }: ViewerProps) {
 const { item: obj, loading, error } = useMetadataItem('object', object ?? null);
Expand DownExpand Up@@ -141,7 +180,7 @@ function StateMachineView({ object, name }: ViewerProps) {
 ? rule.transitions
 : {};
 const field = getField(obj, rule.field);
 const options: SelectOption[] = Array.isArray(field?.options) ? field.options : [];
 const options: StateOption[] = Array.isArray(field?.options) ? field.options : [];
 const optByValue = new Map(options.map((o) => [o.value, o]));
 const labelOf = (v: string) => optByValue.get(v)?.label ?? v;
 const colorOf = (v: string) => optByValue.get(v)?.color;
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
refactor(components): derive metadata-viewer's option shape from the spec's SelectOption by claude[bot] · Pull Request #7013 · objectstack-ai/objectui · GitHub
Skip to content
refactor(components): derive metadata-viewer's option shape from the spec's SelectOption#7013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-sam
merged 1 commit into

from

Aug 31, 2026

+65

−7

 Merged


refactor(components): derive metadata-viewer's option shape from the spec's SelectOption
#7013
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


19 changes: 19 additions & 0 deletions
.changeset/6887-metadata-viewer-derive-select-option.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
---
---

Declaration-only: `metadata-viewer`'s state-machine view no longer hand-writes
the select-option shape.

`packages/components/src/renderers/basic/metadata-viewer.tsx` declared its own
module-local `interface SelectOption` — four of the five keys
`@objectstack/spec/data`'s `SelectOption` declares, with `visibleWhen` dropped
by silence: no `Omit` naming the narrowing and no comment saying the drop was
deliberate. It is now derived, `type StateOption = Omit<SpecSelectOption,
'visibleWhen'>`, the same `Omit`-with-named-narrowings form
`metadata-admin/form-spec.ts` uses for `FormFieldSpec.options`, with the drop
and the retained `default` each written out next to its reason.

No behaviour change and no released surface moves: the type is module-local,
the value it annotates arrives from `useMetadataItem` as `any`, and
`StateMachineView`'s `labelOf` / `colorOf` / `initial` logic is untouched — the
object-field `default` it reads stays the ruled-`enforce` key it always was.

53 changes: 46 additions & 7 deletions
packages/components/src/renderers/basic/metadata-viewer.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -32,6 +32,7 @@ import {
 Minus,
 AlertTriangle,
} from 'lucide-react';
import type { SelectOption as SpecSelectOption } from '@objectstack/spec/data';
import { cn } from '../../lib/utils';
import { readProps } from './readProps';

Expand DownExpand Up@@ -106,12 +107,50 @@ function Placeholder({ tone = 'muted', children }: { tone?: 'muted' | 'warn'; ch
// state_machine — live transition graph from a `state_machine` validation rule
// ---------------------------------------------------------------------------

interface SelectOption {
 label?: string;
 value: string;
 color?: string;
 default?: boolean;
}
/**
 * One declared option of the object field a state machine runs on — DERIVED
 * from the spec's own `SelectOption` (`@objectstack/spec/data`), with the one
 * narrowing this projection needs named in the `Omit` below (objectui#6887).
 *
 * It was a hand-written `{ label?; value; color?; default? }` quadruple: four of
 * the spec's five keys, with the fifth dropped by SILENCE — no `Omit` naming it,
 * no comment saying the drop was deliberate. Nothing type-checks author-written
 * metadata against this declaration (the value arrives from `useMetadataItem`
 * as `any`), so unlike the authoring-side copies this one could not mis-accept
 * anything; what it could do is go on compiling while the spec's option shape
 * moved, and silently answer an older question. Deriving is what stops that,
 * and it is the same form `form-spec.ts` uses one package over for
 * `FormFieldSpec.options` (objectui#6247 / PR #6618).
 *
 * - `visibleWhen` is DROPPED, and now says so. This view draws the DECLARED
 * state set — every option the field declares becomes a chip, and the
 * transition graph is read from the `state_machine` rule, not from who is
 * looking. Per-option `visibleWhen` withdraws an option from a PICKER for
 * one record and one `current_user` (ADR-0068); a diagram of the machine
 * has no such subject, so there is nothing here to evaluate it against.
 * Carrying the key would advertise a gate this projection does not apply.
 *
 * - `default` is KEPT, and is read at `initial` below. That is deliberate and
 * is the whole reason this is a spec derivation rather than a narrower
 * local shape: `default` on the OBJECT-field face is ruled `enforce`
 * (objectstack#7246, implemented by PR #7388) — the engine seeds the insert
 * path from the option marked `default: true` — so the state this view
 * calls "initial" is the same one the platform actually writes.
 *
 * `SelectOption` (`z.input`) rather than `SelectOptionParsed` (`z.infer`) even
 * though this is a read model: on the four retained keys the two are the SAME
 * type — none of `label` / `value` / `color` / `default` carries a `.default()`
 * or a transform — and the entire input/output difference lives on
 * `visibleWhen`, the key omitted above.
 *
 * ⚠️ Structurally this admits one shape LESS than the quadruple it replaces:
 * the spec makes `label` REQUIRED and the hand copy had relaxed it to optional,
 * by silence, the same way it dropped `visibleWhen`. Nothing turned on the
 * relaxation — `labelOf` falls back to the raw value for any state the option
 * list does not describe at all, which is the case that fallback exists for
 * (transition sources and targets are not required to be declared options).
 */
type StateOption = Omit<SpecSelectOption, 'visibleWhen'>;

function StateMachineView({ object, name }: ViewerProps) {
 const { item: obj, loading, error } = useMetadataItem('object', object ?? null);
Expand DownExpand Up@@ -141,7 +180,7 @@ function StateMachineView({ object, name }: ViewerProps) {
 ? rule.transitions
 : {};
 const field = getField(obj, rule.field);
 const options: SelectOption[] = Array.isArray(field?.options) ? field.options : [];
 const options: StateOption[] = Array.isArray(field?.options) ? field.options : [];
 const optByValue = new Map(options.map((o) => [o.value, o]));
 const labelOf = (v: string) => optByValue.get(v)?.label ?? v;
 const colorOf = (v: string) => optByValue.get(v)?.color;
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
refactor(components): derive metadata-viewer's option shape from the spec's SelectOption by claude[bot] · Pull Request #7013 · objectstack-ai/objectui · GitHub
Skip to content
refactor(components): derive metadata-viewer's option shape from the spec's SelectOption#7013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-sam
merged 1 commit into

from

Aug 31, 2026

+65

−7

 Merged


refactor(components): derive metadata-viewer's option shape from the spec's SelectOption
#7013
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


19 changes: 19 additions & 0 deletions
.changeset/6887-metadata-viewer-derive-select-option.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
---
---

Declaration-only: `metadata-viewer`'s state-machine view no longer hand-writes
the select-option shape.

`packages/components/src/renderers/basic/metadata-viewer.tsx` declared its own
module-local `interface SelectOption` — four of the five keys
`@objectstack/spec/data`'s `SelectOption` declares, with `visibleWhen` dropped
by silence: no `Omit` naming the narrowing and no comment saying the drop was
deliberate. It is now derived, `type StateOption = Omit<SpecSelectOption,
'visibleWhen'>`, the same `Omit`-with-named-narrowings form
`metadata-admin/form-spec.ts` uses for `FormFieldSpec.options`, with the drop
and the retained `default` each written out next to its reason.

No behaviour change and no released surface moves: the type is module-local,
the value it annotates arrives from `useMetadataItem` as `any`, and
`StateMachineView`'s `labelOf` / `colorOf` / `initial` logic is untouched — the
object-field `default` it reads stays the ruled-`enforce` key it always was.

53 changes: 46 additions & 7 deletions
packages/components/src/renderers/basic/metadata-viewer.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -32,6 +32,7 @@ import {
 Minus,
 AlertTriangle,
} from 'lucide-react';
import type { SelectOption as SpecSelectOption } from '@objectstack/spec/data';
import { cn } from '../../lib/utils';
import { readProps } from './readProps';

Expand DownExpand Up@@ -106,12 +107,50 @@ function Placeholder({ tone = 'muted', children }: { tone?: 'muted' | 'warn'; ch
// state_machine — live transition graph from a `state_machine` validation rule
// ---------------------------------------------------------------------------

interface SelectOption {
 label?: string;
 value: string;
 color?: string;
 default?: boolean;
}
/**
 * One declared option of the object field a state machine runs on — DERIVED
 * from the spec's own `SelectOption` (`@objectstack/spec/data`), with the one
 * narrowing this projection needs named in the `Omit` below (objectui#6887).
 *
 * It was a hand-written `{ label?; value; color?; default? }` quadruple: four of
 * the spec's five keys, with the fifth dropped by SILENCE — no `Omit` naming it,
 * no comment saying the drop was deliberate. Nothing type-checks author-written
 * metadata against this declaration (the value arrives from `useMetadataItem`
 * as `any`), so unlike the authoring-side copies this one could not mis-accept
 * anything; what it could do is go on compiling while the spec's option shape
 * moved, and silently answer an older question. Deriving is what stops that,
 * and it is the same form `form-spec.ts` uses one package over for
 * `FormFieldSpec.options` (objectui#6247 / PR #6618).
 *
 * - `visibleWhen` is DROPPED, and now says so. This view draws the DECLARED
 * state set — every option the field declares becomes a chip, and the
 * transition graph is read from the `state_machine` rule, not from who is
 * looking. Per-option `visibleWhen` withdraws an option from a PICKER for
 * one record and one `current_user` (ADR-0068); a diagram of the machine
 * has no such subject, so there is nothing here to evaluate it against.
 * Carrying the key would advertise a gate this projection does not apply.
 *
 * - `default` is KEPT, and is read at `initial` below. That is deliberate and
 * is the whole reason this is a spec derivation rather than a narrower
 * local shape: `default` on the OBJECT-field face is ruled `enforce`
 * (objectstack#7246, implemented by PR #7388) — the engine seeds the insert
 * path from the option marked `default: true` — so the state this view
 * calls "initial" is the same one the platform actually writes.
 *
 * `SelectOption` (`z.input`) rather than `SelectOptionParsed` (`z.infer`) even
 * though this is a read model: on the four retained keys the two are the SAME
 * type — none of `label` / `value` / `color` / `default` carries a `.default()`
 * or a transform — and the entire input/output difference lives on
 * `visibleWhen`, the key omitted above.
 *
 * ⚠️ Structurally this admits one shape LESS than the quadruple it replaces:
 * the spec makes `label` REQUIRED and the hand copy had relaxed it to optional,
 * by silence, the same way it dropped `visibleWhen`. Nothing turned on the
 * relaxation — `labelOf` falls back to the raw value for any state the option
 * list does not describe at all, which is the case that fallback exists for
 * (transition sources and targets are not required to be declared options).
 */
type StateOption = Omit<SpecSelectOption, 'visibleWhen'>;

function StateMachineView({ object, name }: ViewerProps) {
 const { item: obj, loading, error } = useMetadataItem('object', object ?? null);
Expand DownExpand Up@@ -141,7 +180,7 @@ function StateMachineView({ object, name }: ViewerProps) {
 ? rule.transitions
 : {};
 const field = getField(obj, rule.field);
 const options: SelectOption[] = Array.isArray(field?.options) ? field.options : [];
 const options: StateOption[] = Array.isArray(field?.options) ? field.options : [];
 const optByValue = new Map(options.map((o) => [o.value, o]));
 const labelOf = (v: string) => optByValue.get(v)?.label ?? v;
 const colorOf = (v: string) => optByValue.get(v)?.color;
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
refactor(components): derive metadata-viewer's option shape from the spec's SelectOption by claude[bot] · Pull Request #7013 · objectstack-ai/objectui · GitHub
Skip to content
refactor(components): derive metadata-viewer's option shape from the spec's SelectOption#7013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-sam
merged 1 commit into

from

Aug 31, 2026

+65

−7

 Merged


refactor(components): derive metadata-viewer's option shape from the spec's SelectOption
#7013
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


19 changes: 19 additions & 0 deletions
.changeset/6887-metadata-viewer-derive-select-option.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
---
---

Declaration-only: `metadata-viewer`'s state-machine view no longer hand-writes
the select-option shape.

`packages/components/src/renderers/basic/metadata-viewer.tsx` declared its own
module-local `interface SelectOption` — four of the five keys
`@objectstack/spec/data`'s `SelectOption` declares, with `visibleWhen` dropped
by silence: no `Omit` naming the narrowing and no comment saying the drop was
deliberate. It is now derived, `type StateOption = Omit<SpecSelectOption,
'visibleWhen'>`, the same `Omit`-with-named-narrowings form
`metadata-admin/form-spec.ts` uses for `FormFieldSpec.options`, with the drop
and the retained `default` each written out next to its reason.

No behaviour change and no released surface moves: the type is module-local,
the value it annotates arrives from `useMetadataItem` as `any`, and
`StateMachineView`'s `labelOf` / `colorOf` / `initial` logic is untouched — the
object-field `default` it reads stays the ruled-`enforce` key it always was.

53 changes: 46 additions & 7 deletions
packages/components/src/renderers/basic/metadata-viewer.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -32,6 +32,7 @@ import {
 Minus,
 AlertTriangle,
} from 'lucide-react';
import type { SelectOption as SpecSelectOption } from '@objectstack/spec/data';
import { cn } from '../../lib/utils';
import { readProps } from './readProps';

Expand DownExpand Up@@ -106,12 +107,50 @@ function Placeholder({ tone = 'muted', children }: { tone?: 'muted' | 'warn'; ch
// state_machine — live transition graph from a `state_machine` validation rule
// ---------------------------------------------------------------------------

interface SelectOption {
 label?: string;
 value: string;
 color?: string;
 default?: boolean;
}
/**
 * One declared option of the object field a state machine runs on — DERIVED
 * from the spec's own `SelectOption` (`@objectstack/spec/data`), with the one
 * narrowing this projection needs named in the `Omit` below (objectui#6887).
 *
 * It was a hand-written `{ label?; value; color?; default? }` quadruple: four of
 * the spec's five keys, with the fifth dropped by SILENCE — no `Omit` naming it,
 * no comment saying the drop was deliberate. Nothing type-checks author-written
 * metadata against this declaration (the value arrives from `useMetadataItem`
 * as `any`), so unlike the authoring-side copies this one could not mis-accept
 * anything; what it could do is go on compiling while the spec's option shape
 * moved, and silently answer an older question. Deriving is what stops that,
 * and it is the same form `form-spec.ts` uses one package over for
 * `FormFieldSpec.options` (objectui#6247 / PR #6618).
 *
 * - `visibleWhen` is DROPPED, and now says so. This view draws the DECLARED
 * state set — every option the field declares becomes a chip, and the
 * transition graph is read from the `state_machine` rule, not from who is
 * looking. Per-option `visibleWhen` withdraws an option from a PICKER for
 * one record and one `current_user` (ADR-0068); a diagram of the machine
 * has no such subject, so there is nothing here to evaluate it against.
 * Carrying the key would advertise a gate this projection does not apply.
 *
 * - `default` is KEPT, and is read at `initial` below. That is deliberate and
 * is the whole reason this is a spec derivation rather than a narrower
 * local shape: `default` on the OBJECT-field face is ruled `enforce`
 * (objectstack#7246, implemented by PR #7388) — the engine seeds the insert
 * path from the option marked `default: true` — so the state this view
 * calls "initial" is the same one the platform actually writes.
 *
 * `SelectOption` (`z.input`) rather than `SelectOptionParsed` (`z.infer`) even
 * though this is a read model: on the four retained keys the two are the SAME
 * type — none of `label` / `value` / `color` / `default` carries a `.default()`
 * or a transform — and the entire input/output difference lives on
 * `visibleWhen`, the key omitted above.
 *
 * ⚠️ Structurally this admits one shape LESS than the quadruple it replaces:
 * the spec makes `label` REQUIRED and the hand copy had relaxed it to optional,
 * by silence, the same way it dropped `visibleWhen`. Nothing turned on the
 * relaxation — `labelOf` falls back to the raw value for any state the option
 * list does not describe at all, which is the case that fallback exists for
 * (transition sources and targets are not required to be declared options).
 */
type StateOption = Omit<SpecSelectOption, 'visibleWhen'>;

function StateMachineView({ object, name }: ViewerProps) {
 const { item: obj, loading, error } = useMetadataItem('object', object ?? null);
Expand DownExpand Up@@ -141,7 +180,7 @@ function StateMachineView({ object, name }: ViewerProps) {
 ? rule.transitions
 : {};
 const field = getField(obj, rule.field);
 const options: SelectOption[] = Array.isArray(field?.options) ? field.options : [];
 const options: StateOption[] = Array.isArray(field?.options) ? field.options : [];
 const optByValue = new Map(options.map((o) => [o.value, o]));
 const labelOf = (v: string) => optByValue.get(v)?.label ?? v;
 const colorOf = (v: string) => optByValue.get(v)?.color;
Expand Down
Loading