test(spec-parity): converge the non-optional enum-options casts onto the shared reader (#7025)#7057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-sam merged 1 commit into from
Aug 31, 2026
Merged

test(spec-parity): converge the non-optional enum-options casts onto the shared reader (#7025) #7057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions .changeset/7025-nonoptional-enum-cast.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
---
---

Internal test-only change, no user-visible behaviour (objectui#7025).

The SIXTH spelling of the Zod-internals reader hazard objectui#5872 catalogues:
9 spec-parity test files in 7 packages cast an enum node NON-optionally to an
options-bearing shape and read `.options` straight off it. They converge onto
`@object-ui/test-support`'s `enumOptions(node)` — the same walk objectui#6924
converged the optional-cast family onto in PR #7024.

Unlike that family, these sites failed LOUDLY (spreading `undefined` throws), and
the shared reader deliberately answers `[]` rather than raising. So every site
keeps its own non-vacuity duty: a throwing wrapper at the seven module-scope
reads, and the suite's own pre-existing non-vacuity assertion at the two in-test
reads. A bare conversion would have traded a loud failure for a silent empty
vocabulary — a regression, not a convergence.

Only test files, two `devDependencies` edges and the lockfile change; no
package's shipped `dist/` and no public type moves.
28 changes: 25 additions & 3 deletions packages/app-shell/src/utils/expandableFamily.identity-5874.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -54,16 +54,38 @@
import { describe, it, expect, vi, afterEach } from 'vitest';
import { EXPANDABLE_FIELD_TYPES } from '@object-ui/core';
import { FieldType } from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';
import { ActionParamSchema } from '@objectstack/spec/ui';
import {
resolveActionParams,
type ResolveActionParamsContext,
type RawActionParam,
} from './resolveActionParams';

const SPEC_FIELD_TYPES: readonly string[] = [
...(FieldType as unknown as { options: readonly string[] }).options,
];
/**
* The spec's own `FieldType` vocabulary.
*
* The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924);
* the THROW stays HERE, because the reader deliberately answers `[]` rather than
* raising and this read is module-scope. What it replaces was a NON-OPTIONAL
* cast of the enum node to an options-bearing shape, spread directly — which
* failed LOUDLY the moment the cast stopped holding (spreading `undefined`
* throws), so a bare `enumOptions` call here would have traded a loud failure
* for a silently empty vocabulary: every assertion below would then pass over
* nothing. That trade is the regression objectui#7025 exists to refuse. (The
* retired spelling is deliberately NOT quoted here: the card's enumeration
* instrument is a grep for it, and a comment carrying the literal text makes
* every future re-derivation of this population read a false positive.)
*/
const readSpecFieldTypes = (): readonly string[] => {
const options = enumOptions(FieldType);
if (options.length === 0) {
throw new Error('could not read FieldType.options from @objectstack/spec');
}
return options;
};

const SPEC_FIELD_TYPES: readonly string[] = readSpecFieldTypes();

/** Every picker key `lookupExtras` copies off the resolved object field. */
const PICKER_KEYS = [
Expand Down
26 changes: 25 additions & 1 deletion packages/app-shell/src/views/richtextSurfaceParity.test.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -27,11 +27,35 @@
*/
import { describe, it, expect } from 'vitest';
import { FieldType } from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';
import { isWideFieldType as detailIsWide } from '@object-ui/plugin-detail';
import { isWideFieldType as formIsWide } from '@object-ui/plugin-form';
import { isSecondaryField } from './RecordDetailView';

const SPEC_TYPES: readonly string[] = [...(FieldType as { options: readonly string[] }).options];
/**
* The spec's own `FieldType` vocabulary.
*
* The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924);
* the THROW stays HERE, because the reader deliberately answers `[]` rather than
* raising and this read is module-scope. What it replaces was a NON-OPTIONAL
* cast of the enum node to an options-bearing shape, spread directly — which
* failed LOUDLY the moment the cast stopped holding (spreading `undefined`
* throws), so a bare `enumOptions` call here would have traded a loud failure
* for a silently empty vocabulary: the derived assertions below would then pass
* over nothing. That trade is the regression objectui#7025 exists to refuse.
* (The retired spelling is deliberately NOT quoted here: the card's enumeration
* instrument is a grep for it, and a comment carrying the literal text makes
* every future re-derivation of this population read a false positive.)
*/
const readSpecTypes = (): readonly string[] => {
const options = enumOptions(FieldType);
if (options.length === 0) {
throw new Error('could not read FieldType.options from @objectstack/spec');
}
return options;
};

const SPEC_TYPES: readonly string[] = readSpecTypes();

/**
* ONE fixture, read by all three rules. `body` is the field the card is about;
Expand Down
28 changes: 25 additions & 3 deletions packages/plugin-dashboard/src/__tests__/expandableFamily.identity-5692.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -71,12 +71,34 @@ import { fileURLToPath } from 'node:url';
import { describe, it, expect, vi } from 'vitest';
import { EXPANDABLE_FIELD_TYPES } from '@object-ui/core';
import { FieldType } from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';
import { isLookupType } from '../recordFields';
import { computeLookupExpand } from '../ObjectDataTable';

const SPEC_FIELD_TYPES: readonly string[] = [
...(FieldType as unknown as { options: readonly string[] }).options,
];
/**
* The spec's own `FieldType` vocabulary.
*
* The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924);
* the THROW stays HERE, because the reader deliberately answers `[]` rather than
* raising and this read is module-scope. What it replaces was a NON-OPTIONAL
* cast of the enum node to an options-bearing shape, spread directly — which
* failed LOUDLY the moment the cast stopped holding (spreading `undefined`
* throws), so a bare `enumOptions` call here would have traded a loud failure
* for a silently empty vocabulary: every assertion below would then pass over
* nothing. That trade is the regression objectui#7025 exists to refuse. (The
* retired spelling is deliberately NOT quoted here: the card's enumeration
* instrument is a grep for it, and a comment carrying the literal text makes
* every future re-derivation of this population read a false positive.)
*/
const readSpecFieldTypes = (): readonly string[] => {
const options = enumOptions(FieldType);
if (options.length === 0) {
throw new Error('could not read FieldType.options from @objectstack/spec');
}
return options;
};

const SPEC_FIELD_TYPES: readonly string[] = readSpecFieldTypes();

/** The relations an ordinary dashboard table shows — the regression control. */
const ORDINARY_RELATIONS = ['lookup', 'master_detail', 'user'] as const;
Expand Down
26 changes: 25 additions & 1 deletion packages/plugin-detail/src/__tests__/autoLayout.wideSpelling.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -20,10 +20,34 @@
*/
import { describe, it, expect } from 'vitest';
import { FieldType } from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';
import { mapFieldTypeToFormType } from '@object-ui/fields';
import { isWideFieldType, applyAutoSpan } from '../autoLayout';

const SPEC_TYPES: readonly string[] = [...(FieldType as { options: readonly string[] }).options];
/**
* The spec's own `FieldType` vocabulary.
*
* The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924);
* the THROW stays HERE, because the reader deliberately answers `[]` rather than
* raising and this read is module-scope. What it replaces was a NON-OPTIONAL
* cast of the enum node to an options-bearing shape, spread directly — which
* failed LOUDLY the moment the cast stopped holding (spreading `undefined`
* throws), so a bare `enumOptions` call here would have traded a loud failure
* for a silently empty vocabulary: the derived assertions below would then pass
* over nothing. That trade is the regression objectui#7025 exists to refuse.
* (The retired spelling is deliberately NOT quoted here: the card's enumeration
* instrument is a grep for it, and a comment carrying the literal text makes
* every future re-derivation of this population read a false positive.)
*/
const readSpecTypes = (): readonly string[] => {
const options = enumOptions(FieldType);
if (options.length === 0) {
throw new Error('could not read FieldType.options from @objectstack/spec');
}
return options;
};

const SPEC_TYPES: readonly string[] = readSpecTypes();

/**
* The long-form / document family: the spec types whose value is a whole block
Expand Down
28 changes: 25 additions & 3 deletions packages/plugin-detail/src/__tests__/expandableFamily.identity-5874.test.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -66,12 +66,34 @@ import { render } from '@testing-library/react';
import React from 'react';
import { EXPANDABLE_FIELD_TYPES } from '@object-ui/core';
import { FieldType } from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';
import { HeaderHighlight } from '../HeaderHighlight';
import { RecordDetailDrawer } from '../RecordDetailDrawer';

const SPEC_FIELD_TYPES: readonly string[] = [
...(FieldType as unknown as { options: readonly string[] }).options,
];
/**
* The spec's own `FieldType` vocabulary.
*
* The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924);
* the THROW stays HERE, because the reader deliberately answers `[]` rather than
* raising and this read is module-scope. What it replaces was a NON-OPTIONAL
* cast of the enum node to an options-bearing shape, spread directly — which
* failed LOUDLY the moment the cast stopped holding (spreading `undefined`
* throws), so a bare `enumOptions` call here would have traded a loud failure
* for a silently empty vocabulary: every assertion below would then pass over
* nothing. That trade is the regression objectui#7025 exists to refuse. (The
* retired spelling is deliberately NOT quoted here: the card's enumeration
* instrument is a grep for it, and a comment carrying the literal text makes
* every future re-derivation of this population read a false positive.)
*/
const readSpecFieldTypes = (): readonly string[] => {
const options = enumOptions(FieldType);
if (options.length === 0) {
throw new Error('could not read FieldType.options from @objectstack/spec');
}
return options;
};

const SPEC_FIELD_TYPES: readonly string[] = readSpecFieldTypes();

/**
* The drawer hands its derived field list to `DetailView` as `schema.fields`.
Expand Down
1 change: 1 addition & 0 deletions packages/plugin-form/package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -37,6 +37,7 @@
},
"devDependencies": {
"@object-ui/data-objectstack": "workspace:*",
"@object-ui/test-support": "workspace:*",
"@vitejs/plugin-react": "^6.0.5",
"msw": "^2.15.0",
"typescript": "^6.0.3",
Expand Down
26 changes: 25 additions & 1 deletion packages/plugin-form/src/__tests__/autoLayout.wideSpelling.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,11 +19,35 @@
*/
import { describe, it, expect } from 'vitest';
import { FieldType } from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';
import { mapFieldTypeToFormType } from '@object-ui/fields';
import { isWideFieldType, resolveColSpan } from '../autoLayout';
import type { FormField } from '@object-ui/types';

const SPEC_TYPES: readonly string[] = [...(FieldType as { options: readonly string[] }).options];
/**
* The spec's own `FieldType` vocabulary.
*
* The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924);
* the THROW stays HERE, because the reader deliberately answers `[]` rather than
* raising and this read is module-scope. What it replaces was a NON-OPTIONAL
* cast of the enum node to an options-bearing shape, spread directly — which
* failed LOUDLY the moment the cast stopped holding (spreading `undefined`
* throws), so a bare `enumOptions` call here would have traded a loud failure
* for a silently empty vocabulary: the derived assertions below would then pass
* over nothing. That trade is the regression objectui#7025 exists to refuse.
* (The retired spelling is deliberately NOT quoted here: the card's enumeration
* instrument is a grep for it, and a comment carrying the literal text makes
* every future re-derivation of this population read a false positive.)
*/
const readSpecTypes = (): readonly string[] => {
const options = enumOptions(FieldType);
if (options.length === 0) {
throw new Error('could not read FieldType.options from @objectstack/spec');
}
return options;
};

const SPEC_TYPES: readonly string[] = readSpecTypes();

/** The long-form / document family, spelled as the SPEC spells it. */
const WIDE_SPEC_TYPES = ['textarea', 'markdown', 'html', 'richtext'] as const;
Expand Down
21 changes: 19 additions & 2 deletions packages/plugin-grid/src/__tests__/spec-symbol-batch7.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,15 +36,32 @@ import {
MULTI_CAPABLE_TYPES,
MULTI_OPTION_TYPES,
} from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';

import { SUPPORTED_SUMMARY_TYPES, type ColumnSummarySetting, type ColumnSummaryType } from '../useColumnSummary';
import { hasMultiValueShape } from '../hooks/multiValueFields';

const specSummaryOptions = (ColumnSummarySchema as unknown as { options: readonly string[] }).options;
/**
* The spec's column-summary vocabulary.
*
* The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924).
* No throw wrapper here — unlike the module-scope readers converted alongside it
* in objectui#7025, this suite already discharges the reader's non-vacuity duty
* with its OWN first assertion below, which is the sanctioned alternative. What
* it replaces was a NON-OPTIONAL cast of the enum node to an options-bearing
* shape; the loudness that cast provided is preserved by that assertion, not
* lost to `[]`.
*/
const specSummaryOptions: readonly string[] = enumOptions(ColumnSummarySchema);

describe('the column-summary vocabulary comes from the spec', () => {
it('reads a non-empty enum from the spec (the probe itself is not vacuous)', () => {
expect(Array.isArray(specSummaryOptions) && specSummaryOptions.length > 0).toBe(true);
// The reader answers `[]` when it cannot read the enum, so THIS is what
// keeps every assertion below from passing over an empty list.
expect(
specSummaryOptions,
'could not read ColumnSummarySchema.options from the spec',
).not.toEqual([]);
});

it('every aggregation the spec accepts is one this renderer computes', () => {
Expand Down
1 change: 1 addition & 0 deletions packages/plugin-kanban/package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -51,6 +51,7 @@
},
"devDependencies": {
"@object-ui/data-objectstack": "workspace:*",
"@object-ui/test-support": "workspace:*",
"@tailwindcss/postcss": "^4.3.3",
"@types/react": "19.2.18",
"@types/react-dom": "19.2.4",
Expand Down
28 changes: 25 additions & 3 deletions packages/plugin-kanban/src/__tests__/expandableFamily.identity-5874.test.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -63,6 +63,7 @@ import { render, waitFor } from '@testing-library/react';
import React from 'react';
import { EXPANDABLE_FIELD_TYPES } from '@object-ui/core';
import { FieldType } from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';
import { SchemaRenderer, SchemaRendererProvider } from '@object-ui/react';
// Registers `object-kanban`.
import '../index';
Expand All@@ -73,9 +74,30 @@ import '../index';
// so ESM's module cache makes that factory resolve immediately.
import '../KanbanImpl';

const SPEC_FIELD_TYPES: readonly string[] = [
...(FieldType as unknown as { options: readonly string[] }).options,
];
/**
* The spec's own `FieldType` vocabulary.
*
* The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924);
* the THROW stays HERE, because the reader deliberately answers `[]` rather than
* raising and this read is module-scope. What it replaces was a NON-OPTIONAL
* cast of the enum node to an options-bearing shape, spread directly — which
* failed LOUDLY the moment the cast stopped holding (spreading `undefined`
* throws), so a bare `enumOptions` call here would have traded a loud failure
* for a silently empty vocabulary: every assertion below would then pass over
* nothing. That trade is the regression objectui#7025 exists to refuse. (The
* retired spelling is deliberately NOT quoted here: the card's enumeration
* instrument is a grep for it, and a comment carrying the literal text makes
* every future re-derivation of this population read a false positive.)
*/
const readSpecFieldTypes = (): readonly string[] => {
const options = enumOptions(FieldType);
if (options.length === 0) {
throw new Error('could not read FieldType.options from @objectstack/spec');
}
return options;
};

const SPEC_FIELD_TYPES: readonly string[] = readSpecFieldTypes();

/**
* A board with NO `cardFields` and NO `highlightFields`, so cards fall to the
Expand Down
8 changes: 7 additions & 1 deletion packages/types/src/__tests__/spec-subschema-parity.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -39,6 +39,7 @@ import {
ChartTypeSchema as SpecChartTypeSchema,
PageTypeSchema as SpecPageTypeSchema,
} from '@objectstack/spec/ui';
import { enumOptions } from '@object-ui/test-support';
import {
HttpMethodSchema,
HttpRequestSchema,
Expand DownExpand Up@@ -175,7 +176,12 @@ describe('ListColumnSchema is the spec schema (the extension collapsed)', () =>
// arm through `lazySchema`, whose Proxy resolves `.shape.type` to the inner
// enum instead of the exported schema object, so a `toBe` check would test
// the wrapper rather than the vocabulary it is meant to protect.
const vocabulary = (SpecColumnSummarySchema as unknown as { options: string[] }).options;
// The wrapper walk is `@object-ui/test-support`'s shared reader
// (objectui#6924). No throw wrapper: the assertion on the next line already
// discharges the reader's non-vacuity duty, which is what keeps the loop
// below from passing over an empty vocabulary now that a failed read
// answers `[]` instead of throwing (objectui#7025).
const vocabulary = enumOptions(SpecColumnSummarySchema);
expect(vocabulary.length, 'spec ColumnSummarySchema should be a non-empty enum').toBeGreaterThan(0);

for (const agg of vocabulary) {
Expand Down
6 changes: 6 additions & 0 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
test(spec-parity): converge the non-optional enum-options casts onto the shared reader (#7025)#7057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-sam
merged 1 commit into

from

Aug 31, 2026
 Merged


test(spec-parity): converge the non-optional enum-options casts onto the shared reader (#7025)
#7057
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


20 changes: 20 additions & 0 deletions
.changeset/7025-nonoptional-enum-cast.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
---
---

Internal test-only change, no user-visible behaviour (objectui#7025).

The SIXTH spelling of the Zod-internals reader hazard objectui#5872 catalogues:
9 spec-parity test files in 7 packages cast an enum node NON-optionally to an
options-bearing shape and read `.options` straight off it. They converge onto
`@object-ui/test-support`'s `enumOptions(node)` — the same walk objectui#6924
converged the optional-cast family onto in PR #7024.

Unlike that family, these sites failed LOUDLY (spreading `undefined` throws), and
the shared reader deliberately answers `[]` rather than raising. So every site
keeps its own non-vacuity duty: a throwing wrapper at the seven module-scope
reads, and the suite's own pre-existing non-vacuity assertion at the two in-test
reads. A bare conversion would have traded a loud failure for a silent empty
vocabulary — a regression, not a convergence.

Only test files, two `devDependencies` edges and the lockfile change; no
package's shipped `dist/` and no public type moves.

28 changes: 25 additions & 3 deletions
packages/app-shell/src/utils/expandableFamily.identity-5874.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -54,16 +54,38 @@
import { describe, it, expect, vi, afterEach } from 'vitest';
import { EXPANDABLE_FIELD_TYPES } from '@object-ui/core';
import { FieldType } from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';
import { ActionParamSchema } from '@objectstack/spec/ui';
import {
 resolveActionParams,
 type ResolveActionParamsContext,
 type RawActionParam,
} from './resolveActionParams';

const SPEC_FIELD_TYPES: readonly string[] = [
 ...(FieldType as unknown as { options: readonly string[] }).options,
];
/**
 * The spec's own `FieldType` vocabulary.
 *
 * The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924);
 * the THROW stays HERE, because the reader deliberately answers `[]` rather than
 * raising and this read is module-scope. What it replaces was a NON-OPTIONAL
 * cast of the enum node to an options-bearing shape, spread directly — which
 * failed LOUDLY the moment the cast stopped holding (spreading `undefined`
 * throws), so a bare `enumOptions` call here would have traded a loud failure
 * for a silently empty vocabulary: every assertion below would then pass over
 * nothing. That trade is the regression objectui#7025 exists to refuse. (The
 * retired spelling is deliberately NOT quoted here: the card's enumeration
 * instrument is a grep for it, and a comment carrying the literal text makes
 * every future re-derivation of this population read a false positive.)
 */
const readSpecFieldTypes = (): readonly string[] => {
 const options = enumOptions(FieldType);
 if (options.length === 0) {
 throw new Error('could not read FieldType.options from @objectstack/spec');
 }
 return options;
};

const SPEC_FIELD_TYPES: readonly string[] = readSpecFieldTypes();

/** Every picker key `lookupExtras` copies off the resolved object field. */
const PICKER_KEYS = [
Expand Down

26 changes: 25 additions & 1 deletion
packages/app-shell/src/views/richtextSurfaceParity.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -27,11 +27,35 @@
 */
import { describe, it, expect } from 'vitest';
import { FieldType } from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';
import { isWideFieldType as detailIsWide } from '@object-ui/plugin-detail';
import { isWideFieldType as formIsWide } from '@object-ui/plugin-form';
import { isSecondaryField } from './RecordDetailView';

const SPEC_TYPES: readonly string[] = [...(FieldType as { options: readonly string[] }).options];
/**
 * The spec's own `FieldType` vocabulary.
 *
 * The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924);
 * the THROW stays HERE, because the reader deliberately answers `[]` rather than
 * raising and this read is module-scope. What it replaces was a NON-OPTIONAL
 * cast of the enum node to an options-bearing shape, spread directly — which
 * failed LOUDLY the moment the cast stopped holding (spreading `undefined`
 * throws), so a bare `enumOptions` call here would have traded a loud failure
 * for a silently empty vocabulary: the derived assertions below would then pass
 * over nothing. That trade is the regression objectui#7025 exists to refuse.
 * (The retired spelling is deliberately NOT quoted here: the card's enumeration
 * instrument is a grep for it, and a comment carrying the literal text makes
 * every future re-derivation of this population read a false positive.)
 */
const readSpecTypes = (): readonly string[] => {
 const options = enumOptions(FieldType);
 if (options.length === 0) {
 throw new Error('could not read FieldType.options from @objectstack/spec');
 }
 return options;
};

const SPEC_TYPES: readonly string[] = readSpecTypes();

/**
 * ONE fixture, read by all three rules. `body` is the field the card is about;
Expand Down

28 changes: 25 additions & 3 deletions
packages/plugin-dashboard/src/__tests__/expandableFamily.identity-5692.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -71,12 +71,34 @@ import { fileURLToPath } from 'node:url';
import { describe, it, expect, vi } from 'vitest';
import { EXPANDABLE_FIELD_TYPES } from '@object-ui/core';
import { FieldType } from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';
import { isLookupType } from '../recordFields';
import { computeLookupExpand } from '../ObjectDataTable';

const SPEC_FIELD_TYPES: readonly string[] = [
 ...(FieldType as unknown as { options: readonly string[] }).options,
];
/**
 * The spec's own `FieldType` vocabulary.
 *
 * The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924);
 * the THROW stays HERE, because the reader deliberately answers `[]` rather than
 * raising and this read is module-scope. What it replaces was a NON-OPTIONAL
 * cast of the enum node to an options-bearing shape, spread directly — which
 * failed LOUDLY the moment the cast stopped holding (spreading `undefined`
 * throws), so a bare `enumOptions` call here would have traded a loud failure
 * for a silently empty vocabulary: every assertion below would then pass over
 * nothing. That trade is the regression objectui#7025 exists to refuse. (The
 * retired spelling is deliberately NOT quoted here: the card's enumeration
 * instrument is a grep for it, and a comment carrying the literal text makes
 * every future re-derivation of this population read a false positive.)
 */
const readSpecFieldTypes = (): readonly string[] => {
 const options = enumOptions(FieldType);
 if (options.length === 0) {
 throw new Error('could not read FieldType.options from @objectstack/spec');
 }
 return options;
};

const SPEC_FIELD_TYPES: readonly string[] = readSpecFieldTypes();

/** The relations an ordinary dashboard table shows — the regression control. */
const ORDINARY_RELATIONS = ['lookup', 'master_detail', 'user'] as const;
Expand Down

26 changes: 25 additions & 1 deletion
packages/plugin-detail/src/__tests__/autoLayout.wideSpelling.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -20,10 +20,34 @@
 */
import { describe, it, expect } from 'vitest';
import { FieldType } from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';
import { mapFieldTypeToFormType } from '@object-ui/fields';
import { isWideFieldType, applyAutoSpan } from '../autoLayout';

const SPEC_TYPES: readonly string[] = [...(FieldType as { options: readonly string[] }).options];
/**
 * The spec's own `FieldType` vocabulary.
 *
 * The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924);
 * the THROW stays HERE, because the reader deliberately answers `[]` rather than
 * raising and this read is module-scope. What it replaces was a NON-OPTIONAL
 * cast of the enum node to an options-bearing shape, spread directly — which
 * failed LOUDLY the moment the cast stopped holding (spreading `undefined`
 * throws), so a bare `enumOptions` call here would have traded a loud failure
 * for a silently empty vocabulary: the derived assertions below would then pass
 * over nothing. That trade is the regression objectui#7025 exists to refuse.
 * (The retired spelling is deliberately NOT quoted here: the card's enumeration
 * instrument is a grep for it, and a comment carrying the literal text makes
 * every future re-derivation of this population read a false positive.)
 */
const readSpecTypes = (): readonly string[] => {
 const options = enumOptions(FieldType);
 if (options.length === 0) {
 throw new Error('could not read FieldType.options from @objectstack/spec');
 }
 return options;
};

const SPEC_TYPES: readonly string[] = readSpecTypes();

/**
 * The long-form / document family: the spec types whose value is a whole block
Expand Down

28 changes: 25 additions & 3 deletions
packages/plugin-detail/src/__tests__/expandableFamily.identity-5874.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -66,12 +66,34 @@ import { render } from '@testing-library/react';
import React from 'react';
import { EXPANDABLE_FIELD_TYPES } from '@object-ui/core';
import { FieldType } from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';
import { HeaderHighlight } from '../HeaderHighlight';
import { RecordDetailDrawer } from '../RecordDetailDrawer';

const SPEC_FIELD_TYPES: readonly string[] = [
 ...(FieldType as unknown as { options: readonly string[] }).options,
];
/**
 * The spec's own `FieldType` vocabulary.
 *
 * The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924);
 * the THROW stays HERE, because the reader deliberately answers `[]` rather than
 * raising and this read is module-scope. What it replaces was a NON-OPTIONAL
 * cast of the enum node to an options-bearing shape, spread directly — which
 * failed LOUDLY the moment the cast stopped holding (spreading `undefined`
 * throws), so a bare `enumOptions` call here would have traded a loud failure
 * for a silently empty vocabulary: every assertion below would then pass over
 * nothing. That trade is the regression objectui#7025 exists to refuse. (The
 * retired spelling is deliberately NOT quoted here: the card's enumeration
 * instrument is a grep for it, and a comment carrying the literal text makes
 * every future re-derivation of this population read a false positive.)
 */
const readSpecFieldTypes = (): readonly string[] => {
 const options = enumOptions(FieldType);
 if (options.length === 0) {
 throw new Error('could not read FieldType.options from @objectstack/spec');
 }
 return options;
};

const SPEC_FIELD_TYPES: readonly string[] = readSpecFieldTypes();

/**
 * The drawer hands its derived field list to `DetailView` as `schema.fields`.
Expand Down

1 change: 1 addition & 0 deletions
packages/plugin-form/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -37,6 +37,7 @@
 },
 "devDependencies": {
 "@object-ui/data-objectstack": "workspace:*",
 "@object-ui/test-support": "workspace:*",
 "@vitejs/plugin-react": "^6.0.5",
 "msw": "^2.15.0",
 "typescript": "^6.0.3",
Expand Down

26 changes: 25 additions & 1 deletion
packages/plugin-form/src/__tests__/autoLayout.wideSpelling.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -19,11 +19,35 @@
 */
import { describe, it, expect } from 'vitest';
import { FieldType } from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';
import { mapFieldTypeToFormType } from '@object-ui/fields';
import { isWideFieldType, resolveColSpan } from '../autoLayout';
import type { FormField } from '@object-ui/types';

const SPEC_TYPES: readonly string[] = [...(FieldType as { options: readonly string[] }).options];
/**
 * The spec's own `FieldType` vocabulary.
 *
 * The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924);
 * the THROW stays HERE, because the reader deliberately answers `[]` rather than
 * raising and this read is module-scope. What it replaces was a NON-OPTIONAL
 * cast of the enum node to an options-bearing shape, spread directly — which
 * failed LOUDLY the moment the cast stopped holding (spreading `undefined`
 * throws), so a bare `enumOptions` call here would have traded a loud failure
 * for a silently empty vocabulary: the derived assertions below would then pass
 * over nothing. That trade is the regression objectui#7025 exists to refuse.
 * (The retired spelling is deliberately NOT quoted here: the card's enumeration
 * instrument is a grep for it, and a comment carrying the literal text makes
 * every future re-derivation of this population read a false positive.)
 */
const readSpecTypes = (): readonly string[] => {
 const options = enumOptions(FieldType);
 if (options.length === 0) {
 throw new Error('could not read FieldType.options from @objectstack/spec');
 }
 return options;
};

const SPEC_TYPES: readonly string[] = readSpecTypes();

/** The long-form / document family, spelled as the SPEC spells it. */
const WIDE_SPEC_TYPES = ['textarea', 'markdown', 'html', 'richtext'] as const;
Expand Down

21 changes: 19 additions & 2 deletions
packages/plugin-grid/src/__tests__/spec-symbol-batch7.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,15 +36,32 @@ import {
 MULTI_CAPABLE_TYPES,
 MULTI_OPTION_TYPES,
} from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';

import { SUPPORTED_SUMMARY_TYPES, type ColumnSummarySetting, type ColumnSummaryType } from '../useColumnSummary';
import { hasMultiValueShape } from '../hooks/multiValueFields';

const specSummaryOptions = (ColumnSummarySchema as unknown as { options: readonly string[] }).options;
/**
 * The spec's column-summary vocabulary.
 *
 * The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924).
 * No throw wrapper here — unlike the module-scope readers converted alongside it
 * in objectui#7025, this suite already discharges the reader's non-vacuity duty
 * with its OWN first assertion below, which is the sanctioned alternative. What
 * it replaces was a NON-OPTIONAL cast of the enum node to an options-bearing
 * shape; the loudness that cast provided is preserved by that assertion, not
 * lost to `[]`.
 */
const specSummaryOptions: readonly string[] = enumOptions(ColumnSummarySchema);

describe('the column-summary vocabulary comes from the spec', () => {
 it('reads a non-empty enum from the spec (the probe itself is not vacuous)', () => {
 expect(Array.isArray(specSummaryOptions) && specSummaryOptions.length > 0).toBe(true);
 // The reader answers `[]` when it cannot read the enum, so THIS is what
 // keeps every assertion below from passing over an empty list.
 expect(
 specSummaryOptions,
 'could not read ColumnSummarySchema.options from the spec',
 ).not.toEqual([]);
 });

 it('every aggregation the spec accepts is one this renderer computes', () => {
Expand Down

1 change: 1 addition & 0 deletions
packages/plugin-kanban/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,6 +51,7 @@
 },
 "devDependencies": {
 "@object-ui/data-objectstack": "workspace:*",
 "@object-ui/test-support": "workspace:*",
 "@tailwindcss/postcss": "^4.3.3",
 "@types/react": "19.2.18",
 "@types/react-dom": "19.2.4",
Expand Down

28 changes: 25 additions & 3 deletions
packages/plugin-kanban/src/__tests__/expandableFamily.identity-5874.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -63,6 +63,7 @@ import { render, waitFor } from '@testing-library/react';
import React from 'react';
import { EXPANDABLE_FIELD_TYPES } from '@object-ui/core';
import { FieldType } from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';
import { SchemaRenderer, SchemaRendererProvider } from '@object-ui/react';
// Registers `object-kanban`.
import '../index';
Expand All@@ -73,9 +74,30 @@ import '../index';
// so ESM's module cache makes that factory resolve immediately.
import '../KanbanImpl';

const SPEC_FIELD_TYPES: readonly string[] = [
 ...(FieldType as unknown as { options: readonly string[] }).options,
];
/**
 * The spec's own `FieldType` vocabulary.
 *
 * The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924);
 * the THROW stays HERE, because the reader deliberately answers `[]` rather than
 * raising and this read is module-scope. What it replaces was a NON-OPTIONAL
 * cast of the enum node to an options-bearing shape, spread directly — which
 * failed LOUDLY the moment the cast stopped holding (spreading `undefined`
 * throws), so a bare `enumOptions` call here would have traded a loud failure
 * for a silently empty vocabulary: every assertion below would then pass over
 * nothing. That trade is the regression objectui#7025 exists to refuse. (The
 * retired spelling is deliberately NOT quoted here: the card's enumeration
 * instrument is a grep for it, and a comment carrying the literal text makes
 * every future re-derivation of this population read a false positive.)
 */
const readSpecFieldTypes = (): readonly string[] => {
 const options = enumOptions(FieldType);
 if (options.length === 0) {
 throw new Error('could not read FieldType.options from @objectstack/spec');
 }
 return options;
};

const SPEC_FIELD_TYPES: readonly string[] = readSpecFieldTypes();

/**
 * A board with NO `cardFields` and NO `highlightFields`, so cards fall to the
Expand Down

8 changes: 7 additions & 1 deletion
packages/types/src/__tests__/spec-subschema-parity.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -39,6 +39,7 @@ import {
 ChartTypeSchema as SpecChartTypeSchema,
 PageTypeSchema as SpecPageTypeSchema,
} from '@objectstack/spec/ui';
import { enumOptions } from '@object-ui/test-support';
import {
 HttpMethodSchema,
 HttpRequestSchema,
Expand DownExpand Up@@ -175,7 +176,12 @@ describe('ListColumnSchema is the spec schema (the extension collapsed)', () =>
 // arm through `lazySchema`, whose Proxy resolves `.shape.type` to the inner
 // enum instead of the exported schema object, so a `toBe` check would test
 // the wrapper rather than the vocabulary it is meant to protect.
 const vocabulary = (SpecColumnSummarySchema as unknown as { options: string[] }).options;
 // The wrapper walk is `@object-ui/test-support`'s shared reader
 // (objectui#6924). No throw wrapper: the assertion on the next line already
 // discharges the reader's non-vacuity duty, which is what keeps the loop
 // below from passing over an empty vocabulary now that a failed read
 // answers `[]` instead of throwing (objectui#7025).
 const vocabulary = enumOptions(SpecColumnSummarySchema);
 expect(vocabulary.length, 'spec ColumnSummarySchema should be a non-empty enum').toBeGreaterThan(0);

 for (const agg of vocabulary) {
Expand Down

6 changes: 6 additions & 0 deletions
pnpm-lock.yaml

View file


Open in desktop


Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
test(spec-parity): converge the non-optional enum-options casts onto the shared reader (#7025)#7057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-sam
merged 1 commit into

from

Aug 31, 2026
 Merged


test(spec-parity): converge the non-optional enum-options casts onto the shared reader (#7025)
#7057
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


20 changes: 20 additions & 0 deletions
.changeset/7025-nonoptional-enum-cast.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
---
---

Internal test-only change, no user-visible behaviour (objectui#7025).

The SIXTH spelling of the Zod-internals reader hazard objectui#5872 catalogues:
9 spec-parity test files in 7 packages cast an enum node NON-optionally to an
options-bearing shape and read `.options` straight off it. They converge onto
`@object-ui/test-support`'s `enumOptions(node)` — the same walk objectui#6924
converged the optional-cast family onto in PR #7024.

Unlike that family, these sites failed LOUDLY (spreading `undefined` throws), and
the shared reader deliberately answers `[]` rather than raising. So every site
keeps its own non-vacuity duty: a throwing wrapper at the seven module-scope
reads, and the suite's own pre-existing non-vacuity assertion at the two in-test
reads. A bare conversion would have traded a loud failure for a silent empty
vocabulary — a regression, not a convergence.

Only test files, two `devDependencies` edges and the lockfile change; no
package's shipped `dist/` and no public type moves.

28 changes: 25 additions & 3 deletions
packages/app-shell/src/utils/expandableFamily.identity-5874.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -54,16 +54,38 @@
import { describe, it, expect, vi, afterEach } from 'vitest';
import { EXPANDABLE_FIELD_TYPES } from '@object-ui/core';
import { FieldType } from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';
import { ActionParamSchema } from '@objectstack/spec/ui';
import {
 resolveActionParams,
 type ResolveActionParamsContext,
 type RawActionParam,
} from './resolveActionParams';

const SPEC_FIELD_TYPES: readonly string[] = [
 ...(FieldType as unknown as { options: readonly string[] }).options,
];
/**
 * The spec's own `FieldType` vocabulary.
 *
 * The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924);
 * the THROW stays HERE, because the reader deliberately answers `[]` rather than
 * raising and this read is module-scope. What it replaces was a NON-OPTIONAL
 * cast of the enum node to an options-bearing shape, spread directly — which
 * failed LOUDLY the moment the cast stopped holding (spreading `undefined`
 * throws), so a bare `enumOptions` call here would have traded a loud failure
 * for a silently empty vocabulary: every assertion below would then pass over
 * nothing. That trade is the regression objectui#7025 exists to refuse. (The
 * retired spelling is deliberately NOT quoted here: the card's enumeration
 * instrument is a grep for it, and a comment carrying the literal text makes
 * every future re-derivation of this population read a false positive.)
 */
const readSpecFieldTypes = (): readonly string[] => {
 const options = enumOptions(FieldType);
 if (options.length === 0) {
 throw new Error('could not read FieldType.options from @objectstack/spec');
 }
 return options;
};

const SPEC_FIELD_TYPES: readonly string[] = readSpecFieldTypes();

/** Every picker key `lookupExtras` copies off the resolved object field. */
const PICKER_KEYS = [
Expand Down

26 changes: 25 additions & 1 deletion
packages/app-shell/src/views/richtextSurfaceParity.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -27,11 +27,35 @@
 */
import { describe, it, expect } from 'vitest';
import { FieldType } from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';
import { isWideFieldType as detailIsWide } from '@object-ui/plugin-detail';
import { isWideFieldType as formIsWide } from '@object-ui/plugin-form';
import { isSecondaryField } from './RecordDetailView';

const SPEC_TYPES: readonly string[] = [...(FieldType as { options: readonly string[] }).options];
/**
 * The spec's own `FieldType` vocabulary.
 *
 * The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924);
 * the THROW stays HERE, because the reader deliberately answers `[]` rather than
 * raising and this read is module-scope. What it replaces was a NON-OPTIONAL
 * cast of the enum node to an options-bearing shape, spread directly — which
 * failed LOUDLY the moment the cast stopped holding (spreading `undefined`
 * throws), so a bare `enumOptions` call here would have traded a loud failure
 * for a silently empty vocabulary: the derived assertions below would then pass
 * over nothing. That trade is the regression objectui#7025 exists to refuse.
 * (The retired spelling is deliberately NOT quoted here: the card's enumeration
 * instrument is a grep for it, and a comment carrying the literal text makes
 * every future re-derivation of this population read a false positive.)
 */
const readSpecTypes = (): readonly string[] => {
 const options = enumOptions(FieldType);
 if (options.length === 0) {
 throw new Error('could not read FieldType.options from @objectstack/spec');
 }
 return options;
};

const SPEC_TYPES: readonly string[] = readSpecTypes();

/**
 * ONE fixture, read by all three rules. `body` is the field the card is about;
Expand Down

28 changes: 25 additions & 3 deletions
packages/plugin-dashboard/src/__tests__/expandableFamily.identity-5692.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -71,12 +71,34 @@ import { fileURLToPath } from 'node:url';
import { describe, it, expect, vi } from 'vitest';
import { EXPANDABLE_FIELD_TYPES } from '@object-ui/core';
import { FieldType } from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';
import { isLookupType } from '../recordFields';
import { computeLookupExpand } from '../ObjectDataTable';

const SPEC_FIELD_TYPES: readonly string[] = [
 ...(FieldType as unknown as { options: readonly string[] }).options,
];
/**
 * The spec's own `FieldType` vocabulary.
 *
 * The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924);
 * the THROW stays HERE, because the reader deliberately answers `[]` rather than
 * raising and this read is module-scope. What it replaces was a NON-OPTIONAL
 * cast of the enum node to an options-bearing shape, spread directly — which
 * failed LOUDLY the moment the cast stopped holding (spreading `undefined`
 * throws), so a bare `enumOptions` call here would have traded a loud failure
 * for a silently empty vocabulary: every assertion below would then pass over
 * nothing. That trade is the regression objectui#7025 exists to refuse. (The
 * retired spelling is deliberately NOT quoted here: the card's enumeration
 * instrument is a grep for it, and a comment carrying the literal text makes
 * every future re-derivation of this population read a false positive.)
 */
const readSpecFieldTypes = (): readonly string[] => {
 const options = enumOptions(FieldType);
 if (options.length === 0) {
 throw new Error('could not read FieldType.options from @objectstack/spec');
 }
 return options;
};

const SPEC_FIELD_TYPES: readonly string[] = readSpecFieldTypes();

/** The relations an ordinary dashboard table shows — the regression control. */
const ORDINARY_RELATIONS = ['lookup', 'master_detail', 'user'] as const;
Expand Down

26 changes: 25 additions & 1 deletion
packages/plugin-detail/src/__tests__/autoLayout.wideSpelling.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -20,10 +20,34 @@
 */
import { describe, it, expect } from 'vitest';
import { FieldType } from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';
import { mapFieldTypeToFormType } from '@object-ui/fields';
import { isWideFieldType, applyAutoSpan } from '../autoLayout';

const SPEC_TYPES: readonly string[] = [...(FieldType as { options: readonly string[] }).options];
/**
 * The spec's own `FieldType` vocabulary.
 *
 * The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924);
 * the THROW stays HERE, because the reader deliberately answers `[]` rather than
 * raising and this read is module-scope. What it replaces was a NON-OPTIONAL
 * cast of the enum node to an options-bearing shape, spread directly — which
 * failed LOUDLY the moment the cast stopped holding (spreading `undefined`
 * throws), so a bare `enumOptions` call here would have traded a loud failure
 * for a silently empty vocabulary: the derived assertions below would then pass
 * over nothing. That trade is the regression objectui#7025 exists to refuse.
 * (The retired spelling is deliberately NOT quoted here: the card's enumeration
 * instrument is a grep for it, and a comment carrying the literal text makes
 * every future re-derivation of this population read a false positive.)
 */
const readSpecTypes = (): readonly string[] => {
 const options = enumOptions(FieldType);
 if (options.length === 0) {
 throw new Error('could not read FieldType.options from @objectstack/spec');
 }
 return options;
};

const SPEC_TYPES: readonly string[] = readSpecTypes();

/**
 * The long-form / document family: the spec types whose value is a whole block
Expand Down

28 changes: 25 additions & 3 deletions
packages/plugin-detail/src/__tests__/expandableFamily.identity-5874.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -66,12 +66,34 @@ import { render } from '@testing-library/react';
import React from 'react';
import { EXPANDABLE_FIELD_TYPES } from '@object-ui/core';
import { FieldType } from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';
import { HeaderHighlight } from '../HeaderHighlight';
import { RecordDetailDrawer } from '../RecordDetailDrawer';

const SPEC_FIELD_TYPES: readonly string[] = [
 ...(FieldType as unknown as { options: readonly string[] }).options,
];
/**
 * The spec's own `FieldType` vocabulary.
 *
 * The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924);
 * the THROW stays HERE, because the reader deliberately answers `[]` rather than
 * raising and this read is module-scope. What it replaces was a NON-OPTIONAL
 * cast of the enum node to an options-bearing shape, spread directly — which
 * failed LOUDLY the moment the cast stopped holding (spreading `undefined`
 * throws), so a bare `enumOptions` call here would have traded a loud failure
 * for a silently empty vocabulary: every assertion below would then pass over
 * nothing. That trade is the regression objectui#7025 exists to refuse. (The
 * retired spelling is deliberately NOT quoted here: the card's enumeration
 * instrument is a grep for it, and a comment carrying the literal text makes
 * every future re-derivation of this population read a false positive.)
 */
const readSpecFieldTypes = (): readonly string[] => {
 const options = enumOptions(FieldType);
 if (options.length === 0) {
 throw new Error('could not read FieldType.options from @objectstack/spec');
 }
 return options;
};

const SPEC_FIELD_TYPES: readonly string[] = readSpecFieldTypes();

/**
 * The drawer hands its derived field list to `DetailView` as `schema.fields`.
Expand Down

1 change: 1 addition & 0 deletions
packages/plugin-form/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -37,6 +37,7 @@
 },
 "devDependencies": {
 "@object-ui/data-objectstack": "workspace:*",
 "@object-ui/test-support": "workspace:*",
 "@vitejs/plugin-react": "^6.0.5",
 "msw": "^2.15.0",
 "typescript": "^6.0.3",
Expand Down

26 changes: 25 additions & 1 deletion
packages/plugin-form/src/__tests__/autoLayout.wideSpelling.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -19,11 +19,35 @@
 */
import { describe, it, expect } from 'vitest';
import { FieldType } from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';
import { mapFieldTypeToFormType } from '@object-ui/fields';
import { isWideFieldType, resolveColSpan } from '../autoLayout';
import type { FormField } from '@object-ui/types';

const SPEC_TYPES: readonly string[] = [...(FieldType as { options: readonly string[] }).options];
/**
 * The spec's own `FieldType` vocabulary.
 *
 * The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924);
 * the THROW stays HERE, because the reader deliberately answers `[]` rather than
 * raising and this read is module-scope. What it replaces was a NON-OPTIONAL
 * cast of the enum node to an options-bearing shape, spread directly — which
 * failed LOUDLY the moment the cast stopped holding (spreading `undefined`
 * throws), so a bare `enumOptions` call here would have traded a loud failure
 * for a silently empty vocabulary: the derived assertions below would then pass
 * over nothing. That trade is the regression objectui#7025 exists to refuse.
 * (The retired spelling is deliberately NOT quoted here: the card's enumeration
 * instrument is a grep for it, and a comment carrying the literal text makes
 * every future re-derivation of this population read a false positive.)
 */
const readSpecTypes = (): readonly string[] => {
 const options = enumOptions(FieldType);
 if (options.length === 0) {
 throw new Error('could not read FieldType.options from @objectstack/spec');
 }
 return options;
};

const SPEC_TYPES: readonly string[] = readSpecTypes();

/** The long-form / document family, spelled as the SPEC spells it. */
const WIDE_SPEC_TYPES = ['textarea', 'markdown', 'html', 'richtext'] as const;
Expand Down

21 changes: 19 additions & 2 deletions
packages/plugin-grid/src/__tests__/spec-symbol-batch7.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,15 +36,32 @@ import {
 MULTI_CAPABLE_TYPES,
 MULTI_OPTION_TYPES,
} from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';

import { SUPPORTED_SUMMARY_TYPES, type ColumnSummarySetting, type ColumnSummaryType } from '../useColumnSummary';
import { hasMultiValueShape } from '../hooks/multiValueFields';

const specSummaryOptions = (ColumnSummarySchema as unknown as { options: readonly string[] }).options;
/**
 * The spec's column-summary vocabulary.
 *
 * The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924).
 * No throw wrapper here — unlike the module-scope readers converted alongside it
 * in objectui#7025, this suite already discharges the reader's non-vacuity duty
 * with its OWN first assertion below, which is the sanctioned alternative. What
 * it replaces was a NON-OPTIONAL cast of the enum node to an options-bearing
 * shape; the loudness that cast provided is preserved by that assertion, not
 * lost to `[]`.
 */
const specSummaryOptions: readonly string[] = enumOptions(ColumnSummarySchema);

describe('the column-summary vocabulary comes from the spec', () => {
 it('reads a non-empty enum from the spec (the probe itself is not vacuous)', () => {
 expect(Array.isArray(specSummaryOptions) && specSummaryOptions.length > 0).toBe(true);
 // The reader answers `[]` when it cannot read the enum, so THIS is what
 // keeps every assertion below from passing over an empty list.
 expect(
 specSummaryOptions,
 'could not read ColumnSummarySchema.options from the spec',
 ).not.toEqual([]);
 });

 it('every aggregation the spec accepts is one this renderer computes', () => {
Expand Down

1 change: 1 addition & 0 deletions
packages/plugin-kanban/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,6 +51,7 @@
 },
 "devDependencies": {
 "@object-ui/data-objectstack": "workspace:*",
 "@object-ui/test-support": "workspace:*",
 "@tailwindcss/postcss": "^4.3.3",
 "@types/react": "19.2.18",
 "@types/react-dom": "19.2.4",
Expand Down

28 changes: 25 additions & 3 deletions
packages/plugin-kanban/src/__tests__/expandableFamily.identity-5874.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -63,6 +63,7 @@ import { render, waitFor } from '@testing-library/react';
import React from 'react';
import { EXPANDABLE_FIELD_TYPES } from '@object-ui/core';
import { FieldType } from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';
import { SchemaRenderer, SchemaRendererProvider } from '@object-ui/react';
// Registers `object-kanban`.
import '../index';
Expand All@@ -73,9 +74,30 @@ import '../index';
// so ESM's module cache makes that factory resolve immediately.
import '../KanbanImpl';

const SPEC_FIELD_TYPES: readonly string[] = [
 ...(FieldType as unknown as { options: readonly string[] }).options,
];
/**
 * The spec's own `FieldType` vocabulary.
 *
 * The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924);
 * the THROW stays HERE, because the reader deliberately answers `[]` rather than
 * raising and this read is module-scope. What it replaces was a NON-OPTIONAL
 * cast of the enum node to an options-bearing shape, spread directly — which
 * failed LOUDLY the moment the cast stopped holding (spreading `undefined`
 * throws), so a bare `enumOptions` call here would have traded a loud failure
 * for a silently empty vocabulary: every assertion below would then pass over
 * nothing. That trade is the regression objectui#7025 exists to refuse. (The
 * retired spelling is deliberately NOT quoted here: the card's enumeration
 * instrument is a grep for it, and a comment carrying the literal text makes
 * every future re-derivation of this population read a false positive.)
 */
const readSpecFieldTypes = (): readonly string[] => {
 const options = enumOptions(FieldType);
 if (options.length === 0) {
 throw new Error('could not read FieldType.options from @objectstack/spec');
 }
 return options;
};

const SPEC_FIELD_TYPES: readonly string[] = readSpecFieldTypes();

/**
 * A board with NO `cardFields` and NO `highlightFields`, so cards fall to the
Expand Down

8 changes: 7 additions & 1 deletion
packages/types/src/__tests__/spec-subschema-parity.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -39,6 +39,7 @@ import {
 ChartTypeSchema as SpecChartTypeSchema,
 PageTypeSchema as SpecPageTypeSchema,
} from '@objectstack/spec/ui';
import { enumOptions } from '@object-ui/test-support';
import {
 HttpMethodSchema,
 HttpRequestSchema,
Expand DownExpand Up@@ -175,7 +176,12 @@ describe('ListColumnSchema is the spec schema (the extension collapsed)', () =>
 // arm through `lazySchema`, whose Proxy resolves `.shape.type` to the inner
 // enum instead of the exported schema object, so a `toBe` check would test
 // the wrapper rather than the vocabulary it is meant to protect.
 const vocabulary = (SpecColumnSummarySchema as unknown as { options: string[] }).options;
 // The wrapper walk is `@object-ui/test-support`'s shared reader
 // (objectui#6924). No throw wrapper: the assertion on the next line already
 // discharges the reader's non-vacuity duty, which is what keeps the loop
 // below from passing over an empty vocabulary now that a failed read
 // answers `[]` instead of throwing (objectui#7025).
 const vocabulary = enumOptions(SpecColumnSummarySchema);
 expect(vocabulary.length, 'spec ColumnSummarySchema should be a non-empty enum').toBeGreaterThan(0);

 for (const agg of vocabulary) {
Expand Down

6 changes: 6 additions & 0 deletions
pnpm-lock.yaml

View file


Open in desktop


Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
test(spec-parity): converge the non-optional enum-options casts onto the shared reader (#7025)#7057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-sam
merged 1 commit into

from

Aug 31, 2026
 Merged


test(spec-parity): converge the non-optional enum-options casts onto the shared reader (#7025)
#7057
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


20 changes: 20 additions & 0 deletions
.changeset/7025-nonoptional-enum-cast.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
---
---

Internal test-only change, no user-visible behaviour (objectui#7025).

The SIXTH spelling of the Zod-internals reader hazard objectui#5872 catalogues:
9 spec-parity test files in 7 packages cast an enum node NON-optionally to an
options-bearing shape and read `.options` straight off it. They converge onto
`@object-ui/test-support`'s `enumOptions(node)` — the same walk objectui#6924
converged the optional-cast family onto in PR #7024.

Unlike that family, these sites failed LOUDLY (spreading `undefined` throws), and
the shared reader deliberately answers `[]` rather than raising. So every site
keeps its own non-vacuity duty: a throwing wrapper at the seven module-scope
reads, and the suite's own pre-existing non-vacuity assertion at the two in-test
reads. A bare conversion would have traded a loud failure for a silent empty
vocabulary — a regression, not a convergence.

Only test files, two `devDependencies` edges and the lockfile change; no
package's shipped `dist/` and no public type moves.

28 changes: 25 additions & 3 deletions
packages/app-shell/src/utils/expandableFamily.identity-5874.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -54,16 +54,38 @@
import { describe, it, expect, vi, afterEach } from 'vitest';
import { EXPANDABLE_FIELD_TYPES } from '@object-ui/core';
import { FieldType } from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';
import { ActionParamSchema } from '@objectstack/spec/ui';
import {
 resolveActionParams,
 type ResolveActionParamsContext,
 type RawActionParam,
} from './resolveActionParams';

const SPEC_FIELD_TYPES: readonly string[] = [
 ...(FieldType as unknown as { options: readonly string[] }).options,
];
/**
 * The spec's own `FieldType` vocabulary.
 *
 * The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924);
 * the THROW stays HERE, because the reader deliberately answers `[]` rather than
 * raising and this read is module-scope. What it replaces was a NON-OPTIONAL
 * cast of the enum node to an options-bearing shape, spread directly — which
 * failed LOUDLY the moment the cast stopped holding (spreading `undefined`
 * throws), so a bare `enumOptions` call here would have traded a loud failure
 * for a silently empty vocabulary: every assertion below would then pass over
 * nothing. That trade is the regression objectui#7025 exists to refuse. (The
 * retired spelling is deliberately NOT quoted here: the card's enumeration
 * instrument is a grep for it, and a comment carrying the literal text makes
 * every future re-derivation of this population read a false positive.)
 */
const readSpecFieldTypes = (): readonly string[] => {
 const options = enumOptions(FieldType);
 if (options.length === 0) {
 throw new Error('could not read FieldType.options from @objectstack/spec');
 }
 return options;
};

const SPEC_FIELD_TYPES: readonly string[] = readSpecFieldTypes();

/** Every picker key `lookupExtras` copies off the resolved object field. */
const PICKER_KEYS = [
Expand Down

26 changes: 25 additions & 1 deletion
packages/app-shell/src/views/richtextSurfaceParity.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -27,11 +27,35 @@
 */
import { describe, it, expect } from 'vitest';
import { FieldType } from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';
import { isWideFieldType as detailIsWide } from '@object-ui/plugin-detail';
import { isWideFieldType as formIsWide } from '@object-ui/plugin-form';
import { isSecondaryField } from './RecordDetailView';

const SPEC_TYPES: readonly string[] = [...(FieldType as { options: readonly string[] }).options];
/**
 * The spec's own `FieldType` vocabulary.
 *
 * The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924);
 * the THROW stays HERE, because the reader deliberately answers `[]` rather than
 * raising and this read is module-scope. What it replaces was a NON-OPTIONAL
 * cast of the enum node to an options-bearing shape, spread directly — which
 * failed LOUDLY the moment the cast stopped holding (spreading `undefined`
 * throws), so a bare `enumOptions` call here would have traded a loud failure
 * for a silently empty vocabulary: the derived assertions below would then pass
 * over nothing. That trade is the regression objectui#7025 exists to refuse.
 * (The retired spelling is deliberately NOT quoted here: the card's enumeration
 * instrument is a grep for it, and a comment carrying the literal text makes
 * every future re-derivation of this population read a false positive.)
 */
const readSpecTypes = (): readonly string[] => {
 const options = enumOptions(FieldType);
 if (options.length === 0) {
 throw new Error('could not read FieldType.options from @objectstack/spec');
 }
 return options;
};

const SPEC_TYPES: readonly string[] = readSpecTypes();

/**
 * ONE fixture, read by all three rules. `body` is the field the card is about;
Expand Down

28 changes: 25 additions & 3 deletions
packages/plugin-dashboard/src/__tests__/expandableFamily.identity-5692.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -71,12 +71,34 @@ import { fileURLToPath } from 'node:url';
import { describe, it, expect, vi } from 'vitest';
import { EXPANDABLE_FIELD_TYPES } from '@object-ui/core';
import { FieldType } from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';
import { isLookupType } from '../recordFields';
import { computeLookupExpand } from '../ObjectDataTable';

const SPEC_FIELD_TYPES: readonly string[] = [
 ...(FieldType as unknown as { options: readonly string[] }).options,
];
/**
 * The spec's own `FieldType` vocabulary.
 *
 * The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924);
 * the THROW stays HERE, because the reader deliberately answers `[]` rather than
 * raising and this read is module-scope. What it replaces was a NON-OPTIONAL
 * cast of the enum node to an options-bearing shape, spread directly — which
 * failed LOUDLY the moment the cast stopped holding (spreading `undefined`
 * throws), so a bare `enumOptions` call here would have traded a loud failure
 * for a silently empty vocabulary: every assertion below would then pass over
 * nothing. That trade is the regression objectui#7025 exists to refuse. (The
 * retired spelling is deliberately NOT quoted here: the card's enumeration
 * instrument is a grep for it, and a comment carrying the literal text makes
 * every future re-derivation of this population read a false positive.)
 */
const readSpecFieldTypes = (): readonly string[] => {
 const options = enumOptions(FieldType);
 if (options.length === 0) {
 throw new Error('could not read FieldType.options from @objectstack/spec');
 }
 return options;
};

const SPEC_FIELD_TYPES: readonly string[] = readSpecFieldTypes();

/** The relations an ordinary dashboard table shows — the regression control. */
const ORDINARY_RELATIONS = ['lookup', 'master_detail', 'user'] as const;
Expand Down

26 changes: 25 additions & 1 deletion
packages/plugin-detail/src/__tests__/autoLayout.wideSpelling.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -20,10 +20,34 @@
 */
import { describe, it, expect } from 'vitest';
import { FieldType } from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';
import { mapFieldTypeToFormType } from '@object-ui/fields';
import { isWideFieldType, applyAutoSpan } from '../autoLayout';

const SPEC_TYPES: readonly string[] = [...(FieldType as { options: readonly string[] }).options];
/**
 * The spec's own `FieldType` vocabulary.
 *
 * The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924);
 * the THROW stays HERE, because the reader deliberately answers `[]` rather than
 * raising and this read is module-scope. What it replaces was a NON-OPTIONAL
 * cast of the enum node to an options-bearing shape, spread directly — which
 * failed LOUDLY the moment the cast stopped holding (spreading `undefined`
 * throws), so a bare `enumOptions` call here would have traded a loud failure
 * for a silently empty vocabulary: the derived assertions below would then pass
 * over nothing. That trade is the regression objectui#7025 exists to refuse.
 * (The retired spelling is deliberately NOT quoted here: the card's enumeration
 * instrument is a grep for it, and a comment carrying the literal text makes
 * every future re-derivation of this population read a false positive.)
 */
const readSpecTypes = (): readonly string[] => {
 const options = enumOptions(FieldType);
 if (options.length === 0) {
 throw new Error('could not read FieldType.options from @objectstack/spec');
 }
 return options;
};

const SPEC_TYPES: readonly string[] = readSpecTypes();

/**
 * The long-form / document family: the spec types whose value is a whole block
Expand Down

28 changes: 25 additions & 3 deletions
packages/plugin-detail/src/__tests__/expandableFamily.identity-5874.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -66,12 +66,34 @@ import { render } from '@testing-library/react';
import React from 'react';
import { EXPANDABLE_FIELD_TYPES } from '@object-ui/core';
import { FieldType } from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';
import { HeaderHighlight } from '../HeaderHighlight';
import { RecordDetailDrawer } from '../RecordDetailDrawer';

const SPEC_FIELD_TYPES: readonly string[] = [
 ...(FieldType as unknown as { options: readonly string[] }).options,
];
/**
 * The spec's own `FieldType` vocabulary.
 *
 * The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924);
 * the THROW stays HERE, because the reader deliberately answers `[]` rather than
 * raising and this read is module-scope. What it replaces was a NON-OPTIONAL
 * cast of the enum node to an options-bearing shape, spread directly — which
 * failed LOUDLY the moment the cast stopped holding (spreading `undefined`
 * throws), so a bare `enumOptions` call here would have traded a loud failure
 * for a silently empty vocabulary: every assertion below would then pass over
 * nothing. That trade is the regression objectui#7025 exists to refuse. (The
 * retired spelling is deliberately NOT quoted here: the card's enumeration
 * instrument is a grep for it, and a comment carrying the literal text makes
 * every future re-derivation of this population read a false positive.)
 */
const readSpecFieldTypes = (): readonly string[] => {
 const options = enumOptions(FieldType);
 if (options.length === 0) {
 throw new Error('could not read FieldType.options from @objectstack/spec');
 }
 return options;
};

const SPEC_FIELD_TYPES: readonly string[] = readSpecFieldTypes();

/**
 * The drawer hands its derived field list to `DetailView` as `schema.fields`.
Expand Down

1 change: 1 addition & 0 deletions
packages/plugin-form/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -37,6 +37,7 @@
 },
 "devDependencies": {
 "@object-ui/data-objectstack": "workspace:*",
 "@object-ui/test-support": "workspace:*",
 "@vitejs/plugin-react": "^6.0.5",
 "msw": "^2.15.0",
 "typescript": "^6.0.3",
Expand Down

26 changes: 25 additions & 1 deletion
packages/plugin-form/src/__tests__/autoLayout.wideSpelling.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -19,11 +19,35 @@
 */
import { describe, it, expect } from 'vitest';
import { FieldType } from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';
import { mapFieldTypeToFormType } from '@object-ui/fields';
import { isWideFieldType, resolveColSpan } from '../autoLayout';
import type { FormField } from '@object-ui/types';

const SPEC_TYPES: readonly string[] = [...(FieldType as { options: readonly string[] }).options];
/**
 * The spec's own `FieldType` vocabulary.
 *
 * The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924);
 * the THROW stays HERE, because the reader deliberately answers `[]` rather than
 * raising and this read is module-scope. What it replaces was a NON-OPTIONAL
 * cast of the enum node to an options-bearing shape, spread directly — which
 * failed LOUDLY the moment the cast stopped holding (spreading `undefined`
 * throws), so a bare `enumOptions` call here would have traded a loud failure
 * for a silently empty vocabulary: the derived assertions below would then pass
 * over nothing. That trade is the regression objectui#7025 exists to refuse.
 * (The retired spelling is deliberately NOT quoted here: the card's enumeration
 * instrument is a grep for it, and a comment carrying the literal text makes
 * every future re-derivation of this population read a false positive.)
 */
const readSpecTypes = (): readonly string[] => {
 const options = enumOptions(FieldType);
 if (options.length === 0) {
 throw new Error('could not read FieldType.options from @objectstack/spec');
 }
 return options;
};

const SPEC_TYPES: readonly string[] = readSpecTypes();

/** The long-form / document family, spelled as the SPEC spells it. */
const WIDE_SPEC_TYPES = ['textarea', 'markdown', 'html', 'richtext'] as const;
Expand Down

21 changes: 19 additions & 2 deletions
packages/plugin-grid/src/__tests__/spec-symbol-batch7.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,15 +36,32 @@ import {
 MULTI_CAPABLE_TYPES,
 MULTI_OPTION_TYPES,
} from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';

import { SUPPORTED_SUMMARY_TYPES, type ColumnSummarySetting, type ColumnSummaryType } from '../useColumnSummary';
import { hasMultiValueShape } from '../hooks/multiValueFields';

const specSummaryOptions = (ColumnSummarySchema as unknown as { options: readonly string[] }).options;
/**
 * The spec's column-summary vocabulary.
 *
 * The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924).
 * No throw wrapper here — unlike the module-scope readers converted alongside it
 * in objectui#7025, this suite already discharges the reader's non-vacuity duty
 * with its OWN first assertion below, which is the sanctioned alternative. What
 * it replaces was a NON-OPTIONAL cast of the enum node to an options-bearing
 * shape; the loudness that cast provided is preserved by that assertion, not
 * lost to `[]`.
 */
const specSummaryOptions: readonly string[] = enumOptions(ColumnSummarySchema);

describe('the column-summary vocabulary comes from the spec', () => {
 it('reads a non-empty enum from the spec (the probe itself is not vacuous)', () => {
 expect(Array.isArray(specSummaryOptions) && specSummaryOptions.length > 0).toBe(true);
 // The reader answers `[]` when it cannot read the enum, so THIS is what
 // keeps every assertion below from passing over an empty list.
 expect(
 specSummaryOptions,
 'could not read ColumnSummarySchema.options from the spec',
 ).not.toEqual([]);
 });

 it('every aggregation the spec accepts is one this renderer computes', () => {
Expand Down

1 change: 1 addition & 0 deletions
packages/plugin-kanban/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,6 +51,7 @@
 },
 "devDependencies": {
 "@object-ui/data-objectstack": "workspace:*",
 "@object-ui/test-support": "workspace:*",
 "@tailwindcss/postcss": "^4.3.3",
 "@types/react": "19.2.18",
 "@types/react-dom": "19.2.4",
Expand Down

28 changes: 25 additions & 3 deletions
packages/plugin-kanban/src/__tests__/expandableFamily.identity-5874.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -63,6 +63,7 @@ import { render, waitFor } from '@testing-library/react';
import React from 'react';
import { EXPANDABLE_FIELD_TYPES } from '@object-ui/core';
import { FieldType } from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';
import { SchemaRenderer, SchemaRendererProvider } from '@object-ui/react';
// Registers `object-kanban`.
import '../index';
Expand All@@ -73,9 +74,30 @@ import '../index';
// so ESM's module cache makes that factory resolve immediately.
import '../KanbanImpl';

const SPEC_FIELD_TYPES: readonly string[] = [
 ...(FieldType as unknown as { options: readonly string[] }).options,
];
/**
 * The spec's own `FieldType` vocabulary.
 *
 * The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924);
 * the THROW stays HERE, because the reader deliberately answers `[]` rather than
 * raising and this read is module-scope. What it replaces was a NON-OPTIONAL
 * cast of the enum node to an options-bearing shape, spread directly — which
 * failed LOUDLY the moment the cast stopped holding (spreading `undefined`
 * throws), so a bare `enumOptions` call here would have traded a loud failure
 * for a silently empty vocabulary: every assertion below would then pass over
 * nothing. That trade is the regression objectui#7025 exists to refuse. (The
 * retired spelling is deliberately NOT quoted here: the card's enumeration
 * instrument is a grep for it, and a comment carrying the literal text makes
 * every future re-derivation of this population read a false positive.)
 */
const readSpecFieldTypes = (): readonly string[] => {
 const options = enumOptions(FieldType);
 if (options.length === 0) {
 throw new Error('could not read FieldType.options from @objectstack/spec');
 }
 return options;
};

const SPEC_FIELD_TYPES: readonly string[] = readSpecFieldTypes();

/**
 * A board with NO `cardFields` and NO `highlightFields`, so cards fall to the
Expand Down

8 changes: 7 additions & 1 deletion
packages/types/src/__tests__/spec-subschema-parity.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -39,6 +39,7 @@ import {
 ChartTypeSchema as SpecChartTypeSchema,
 PageTypeSchema as SpecPageTypeSchema,
} from '@objectstack/spec/ui';
import { enumOptions } from '@object-ui/test-support';
import {
 HttpMethodSchema,
 HttpRequestSchema,
Expand DownExpand Up@@ -175,7 +176,12 @@ describe('ListColumnSchema is the spec schema (the extension collapsed)', () =>
 // arm through `lazySchema`, whose Proxy resolves `.shape.type` to the inner
 // enum instead of the exported schema object, so a `toBe` check would test
 // the wrapper rather than the vocabulary it is meant to protect.
 const vocabulary = (SpecColumnSummarySchema as unknown as { options: string[] }).options;
 // The wrapper walk is `@object-ui/test-support`'s shared reader
 // (objectui#6924). No throw wrapper: the assertion on the next line already
 // discharges the reader's non-vacuity duty, which is what keeps the loop
 // below from passing over an empty vocabulary now that a failed read
 // answers `[]` instead of throwing (objectui#7025).
 const vocabulary = enumOptions(SpecColumnSummarySchema);
 expect(vocabulary.length, 'spec ColumnSummarySchema should be a non-empty enum').toBeGreaterThan(0);

 for (const agg of vocabulary) {
Expand Down

6 changes: 6 additions & 0 deletions
pnpm-lock.yaml

View file


Open in desktop


Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
test(spec-parity): converge the non-optional enum-options casts onto the shared reader (#7025)#7057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-sam
merged 1 commit into

from

Aug 31, 2026
 Merged


test(spec-parity): converge the non-optional enum-options casts onto the shared reader (#7025)
#7057
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


20 changes: 20 additions & 0 deletions
.changeset/7025-nonoptional-enum-cast.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
---
---

Internal test-only change, no user-visible behaviour (objectui#7025).

The SIXTH spelling of the Zod-internals reader hazard objectui#5872 catalogues:
9 spec-parity test files in 7 packages cast an enum node NON-optionally to an
options-bearing shape and read `.options` straight off it. They converge onto
`@object-ui/test-support`'s `enumOptions(node)` — the same walk objectui#6924
converged the optional-cast family onto in PR #7024.

Unlike that family, these sites failed LOUDLY (spreading `undefined` throws), and
the shared reader deliberately answers `[]` rather than raising. So every site
keeps its own non-vacuity duty: a throwing wrapper at the seven module-scope
reads, and the suite's own pre-existing non-vacuity assertion at the two in-test
reads. A bare conversion would have traded a loud failure for a silent empty
vocabulary — a regression, not a convergence.

Only test files, two `devDependencies` edges and the lockfile change; no
package's shipped `dist/` and no public type moves.

28 changes: 25 additions & 3 deletions
packages/app-shell/src/utils/expandableFamily.identity-5874.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -54,16 +54,38 @@
import { describe, it, expect, vi, afterEach } from 'vitest';
import { EXPANDABLE_FIELD_TYPES } from '@object-ui/core';
import { FieldType } from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';
import { ActionParamSchema } from '@objectstack/spec/ui';
import {
 resolveActionParams,
 type ResolveActionParamsContext,
 type RawActionParam,
} from './resolveActionParams';

const SPEC_FIELD_TYPES: readonly string[] = [
 ...(FieldType as unknown as { options: readonly string[] }).options,
];
/**
 * The spec's own `FieldType` vocabulary.
 *
 * The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924);
 * the THROW stays HERE, because the reader deliberately answers `[]` rather than
 * raising and this read is module-scope. What it replaces was a NON-OPTIONAL
 * cast of the enum node to an options-bearing shape, spread directly — which
 * failed LOUDLY the moment the cast stopped holding (spreading `undefined`
 * throws), so a bare `enumOptions` call here would have traded a loud failure
 * for a silently empty vocabulary: every assertion below would then pass over
 * nothing. That trade is the regression objectui#7025 exists to refuse. (The
 * retired spelling is deliberately NOT quoted here: the card's enumeration
 * instrument is a grep for it, and a comment carrying the literal text makes
 * every future re-derivation of this population read a false positive.)
 */
const readSpecFieldTypes = (): readonly string[] => {
 const options = enumOptions(FieldType);
 if (options.length === 0) {
 throw new Error('could not read FieldType.options from @objectstack/spec');
 }
 return options;
};

const SPEC_FIELD_TYPES: readonly string[] = readSpecFieldTypes();

/** Every picker key `lookupExtras` copies off the resolved object field. */
const PICKER_KEYS = [
Expand Down

26 changes: 25 additions & 1 deletion
packages/app-shell/src/views/richtextSurfaceParity.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -27,11 +27,35 @@
 */
import { describe, it, expect } from 'vitest';
import { FieldType } from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';
import { isWideFieldType as detailIsWide } from '@object-ui/plugin-detail';
import { isWideFieldType as formIsWide } from '@object-ui/plugin-form';
import { isSecondaryField } from './RecordDetailView';

const SPEC_TYPES: readonly string[] = [...(FieldType as { options: readonly string[] }).options];
/**
 * The spec's own `FieldType` vocabulary.
 *
 * The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924);
 * the THROW stays HERE, because the reader deliberately answers `[]` rather than
 * raising and this read is module-scope. What it replaces was a NON-OPTIONAL
 * cast of the enum node to an options-bearing shape, spread directly — which
 * failed LOUDLY the moment the cast stopped holding (spreading `undefined`
 * throws), so a bare `enumOptions` call here would have traded a loud failure
 * for a silently empty vocabulary: the derived assertions below would then pass
 * over nothing. That trade is the regression objectui#7025 exists to refuse.
 * (The retired spelling is deliberately NOT quoted here: the card's enumeration
 * instrument is a grep for it, and a comment carrying the literal text makes
 * every future re-derivation of this population read a false positive.)
 */
const readSpecTypes = (): readonly string[] => {
 const options = enumOptions(FieldType);
 if (options.length === 0) {
 throw new Error('could not read FieldType.options from @objectstack/spec');
 }
 return options;
};

const SPEC_TYPES: readonly string[] = readSpecTypes();

/**
 * ONE fixture, read by all three rules. `body` is the field the card is about;
Expand Down

28 changes: 25 additions & 3 deletions
packages/plugin-dashboard/src/__tests__/expandableFamily.identity-5692.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -71,12 +71,34 @@ import { fileURLToPath } from 'node:url';
import { describe, it, expect, vi } from 'vitest';
import { EXPANDABLE_FIELD_TYPES } from '@object-ui/core';
import { FieldType } from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';
import { isLookupType } from '../recordFields';
import { computeLookupExpand } from '../ObjectDataTable';

const SPEC_FIELD_TYPES: readonly string[] = [
 ...(FieldType as unknown as { options: readonly string[] }).options,
];
/**
 * The spec's own `FieldType` vocabulary.
 *
 * The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924);
 * the THROW stays HERE, because the reader deliberately answers `[]` rather than
 * raising and this read is module-scope. What it replaces was a NON-OPTIONAL
 * cast of the enum node to an options-bearing shape, spread directly — which
 * failed LOUDLY the moment the cast stopped holding (spreading `undefined`
 * throws), so a bare `enumOptions` call here would have traded a loud failure
 * for a silently empty vocabulary: every assertion below would then pass over
 * nothing. That trade is the regression objectui#7025 exists to refuse. (The
 * retired spelling is deliberately NOT quoted here: the card's enumeration
 * instrument is a grep for it, and a comment carrying the literal text makes
 * every future re-derivation of this population read a false positive.)
 */
const readSpecFieldTypes = (): readonly string[] => {
 const options = enumOptions(FieldType);
 if (options.length === 0) {
 throw new Error('could not read FieldType.options from @objectstack/spec');
 }
 return options;
};

const SPEC_FIELD_TYPES: readonly string[] = readSpecFieldTypes();

/** The relations an ordinary dashboard table shows — the regression control. */
const ORDINARY_RELATIONS = ['lookup', 'master_detail', 'user'] as const;
Expand Down

26 changes: 25 additions & 1 deletion
packages/plugin-detail/src/__tests__/autoLayout.wideSpelling.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -20,10 +20,34 @@
 */
import { describe, it, expect } from 'vitest';
import { FieldType } from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';
import { mapFieldTypeToFormType } from '@object-ui/fields';
import { isWideFieldType, applyAutoSpan } from '../autoLayout';

const SPEC_TYPES: readonly string[] = [...(FieldType as { options: readonly string[] }).options];
/**
 * The spec's own `FieldType` vocabulary.
 *
 * The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924);
 * the THROW stays HERE, because the reader deliberately answers `[]` rather than
 * raising and this read is module-scope. What it replaces was a NON-OPTIONAL
 * cast of the enum node to an options-bearing shape, spread directly — which
 * failed LOUDLY the moment the cast stopped holding (spreading `undefined`
 * throws), so a bare `enumOptions` call here would have traded a loud failure
 * for a silently empty vocabulary: the derived assertions below would then pass
 * over nothing. That trade is the regression objectui#7025 exists to refuse.
 * (The retired spelling is deliberately NOT quoted here: the card's enumeration
 * instrument is a grep for it, and a comment carrying the literal text makes
 * every future re-derivation of this population read a false positive.)
 */
const readSpecTypes = (): readonly string[] => {
 const options = enumOptions(FieldType);
 if (options.length === 0) {
 throw new Error('could not read FieldType.options from @objectstack/spec');
 }
 return options;
};

const SPEC_TYPES: readonly string[] = readSpecTypes();

/**
 * The long-form / document family: the spec types whose value is a whole block
Expand Down

28 changes: 25 additions & 3 deletions
packages/plugin-detail/src/__tests__/expandableFamily.identity-5874.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -66,12 +66,34 @@ import { render } from '@testing-library/react';
import React from 'react';
import { EXPANDABLE_FIELD_TYPES } from '@object-ui/core';
import { FieldType } from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';
import { HeaderHighlight } from '../HeaderHighlight';
import { RecordDetailDrawer } from '../RecordDetailDrawer';

const SPEC_FIELD_TYPES: readonly string[] = [
 ...(FieldType as unknown as { options: readonly string[] }).options,
];
/**
 * The spec's own `FieldType` vocabulary.
 *
 * The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924);
 * the THROW stays HERE, because the reader deliberately answers `[]` rather than
 * raising and this read is module-scope. What it replaces was a NON-OPTIONAL
 * cast of the enum node to an options-bearing shape, spread directly — which
 * failed LOUDLY the moment the cast stopped holding (spreading `undefined`
 * throws), so a bare `enumOptions` call here would have traded a loud failure
 * for a silently empty vocabulary: every assertion below would then pass over
 * nothing. That trade is the regression objectui#7025 exists to refuse. (The
 * retired spelling is deliberately NOT quoted here: the card's enumeration
 * instrument is a grep for it, and a comment carrying the literal text makes
 * every future re-derivation of this population read a false positive.)
 */
const readSpecFieldTypes = (): readonly string[] => {
 const options = enumOptions(FieldType);
 if (options.length === 0) {
 throw new Error('could not read FieldType.options from @objectstack/spec');
 }
 return options;
};

const SPEC_FIELD_TYPES: readonly string[] = readSpecFieldTypes();

/**
 * The drawer hands its derived field list to `DetailView` as `schema.fields`.
Expand Down

1 change: 1 addition & 0 deletions
packages/plugin-form/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -37,6 +37,7 @@
 },
 "devDependencies": {
 "@object-ui/data-objectstack": "workspace:*",
 "@object-ui/test-support": "workspace:*",
 "@vitejs/plugin-react": "^6.0.5",
 "msw": "^2.15.0",
 "typescript": "^6.0.3",
Expand Down

26 changes: 25 additions & 1 deletion
packages/plugin-form/src/__tests__/autoLayout.wideSpelling.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -19,11 +19,35 @@
 */
import { describe, it, expect } from 'vitest';
import { FieldType } from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';
import { mapFieldTypeToFormType } from '@object-ui/fields';
import { isWideFieldType, resolveColSpan } from '../autoLayout';
import type { FormField } from '@object-ui/types';

const SPEC_TYPES: readonly string[] = [...(FieldType as { options: readonly string[] }).options];
/**
 * The spec's own `FieldType` vocabulary.
 *
 * The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924);
 * the THROW stays HERE, because the reader deliberately answers `[]` rather than
 * raising and this read is module-scope. What it replaces was a NON-OPTIONAL
 * cast of the enum node to an options-bearing shape, spread directly — which
 * failed LOUDLY the moment the cast stopped holding (spreading `undefined`
 * throws), so a bare `enumOptions` call here would have traded a loud failure
 * for a silently empty vocabulary: the derived assertions below would then pass
 * over nothing. That trade is the regression objectui#7025 exists to refuse.
 * (The retired spelling is deliberately NOT quoted here: the card's enumeration
 * instrument is a grep for it, and a comment carrying the literal text makes
 * every future re-derivation of this population read a false positive.)
 */
const readSpecTypes = (): readonly string[] => {
 const options = enumOptions(FieldType);
 if (options.length === 0) {
 throw new Error('could not read FieldType.options from @objectstack/spec');
 }
 return options;
};

const SPEC_TYPES: readonly string[] = readSpecTypes();

/** The long-form / document family, spelled as the SPEC spells it. */
const WIDE_SPEC_TYPES = ['textarea', 'markdown', 'html', 'richtext'] as const;
Expand Down

21 changes: 19 additions & 2 deletions
packages/plugin-grid/src/__tests__/spec-symbol-batch7.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,15 +36,32 @@ import {
 MULTI_CAPABLE_TYPES,
 MULTI_OPTION_TYPES,
} from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';

import { SUPPORTED_SUMMARY_TYPES, type ColumnSummarySetting, type ColumnSummaryType } from '../useColumnSummary';
import { hasMultiValueShape } from '../hooks/multiValueFields';

const specSummaryOptions = (ColumnSummarySchema as unknown as { options: readonly string[] }).options;
/**
 * The spec's column-summary vocabulary.
 *
 * The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924).
 * No throw wrapper here — unlike the module-scope readers converted alongside it
 * in objectui#7025, this suite already discharges the reader's non-vacuity duty
 * with its OWN first assertion below, which is the sanctioned alternative. What
 * it replaces was a NON-OPTIONAL cast of the enum node to an options-bearing
 * shape; the loudness that cast provided is preserved by that assertion, not
 * lost to `[]`.
 */
const specSummaryOptions: readonly string[] = enumOptions(ColumnSummarySchema);

describe('the column-summary vocabulary comes from the spec', () => {
 it('reads a non-empty enum from the spec (the probe itself is not vacuous)', () => {
 expect(Array.isArray(specSummaryOptions) && specSummaryOptions.length > 0).toBe(true);
 // The reader answers `[]` when it cannot read the enum, so THIS is what
 // keeps every assertion below from passing over an empty list.
 expect(
 specSummaryOptions,
 'could not read ColumnSummarySchema.options from the spec',
 ).not.toEqual([]);
 });

 it('every aggregation the spec accepts is one this renderer computes', () => {
Expand Down

1 change: 1 addition & 0 deletions
packages/plugin-kanban/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,6 +51,7 @@
 },
 "devDependencies": {
 "@object-ui/data-objectstack": "workspace:*",
 "@object-ui/test-support": "workspace:*",
 "@tailwindcss/postcss": "^4.3.3",
 "@types/react": "19.2.18",
 "@types/react-dom": "19.2.4",
Expand Down

28 changes: 25 additions & 3 deletions
packages/plugin-kanban/src/__tests__/expandableFamily.identity-5874.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -63,6 +63,7 @@ import { render, waitFor } from '@testing-library/react';
import React from 'react';
import { EXPANDABLE_FIELD_TYPES } from '@object-ui/core';
import { FieldType } from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';
import { SchemaRenderer, SchemaRendererProvider } from '@object-ui/react';
// Registers `object-kanban`.
import '../index';
Expand All@@ -73,9 +74,30 @@ import '../index';
// so ESM's module cache makes that factory resolve immediately.
import '../KanbanImpl';

const SPEC_FIELD_TYPES: readonly string[] = [
 ...(FieldType as unknown as { options: readonly string[] }).options,
];
/**
 * The spec's own `FieldType` vocabulary.
 *
 * The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924);
 * the THROW stays HERE, because the reader deliberately answers `[]` rather than
 * raising and this read is module-scope. What it replaces was a NON-OPTIONAL
 * cast of the enum node to an options-bearing shape, spread directly — which
 * failed LOUDLY the moment the cast stopped holding (spreading `undefined`
 * throws), so a bare `enumOptions` call here would have traded a loud failure
 * for a silently empty vocabulary: every assertion below would then pass over
 * nothing. That trade is the regression objectui#7025 exists to refuse. (The
 * retired spelling is deliberately NOT quoted here: the card's enumeration
 * instrument is a grep for it, and a comment carrying the literal text makes
 * every future re-derivation of this population read a false positive.)
 */
const readSpecFieldTypes = (): readonly string[] => {
 const options = enumOptions(FieldType);
 if (options.length === 0) {
 throw new Error('could not read FieldType.options from @objectstack/spec');
 }
 return options;
};

const SPEC_FIELD_TYPES: readonly string[] = readSpecFieldTypes();

/**
 * A board with NO `cardFields` and NO `highlightFields`, so cards fall to the
Expand Down

8 changes: 7 additions & 1 deletion
packages/types/src/__tests__/spec-subschema-parity.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -39,6 +39,7 @@ import {
 ChartTypeSchema as SpecChartTypeSchema,
 PageTypeSchema as SpecPageTypeSchema,
} from '@objectstack/spec/ui';
import { enumOptions } from '@object-ui/test-support';
import {
 HttpMethodSchema,
 HttpRequestSchema,
Expand DownExpand Up@@ -175,7 +176,12 @@ describe('ListColumnSchema is the spec schema (the extension collapsed)', () =>
 // arm through `lazySchema`, whose Proxy resolves `.shape.type` to the inner
 // enum instead of the exported schema object, so a `toBe` check would test
 // the wrapper rather than the vocabulary it is meant to protect.
 const vocabulary = (SpecColumnSummarySchema as unknown as { options: string[] }).options;
 // The wrapper walk is `@object-ui/test-support`'s shared reader
 // (objectui#6924). No throw wrapper: the assertion on the next line already
 // discharges the reader's non-vacuity duty, which is what keeps the loop
 // below from passing over an empty vocabulary now that a failed read
 // answers `[]` instead of throwing (objectui#7025).
 const vocabulary = enumOptions(SpecColumnSummarySchema);
 expect(vocabulary.length, 'spec ColumnSummarySchema should be a non-empty enum').toBeGreaterThan(0);

 for (const agg of vocabulary) {
Expand Down

6 changes: 6 additions & 0 deletions
pnpm-lock.yaml

View file


Open in desktop


Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
test(spec-parity): converge the non-optional enum-options casts onto the shared reader (#7025)#7057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-sam
merged 1 commit into

from

Aug 31, 2026
 Merged


test(spec-parity): converge the non-optional enum-options casts onto the shared reader (#7025)
#7057
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


20 changes: 20 additions & 0 deletions
.changeset/7025-nonoptional-enum-cast.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
---
---

Internal test-only change, no user-visible behaviour (objectui#7025).

The SIXTH spelling of the Zod-internals reader hazard objectui#5872 catalogues:
9 spec-parity test files in 7 packages cast an enum node NON-optionally to an
options-bearing shape and read `.options` straight off it. They converge onto
`@object-ui/test-support`'s `enumOptions(node)` — the same walk objectui#6924
converged the optional-cast family onto in PR #7024.

Unlike that family, these sites failed LOUDLY (spreading `undefined` throws), and
the shared reader deliberately answers `[]` rather than raising. So every site
keeps its own non-vacuity duty: a throwing wrapper at the seven module-scope
reads, and the suite's own pre-existing non-vacuity assertion at the two in-test
reads. A bare conversion would have traded a loud failure for a silent empty
vocabulary — a regression, not a convergence.

Only test files, two `devDependencies` edges and the lockfile change; no
package's shipped `dist/` and no public type moves.

28 changes: 25 additions & 3 deletions
packages/app-shell/src/utils/expandableFamily.identity-5874.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -54,16 +54,38 @@
import { describe, it, expect, vi, afterEach } from 'vitest';
import { EXPANDABLE_FIELD_TYPES } from '@object-ui/core';
import { FieldType } from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';
import { ActionParamSchema } from '@objectstack/spec/ui';
import {
 resolveActionParams,
 type ResolveActionParamsContext,
 type RawActionParam,
} from './resolveActionParams';

const SPEC_FIELD_TYPES: readonly string[] = [
 ...(FieldType as unknown as { options: readonly string[] }).options,
];
/**
 * The spec's own `FieldType` vocabulary.
 *
 * The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924);
 * the THROW stays HERE, because the reader deliberately answers `[]` rather than
 * raising and this read is module-scope. What it replaces was a NON-OPTIONAL
 * cast of the enum node to an options-bearing shape, spread directly — which
 * failed LOUDLY the moment the cast stopped holding (spreading `undefined`
 * throws), so a bare `enumOptions` call here would have traded a loud failure
 * for a silently empty vocabulary: every assertion below would then pass over
 * nothing. That trade is the regression objectui#7025 exists to refuse. (The
 * retired spelling is deliberately NOT quoted here: the card's enumeration
 * instrument is a grep for it, and a comment carrying the literal text makes
 * every future re-derivation of this population read a false positive.)
 */
const readSpecFieldTypes = (): readonly string[] => {
 const options = enumOptions(FieldType);
 if (options.length === 0) {
 throw new Error('could not read FieldType.options from @objectstack/spec');
 }
 return options;
};

const SPEC_FIELD_TYPES: readonly string[] = readSpecFieldTypes();

/** Every picker key `lookupExtras` copies off the resolved object field. */
const PICKER_KEYS = [
Expand Down

26 changes: 25 additions & 1 deletion
packages/app-shell/src/views/richtextSurfaceParity.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -27,11 +27,35 @@
 */
import { describe, it, expect } from 'vitest';
import { FieldType } from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';
import { isWideFieldType as detailIsWide } from '@object-ui/plugin-detail';
import { isWideFieldType as formIsWide } from '@object-ui/plugin-form';
import { isSecondaryField } from './RecordDetailView';

const SPEC_TYPES: readonly string[] = [...(FieldType as { options: readonly string[] }).options];
/**
 * The spec's own `FieldType` vocabulary.
 *
 * The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924);
 * the THROW stays HERE, because the reader deliberately answers `[]` rather than
 * raising and this read is module-scope. What it replaces was a NON-OPTIONAL
 * cast of the enum node to an options-bearing shape, spread directly — which
 * failed LOUDLY the moment the cast stopped holding (spreading `undefined`
 * throws), so a bare `enumOptions` call here would have traded a loud failure
 * for a silently empty vocabulary: the derived assertions below would then pass
 * over nothing. That trade is the regression objectui#7025 exists to refuse.
 * (The retired spelling is deliberately NOT quoted here: the card's enumeration
 * instrument is a grep for it, and a comment carrying the literal text makes
 * every future re-derivation of this population read a false positive.)
 */
const readSpecTypes = (): readonly string[] => {
 const options = enumOptions(FieldType);
 if (options.length === 0) {
 throw new Error('could not read FieldType.options from @objectstack/spec');
 }
 return options;
};

const SPEC_TYPES: readonly string[] = readSpecTypes();

/**
 * ONE fixture, read by all three rules. `body` is the field the card is about;
Expand Down

28 changes: 25 additions & 3 deletions
packages/plugin-dashboard/src/__tests__/expandableFamily.identity-5692.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -71,12 +71,34 @@ import { fileURLToPath } from 'node:url';
import { describe, it, expect, vi } from 'vitest';
import { EXPANDABLE_FIELD_TYPES } from '@object-ui/core';
import { FieldType } from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';
import { isLookupType } from '../recordFields';
import { computeLookupExpand } from '../ObjectDataTable';

const SPEC_FIELD_TYPES: readonly string[] = [
 ...(FieldType as unknown as { options: readonly string[] }).options,
];
/**
 * The spec's own `FieldType` vocabulary.
 *
 * The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924);
 * the THROW stays HERE, because the reader deliberately answers `[]` rather than
 * raising and this read is module-scope. What it replaces was a NON-OPTIONAL
 * cast of the enum node to an options-bearing shape, spread directly — which
 * failed LOUDLY the moment the cast stopped holding (spreading `undefined`
 * throws), so a bare `enumOptions` call here would have traded a loud failure
 * for a silently empty vocabulary: every assertion below would then pass over
 * nothing. That trade is the regression objectui#7025 exists to refuse. (The
 * retired spelling is deliberately NOT quoted here: the card's enumeration
 * instrument is a grep for it, and a comment carrying the literal text makes
 * every future re-derivation of this population read a false positive.)
 */
const readSpecFieldTypes = (): readonly string[] => {
 const options = enumOptions(FieldType);
 if (options.length === 0) {
 throw new Error('could not read FieldType.options from @objectstack/spec');
 }
 return options;
};

const SPEC_FIELD_TYPES: readonly string[] = readSpecFieldTypes();

/** The relations an ordinary dashboard table shows — the regression control. */
const ORDINARY_RELATIONS = ['lookup', 'master_detail', 'user'] as const;
Expand Down

26 changes: 25 additions & 1 deletion
packages/plugin-detail/src/__tests__/autoLayout.wideSpelling.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -20,10 +20,34 @@
 */
import { describe, it, expect } from 'vitest';
import { FieldType } from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';
import { mapFieldTypeToFormType } from '@object-ui/fields';
import { isWideFieldType, applyAutoSpan } from '../autoLayout';

const SPEC_TYPES: readonly string[] = [...(FieldType as { options: readonly string[] }).options];
/**
 * The spec's own `FieldType` vocabulary.
 *
 * The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924);
 * the THROW stays HERE, because the reader deliberately answers `[]` rather than
 * raising and this read is module-scope. What it replaces was a NON-OPTIONAL
 * cast of the enum node to an options-bearing shape, spread directly — which
 * failed LOUDLY the moment the cast stopped holding (spreading `undefined`
 * throws), so a bare `enumOptions` call here would have traded a loud failure
 * for a silently empty vocabulary: the derived assertions below would then pass
 * over nothing. That trade is the regression objectui#7025 exists to refuse.
 * (The retired spelling is deliberately NOT quoted here: the card's enumeration
 * instrument is a grep for it, and a comment carrying the literal text makes
 * every future re-derivation of this population read a false positive.)
 */
const readSpecTypes = (): readonly string[] => {
 const options = enumOptions(FieldType);
 if (options.length === 0) {
 throw new Error('could not read FieldType.options from @objectstack/spec');
 }
 return options;
};

const SPEC_TYPES: readonly string[] = readSpecTypes();

/**
 * The long-form / document family: the spec types whose value is a whole block
Expand Down

28 changes: 25 additions & 3 deletions
packages/plugin-detail/src/__tests__/expandableFamily.identity-5874.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -66,12 +66,34 @@ import { render } from '@testing-library/react';
import React from 'react';
import { EXPANDABLE_FIELD_TYPES } from '@object-ui/core';
import { FieldType } from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';
import { HeaderHighlight } from '../HeaderHighlight';
import { RecordDetailDrawer } from '../RecordDetailDrawer';

const SPEC_FIELD_TYPES: readonly string[] = [
 ...(FieldType as unknown as { options: readonly string[] }).options,
];
/**
 * The spec's own `FieldType` vocabulary.
 *
 * The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924);
 * the THROW stays HERE, because the reader deliberately answers `[]` rather than
 * raising and this read is module-scope. What it replaces was a NON-OPTIONAL
 * cast of the enum node to an options-bearing shape, spread directly — which
 * failed LOUDLY the moment the cast stopped holding (spreading `undefined`
 * throws), so a bare `enumOptions` call here would have traded a loud failure
 * for a silently empty vocabulary: every assertion below would then pass over
 * nothing. That trade is the regression objectui#7025 exists to refuse. (The
 * retired spelling is deliberately NOT quoted here: the card's enumeration
 * instrument is a grep for it, and a comment carrying the literal text makes
 * every future re-derivation of this population read a false positive.)
 */
const readSpecFieldTypes = (): readonly string[] => {
 const options = enumOptions(FieldType);
 if (options.length === 0) {
 throw new Error('could not read FieldType.options from @objectstack/spec');
 }
 return options;
};

const SPEC_FIELD_TYPES: readonly string[] = readSpecFieldTypes();

/**
 * The drawer hands its derived field list to `DetailView` as `schema.fields`.
Expand Down

1 change: 1 addition & 0 deletions
packages/plugin-form/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -37,6 +37,7 @@
 },
 "devDependencies": {
 "@object-ui/data-objectstack": "workspace:*",
 "@object-ui/test-support": "workspace:*",
 "@vitejs/plugin-react": "^6.0.5",
 "msw": "^2.15.0",
 "typescript": "^6.0.3",
Expand Down

26 changes: 25 additions & 1 deletion
packages/plugin-form/src/__tests__/autoLayout.wideSpelling.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -19,11 +19,35 @@
 */
import { describe, it, expect } from 'vitest';
import { FieldType } from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';
import { mapFieldTypeToFormType } from '@object-ui/fields';
import { isWideFieldType, resolveColSpan } from '../autoLayout';
import type { FormField } from '@object-ui/types';

const SPEC_TYPES: readonly string[] = [...(FieldType as { options: readonly string[] }).options];
/**
 * The spec's own `FieldType` vocabulary.
 *
 * The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924);
 * the THROW stays HERE, because the reader deliberately answers `[]` rather than
 * raising and this read is module-scope. What it replaces was a NON-OPTIONAL
 * cast of the enum node to an options-bearing shape, spread directly — which
 * failed LOUDLY the moment the cast stopped holding (spreading `undefined`
 * throws), so a bare `enumOptions` call here would have traded a loud failure
 * for a silently empty vocabulary: the derived assertions below would then pass
 * over nothing. That trade is the regression objectui#7025 exists to refuse.
 * (The retired spelling is deliberately NOT quoted here: the card's enumeration
 * instrument is a grep for it, and a comment carrying the literal text makes
 * every future re-derivation of this population read a false positive.)
 */
const readSpecTypes = (): readonly string[] => {
 const options = enumOptions(FieldType);
 if (options.length === 0) {
 throw new Error('could not read FieldType.options from @objectstack/spec');
 }
 return options;
};

const SPEC_TYPES: readonly string[] = readSpecTypes();

/** The long-form / document family, spelled as the SPEC spells it. */
const WIDE_SPEC_TYPES = ['textarea', 'markdown', 'html', 'richtext'] as const;
Expand Down

21 changes: 19 additions & 2 deletions
packages/plugin-grid/src/__tests__/spec-symbol-batch7.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,15 +36,32 @@ import {
 MULTI_CAPABLE_TYPES,
 MULTI_OPTION_TYPES,
} from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';

import { SUPPORTED_SUMMARY_TYPES, type ColumnSummarySetting, type ColumnSummaryType } from '../useColumnSummary';
import { hasMultiValueShape } from '../hooks/multiValueFields';

const specSummaryOptions = (ColumnSummarySchema as unknown as { options: readonly string[] }).options;
/**
 * The spec's column-summary vocabulary.
 *
 * The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924).
 * No throw wrapper here — unlike the module-scope readers converted alongside it
 * in objectui#7025, this suite already discharges the reader's non-vacuity duty
 * with its OWN first assertion below, which is the sanctioned alternative. What
 * it replaces was a NON-OPTIONAL cast of the enum node to an options-bearing
 * shape; the loudness that cast provided is preserved by that assertion, not
 * lost to `[]`.
 */
const specSummaryOptions: readonly string[] = enumOptions(ColumnSummarySchema);

describe('the column-summary vocabulary comes from the spec', () => {
 it('reads a non-empty enum from the spec (the probe itself is not vacuous)', () => {
 expect(Array.isArray(specSummaryOptions) && specSummaryOptions.length > 0).toBe(true);
 // The reader answers `[]` when it cannot read the enum, so THIS is what
 // keeps every assertion below from passing over an empty list.
 expect(
 specSummaryOptions,
 'could not read ColumnSummarySchema.options from the spec',
 ).not.toEqual([]);
 });

 it('every aggregation the spec accepts is one this renderer computes', () => {
Expand Down

1 change: 1 addition & 0 deletions
packages/plugin-kanban/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,6 +51,7 @@
 },
 "devDependencies": {
 "@object-ui/data-objectstack": "workspace:*",
 "@object-ui/test-support": "workspace:*",
 "@tailwindcss/postcss": "^4.3.3",
 "@types/react": "19.2.18",
 "@types/react-dom": "19.2.4",
Expand Down

28 changes: 25 additions & 3 deletions
packages/plugin-kanban/src/__tests__/expandableFamily.identity-5874.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -63,6 +63,7 @@ import { render, waitFor } from '@testing-library/react';
import React from 'react';
import { EXPANDABLE_FIELD_TYPES } from '@object-ui/core';
import { FieldType } from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';
import { SchemaRenderer, SchemaRendererProvider } from '@object-ui/react';
// Registers `object-kanban`.
import '../index';
Expand All@@ -73,9 +74,30 @@ import '../index';
// so ESM's module cache makes that factory resolve immediately.
import '../KanbanImpl';

const SPEC_FIELD_TYPES: readonly string[] = [
 ...(FieldType as unknown as { options: readonly string[] }).options,
];
/**
 * The spec's own `FieldType` vocabulary.
 *
 * The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924);
 * the THROW stays HERE, because the reader deliberately answers `[]` rather than
 * raising and this read is module-scope. What it replaces was a NON-OPTIONAL
 * cast of the enum node to an options-bearing shape, spread directly — which
 * failed LOUDLY the moment the cast stopped holding (spreading `undefined`
 * throws), so a bare `enumOptions` call here would have traded a loud failure
 * for a silently empty vocabulary: every assertion below would then pass over
 * nothing. That trade is the regression objectui#7025 exists to refuse. (The
 * retired spelling is deliberately NOT quoted here: the card's enumeration
 * instrument is a grep for it, and a comment carrying the literal text makes
 * every future re-derivation of this population read a false positive.)
 */
const readSpecFieldTypes = (): readonly string[] => {
 const options = enumOptions(FieldType);
 if (options.length === 0) {
 throw new Error('could not read FieldType.options from @objectstack/spec');
 }
 return options;
};

const SPEC_FIELD_TYPES: readonly string[] = readSpecFieldTypes();

/**
 * A board with NO `cardFields` and NO `highlightFields`, so cards fall to the
Expand Down

8 changes: 7 additions & 1 deletion
packages/types/src/__tests__/spec-subschema-parity.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -39,6 +39,7 @@ import {
 ChartTypeSchema as SpecChartTypeSchema,
 PageTypeSchema as SpecPageTypeSchema,
} from '@objectstack/spec/ui';
import { enumOptions } from '@object-ui/test-support';
import {
 HttpMethodSchema,
 HttpRequestSchema,
Expand DownExpand Up@@ -175,7 +176,12 @@ describe('ListColumnSchema is the spec schema (the extension collapsed)', () =>
 // arm through `lazySchema`, whose Proxy resolves `.shape.type` to the inner
 // enum instead of the exported schema object, so a `toBe` check would test
 // the wrapper rather than the vocabulary it is meant to protect.
 const vocabulary = (SpecColumnSummarySchema as unknown as { options: string[] }).options;
 // The wrapper walk is `@object-ui/test-support`'s shared reader
 // (objectui#6924). No throw wrapper: the assertion on the next line already
 // discharges the reader's non-vacuity duty, which is what keeps the loop
 // below from passing over an empty vocabulary now that a failed read
 // answers `[]` instead of throwing (objectui#7025).
 const vocabulary = enumOptions(SpecColumnSummarySchema);
 expect(vocabulary.length, 'spec ColumnSummarySchema should be a non-empty enum').toBeGreaterThan(0);

 for (const agg of vocabulary) {
Expand Down

6 changes: 6 additions & 0 deletions
pnpm-lock.yaml

View file


Open in desktop


Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
test(spec-parity): converge the non-optional enum-options casts onto the shared reader (#7025)#7057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-sam
merged 1 commit into

from

Aug 31, 2026
 Merged


test(spec-parity): converge the non-optional enum-options casts onto the shared reader (#7025)
#7057
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


20 changes: 20 additions & 0 deletions
.changeset/7025-nonoptional-enum-cast.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
---
---

Internal test-only change, no user-visible behaviour (objectui#7025).

The SIXTH spelling of the Zod-internals reader hazard objectui#5872 catalogues:
9 spec-parity test files in 7 packages cast an enum node NON-optionally to an
options-bearing shape and read `.options` straight off it. They converge onto
`@object-ui/test-support`'s `enumOptions(node)` — the same walk objectui#6924
converged the optional-cast family onto in PR #7024.

Unlike that family, these sites failed LOUDLY (spreading `undefined` throws), and
the shared reader deliberately answers `[]` rather than raising. So every site
keeps its own non-vacuity duty: a throwing wrapper at the seven module-scope
reads, and the suite's own pre-existing non-vacuity assertion at the two in-test
reads. A bare conversion would have traded a loud failure for a silent empty
vocabulary — a regression, not a convergence.

Only test files, two `devDependencies` edges and the lockfile change; no
package's shipped `dist/` and no public type moves.

28 changes: 25 additions & 3 deletions
packages/app-shell/src/utils/expandableFamily.identity-5874.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -54,16 +54,38 @@
import { describe, it, expect, vi, afterEach } from 'vitest';
import { EXPANDABLE_FIELD_TYPES } from '@object-ui/core';
import { FieldType } from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';
import { ActionParamSchema } from '@objectstack/spec/ui';
import {
 resolveActionParams,
 type ResolveActionParamsContext,
 type RawActionParam,
} from './resolveActionParams';

const SPEC_FIELD_TYPES: readonly string[] = [
 ...(FieldType as unknown as { options: readonly string[] }).options,
];
/**
 * The spec's own `FieldType` vocabulary.
 *
 * The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924);
 * the THROW stays HERE, because the reader deliberately answers `[]` rather than
 * raising and this read is module-scope. What it replaces was a NON-OPTIONAL
 * cast of the enum node to an options-bearing shape, spread directly — which
 * failed LOUDLY the moment the cast stopped holding (spreading `undefined`
 * throws), so a bare `enumOptions` call here would have traded a loud failure
 * for a silently empty vocabulary: every assertion below would then pass over
 * nothing. That trade is the regression objectui#7025 exists to refuse. (The
 * retired spelling is deliberately NOT quoted here: the card's enumeration
 * instrument is a grep for it, and a comment carrying the literal text makes
 * every future re-derivation of this population read a false positive.)
 */
const readSpecFieldTypes = (): readonly string[] => {
 const options = enumOptions(FieldType);
 if (options.length === 0) {
 throw new Error('could not read FieldType.options from @objectstack/spec');
 }
 return options;
};

const SPEC_FIELD_TYPES: readonly string[] = readSpecFieldTypes();

/** Every picker key `lookupExtras` copies off the resolved object field. */
const PICKER_KEYS = [
Expand Down

26 changes: 25 additions & 1 deletion
packages/app-shell/src/views/richtextSurfaceParity.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -27,11 +27,35 @@
 */
import { describe, it, expect } from 'vitest';
import { FieldType } from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';
import { isWideFieldType as detailIsWide } from '@object-ui/plugin-detail';
import { isWideFieldType as formIsWide } from '@object-ui/plugin-form';
import { isSecondaryField } from './RecordDetailView';

const SPEC_TYPES: readonly string[] = [...(FieldType as { options: readonly string[] }).options];
/**
 * The spec's own `FieldType` vocabulary.
 *
 * The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924);
 * the THROW stays HERE, because the reader deliberately answers `[]` rather than
 * raising and this read is module-scope. What it replaces was a NON-OPTIONAL
 * cast of the enum node to an options-bearing shape, spread directly — which
 * failed LOUDLY the moment the cast stopped holding (spreading `undefined`
 * throws), so a bare `enumOptions` call here would have traded a loud failure
 * for a silently empty vocabulary: the derived assertions below would then pass
 * over nothing. That trade is the regression objectui#7025 exists to refuse.
 * (The retired spelling is deliberately NOT quoted here: the card's enumeration
 * instrument is a grep for it, and a comment carrying the literal text makes
 * every future re-derivation of this population read a false positive.)
 */
const readSpecTypes = (): readonly string[] => {
 const options = enumOptions(FieldType);
 if (options.length === 0) {
 throw new Error('could not read FieldType.options from @objectstack/spec');
 }
 return options;
};

const SPEC_TYPES: readonly string[] = readSpecTypes();

/**
 * ONE fixture, read by all three rules. `body` is the field the card is about;
Expand Down

28 changes: 25 additions & 3 deletions
packages/plugin-dashboard/src/__tests__/expandableFamily.identity-5692.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -71,12 +71,34 @@ import { fileURLToPath } from 'node:url';
import { describe, it, expect, vi } from 'vitest';
import { EXPANDABLE_FIELD_TYPES } from '@object-ui/core';
import { FieldType } from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';
import { isLookupType } from '../recordFields';
import { computeLookupExpand } from '../ObjectDataTable';

const SPEC_FIELD_TYPES: readonly string[] = [
 ...(FieldType as unknown as { options: readonly string[] }).options,
];
/**
 * The spec's own `FieldType` vocabulary.
 *
 * The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924);
 * the THROW stays HERE, because the reader deliberately answers `[]` rather than
 * raising and this read is module-scope. What it replaces was a NON-OPTIONAL
 * cast of the enum node to an options-bearing shape, spread directly — which
 * failed LOUDLY the moment the cast stopped holding (spreading `undefined`
 * throws), so a bare `enumOptions` call here would have traded a loud failure
 * for a silently empty vocabulary: every assertion below would then pass over
 * nothing. That trade is the regression objectui#7025 exists to refuse. (The
 * retired spelling is deliberately NOT quoted here: the card's enumeration
 * instrument is a grep for it, and a comment carrying the literal text makes
 * every future re-derivation of this population read a false positive.)
 */
const readSpecFieldTypes = (): readonly string[] => {
 const options = enumOptions(FieldType);
 if (options.length === 0) {
 throw new Error('could not read FieldType.options from @objectstack/spec');
 }
 return options;
};

const SPEC_FIELD_TYPES: readonly string[] = readSpecFieldTypes();

/** The relations an ordinary dashboard table shows — the regression control. */
const ORDINARY_RELATIONS = ['lookup', 'master_detail', 'user'] as const;
Expand Down

26 changes: 25 additions & 1 deletion
packages/plugin-detail/src/__tests__/autoLayout.wideSpelling.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -20,10 +20,34 @@
 */
import { describe, it, expect } from 'vitest';
import { FieldType } from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';
import { mapFieldTypeToFormType } from '@object-ui/fields';
import { isWideFieldType, applyAutoSpan } from '../autoLayout';

const SPEC_TYPES: readonly string[] = [...(FieldType as { options: readonly string[] }).options];
/**
 * The spec's own `FieldType` vocabulary.
 *
 * The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924);
 * the THROW stays HERE, because the reader deliberately answers `[]` rather than
 * raising and this read is module-scope. What it replaces was a NON-OPTIONAL
 * cast of the enum node to an options-bearing shape, spread directly — which
 * failed LOUDLY the moment the cast stopped holding (spreading `undefined`
 * throws), so a bare `enumOptions` call here would have traded a loud failure
 * for a silently empty vocabulary: the derived assertions below would then pass
 * over nothing. That trade is the regression objectui#7025 exists to refuse.
 * (The retired spelling is deliberately NOT quoted here: the card's enumeration
 * instrument is a grep for it, and a comment carrying the literal text makes
 * every future re-derivation of this population read a false positive.)
 */
const readSpecTypes = (): readonly string[] => {
 const options = enumOptions(FieldType);
 if (options.length === 0) {
 throw new Error('could not read FieldType.options from @objectstack/spec');
 }
 return options;
};

const SPEC_TYPES: readonly string[] = readSpecTypes();

/**
 * The long-form / document family: the spec types whose value is a whole block
Expand Down

28 changes: 25 additions & 3 deletions
packages/plugin-detail/src/__tests__/expandableFamily.identity-5874.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -66,12 +66,34 @@ import { render } from '@testing-library/react';
import React from 'react';
import { EXPANDABLE_FIELD_TYPES } from '@object-ui/core';
import { FieldType } from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';
import { HeaderHighlight } from '../HeaderHighlight';
import { RecordDetailDrawer } from '../RecordDetailDrawer';

const SPEC_FIELD_TYPES: readonly string[] = [
 ...(FieldType as unknown as { options: readonly string[] }).options,
];
/**
 * The spec's own `FieldType` vocabulary.
 *
 * The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924);
 * the THROW stays HERE, because the reader deliberately answers `[]` rather than
 * raising and this read is module-scope. What it replaces was a NON-OPTIONAL
 * cast of the enum node to an options-bearing shape, spread directly — which
 * failed LOUDLY the moment the cast stopped holding (spreading `undefined`
 * throws), so a bare `enumOptions` call here would have traded a loud failure
 * for a silently empty vocabulary: every assertion below would then pass over
 * nothing. That trade is the regression objectui#7025 exists to refuse. (The
 * retired spelling is deliberately NOT quoted here: the card's enumeration
 * instrument is a grep for it, and a comment carrying the literal text makes
 * every future re-derivation of this population read a false positive.)
 */
const readSpecFieldTypes = (): readonly string[] => {
 const options = enumOptions(FieldType);
 if (options.length === 0) {
 throw new Error('could not read FieldType.options from @objectstack/spec');
 }
 return options;
};

const SPEC_FIELD_TYPES: readonly string[] = readSpecFieldTypes();

/**
 * The drawer hands its derived field list to `DetailView` as `schema.fields`.
Expand Down

1 change: 1 addition & 0 deletions
packages/plugin-form/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -37,6 +37,7 @@
 },
 "devDependencies": {
 "@object-ui/data-objectstack": "workspace:*",
 "@object-ui/test-support": "workspace:*",
 "@vitejs/plugin-react": "^6.0.5",
 "msw": "^2.15.0",
 "typescript": "^6.0.3",
Expand Down

26 changes: 25 additions & 1 deletion
packages/plugin-form/src/__tests__/autoLayout.wideSpelling.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -19,11 +19,35 @@
 */
import { describe, it, expect } from 'vitest';
import { FieldType } from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';
import { mapFieldTypeToFormType } from '@object-ui/fields';
import { isWideFieldType, resolveColSpan } from '../autoLayout';
import type { FormField } from '@object-ui/types';

const SPEC_TYPES: readonly string[] = [...(FieldType as { options: readonly string[] }).options];
/**
 * The spec's own `FieldType` vocabulary.
 *
 * The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924);
 * the THROW stays HERE, because the reader deliberately answers `[]` rather than
 * raising and this read is module-scope. What it replaces was a NON-OPTIONAL
 * cast of the enum node to an options-bearing shape, spread directly — which
 * failed LOUDLY the moment the cast stopped holding (spreading `undefined`
 * throws), so a bare `enumOptions` call here would have traded a loud failure
 * for a silently empty vocabulary: the derived assertions below would then pass
 * over nothing. That trade is the regression objectui#7025 exists to refuse.
 * (The retired spelling is deliberately NOT quoted here: the card's enumeration
 * instrument is a grep for it, and a comment carrying the literal text makes
 * every future re-derivation of this population read a false positive.)
 */
const readSpecTypes = (): readonly string[] => {
 const options = enumOptions(FieldType);
 if (options.length === 0) {
 throw new Error('could not read FieldType.options from @objectstack/spec');
 }
 return options;
};

const SPEC_TYPES: readonly string[] = readSpecTypes();

/** The long-form / document family, spelled as the SPEC spells it. */
const WIDE_SPEC_TYPES = ['textarea', 'markdown', 'html', 'richtext'] as const;
Expand Down

21 changes: 19 additions & 2 deletions
packages/plugin-grid/src/__tests__/spec-symbol-batch7.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,15 +36,32 @@ import {
 MULTI_CAPABLE_TYPES,
 MULTI_OPTION_TYPES,
} from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';

import { SUPPORTED_SUMMARY_TYPES, type ColumnSummarySetting, type ColumnSummaryType } from '../useColumnSummary';
import { hasMultiValueShape } from '../hooks/multiValueFields';

const specSummaryOptions = (ColumnSummarySchema as unknown as { options: readonly string[] }).options;
/**
 * The spec's column-summary vocabulary.
 *
 * The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924).
 * No throw wrapper here — unlike the module-scope readers converted alongside it
 * in objectui#7025, this suite already discharges the reader's non-vacuity duty
 * with its OWN first assertion below, which is the sanctioned alternative. What
 * it replaces was a NON-OPTIONAL cast of the enum node to an options-bearing
 * shape; the loudness that cast provided is preserved by that assertion, not
 * lost to `[]`.
 */
const specSummaryOptions: readonly string[] = enumOptions(ColumnSummarySchema);

describe('the column-summary vocabulary comes from the spec', () => {
 it('reads a non-empty enum from the spec (the probe itself is not vacuous)', () => {
 expect(Array.isArray(specSummaryOptions) && specSummaryOptions.length > 0).toBe(true);
 // The reader answers `[]` when it cannot read the enum, so THIS is what
 // keeps every assertion below from passing over an empty list.
 expect(
 specSummaryOptions,
 'could not read ColumnSummarySchema.options from the spec',
 ).not.toEqual([]);
 });

 it('every aggregation the spec accepts is one this renderer computes', () => {
Expand Down

1 change: 1 addition & 0 deletions
packages/plugin-kanban/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,6 +51,7 @@
 },
 "devDependencies": {
 "@object-ui/data-objectstack": "workspace:*",
 "@object-ui/test-support": "workspace:*",
 "@tailwindcss/postcss": "^4.3.3",
 "@types/react": "19.2.18",
 "@types/react-dom": "19.2.4",
Expand Down

28 changes: 25 additions & 3 deletions
packages/plugin-kanban/src/__tests__/expandableFamily.identity-5874.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -63,6 +63,7 @@ import { render, waitFor } from '@testing-library/react';
import React from 'react';
import { EXPANDABLE_FIELD_TYPES } from '@object-ui/core';
import { FieldType } from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';
import { SchemaRenderer, SchemaRendererProvider } from '@object-ui/react';
// Registers `object-kanban`.
import '../index';
Expand All@@ -73,9 +74,30 @@ import '../index';
// so ESM's module cache makes that factory resolve immediately.
import '../KanbanImpl';

const SPEC_FIELD_TYPES: readonly string[] = [
 ...(FieldType as unknown as { options: readonly string[] }).options,
];
/**
 * The spec's own `FieldType` vocabulary.
 *
 * The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924);
 * the THROW stays HERE, because the reader deliberately answers `[]` rather than
 * raising and this read is module-scope. What it replaces was a NON-OPTIONAL
 * cast of the enum node to an options-bearing shape, spread directly — which
 * failed LOUDLY the moment the cast stopped holding (spreading `undefined`
 * throws), so a bare `enumOptions` call here would have traded a loud failure
 * for a silently empty vocabulary: every assertion below would then pass over
 * nothing. That trade is the regression objectui#7025 exists to refuse. (The
 * retired spelling is deliberately NOT quoted here: the card's enumeration
 * instrument is a grep for it, and a comment carrying the literal text makes
 * every future re-derivation of this population read a false positive.)
 */
const readSpecFieldTypes = (): readonly string[] => {
 const options = enumOptions(FieldType);
 if (options.length === 0) {
 throw new Error('could not read FieldType.options from @objectstack/spec');
 }
 return options;
};

const SPEC_FIELD_TYPES: readonly string[] = readSpecFieldTypes();

/**
 * A board with NO `cardFields` and NO `highlightFields`, so cards fall to the
Expand Down

8 changes: 7 additions & 1 deletion
packages/types/src/__tests__/spec-subschema-parity.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -39,6 +39,7 @@ import {
 ChartTypeSchema as SpecChartTypeSchema,
 PageTypeSchema as SpecPageTypeSchema,
} from '@objectstack/spec/ui';
import { enumOptions } from '@object-ui/test-support';
import {
 HttpMethodSchema,
 HttpRequestSchema,
Expand DownExpand Up@@ -175,7 +176,12 @@ describe('ListColumnSchema is the spec schema (the extension collapsed)', () =>
 // arm through `lazySchema`, whose Proxy resolves `.shape.type` to the inner
 // enum instead of the exported schema object, so a `toBe` check would test
 // the wrapper rather than the vocabulary it is meant to protect.
 const vocabulary = (SpecColumnSummarySchema as unknown as { options: string[] }).options;
 // The wrapper walk is `@object-ui/test-support`'s shared reader
 // (objectui#6924). No throw wrapper: the assertion on the next line already
 // discharges the reader's non-vacuity duty, which is what keeps the loop
 // below from passing over an empty vocabulary now that a failed read
 // answers `[]` instead of throwing (objectui#7025).
 const vocabulary = enumOptions(SpecColumnSummarySchema);
 expect(vocabulary.length, 'spec ColumnSummarySchema should be a non-empty enum').toBeGreaterThan(0);

 for (const agg of vocabulary) {
Expand Down

6 changes: 6 additions & 0 deletions
pnpm-lock.yaml

View file


Open in desktop


Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
test(spec-parity): converge the non-optional enum-options casts onto the shared reader (#7025)#7057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-sam
merged 1 commit into

from

Aug 31, 2026
 Merged


test(spec-parity): converge the non-optional enum-options casts onto the shared reader (#7025)
#7057
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


20 changes: 20 additions & 0 deletions
.changeset/7025-nonoptional-enum-cast.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
---
---

Internal test-only change, no user-visible behaviour (objectui#7025).

The SIXTH spelling of the Zod-internals reader hazard objectui#5872 catalogues:
9 spec-parity test files in 7 packages cast an enum node NON-optionally to an
options-bearing shape and read `.options` straight off it. They converge onto
`@object-ui/test-support`'s `enumOptions(node)` — the same walk objectui#6924
converged the optional-cast family onto in PR #7024.

Unlike that family, these sites failed LOUDLY (spreading `undefined` throws), and
the shared reader deliberately answers `[]` rather than raising. So every site
keeps its own non-vacuity duty: a throwing wrapper at the seven module-scope
reads, and the suite's own pre-existing non-vacuity assertion at the two in-test
reads. A bare conversion would have traded a loud failure for a silent empty
vocabulary — a regression, not a convergence.

Only test files, two `devDependencies` edges and the lockfile change; no
package's shipped `dist/` and no public type moves.

28 changes: 25 additions & 3 deletions
packages/app-shell/src/utils/expandableFamily.identity-5874.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -54,16 +54,38 @@
import { describe, it, expect, vi, afterEach } from 'vitest';
import { EXPANDABLE_FIELD_TYPES } from '@object-ui/core';
import { FieldType } from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';
import { ActionParamSchema } from '@objectstack/spec/ui';
import {
 resolveActionParams,
 type ResolveActionParamsContext,
 type RawActionParam,
} from './resolveActionParams';

const SPEC_FIELD_TYPES: readonly string[] = [
 ...(FieldType as unknown as { options: readonly string[] }).options,
];
/**
 * The spec's own `FieldType` vocabulary.
 *
 * The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924);
 * the THROW stays HERE, because the reader deliberately answers `[]` rather than
 * raising and this read is module-scope. What it replaces was a NON-OPTIONAL
 * cast of the enum node to an options-bearing shape, spread directly — which
 * failed LOUDLY the moment the cast stopped holding (spreading `undefined`
 * throws), so a bare `enumOptions` call here would have traded a loud failure
 * for a silently empty vocabulary: every assertion below would then pass over
 * nothing. That trade is the regression objectui#7025 exists to refuse. (The
 * retired spelling is deliberately NOT quoted here: the card's enumeration
 * instrument is a grep for it, and a comment carrying the literal text makes
 * every future re-derivation of this population read a false positive.)
 */
const readSpecFieldTypes = (): readonly string[] => {
 const options = enumOptions(FieldType);
 if (options.length === 0) {
 throw new Error('could not read FieldType.options from @objectstack/spec');
 }
 return options;
};

const SPEC_FIELD_TYPES: readonly string[] = readSpecFieldTypes();

/** Every picker key `lookupExtras` copies off the resolved object field. */
const PICKER_KEYS = [
Expand Down

26 changes: 25 additions & 1 deletion
packages/app-shell/src/views/richtextSurfaceParity.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -27,11 +27,35 @@
 */
import { describe, it, expect } from 'vitest';
import { FieldType } from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';
import { isWideFieldType as detailIsWide } from '@object-ui/plugin-detail';
import { isWideFieldType as formIsWide } from '@object-ui/plugin-form';
import { isSecondaryField } from './RecordDetailView';

const SPEC_TYPES: readonly string[] = [...(FieldType as { options: readonly string[] }).options];
/**
 * The spec's own `FieldType` vocabulary.
 *
 * The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924);
 * the THROW stays HERE, because the reader deliberately answers `[]` rather than
 * raising and this read is module-scope. What it replaces was a NON-OPTIONAL
 * cast of the enum node to an options-bearing shape, spread directly — which
 * failed LOUDLY the moment the cast stopped holding (spreading `undefined`
 * throws), so a bare `enumOptions` call here would have traded a loud failure
 * for a silently empty vocabulary: the derived assertions below would then pass
 * over nothing. That trade is the regression objectui#7025 exists to refuse.
 * (The retired spelling is deliberately NOT quoted here: the card's enumeration
 * instrument is a grep for it, and a comment carrying the literal text makes
 * every future re-derivation of this population read a false positive.)
 */
const readSpecTypes = (): readonly string[] => {
 const options = enumOptions(FieldType);
 if (options.length === 0) {
 throw new Error('could not read FieldType.options from @objectstack/spec');
 }
 return options;
};

const SPEC_TYPES: readonly string[] = readSpecTypes();

/**
 * ONE fixture, read by all three rules. `body` is the field the card is about;
Expand Down

28 changes: 25 additions & 3 deletions
packages/plugin-dashboard/src/__tests__/expandableFamily.identity-5692.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -71,12 +71,34 @@ import { fileURLToPath } from 'node:url';
import { describe, it, expect, vi } from 'vitest';
import { EXPANDABLE_FIELD_TYPES } from '@object-ui/core';
import { FieldType } from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';
import { isLookupType } from '../recordFields';
import { computeLookupExpand } from '../ObjectDataTable';

const SPEC_FIELD_TYPES: readonly string[] = [
 ...(FieldType as unknown as { options: readonly string[] }).options,
];
/**
 * The spec's own `FieldType` vocabulary.
 *
 * The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924);
 * the THROW stays HERE, because the reader deliberately answers `[]` rather than
 * raising and this read is module-scope. What it replaces was a NON-OPTIONAL
 * cast of the enum node to an options-bearing shape, spread directly — which
 * failed LOUDLY the moment the cast stopped holding (spreading `undefined`
 * throws), so a bare `enumOptions` call here would have traded a loud failure
 * for a silently empty vocabulary: every assertion below would then pass over
 * nothing. That trade is the regression objectui#7025 exists to refuse. (The
 * retired spelling is deliberately NOT quoted here: the card's enumeration
 * instrument is a grep for it, and a comment carrying the literal text makes
 * every future re-derivation of this population read a false positive.)
 */
const readSpecFieldTypes = (): readonly string[] => {
 const options = enumOptions(FieldType);
 if (options.length === 0) {
 throw new Error('could not read FieldType.options from @objectstack/spec');
 }
 return options;
};

const SPEC_FIELD_TYPES: readonly string[] = readSpecFieldTypes();

/** The relations an ordinary dashboard table shows — the regression control. */
const ORDINARY_RELATIONS = ['lookup', 'master_detail', 'user'] as const;
Expand Down

26 changes: 25 additions & 1 deletion
packages/plugin-detail/src/__tests__/autoLayout.wideSpelling.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -20,10 +20,34 @@
 */
import { describe, it, expect } from 'vitest';
import { FieldType } from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';
import { mapFieldTypeToFormType } from '@object-ui/fields';
import { isWideFieldType, applyAutoSpan } from '../autoLayout';

const SPEC_TYPES: readonly string[] = [...(FieldType as { options: readonly string[] }).options];
/**
 * The spec's own `FieldType` vocabulary.
 *
 * The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924);
 * the THROW stays HERE, because the reader deliberately answers `[]` rather than
 * raising and this read is module-scope. What it replaces was a NON-OPTIONAL
 * cast of the enum node to an options-bearing shape, spread directly — which
 * failed LOUDLY the moment the cast stopped holding (spreading `undefined`
 * throws), so a bare `enumOptions` call here would have traded a loud failure
 * for a silently empty vocabulary: the derived assertions below would then pass
 * over nothing. That trade is the regression objectui#7025 exists to refuse.
 * (The retired spelling is deliberately NOT quoted here: the card's enumeration
 * instrument is a grep for it, and a comment carrying the literal text makes
 * every future re-derivation of this population read a false positive.)
 */
const readSpecTypes = (): readonly string[] => {
 const options = enumOptions(FieldType);
 if (options.length === 0) {
 throw new Error('could not read FieldType.options from @objectstack/spec');
 }
 return options;
};

const SPEC_TYPES: readonly string[] = readSpecTypes();

/**
 * The long-form / document family: the spec types whose value is a whole block
Expand Down

28 changes: 25 additions & 3 deletions
packages/plugin-detail/src/__tests__/expandableFamily.identity-5874.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -66,12 +66,34 @@ import { render } from '@testing-library/react';
import React from 'react';
import { EXPANDABLE_FIELD_TYPES } from '@object-ui/core';
import { FieldType } from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';
import { HeaderHighlight } from '../HeaderHighlight';
import { RecordDetailDrawer } from '../RecordDetailDrawer';

const SPEC_FIELD_TYPES: readonly string[] = [
 ...(FieldType as unknown as { options: readonly string[] }).options,
];
/**
 * The spec's own `FieldType` vocabulary.
 *
 * The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924);
 * the THROW stays HERE, because the reader deliberately answers `[]` rather than
 * raising and this read is module-scope. What it replaces was a NON-OPTIONAL
 * cast of the enum node to an options-bearing shape, spread directly — which
 * failed LOUDLY the moment the cast stopped holding (spreading `undefined`
 * throws), so a bare `enumOptions` call here would have traded a loud failure
 * for a silently empty vocabulary: every assertion below would then pass over
 * nothing. That trade is the regression objectui#7025 exists to refuse. (The
 * retired spelling is deliberately NOT quoted here: the card's enumeration
 * instrument is a grep for it, and a comment carrying the literal text makes
 * every future re-derivation of this population read a false positive.)
 */
const readSpecFieldTypes = (): readonly string[] => {
 const options = enumOptions(FieldType);
 if (options.length === 0) {
 throw new Error('could not read FieldType.options from @objectstack/spec');
 }
 return options;
};

const SPEC_FIELD_TYPES: readonly string[] = readSpecFieldTypes();

/**
 * The drawer hands its derived field list to `DetailView` as `schema.fields`.
Expand Down

1 change: 1 addition & 0 deletions
packages/plugin-form/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -37,6 +37,7 @@
 },
 "devDependencies": {
 "@object-ui/data-objectstack": "workspace:*",
 "@object-ui/test-support": "workspace:*",
 "@vitejs/plugin-react": "^6.0.5",
 "msw": "^2.15.0",
 "typescript": "^6.0.3",
Expand Down

26 changes: 25 additions & 1 deletion
packages/plugin-form/src/__tests__/autoLayout.wideSpelling.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -19,11 +19,35 @@
 */
import { describe, it, expect } from 'vitest';
import { FieldType } from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';
import { mapFieldTypeToFormType } from '@object-ui/fields';
import { isWideFieldType, resolveColSpan } from '../autoLayout';
import type { FormField } from '@object-ui/types';

const SPEC_TYPES: readonly string[] = [...(FieldType as { options: readonly string[] }).options];
/**
 * The spec's own `FieldType` vocabulary.
 *
 * The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924);
 * the THROW stays HERE, because the reader deliberately answers `[]` rather than
 * raising and this read is module-scope. What it replaces was a NON-OPTIONAL
 * cast of the enum node to an options-bearing shape, spread directly — which
 * failed LOUDLY the moment the cast stopped holding (spreading `undefined`
 * throws), so a bare `enumOptions` call here would have traded a loud failure
 * for a silently empty vocabulary: the derived assertions below would then pass
 * over nothing. That trade is the regression objectui#7025 exists to refuse.
 * (The retired spelling is deliberately NOT quoted here: the card's enumeration
 * instrument is a grep for it, and a comment carrying the literal text makes
 * every future re-derivation of this population read a false positive.)
 */
const readSpecTypes = (): readonly string[] => {
 const options = enumOptions(FieldType);
 if (options.length === 0) {
 throw new Error('could not read FieldType.options from @objectstack/spec');
 }
 return options;
};

const SPEC_TYPES: readonly string[] = readSpecTypes();

/** The long-form / document family, spelled as the SPEC spells it. */
const WIDE_SPEC_TYPES = ['textarea', 'markdown', 'html', 'richtext'] as const;
Expand Down

21 changes: 19 additions & 2 deletions
packages/plugin-grid/src/__tests__/spec-symbol-batch7.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,15 +36,32 @@ import {
 MULTI_CAPABLE_TYPES,
 MULTI_OPTION_TYPES,
} from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';

import { SUPPORTED_SUMMARY_TYPES, type ColumnSummarySetting, type ColumnSummaryType } from '../useColumnSummary';
import { hasMultiValueShape } from '../hooks/multiValueFields';

const specSummaryOptions = (ColumnSummarySchema as unknown as { options: readonly string[] }).options;
/**
 * The spec's column-summary vocabulary.
 *
 * The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924).
 * No throw wrapper here — unlike the module-scope readers converted alongside it
 * in objectui#7025, this suite already discharges the reader's non-vacuity duty
 * with its OWN first assertion below, which is the sanctioned alternative. What
 * it replaces was a NON-OPTIONAL cast of the enum node to an options-bearing
 * shape; the loudness that cast provided is preserved by that assertion, not
 * lost to `[]`.
 */
const specSummaryOptions: readonly string[] = enumOptions(ColumnSummarySchema);

describe('the column-summary vocabulary comes from the spec', () => {
 it('reads a non-empty enum from the spec (the probe itself is not vacuous)', () => {
 expect(Array.isArray(specSummaryOptions) && specSummaryOptions.length > 0).toBe(true);
 // The reader answers `[]` when it cannot read the enum, so THIS is what
 // keeps every assertion below from passing over an empty list.
 expect(
 specSummaryOptions,
 'could not read ColumnSummarySchema.options from the spec',
 ).not.toEqual([]);
 });

 it('every aggregation the spec accepts is one this renderer computes', () => {
Expand Down

1 change: 1 addition & 0 deletions
packages/plugin-kanban/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -51,6 +51,7 @@
 },
 "devDependencies": {
 "@object-ui/data-objectstack": "workspace:*",
 "@object-ui/test-support": "workspace:*",
 "@tailwindcss/postcss": "^4.3.3",
 "@types/react": "19.2.18",
 "@types/react-dom": "19.2.4",
Expand Down

28 changes: 25 additions & 3 deletions
packages/plugin-kanban/src/__tests__/expandableFamily.identity-5874.test.tsx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -63,6 +63,7 @@ import { render, waitFor } from '@testing-library/react';
import React from 'react';
import { EXPANDABLE_FIELD_TYPES } from '@object-ui/core';
import { FieldType } from '@objectstack/spec/data';
import { enumOptions } from '@object-ui/test-support';
import { SchemaRenderer, SchemaRendererProvider } from '@object-ui/react';
// Registers `object-kanban`.
import '../index';
Expand All@@ -73,9 +74,30 @@ import '../index';
// so ESM's module cache makes that factory resolve immediately.
import '../KanbanImpl';

const SPEC_FIELD_TYPES: readonly string[] = [
 ...(FieldType as unknown as { options: readonly string[] }).options,
];
/**
 * The spec's own `FieldType` vocabulary.
 *
 * The wrapper walk is `@object-ui/test-support`'s shared reader (objectui#6924);
 * the THROW stays HERE, because the reader deliberately answers `[]` rather than
 * raising and this read is module-scope. What it replaces was a NON-OPTIONAL
 * cast of the enum node to an options-bearing shape, spread directly — which
 * failed LOUDLY the moment the cast stopped holding (spreading `undefined`
 * throws), so a bare `enumOptions` call here would have traded a loud failure
 * for a silently empty vocabulary: every assertion below would then pass over
 * nothing. That trade is the regression objectui#7025 exists to refuse. (The
 * retired spelling is deliberately NOT quoted here: the card's enumeration
 * instrument is a grep for it, and a comment carrying the literal text makes
 * every future re-derivation of this population read a false positive.)
 */
const readSpecFieldTypes = (): readonly string[] => {
 const options = enumOptions(FieldType);
 if (options.length === 0) {
 throw new Error('could not read FieldType.options from @objectstack/spec');
 }
 return options;
};

const SPEC_FIELD_TYPES: readonly string[] = readSpecFieldTypes();

/**
 * A board with NO `cardFields` and NO `highlightFields`, so cards fall to the
Expand Down

8 changes: 7 additions & 1 deletion
packages/types/src/__tests__/spec-subschema-parity.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -39,6 +39,7 @@ import {
 ChartTypeSchema as SpecChartTypeSchema,
 PageTypeSchema as SpecPageTypeSchema,
} from '@objectstack/spec/ui';
import { enumOptions } from '@object-ui/test-support';
import {
 HttpMethodSchema,
 HttpRequestSchema,
Expand DownExpand Up@@ -175,7 +176,12 @@ describe('ListColumnSchema is the spec schema (the extension collapsed)', () =>
 // arm through `lazySchema`, whose Proxy resolves `.shape.type` to the inner
 // enum instead of the exported schema object, so a `toBe` check would test
 // the wrapper rather than the vocabulary it is meant to protect.
 const vocabulary = (SpecColumnSummarySchema as unknown as { options: string[] }).options;
 // The wrapper walk is `@object-ui/test-support`'s shared reader
 // (objectui#6924). No throw wrapper: the assertion on the next line already
 // discharges the reader's non-vacuity duty, which is what keeps the loop
 // below from passing over an empty vocabulary now that a failed read
 // answers `[]` instead of throwing (objectui#7025).
 const vocabulary = enumOptions(SpecColumnSummarySchema);
 expect(vocabulary.length, 'spec ColumnSummarySchema should be a non-empty enum').toBeGreaterThan(0);

 for (const agg of vocabulary) {
Expand Down

6 changes: 6 additions & 0 deletions
pnpm-lock.yaml

View file


Open in desktop


Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading