docs(components): publish button-group's shipped surface, in both directions#7078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-sam merged 4 commits into from
Aug 31, 2026
Merged

docs(components): publish button-group's shipped surface, in both directions #7078

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bc92486
docs(components): publish button-group's shipped surface, both direct…
claude Aug 31, 2026
2ced94e
docs: changeset for the button-group schema-block correction
claude Aug 31, 2026
467acdf
docs(components): the eleventh row — button-group inherits `disabled:…
claude Aug 31, 2026
0f49c91
test(types): type the wrapper carrier instead of `any` in the doc-sur…
claude Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
82 changes: 82 additions & 0 deletions .changeset/6347-button-group-schema-block.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,82 @@
---
---

Docs only, publishes nothing: `content/docs/components/basic/button-group.mdx`
published a `ButtonGroupSchema` / `ButtonGroupButton` surface that disagreed
with the shipped types in **both** directions. objectui#6347 named the two
over-statements; re-measuring the whole fence against
`packages/types/src/navigation.ts`, `packages/types/src/base.ts` and their Zod
mirrors found eleven rows.

Over-stated — documented, never declared:

| page before | shipped declaration | page after |
| --- | --- | --- |
| `ButtonGroupSchema.value?: string \| string[]` | not declared (`navigation.ts:335-351`, `zod/navigation.zod.ts:154-159`) | removed |
| `ButtonGroupSchema.selectionMode?: 'single' \| 'multiple' \| 'none'` | not declared (same two blocks) | removed |
| `ButtonGroupButton.value: string` (required) | not declared (`navigation.ts:305-330`, `zod/navigation.zod.ts:142-149`) | removed |
| `ButtonGroupButton.icon?: string` | not declared (same two blocks) | removed |
| `buttons: ButtonGroupButton[]` (required) | `buttons?: ButtonGroupButton[]` (`navigation.ts:340`, `.zod.ts:156`) | `buttons?:` |
| `label?: string` | `label: string` — required (`navigation.ts:309`, `.zod.ts:143`) | `label:` |

Under-stated — declared, never documented:

| page before | shipped declaration | page after |
| --- | --- | --- |
| `ButtonGroupButton` had no `variant` row | `variant?: 'default' \| 'secondary' \| 'destructive' \| 'outline' \| 'ghost' \| 'link'` (`navigation.ts:313`, `.zod.ts:144`) | added |
| `ButtonGroupButton` had no `size` row | `size?: 'default' \| 'sm' \| 'lg' \| 'icon'` (`navigation.ts:317`, `.zod.ts:145`) | added |
| `ButtonGroupButton` had no `onClick` row | `onClick?: () => void` (`navigation.ts:325`, `.zod.ts:147`) | added, annotated as a runtime slot |
| `ButtonGroupButton` had no `className` row | `className?: string` (`navigation.ts:329`, `.zod.ts:148`) | added |
| `ButtonGroupSchema.variant?: 'default' \| 'outline' \| 'ghost'` | six members (`navigation.ts:345`, `.zod.ts:157`) | `secondary`, `destructive`, `link` restored |
| `ButtonGroupSchema.size?: 'sm' \| 'default' \| 'lg'` | four members (`navigation.ts:350`, `.zod.ts:158`) | `icon` restored |
| `disabled?: boolean` | `BaseSchema.disabled?: boolean \| string` (`base.ts`, `zod/base.zod.ts:190`) — `ButtonGroupSchema` does **not** redeclare it | `boolean \| string` |

Both directions are one defect class with the sign flipped. Fixing only the
direction a card happens to notice is what left these omissions sitting beside
two earlier corrections to the same page (objectui#6132, objectui#6143).

The `disabled` row deserves its own note, because it looks like a convention and
is not. Fourteen `content/docs/components/**` pages spell a component schema's
own `disabled` as `boolean` — but **thirteen of those fourteen schemas redeclare
`disabled?: boolean` themselves** (`ButtonSchema`, `SelectSchema`,
`SwitchSchema`, `ToggleGroupSchema` and nine more), so those pages are right.
`ButtonGroupSchema` is the one that does not, so it inherits `BaseSchema`'s
`boolean | string` and this page was the outlier rather than the convention.
Whether `ButtonGroupSchema` *should* narrow it like its thirteen siblings is a
types question, not a docs one, and is deliberately not answered here — the
renderer reads neither spelling today.

`onClick` is documented as declared and annotated as a runtime slot: it is
`z.function()`, and objectui#4453 narrowed the runtime to
`typeof === 'function'`, so a JSON author cannot supply one.

**`## Selection Mode` is deleted, not softened.**
`packages/components/src/renderers/basic/button-group.tsx` implements no
selection behaviour at all — no `selectionMode` read, no group-level `value`
read, no state — and it does not wire the declared per-button `onClick` either.
It maps `schema.buttons` to `Button` elements reading `variant`, `size`,
`className` and `label` only. A heading over two inert demos taught a
capability nothing draws. The capability question itself is filed separately
rather than answered here.

The two catalog fixtures the section rendered
(`components-basic-button-group/single-selection`, `/multiple-selection`) are
**kept**. Catalog entries are a separate verification population, fenced off by
PR #6345; orphaning them from this page is the accepted cost, and no gate reads
a catalog entry's page references (the index is generated from the schema
directory by `scripts/regenerate-catalog-index.py`, path-keyed).

`packages/types/src/__tests__/button-group-doc-surface-6347.test.ts` pins the
result. Nothing in CI parses a `plaintext` fence — `check:doc-types` reads only
the `type` string literals and `check:doc-snippets` compiles `ts`/`tsx` fences —
so without it a green CI run would have said "nothing else broke", not "the
correction is right". The pin reads membership off the mirror's `.shape` rather
than off parse acceptance, because `BaseSchema` is `.passthrough()` and carries
`[key: string]: any`: an undeclared `selectionMode` parses green and
type-checks, so acceptance cannot tell "declared" from "admitted unexamined".

No type was minted, no fence moved (the page holds one `plaintext` fence before
and after, so objectui#5867's shrink-only declared population is unchanged), and
no catalog fixture was edited.

Part of objectui#6347.
33 changes: 14 additions & 19 deletions content/docs/components/basic/button-group.mdx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -18,34 +18,29 @@ The Button Group component groups multiple buttons together with consistent styl
<SchemaExample id="components-basic-button-group/with-icons" />
</DemoGrid>

## Selection Mode

<DemoGrid>
<SchemaExample id="components-basic-button-group/single-selection" />
<SchemaExample id="components-basic-button-group/multiple-selection" />
</DemoGrid>

## Schema

```plaintext
interface ButtonGroupButton {
label?: string;
value: string;
icon?: string;
disabled?: boolean;
label: string; // Button label (required)
variant?: 'default' | 'secondary' | 'destructive' | 'outline' | 'ghost' | 'link';
size?: 'default' | 'sm' | 'lg' | 'icon';
disabled?: boolean; // Whether this button is disabled
onClick?: () => void; // Runtime handler; not authorable in JSON
className?: string; // Per-button CSS class
}

interface ButtonGroupSchema {
type: 'button-group';
buttons: ButtonGroupButton[]; // Button definitions
value?: string | string[]; // Selected value(s)
selectionMode?: 'single' | 'multiple' | 'none';
variant?: 'default' | 'outline' | 'ghost';
size?: 'sm' | 'default' | 'lg';
buttons?: ButtonGroupButton[]; // Button definitions

// Defaults applied to every button that does not set its own
variant?: 'default' | 'secondary' | 'destructive' | 'outline' | 'ghost' | 'link';
size?: 'default' | 'sm' | 'lg' | 'icon';

// States
disabled?: boolean;
disabled?: boolean | string; // boolean, or a predicate expression

// Styling
className?: string;
}
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
docs(components): publish button-group's shipped surface, in both directions#7078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-sam
merged 4 commits into

from

Aug 31, 2026
 Merged


docs(components): publish button-group's shipped surface, in both directions
#7078
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
bc92486

docs(components): publish button-group's shipped surface, both direct…


claude Aug 31, 2026
2ced94e

docs: changeset for the button-group schema-block correction


claude Aug 31, 2026
467acdf

docs(components): the eleventh row — button-group inherits `disabled:…


claude Aug 31, 2026
0f49c91

test(types): type the wrapper carrier instead of `any` in the doc-sur…


claude Aug 31, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


82 changes: 82 additions & 0 deletions
.changeset/6347-button-group-schema-block.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,82 @@
---
---

Docs only, publishes nothing: `content/docs/components/basic/button-group.mdx`
published a `ButtonGroupSchema` / `ButtonGroupButton` surface that disagreed
with the shipped types in **both** directions. objectui#6347 named the two
over-statements; re-measuring the whole fence against
`packages/types/src/navigation.ts`, `packages/types/src/base.ts` and their Zod
mirrors found eleven rows.

Over-stated — documented, never declared:

| page before | shipped declaration | page after |
| --- | --- | --- |
| `ButtonGroupSchema.value?: string \| string[]` | not declared (`navigation.ts:335-351`, `zod/navigation.zod.ts:154-159`) | removed |
| `ButtonGroupSchema.selectionMode?: 'single' \| 'multiple' \| 'none'` | not declared (same two blocks) | removed |
| `ButtonGroupButton.value: string` (required) | not declared (`navigation.ts:305-330`, `zod/navigation.zod.ts:142-149`) | removed |
| `ButtonGroupButton.icon?: string` | not declared (same two blocks) | removed |
| `buttons: ButtonGroupButton[]` (required) | `buttons?: ButtonGroupButton[]` (`navigation.ts:340`, `.zod.ts:156`) | `buttons?:` |
| `label?: string` | `label: string` — required (`navigation.ts:309`, `.zod.ts:143`) | `label:` |

Under-stated — declared, never documented:

| page before | shipped declaration | page after |
| --- | --- | --- |
| `ButtonGroupButton` had no `variant` row | `variant?: 'default' \| 'secondary' \| 'destructive' \| 'outline' \| 'ghost' \| 'link'` (`navigation.ts:313`, `.zod.ts:144`) | added |
| `ButtonGroupButton` had no `size` row | `size?: 'default' \| 'sm' \| 'lg' \| 'icon'` (`navigation.ts:317`, `.zod.ts:145`) | added |
| `ButtonGroupButton` had no `onClick` row | `onClick?: () => void` (`navigation.ts:325`, `.zod.ts:147`) | added, annotated as a runtime slot |
| `ButtonGroupButton` had no `className` row | `className?: string` (`navigation.ts:329`, `.zod.ts:148`) | added |
| `ButtonGroupSchema.variant?: 'default' \| 'outline' \| 'ghost'` | six members (`navigation.ts:345`, `.zod.ts:157`) | `secondary`, `destructive`, `link` restored |
| `ButtonGroupSchema.size?: 'sm' \| 'default' \| 'lg'` | four members (`navigation.ts:350`, `.zod.ts:158`) | `icon` restored |
| `disabled?: boolean` | `BaseSchema.disabled?: boolean \| string` (`base.ts`, `zod/base.zod.ts:190`) — `ButtonGroupSchema` does **not** redeclare it | `boolean \| string` |

Both directions are one defect class with the sign flipped. Fixing only the
direction a card happens to notice is what left these omissions sitting beside
two earlier corrections to the same page (objectui#6132, objectui#6143).

The `disabled` row deserves its own note, because it looks like a convention and
is not. Fourteen `content/docs/components/**` pages spell a component schema's
own `disabled` as `boolean` — but **thirteen of those fourteen schemas redeclare
`disabled?: boolean` themselves** (`ButtonSchema`, `SelectSchema`,
`SwitchSchema`, `ToggleGroupSchema` and nine more), so those pages are right.
`ButtonGroupSchema` is the one that does not, so it inherits `BaseSchema`'s
`boolean | string` and this page was the outlier rather than the convention.
Whether `ButtonGroupSchema` *should* narrow it like its thirteen siblings is a
types question, not a docs one, and is deliberately not answered here — the
renderer reads neither spelling today.

`onClick` is documented as declared and annotated as a runtime slot: it is
`z.function()`, and objectui#4453 narrowed the runtime to
`typeof === 'function'`, so a JSON author cannot supply one.

**`## Selection Mode` is deleted, not softened.**
`packages/components/src/renderers/basic/button-group.tsx` implements no
selection behaviour at all — no `selectionMode` read, no group-level `value`
read, no state — and it does not wire the declared per-button `onClick` either.
It maps `schema.buttons` to `Button` elements reading `variant`, `size`,
`className` and `label` only. A heading over two inert demos taught a
capability nothing draws. The capability question itself is filed separately
rather than answered here.

The two catalog fixtures the section rendered
(`components-basic-button-group/single-selection`, `/multiple-selection`) are
**kept**. Catalog entries are a separate verification population, fenced off by
PR #6345; orphaning them from this page is the accepted cost, and no gate reads
a catalog entry's page references (the index is generated from the schema
directory by `scripts/regenerate-catalog-index.py`, path-keyed).

`packages/types/src/__tests__/button-group-doc-surface-6347.test.ts` pins the
result. Nothing in CI parses a `plaintext` fence — `check:doc-types` reads only
the `type` string literals and `check:doc-snippets` compiles `ts`/`tsx` fences —
so without it a green CI run would have said "nothing else broke", not "the
correction is right". The pin reads membership off the mirror's `.shape` rather
than off parse acceptance, because `BaseSchema` is `.passthrough()` and carries
`[key: string]: any`: an undeclared `selectionMode` parses green and
type-checks, so acceptance cannot tell "declared" from "admitted unexamined".

No type was minted, no fence moved (the page holds one `plaintext` fence before
and after, so objectui#5867's shrink-only declared population is unchanged), and
no catalog fixture was edited.

Part of objectui#6347.

33 changes: 14 additions & 19 deletions
content/docs/components/basic/button-group.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18,34 +18,29 @@ The Button Group component groups multiple buttons together with consistent styl
 <SchemaExample id="components-basic-button-group/with-icons" />
</DemoGrid>

## Selection Mode

<DemoGrid>
 <SchemaExample id="components-basic-button-group/single-selection" />
 <SchemaExample id="components-basic-button-group/multiple-selection" />
</DemoGrid>

## Schema

```plaintext
interface ButtonGroupButton {
 label?: string;
 value: string;
 icon?: string;
 disabled?: boolean;
 label: string; // Button label (required)
 variant?: 'default' | 'secondary' | 'destructive' | 'outline' | 'ghost' | 'link';
 size?: 'default' | 'sm' | 'lg' | 'icon';
 disabled?: boolean; // Whether this button is disabled
 onClick?: () => void; // Runtime handler; not authorable in JSON
 className?: string; // Per-button CSS class
}

interface ButtonGroupSchema {
 type: 'button-group';
 buttons: ButtonGroupButton[]; // Button definitions
 value?: string | string[]; // Selected value(s)
selectionMode?: 'single' | 'multiple' | 'none';
 variant?: 'default' | 'outline' | 'ghost';
 size?: 'sm' | 'default' | 'lg';
 buttons?: ButtonGroupButton[]; // Button definitions

// Defaults applied to every button that does not set its own
 variant?: 'default' | 'secondary' | 'destructive' | 'outline' | 'ghost' | 'link';
 size?: 'default' | 'sm' | 'lg' | 'icon';

 // States
 disabled?: boolean;
 disabled?: boolean | string; // boolean, or a predicate expression

 // Styling
 className?: string;
}
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
docs(components): publish button-group's shipped surface, in both directions#7078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-sam
merged 4 commits into

from

Aug 31, 2026
 Merged


docs(components): publish button-group's shipped surface, in both directions
#7078
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
bc92486

docs(components): publish button-group's shipped surface, both direct…


claude Aug 31, 2026
2ced94e

docs: changeset for the button-group schema-block correction


claude Aug 31, 2026
467acdf

docs(components): the eleventh row — button-group inherits `disabled:…


claude Aug 31, 2026
0f49c91

test(types): type the wrapper carrier instead of `any` in the doc-sur…


claude Aug 31, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


82 changes: 82 additions & 0 deletions
.changeset/6347-button-group-schema-block.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,82 @@
---
---

Docs only, publishes nothing: `content/docs/components/basic/button-group.mdx`
published a `ButtonGroupSchema` / `ButtonGroupButton` surface that disagreed
with the shipped types in **both** directions. objectui#6347 named the two
over-statements; re-measuring the whole fence against
`packages/types/src/navigation.ts`, `packages/types/src/base.ts` and their Zod
mirrors found eleven rows.

Over-stated — documented, never declared:

| page before | shipped declaration | page after |
| --- | --- | --- |
| `ButtonGroupSchema.value?: string \| string[]` | not declared (`navigation.ts:335-351`, `zod/navigation.zod.ts:154-159`) | removed |
| `ButtonGroupSchema.selectionMode?: 'single' \| 'multiple' \| 'none'` | not declared (same two blocks) | removed |
| `ButtonGroupButton.value: string` (required) | not declared (`navigation.ts:305-330`, `zod/navigation.zod.ts:142-149`) | removed |
| `ButtonGroupButton.icon?: string` | not declared (same two blocks) | removed |
| `buttons: ButtonGroupButton[]` (required) | `buttons?: ButtonGroupButton[]` (`navigation.ts:340`, `.zod.ts:156`) | `buttons?:` |
| `label?: string` | `label: string` — required (`navigation.ts:309`, `.zod.ts:143`) | `label:` |

Under-stated — declared, never documented:

| page before | shipped declaration | page after |
| --- | --- | --- |
| `ButtonGroupButton` had no `variant` row | `variant?: 'default' \| 'secondary' \| 'destructive' \| 'outline' \| 'ghost' \| 'link'` (`navigation.ts:313`, `.zod.ts:144`) | added |
| `ButtonGroupButton` had no `size` row | `size?: 'default' \| 'sm' \| 'lg' \| 'icon'` (`navigation.ts:317`, `.zod.ts:145`) | added |
| `ButtonGroupButton` had no `onClick` row | `onClick?: () => void` (`navigation.ts:325`, `.zod.ts:147`) | added, annotated as a runtime slot |
| `ButtonGroupButton` had no `className` row | `className?: string` (`navigation.ts:329`, `.zod.ts:148`) | added |
| `ButtonGroupSchema.variant?: 'default' \| 'outline' \| 'ghost'` | six members (`navigation.ts:345`, `.zod.ts:157`) | `secondary`, `destructive`, `link` restored |
| `ButtonGroupSchema.size?: 'sm' \| 'default' \| 'lg'` | four members (`navigation.ts:350`, `.zod.ts:158`) | `icon` restored |
| `disabled?: boolean` | `BaseSchema.disabled?: boolean \| string` (`base.ts`, `zod/base.zod.ts:190`) — `ButtonGroupSchema` does **not** redeclare it | `boolean \| string` |

Both directions are one defect class with the sign flipped. Fixing only the
direction a card happens to notice is what left these omissions sitting beside
two earlier corrections to the same page (objectui#6132, objectui#6143).

The `disabled` row deserves its own note, because it looks like a convention and
is not. Fourteen `content/docs/components/**` pages spell a component schema's
own `disabled` as `boolean` — but **thirteen of those fourteen schemas redeclare
`disabled?: boolean` themselves** (`ButtonSchema`, `SelectSchema`,
`SwitchSchema`, `ToggleGroupSchema` and nine more), so those pages are right.
`ButtonGroupSchema` is the one that does not, so it inherits `BaseSchema`'s
`boolean | string` and this page was the outlier rather than the convention.
Whether `ButtonGroupSchema` *should* narrow it like its thirteen siblings is a
types question, not a docs one, and is deliberately not answered here — the
renderer reads neither spelling today.

`onClick` is documented as declared and annotated as a runtime slot: it is
`z.function()`, and objectui#4453 narrowed the runtime to
`typeof === 'function'`, so a JSON author cannot supply one.

**`## Selection Mode` is deleted, not softened.**
`packages/components/src/renderers/basic/button-group.tsx` implements no
selection behaviour at all — no `selectionMode` read, no group-level `value`
read, no state — and it does not wire the declared per-button `onClick` either.
It maps `schema.buttons` to `Button` elements reading `variant`, `size`,
`className` and `label` only. A heading over two inert demos taught a
capability nothing draws. The capability question itself is filed separately
rather than answered here.

The two catalog fixtures the section rendered
(`components-basic-button-group/single-selection`, `/multiple-selection`) are
**kept**. Catalog entries are a separate verification population, fenced off by
PR #6345; orphaning them from this page is the accepted cost, and no gate reads
a catalog entry's page references (the index is generated from the schema
directory by `scripts/regenerate-catalog-index.py`, path-keyed).

`packages/types/src/__tests__/button-group-doc-surface-6347.test.ts` pins the
result. Nothing in CI parses a `plaintext` fence — `check:doc-types` reads only
the `type` string literals and `check:doc-snippets` compiles `ts`/`tsx` fences —
so without it a green CI run would have said "nothing else broke", not "the
correction is right". The pin reads membership off the mirror's `.shape` rather
than off parse acceptance, because `BaseSchema` is `.passthrough()` and carries
`[key: string]: any`: an undeclared `selectionMode` parses green and
type-checks, so acceptance cannot tell "declared" from "admitted unexamined".

No type was minted, no fence moved (the page holds one `plaintext` fence before
and after, so objectui#5867's shrink-only declared population is unchanged), and
no catalog fixture was edited.

Part of objectui#6347.

33 changes: 14 additions & 19 deletions
content/docs/components/basic/button-group.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18,34 +18,29 @@ The Button Group component groups multiple buttons together with consistent styl
 <SchemaExample id="components-basic-button-group/with-icons" />
</DemoGrid>

## Selection Mode

<DemoGrid>
 <SchemaExample id="components-basic-button-group/single-selection" />
 <SchemaExample id="components-basic-button-group/multiple-selection" />
</DemoGrid>

## Schema

```plaintext
interface ButtonGroupButton {
 label?: string;
 value: string;
 icon?: string;
 disabled?: boolean;
 label: string; // Button label (required)
 variant?: 'default' | 'secondary' | 'destructive' | 'outline' | 'ghost' | 'link';
 size?: 'default' | 'sm' | 'lg' | 'icon';
 disabled?: boolean; // Whether this button is disabled
 onClick?: () => void; // Runtime handler; not authorable in JSON
 className?: string; // Per-button CSS class
}

interface ButtonGroupSchema {
 type: 'button-group';
 buttons: ButtonGroupButton[]; // Button definitions
 value?: string | string[]; // Selected value(s)
selectionMode?: 'single' | 'multiple' | 'none';
 variant?: 'default' | 'outline' | 'ghost';
 size?: 'sm' | 'default' | 'lg';
 buttons?: ButtonGroupButton[]; // Button definitions

// Defaults applied to every button that does not set its own
 variant?: 'default' | 'secondary' | 'destructive' | 'outline' | 'ghost' | 'link';
 size?: 'default' | 'sm' | 'lg' | 'icon';

 // States
 disabled?: boolean;
 disabled?: boolean | string; // boolean, or a predicate expression

 // Styling
 className?: string;
}
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
docs(components): publish button-group's shipped surface, in both directions#7078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-sam
merged 4 commits into

from

Aug 31, 2026
 Merged


docs(components): publish button-group's shipped surface, in both directions
#7078
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
bc92486

docs(components): publish button-group's shipped surface, both direct…


claude Aug 31, 2026
2ced94e

docs: changeset for the button-group schema-block correction


claude Aug 31, 2026
467acdf

docs(components): the eleventh row — button-group inherits `disabled:…


claude Aug 31, 2026
0f49c91

test(types): type the wrapper carrier instead of `any` in the doc-sur…


claude Aug 31, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


82 changes: 82 additions & 0 deletions
.changeset/6347-button-group-schema-block.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,82 @@
---
---

Docs only, publishes nothing: `content/docs/components/basic/button-group.mdx`
published a `ButtonGroupSchema` / `ButtonGroupButton` surface that disagreed
with the shipped types in **both** directions. objectui#6347 named the two
over-statements; re-measuring the whole fence against
`packages/types/src/navigation.ts`, `packages/types/src/base.ts` and their Zod
mirrors found eleven rows.

Over-stated — documented, never declared:

| page before | shipped declaration | page after |
| --- | --- | --- |
| `ButtonGroupSchema.value?: string \| string[]` | not declared (`navigation.ts:335-351`, `zod/navigation.zod.ts:154-159`) | removed |
| `ButtonGroupSchema.selectionMode?: 'single' \| 'multiple' \| 'none'` | not declared (same two blocks) | removed |
| `ButtonGroupButton.value: string` (required) | not declared (`navigation.ts:305-330`, `zod/navigation.zod.ts:142-149`) | removed |
| `ButtonGroupButton.icon?: string` | not declared (same two blocks) | removed |
| `buttons: ButtonGroupButton[]` (required) | `buttons?: ButtonGroupButton[]` (`navigation.ts:340`, `.zod.ts:156`) | `buttons?:` |
| `label?: string` | `label: string` — required (`navigation.ts:309`, `.zod.ts:143`) | `label:` |

Under-stated — declared, never documented:

| page before | shipped declaration | page after |
| --- | --- | --- |
| `ButtonGroupButton` had no `variant` row | `variant?: 'default' \| 'secondary' \| 'destructive' \| 'outline' \| 'ghost' \| 'link'` (`navigation.ts:313`, `.zod.ts:144`) | added |
| `ButtonGroupButton` had no `size` row | `size?: 'default' \| 'sm' \| 'lg' \| 'icon'` (`navigation.ts:317`, `.zod.ts:145`) | added |
| `ButtonGroupButton` had no `onClick` row | `onClick?: () => void` (`navigation.ts:325`, `.zod.ts:147`) | added, annotated as a runtime slot |
| `ButtonGroupButton` had no `className` row | `className?: string` (`navigation.ts:329`, `.zod.ts:148`) | added |
| `ButtonGroupSchema.variant?: 'default' \| 'outline' \| 'ghost'` | six members (`navigation.ts:345`, `.zod.ts:157`) | `secondary`, `destructive`, `link` restored |
| `ButtonGroupSchema.size?: 'sm' \| 'default' \| 'lg'` | four members (`navigation.ts:350`, `.zod.ts:158`) | `icon` restored |
| `disabled?: boolean` | `BaseSchema.disabled?: boolean \| string` (`base.ts`, `zod/base.zod.ts:190`) — `ButtonGroupSchema` does **not** redeclare it | `boolean \| string` |

Both directions are one defect class with the sign flipped. Fixing only the
direction a card happens to notice is what left these omissions sitting beside
two earlier corrections to the same page (objectui#6132, objectui#6143).

The `disabled` row deserves its own note, because it looks like a convention and
is not. Fourteen `content/docs/components/**` pages spell a component schema's
own `disabled` as `boolean` — but **thirteen of those fourteen schemas redeclare
`disabled?: boolean` themselves** (`ButtonSchema`, `SelectSchema`,
`SwitchSchema`, `ToggleGroupSchema` and nine more), so those pages are right.
`ButtonGroupSchema` is the one that does not, so it inherits `BaseSchema`'s
`boolean | string` and this page was the outlier rather than the convention.
Whether `ButtonGroupSchema` *should* narrow it like its thirteen siblings is a
types question, not a docs one, and is deliberately not answered here — the
renderer reads neither spelling today.

`onClick` is documented as declared and annotated as a runtime slot: it is
`z.function()`, and objectui#4453 narrowed the runtime to
`typeof === 'function'`, so a JSON author cannot supply one.

**`## Selection Mode` is deleted, not softened.**
`packages/components/src/renderers/basic/button-group.tsx` implements no
selection behaviour at all — no `selectionMode` read, no group-level `value`
read, no state — and it does not wire the declared per-button `onClick` either.
It maps `schema.buttons` to `Button` elements reading `variant`, `size`,
`className` and `label` only. A heading over two inert demos taught a
capability nothing draws. The capability question itself is filed separately
rather than answered here.

The two catalog fixtures the section rendered
(`components-basic-button-group/single-selection`, `/multiple-selection`) are
**kept**. Catalog entries are a separate verification population, fenced off by
PR #6345; orphaning them from this page is the accepted cost, and no gate reads
a catalog entry's page references (the index is generated from the schema
directory by `scripts/regenerate-catalog-index.py`, path-keyed).

`packages/types/src/__tests__/button-group-doc-surface-6347.test.ts` pins the
result. Nothing in CI parses a `plaintext` fence — `check:doc-types` reads only
the `type` string literals and `check:doc-snippets` compiles `ts`/`tsx` fences —
so without it a green CI run would have said "nothing else broke", not "the
correction is right". The pin reads membership off the mirror's `.shape` rather
than off parse acceptance, because `BaseSchema` is `.passthrough()` and carries
`[key: string]: any`: an undeclared `selectionMode` parses green and
type-checks, so acceptance cannot tell "declared" from "admitted unexamined".

No type was minted, no fence moved (the page holds one `plaintext` fence before
and after, so objectui#5867's shrink-only declared population is unchanged), and
no catalog fixture was edited.

Part of objectui#6347.

33 changes: 14 additions & 19 deletions
content/docs/components/basic/button-group.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18,34 +18,29 @@ The Button Group component groups multiple buttons together with consistent styl
 <SchemaExample id="components-basic-button-group/with-icons" />
</DemoGrid>

## Selection Mode

<DemoGrid>
 <SchemaExample id="components-basic-button-group/single-selection" />
 <SchemaExample id="components-basic-button-group/multiple-selection" />
</DemoGrid>

## Schema

```plaintext
interface ButtonGroupButton {
 label?: string;
 value: string;
 icon?: string;
 disabled?: boolean;
 label: string; // Button label (required)
 variant?: 'default' | 'secondary' | 'destructive' | 'outline' | 'ghost' | 'link';
 size?: 'default' | 'sm' | 'lg' | 'icon';
 disabled?: boolean; // Whether this button is disabled
 onClick?: () => void; // Runtime handler; not authorable in JSON
 className?: string; // Per-button CSS class
}

interface ButtonGroupSchema {
 type: 'button-group';
 buttons: ButtonGroupButton[]; // Button definitions
 value?: string | string[]; // Selected value(s)
selectionMode?: 'single' | 'multiple' | 'none';
 variant?: 'default' | 'outline' | 'ghost';
 size?: 'sm' | 'default' | 'lg';
 buttons?: ButtonGroupButton[]; // Button definitions

// Defaults applied to every button that does not set its own
 variant?: 'default' | 'secondary' | 'destructive' | 'outline' | 'ghost' | 'link';
 size?: 'default' | 'sm' | 'lg' | 'icon';

 // States
 disabled?: boolean;
 disabled?: boolean | string; // boolean, or a predicate expression

 // Styling
 className?: string;
}
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
docs(components): publish button-group's shipped surface, in both directions#7078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-sam
merged 4 commits into

from

Aug 31, 2026
 Merged


docs(components): publish button-group's shipped surface, in both directions
#7078
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
bc92486

docs(components): publish button-group's shipped surface, both direct…


claude Aug 31, 2026
2ced94e

docs: changeset for the button-group schema-block correction


claude Aug 31, 2026
467acdf

docs(components): the eleventh row — button-group inherits `disabled:…


claude Aug 31, 2026
0f49c91

test(types): type the wrapper carrier instead of `any` in the doc-sur…


claude Aug 31, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


82 changes: 82 additions & 0 deletions
.changeset/6347-button-group-schema-block.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,82 @@
---
---

Docs only, publishes nothing: `content/docs/components/basic/button-group.mdx`
published a `ButtonGroupSchema` / `ButtonGroupButton` surface that disagreed
with the shipped types in **both** directions. objectui#6347 named the two
over-statements; re-measuring the whole fence against
`packages/types/src/navigation.ts`, `packages/types/src/base.ts` and their Zod
mirrors found eleven rows.

Over-stated — documented, never declared:

| page before | shipped declaration | page after |
| --- | --- | --- |
| `ButtonGroupSchema.value?: string \| string[]` | not declared (`navigation.ts:335-351`, `zod/navigation.zod.ts:154-159`) | removed |
| `ButtonGroupSchema.selectionMode?: 'single' \| 'multiple' \| 'none'` | not declared (same two blocks) | removed |
| `ButtonGroupButton.value: string` (required) | not declared (`navigation.ts:305-330`, `zod/navigation.zod.ts:142-149`) | removed |
| `ButtonGroupButton.icon?: string` | not declared (same two blocks) | removed |
| `buttons: ButtonGroupButton[]` (required) | `buttons?: ButtonGroupButton[]` (`navigation.ts:340`, `.zod.ts:156`) | `buttons?:` |
| `label?: string` | `label: string` — required (`navigation.ts:309`, `.zod.ts:143`) | `label:` |

Under-stated — declared, never documented:

| page before | shipped declaration | page after |
| --- | --- | --- |
| `ButtonGroupButton` had no `variant` row | `variant?: 'default' \| 'secondary' \| 'destructive' \| 'outline' \| 'ghost' \| 'link'` (`navigation.ts:313`, `.zod.ts:144`) | added |
| `ButtonGroupButton` had no `size` row | `size?: 'default' \| 'sm' \| 'lg' \| 'icon'` (`navigation.ts:317`, `.zod.ts:145`) | added |
| `ButtonGroupButton` had no `onClick` row | `onClick?: () => void` (`navigation.ts:325`, `.zod.ts:147`) | added, annotated as a runtime slot |
| `ButtonGroupButton` had no `className` row | `className?: string` (`navigation.ts:329`, `.zod.ts:148`) | added |
| `ButtonGroupSchema.variant?: 'default' \| 'outline' \| 'ghost'` | six members (`navigation.ts:345`, `.zod.ts:157`) | `secondary`, `destructive`, `link` restored |
| `ButtonGroupSchema.size?: 'sm' \| 'default' \| 'lg'` | four members (`navigation.ts:350`, `.zod.ts:158`) | `icon` restored |
| `disabled?: boolean` | `BaseSchema.disabled?: boolean \| string` (`base.ts`, `zod/base.zod.ts:190`) — `ButtonGroupSchema` does **not** redeclare it | `boolean \| string` |

Both directions are one defect class with the sign flipped. Fixing only the
direction a card happens to notice is what left these omissions sitting beside
two earlier corrections to the same page (objectui#6132, objectui#6143).

The `disabled` row deserves its own note, because it looks like a convention and
is not. Fourteen `content/docs/components/**` pages spell a component schema's
own `disabled` as `boolean` — but **thirteen of those fourteen schemas redeclare
`disabled?: boolean` themselves** (`ButtonSchema`, `SelectSchema`,
`SwitchSchema`, `ToggleGroupSchema` and nine more), so those pages are right.
`ButtonGroupSchema` is the one that does not, so it inherits `BaseSchema`'s
`boolean | string` and this page was the outlier rather than the convention.
Whether `ButtonGroupSchema` *should* narrow it like its thirteen siblings is a
types question, not a docs one, and is deliberately not answered here — the
renderer reads neither spelling today.

`onClick` is documented as declared and annotated as a runtime slot: it is
`z.function()`, and objectui#4453 narrowed the runtime to
`typeof === 'function'`, so a JSON author cannot supply one.

**`## Selection Mode` is deleted, not softened.**
`packages/components/src/renderers/basic/button-group.tsx` implements no
selection behaviour at all — no `selectionMode` read, no group-level `value`
read, no state — and it does not wire the declared per-button `onClick` either.
It maps `schema.buttons` to `Button` elements reading `variant`, `size`,
`className` and `label` only. A heading over two inert demos taught a
capability nothing draws. The capability question itself is filed separately
rather than answered here.

The two catalog fixtures the section rendered
(`components-basic-button-group/single-selection`, `/multiple-selection`) are
**kept**. Catalog entries are a separate verification population, fenced off by
PR #6345; orphaning them from this page is the accepted cost, and no gate reads
a catalog entry's page references (the index is generated from the schema
directory by `scripts/regenerate-catalog-index.py`, path-keyed).

`packages/types/src/__tests__/button-group-doc-surface-6347.test.ts` pins the
result. Nothing in CI parses a `plaintext` fence — `check:doc-types` reads only
the `type` string literals and `check:doc-snippets` compiles `ts`/`tsx` fences —
so without it a green CI run would have said "nothing else broke", not "the
correction is right". The pin reads membership off the mirror's `.shape` rather
than off parse acceptance, because `BaseSchema` is `.passthrough()` and carries
`[key: string]: any`: an undeclared `selectionMode` parses green and
type-checks, so acceptance cannot tell "declared" from "admitted unexamined".

No type was minted, no fence moved (the page holds one `plaintext` fence before
and after, so objectui#5867's shrink-only declared population is unchanged), and
no catalog fixture was edited.

Part of objectui#6347.

33 changes: 14 additions & 19 deletions
content/docs/components/basic/button-group.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18,34 +18,29 @@ The Button Group component groups multiple buttons together with consistent styl
 <SchemaExample id="components-basic-button-group/with-icons" />
</DemoGrid>

## Selection Mode

<DemoGrid>
 <SchemaExample id="components-basic-button-group/single-selection" />
 <SchemaExample id="components-basic-button-group/multiple-selection" />
</DemoGrid>

## Schema

```plaintext
interface ButtonGroupButton {
 label?: string;
 value: string;
 icon?: string;
 disabled?: boolean;
 label: string; // Button label (required)
 variant?: 'default' | 'secondary' | 'destructive' | 'outline' | 'ghost' | 'link';
 size?: 'default' | 'sm' | 'lg' | 'icon';
 disabled?: boolean; // Whether this button is disabled
 onClick?: () => void; // Runtime handler; not authorable in JSON
 className?: string; // Per-button CSS class
}

interface ButtonGroupSchema {
 type: 'button-group';
 buttons: ButtonGroupButton[]; // Button definitions
 value?: string | string[]; // Selected value(s)
selectionMode?: 'single' | 'multiple' | 'none';
 variant?: 'default' | 'outline' | 'ghost';
 size?: 'sm' | 'default' | 'lg';
 buttons?: ButtonGroupButton[]; // Button definitions

// Defaults applied to every button that does not set its own
 variant?: 'default' | 'secondary' | 'destructive' | 'outline' | 'ghost' | 'link';
 size?: 'default' | 'sm' | 'lg' | 'icon';

 // States
 disabled?: boolean;
 disabled?: boolean | string; // boolean, or a predicate expression

 // Styling
 className?: string;
}
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
docs(components): publish button-group's shipped surface, in both directions#7078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-sam
merged 4 commits into

from

Aug 31, 2026
 Merged


docs(components): publish button-group's shipped surface, in both directions
#7078
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
bc92486

docs(components): publish button-group's shipped surface, both direct…


claude Aug 31, 2026
2ced94e

docs: changeset for the button-group schema-block correction


claude Aug 31, 2026
467acdf

docs(components): the eleventh row — button-group inherits `disabled:…


claude Aug 31, 2026
0f49c91

test(types): type the wrapper carrier instead of `any` in the doc-sur…


claude Aug 31, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


82 changes: 82 additions & 0 deletions
.changeset/6347-button-group-schema-block.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,82 @@
---
---

Docs only, publishes nothing: `content/docs/components/basic/button-group.mdx`
published a `ButtonGroupSchema` / `ButtonGroupButton` surface that disagreed
with the shipped types in **both** directions. objectui#6347 named the two
over-statements; re-measuring the whole fence against
`packages/types/src/navigation.ts`, `packages/types/src/base.ts` and their Zod
mirrors found eleven rows.

Over-stated — documented, never declared:

| page before | shipped declaration | page after |
| --- | --- | --- |
| `ButtonGroupSchema.value?: string \| string[]` | not declared (`navigation.ts:335-351`, `zod/navigation.zod.ts:154-159`) | removed |
| `ButtonGroupSchema.selectionMode?: 'single' \| 'multiple' \| 'none'` | not declared (same two blocks) | removed |
| `ButtonGroupButton.value: string` (required) | not declared (`navigation.ts:305-330`, `zod/navigation.zod.ts:142-149`) | removed |
| `ButtonGroupButton.icon?: string` | not declared (same two blocks) | removed |
| `buttons: ButtonGroupButton[]` (required) | `buttons?: ButtonGroupButton[]` (`navigation.ts:340`, `.zod.ts:156`) | `buttons?:` |
| `label?: string` | `label: string` — required (`navigation.ts:309`, `.zod.ts:143`) | `label:` |

Under-stated — declared, never documented:

| page before | shipped declaration | page after |
| --- | --- | --- |
| `ButtonGroupButton` had no `variant` row | `variant?: 'default' \| 'secondary' \| 'destructive' \| 'outline' \| 'ghost' \| 'link'` (`navigation.ts:313`, `.zod.ts:144`) | added |
| `ButtonGroupButton` had no `size` row | `size?: 'default' \| 'sm' \| 'lg' \| 'icon'` (`navigation.ts:317`, `.zod.ts:145`) | added |
| `ButtonGroupButton` had no `onClick` row | `onClick?: () => void` (`navigation.ts:325`, `.zod.ts:147`) | added, annotated as a runtime slot |
| `ButtonGroupButton` had no `className` row | `className?: string` (`navigation.ts:329`, `.zod.ts:148`) | added |
| `ButtonGroupSchema.variant?: 'default' \| 'outline' \| 'ghost'` | six members (`navigation.ts:345`, `.zod.ts:157`) | `secondary`, `destructive`, `link` restored |
| `ButtonGroupSchema.size?: 'sm' \| 'default' \| 'lg'` | four members (`navigation.ts:350`, `.zod.ts:158`) | `icon` restored |
| `disabled?: boolean` | `BaseSchema.disabled?: boolean \| string` (`base.ts`, `zod/base.zod.ts:190`) — `ButtonGroupSchema` does **not** redeclare it | `boolean \| string` |

Both directions are one defect class with the sign flipped. Fixing only the
direction a card happens to notice is what left these omissions sitting beside
two earlier corrections to the same page (objectui#6132, objectui#6143).

The `disabled` row deserves its own note, because it looks like a convention and
is not. Fourteen `content/docs/components/**` pages spell a component schema's
own `disabled` as `boolean` — but **thirteen of those fourteen schemas redeclare
`disabled?: boolean` themselves** (`ButtonSchema`, `SelectSchema`,
`SwitchSchema`, `ToggleGroupSchema` and nine more), so those pages are right.
`ButtonGroupSchema` is the one that does not, so it inherits `BaseSchema`'s
`boolean | string` and this page was the outlier rather than the convention.
Whether `ButtonGroupSchema` *should* narrow it like its thirteen siblings is a
types question, not a docs one, and is deliberately not answered here — the
renderer reads neither spelling today.

`onClick` is documented as declared and annotated as a runtime slot: it is
`z.function()`, and objectui#4453 narrowed the runtime to
`typeof === 'function'`, so a JSON author cannot supply one.

**`## Selection Mode` is deleted, not softened.**
`packages/components/src/renderers/basic/button-group.tsx` implements no
selection behaviour at all — no `selectionMode` read, no group-level `value`
read, no state — and it does not wire the declared per-button `onClick` either.
It maps `schema.buttons` to `Button` elements reading `variant`, `size`,
`className` and `label` only. A heading over two inert demos taught a
capability nothing draws. The capability question itself is filed separately
rather than answered here.

The two catalog fixtures the section rendered
(`components-basic-button-group/single-selection`, `/multiple-selection`) are
**kept**. Catalog entries are a separate verification population, fenced off by
PR #6345; orphaning them from this page is the accepted cost, and no gate reads
a catalog entry's page references (the index is generated from the schema
directory by `scripts/regenerate-catalog-index.py`, path-keyed).

`packages/types/src/__tests__/button-group-doc-surface-6347.test.ts` pins the
result. Nothing in CI parses a `plaintext` fence — `check:doc-types` reads only
the `type` string literals and `check:doc-snippets` compiles `ts`/`tsx` fences —
so without it a green CI run would have said "nothing else broke", not "the
correction is right". The pin reads membership off the mirror's `.shape` rather
than off parse acceptance, because `BaseSchema` is `.passthrough()` and carries
`[key: string]: any`: an undeclared `selectionMode` parses green and
type-checks, so acceptance cannot tell "declared" from "admitted unexamined".

No type was minted, no fence moved (the page holds one `plaintext` fence before
and after, so objectui#5867's shrink-only declared population is unchanged), and
no catalog fixture was edited.

Part of objectui#6347.

33 changes: 14 additions & 19 deletions
content/docs/components/basic/button-group.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18,34 +18,29 @@ The Button Group component groups multiple buttons together with consistent styl
 <SchemaExample id="components-basic-button-group/with-icons" />
</DemoGrid>

## Selection Mode

<DemoGrid>
 <SchemaExample id="components-basic-button-group/single-selection" />
 <SchemaExample id="components-basic-button-group/multiple-selection" />
</DemoGrid>

## Schema

```plaintext
interface ButtonGroupButton {
 label?: string;
 value: string;
 icon?: string;
 disabled?: boolean;
 label: string; // Button label (required)
 variant?: 'default' | 'secondary' | 'destructive' | 'outline' | 'ghost' | 'link';
 size?: 'default' | 'sm' | 'lg' | 'icon';
 disabled?: boolean; // Whether this button is disabled
 onClick?: () => void; // Runtime handler; not authorable in JSON
 className?: string; // Per-button CSS class
}

interface ButtonGroupSchema {
 type: 'button-group';
 buttons: ButtonGroupButton[]; // Button definitions
 value?: string | string[]; // Selected value(s)
selectionMode?: 'single' | 'multiple' | 'none';
 variant?: 'default' | 'outline' | 'ghost';
 size?: 'sm' | 'default' | 'lg';
 buttons?: ButtonGroupButton[]; // Button definitions

// Defaults applied to every button that does not set its own
 variant?: 'default' | 'secondary' | 'destructive' | 'outline' | 'ghost' | 'link';
 size?: 'default' | 'sm' | 'lg' | 'icon';

 // States
 disabled?: boolean;
 disabled?: boolean | string; // boolean, or a predicate expression

 // Styling
 className?: string;
}
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
docs(components): publish button-group's shipped surface, in both directions#7078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-sam
merged 4 commits into

from

Aug 31, 2026
 Merged


docs(components): publish button-group's shipped surface, in both directions
#7078
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
bc92486

docs(components): publish button-group's shipped surface, both direct…


claude Aug 31, 2026
2ced94e

docs: changeset for the button-group schema-block correction


claude Aug 31, 2026
467acdf

docs(components): the eleventh row — button-group inherits `disabled:…


claude Aug 31, 2026
0f49c91

test(types): type the wrapper carrier instead of `any` in the doc-sur…


claude Aug 31, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


82 changes: 82 additions & 0 deletions
.changeset/6347-button-group-schema-block.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,82 @@
---
---

Docs only, publishes nothing: `content/docs/components/basic/button-group.mdx`
published a `ButtonGroupSchema` / `ButtonGroupButton` surface that disagreed
with the shipped types in **both** directions. objectui#6347 named the two
over-statements; re-measuring the whole fence against
`packages/types/src/navigation.ts`, `packages/types/src/base.ts` and their Zod
mirrors found eleven rows.

Over-stated — documented, never declared:

| page before | shipped declaration | page after |
| --- | --- | --- |
| `ButtonGroupSchema.value?: string \| string[]` | not declared (`navigation.ts:335-351`, `zod/navigation.zod.ts:154-159`) | removed |
| `ButtonGroupSchema.selectionMode?: 'single' \| 'multiple' \| 'none'` | not declared (same two blocks) | removed |
| `ButtonGroupButton.value: string` (required) | not declared (`navigation.ts:305-330`, `zod/navigation.zod.ts:142-149`) | removed |
| `ButtonGroupButton.icon?: string` | not declared (same two blocks) | removed |
| `buttons: ButtonGroupButton[]` (required) | `buttons?: ButtonGroupButton[]` (`navigation.ts:340`, `.zod.ts:156`) | `buttons?:` |
| `label?: string` | `label: string` — required (`navigation.ts:309`, `.zod.ts:143`) | `label:` |

Under-stated — declared, never documented:

| page before | shipped declaration | page after |
| --- | --- | --- |
| `ButtonGroupButton` had no `variant` row | `variant?: 'default' \| 'secondary' \| 'destructive' \| 'outline' \| 'ghost' \| 'link'` (`navigation.ts:313`, `.zod.ts:144`) | added |
| `ButtonGroupButton` had no `size` row | `size?: 'default' \| 'sm' \| 'lg' \| 'icon'` (`navigation.ts:317`, `.zod.ts:145`) | added |
| `ButtonGroupButton` had no `onClick` row | `onClick?: () => void` (`navigation.ts:325`, `.zod.ts:147`) | added, annotated as a runtime slot |
| `ButtonGroupButton` had no `className` row | `className?: string` (`navigation.ts:329`, `.zod.ts:148`) | added |
| `ButtonGroupSchema.variant?: 'default' \| 'outline' \| 'ghost'` | six members (`navigation.ts:345`, `.zod.ts:157`) | `secondary`, `destructive`, `link` restored |
| `ButtonGroupSchema.size?: 'sm' \| 'default' \| 'lg'` | four members (`navigation.ts:350`, `.zod.ts:158`) | `icon` restored |
| `disabled?: boolean` | `BaseSchema.disabled?: boolean \| string` (`base.ts`, `zod/base.zod.ts:190`) — `ButtonGroupSchema` does **not** redeclare it | `boolean \| string` |

Both directions are one defect class with the sign flipped. Fixing only the
direction a card happens to notice is what left these omissions sitting beside
two earlier corrections to the same page (objectui#6132, objectui#6143).

The `disabled` row deserves its own note, because it looks like a convention and
is not. Fourteen `content/docs/components/**` pages spell a component schema's
own `disabled` as `boolean` — but **thirteen of those fourteen schemas redeclare
`disabled?: boolean` themselves** (`ButtonSchema`, `SelectSchema`,
`SwitchSchema`, `ToggleGroupSchema` and nine more), so those pages are right.
`ButtonGroupSchema` is the one that does not, so it inherits `BaseSchema`'s
`boolean | string` and this page was the outlier rather than the convention.
Whether `ButtonGroupSchema` *should* narrow it like its thirteen siblings is a
types question, not a docs one, and is deliberately not answered here — the
renderer reads neither spelling today.

`onClick` is documented as declared and annotated as a runtime slot: it is
`z.function()`, and objectui#4453 narrowed the runtime to
`typeof === 'function'`, so a JSON author cannot supply one.

**`## Selection Mode` is deleted, not softened.**
`packages/components/src/renderers/basic/button-group.tsx` implements no
selection behaviour at all — no `selectionMode` read, no group-level `value`
read, no state — and it does not wire the declared per-button `onClick` either.
It maps `schema.buttons` to `Button` elements reading `variant`, `size`,
`className` and `label` only. A heading over two inert demos taught a
capability nothing draws. The capability question itself is filed separately
rather than answered here.

The two catalog fixtures the section rendered
(`components-basic-button-group/single-selection`, `/multiple-selection`) are
**kept**. Catalog entries are a separate verification population, fenced off by
PR #6345; orphaning them from this page is the accepted cost, and no gate reads
a catalog entry's page references (the index is generated from the schema
directory by `scripts/regenerate-catalog-index.py`, path-keyed).

`packages/types/src/__tests__/button-group-doc-surface-6347.test.ts` pins the
result. Nothing in CI parses a `plaintext` fence — `check:doc-types` reads only
the `type` string literals and `check:doc-snippets` compiles `ts`/`tsx` fences —
so without it a green CI run would have said "nothing else broke", not "the
correction is right". The pin reads membership off the mirror's `.shape` rather
than off parse acceptance, because `BaseSchema` is `.passthrough()` and carries
`[key: string]: any`: an undeclared `selectionMode` parses green and
type-checks, so acceptance cannot tell "declared" from "admitted unexamined".

No type was minted, no fence moved (the page holds one `plaintext` fence before
and after, so objectui#5867's shrink-only declared population is unchanged), and
no catalog fixture was edited.

Part of objectui#6347.

33 changes: 14 additions & 19 deletions
content/docs/components/basic/button-group.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18,34 +18,29 @@ The Button Group component groups multiple buttons together with consistent styl
 <SchemaExample id="components-basic-button-group/with-icons" />
</DemoGrid>

## Selection Mode

<DemoGrid>
 <SchemaExample id="components-basic-button-group/single-selection" />
 <SchemaExample id="components-basic-button-group/multiple-selection" />
</DemoGrid>

## Schema

```plaintext
interface ButtonGroupButton {
 label?: string;
 value: string;
 icon?: string;
 disabled?: boolean;
 label: string; // Button label (required)
 variant?: 'default' | 'secondary' | 'destructive' | 'outline' | 'ghost' | 'link';
 size?: 'default' | 'sm' | 'lg' | 'icon';
 disabled?: boolean; // Whether this button is disabled
 onClick?: () => void; // Runtime handler; not authorable in JSON
 className?: string; // Per-button CSS class
}

interface ButtonGroupSchema {
 type: 'button-group';
 buttons: ButtonGroupButton[]; // Button definitions
 value?: string | string[]; // Selected value(s)
selectionMode?: 'single' | 'multiple' | 'none';
 variant?: 'default' | 'outline' | 'ghost';
 size?: 'sm' | 'default' | 'lg';
 buttons?: ButtonGroupButton[]; // Button definitions

// Defaults applied to every button that does not set its own
 variant?: 'default' | 'secondary' | 'destructive' | 'outline' | 'ghost' | 'link';
 size?: 'default' | 'sm' | 'lg' | 'icon';

 // States
 disabled?: boolean;
 disabled?: boolean | string; // boolean, or a predicate expression

 // Styling
 className?: string;
}
Expand Down
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
docs(components): publish button-group's shipped surface, in both directions#7078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

os-sam
merged 4 commits into

from

Aug 31, 2026
 Merged


docs(components): publish button-group's shipped surface, in both directions
#7078
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
bc92486

docs(components): publish button-group's shipped surface, both direct…


claude Aug 31, 2026
2ced94e

docs: changeset for the button-group schema-block correction


claude Aug 31, 2026
467acdf

docs(components): the eleventh row — button-group inherits `disabled:…


claude Aug 31, 2026
0f49c91

test(types): type the wrapper carrier instead of `any` in the doc-sur…


claude Aug 31, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


82 changes: 82 additions & 0 deletions
.changeset/6347-button-group-schema-block.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,82 @@
---
---

Docs only, publishes nothing: `content/docs/components/basic/button-group.mdx`
published a `ButtonGroupSchema` / `ButtonGroupButton` surface that disagreed
with the shipped types in **both** directions. objectui#6347 named the two
over-statements; re-measuring the whole fence against
`packages/types/src/navigation.ts`, `packages/types/src/base.ts` and their Zod
mirrors found eleven rows.

Over-stated — documented, never declared:

| page before | shipped declaration | page after |
| --- | --- | --- |
| `ButtonGroupSchema.value?: string \| string[]` | not declared (`navigation.ts:335-351`, `zod/navigation.zod.ts:154-159`) | removed |
| `ButtonGroupSchema.selectionMode?: 'single' \| 'multiple' \| 'none'` | not declared (same two blocks) | removed |
| `ButtonGroupButton.value: string` (required) | not declared (`navigation.ts:305-330`, `zod/navigation.zod.ts:142-149`) | removed |
| `ButtonGroupButton.icon?: string` | not declared (same two blocks) | removed |
| `buttons: ButtonGroupButton[]` (required) | `buttons?: ButtonGroupButton[]` (`navigation.ts:340`, `.zod.ts:156`) | `buttons?:` |
| `label?: string` | `label: string` — required (`navigation.ts:309`, `.zod.ts:143`) | `label:` |

Under-stated — declared, never documented:

| page before | shipped declaration | page after |
| --- | --- | --- |
| `ButtonGroupButton` had no `variant` row | `variant?: 'default' \| 'secondary' \| 'destructive' \| 'outline' \| 'ghost' \| 'link'` (`navigation.ts:313`, `.zod.ts:144`) | added |
| `ButtonGroupButton` had no `size` row | `size?: 'default' \| 'sm' \| 'lg' \| 'icon'` (`navigation.ts:317`, `.zod.ts:145`) | added |
| `ButtonGroupButton` had no `onClick` row | `onClick?: () => void` (`navigation.ts:325`, `.zod.ts:147`) | added, annotated as a runtime slot |
| `ButtonGroupButton` had no `className` row | `className?: string` (`navigation.ts:329`, `.zod.ts:148`) | added |
| `ButtonGroupSchema.variant?: 'default' \| 'outline' \| 'ghost'` | six members (`navigation.ts:345`, `.zod.ts:157`) | `secondary`, `destructive`, `link` restored |
| `ButtonGroupSchema.size?: 'sm' \| 'default' \| 'lg'` | four members (`navigation.ts:350`, `.zod.ts:158`) | `icon` restored |
| `disabled?: boolean` | `BaseSchema.disabled?: boolean \| string` (`base.ts`, `zod/base.zod.ts:190`) — `ButtonGroupSchema` does **not** redeclare it | `boolean \| string` |

Both directions are one defect class with the sign flipped. Fixing only the
direction a card happens to notice is what left these omissions sitting beside
two earlier corrections to the same page (objectui#6132, objectui#6143).

The `disabled` row deserves its own note, because it looks like a convention and
is not. Fourteen `content/docs/components/**` pages spell a component schema's
own `disabled` as `boolean` — but **thirteen of those fourteen schemas redeclare
`disabled?: boolean` themselves** (`ButtonSchema`, `SelectSchema`,
`SwitchSchema`, `ToggleGroupSchema` and nine more), so those pages are right.
`ButtonGroupSchema` is the one that does not, so it inherits `BaseSchema`'s
`boolean | string` and this page was the outlier rather than the convention.
Whether `ButtonGroupSchema` *should* narrow it like its thirteen siblings is a
types question, not a docs one, and is deliberately not answered here — the
renderer reads neither spelling today.

`onClick` is documented as declared and annotated as a runtime slot: it is
`z.function()`, and objectui#4453 narrowed the runtime to
`typeof === 'function'`, so a JSON author cannot supply one.

**`## Selection Mode` is deleted, not softened.**
`packages/components/src/renderers/basic/button-group.tsx` implements no
selection behaviour at all — no `selectionMode` read, no group-level `value`
read, no state — and it does not wire the declared per-button `onClick` either.
It maps `schema.buttons` to `Button` elements reading `variant`, `size`,
`className` and `label` only. A heading over two inert demos taught a
capability nothing draws. The capability question itself is filed separately
rather than answered here.

The two catalog fixtures the section rendered
(`components-basic-button-group/single-selection`, `/multiple-selection`) are
**kept**. Catalog entries are a separate verification population, fenced off by
PR #6345; orphaning them from this page is the accepted cost, and no gate reads
a catalog entry's page references (the index is generated from the schema
directory by `scripts/regenerate-catalog-index.py`, path-keyed).

`packages/types/src/__tests__/button-group-doc-surface-6347.test.ts` pins the
result. Nothing in CI parses a `plaintext` fence — `check:doc-types` reads only
the `type` string literals and `check:doc-snippets` compiles `ts`/`tsx` fences —
so without it a green CI run would have said "nothing else broke", not "the
correction is right". The pin reads membership off the mirror's `.shape` rather
than off parse acceptance, because `BaseSchema` is `.passthrough()` and carries
`[key: string]: any`: an undeclared `selectionMode` parses green and
type-checks, so acceptance cannot tell "declared" from "admitted unexamined".

No type was minted, no fence moved (the page holds one `plaintext` fence before
and after, so objectui#5867's shrink-only declared population is unchanged), and
no catalog fixture was edited.

Part of objectui#6347.

33 changes: 14 additions & 19 deletions
content/docs/components/basic/button-group.mdx

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18,34 +18,29 @@ The Button Group component groups multiple buttons together with consistent styl
 <SchemaExample id="components-basic-button-group/with-icons" />
</DemoGrid>

## Selection Mode

<DemoGrid>
 <SchemaExample id="components-basic-button-group/single-selection" />
 <SchemaExample id="components-basic-button-group/multiple-selection" />
</DemoGrid>

## Schema

```plaintext
interface ButtonGroupButton {
 label?: string;
 value: string;
 icon?: string;
 disabled?: boolean;
 label: string; // Button label (required)
 variant?: 'default' | 'secondary' | 'destructive' | 'outline' | 'ghost' | 'link';
 size?: 'default' | 'sm' | 'lg' | 'icon';
 disabled?: boolean; // Whether this button is disabled
 onClick?: () => void; // Runtime handler; not authorable in JSON
 className?: string; // Per-button CSS class
}

interface ButtonGroupSchema {
 type: 'button-group';
 buttons: ButtonGroupButton[]; // Button definitions
 value?: string | string[]; // Selected value(s)
selectionMode?: 'single' | 'multiple' | 'none';
 variant?: 'default' | 'outline' | 'ghost';
 size?: 'sm' | 'default' | 'lg';
 buttons?: ButtonGroupButton[]; // Button definitions

// Defaults applied to every button that does not set its own
 variant?: 'default' | 'secondary' | 'destructive' | 'outline' | 'ghost' | 'link';
 size?: 'default' | 'sm' | 'lg' | 'icon';

 // States
 disabled?: boolean;
 disabled?: boolean | string; // boolean, or a predicate expression

 // Styling
 className?: string;
}
Expand Down
Loading
Loading